- 13 Feb, 2020 40 commits
-
-
Adam Ettenberger authored
Consider the following example : <div>some</div> <!-- ID:1 --> <div>text</div> <!-- ID:2 --> <div aria-hidden="true">Hidden</div> <!-- ID:3 --> Forward word navigation starting at ID:1 results in a range : start: {ID:2, text_offset=0} end: {ID:3, text_offset=0} Because ID:3 is ignored, AsUnignoredPosition forward will result in a NULL_POSITION because no unignored content follows. For StopAtLastAnchorBoundary we want to try to resolve AsUnignoredPosition in the opposite direction so it can resolve to the last unignored position in the desired direction before it would have crossed into the ignored region of content at the start/end of the document. Bug: 1049852 Change-Id: Ic19fba25492c915e321c64d2a8d2cfe158c4b7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048905 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741203}
-
Alan Cutter authored
This CL adds instantiations for: - ResourceLoadingHintsBrowserTestWithExperimentEnabled - ResourceLoadingHintsBrowserTestWithExperimentDisabled - ResourceLoadingHintsBrowserTestWithCoinFlipAlwaysHoldback This CL fixes the warnings thrown by browser_tests: [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentEnabled> [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentDisabled> [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithCoinFlipAlwaysHoldback> Change-Id: Idf98ff3a53a377b34b3dfb5340faa379b45e13e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053230 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#741202}
-
Alan Cutter authored
This CL adds instantiations for PreviewsLitePageRedirectServerBrowserTestWithAlwaysHoldback and removes the empty instantiation for CoinFlipHoldbackExperimentBrowserTest. This CL fixes the warnings thrown by browser_tests: [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<PreviewsLitePageRedirectServerBrowserTestWithAlwaysHoldback> [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<CoinFlipHoldbackExperimentBrowserTest> Change-Id: I3ac29a9f8971b8445a8d65e37b2eadc15f3efcd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054126 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Theodore Dubois authored
Rulesets no longer have priorities. CompositeMatcher now returns the highest priority rule from all its rulesets, instead of stopping after the first ruleset. Bug: 1026733 Change-Id: Ie77c4d1171bce374af4999339da7e73c018730e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026747 Commit-Queue: Theodore Dubois <tbodt@google.com> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Theodore Dubois <tbodt@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741200}
-
Sujie Zhu authored
Apart from being used for metrics, we also base our branching logic on UnmaskAuthFlowType in CreditCardAccessManager. so it should be declared in CreditCardAccessManager instead of CreditCardFormEventLogger. We use forward declaring to avoid cyclic imports. Bug: 949269 Change-Id: Idc2a12beaac80f7b9e9fc496d66245c842eebcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052325 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#741199}
-
Mohit Hotwani authored
This gives us offsets in the binary which enables us to run symbolizer to get the function name/source line. After this change stack looks like #0 0x00558c83b8ec (foo.bar+0x2428eb) #1 0x00558c7e9ac8 (foo.bar+0x1f0ac7) #2 0x00558c7ef9b8 (foo.bar+0x1f69b7) Bug: internal b/148287348 Change-Id: I654be3afaecd56a06d0339cf0d6cfc4669812c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053251 Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#741198}
-
Chris Blume authored
Right now, there is a name contains_non_srgb_images that is used a handful of times. The negative "non" complicates things when we have to !contains_non_srgb_images. This CL changes the name to contains_only_srgb_images and inverts the behavior that depends on it. Bug: 955158 Change-Id: I60799094a3f1aea2ffe9cfa58f7f396eb61d1c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055407Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#741197}
-
Scott Violet authored
Specifically make it match the declaration order section: https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.md?cl=head#Declaration_Order BUG=none TEST=none Change-Id: I9380461c30c01d6c6d605764ac3638993dffd991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055048Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741196}
-
Tim Dresser authored
Bug: 1051558 Change-Id: I2748972508acb489f1a455a7dbd8617f26909dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052089 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#741195}
-
Luke Zielinski authored
TBR=robertma Change-Id: I6847834e501645a3e5ad88daabe10e2c64672579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055400 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741194}
-
Regan Hsu authored
This CL will not land until https://chromium-review.googlesource.com/c/chromium/src/+/2051038 and https://chromium-review.googlesource.com/c/chromium/src/+/2051164 lands. Bug: 1049830 Change-Id: I064397122611884eb4e3ed22650c06dda1955191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050097 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#741193}
-
Katie Dektar authored
This reverts commit 0db01e1d. Reason for revert: Appears to cause a compile failure and closed the tree Original change's description: > [Android] Move NfcSystemLevelSetting and modularize NFC code > > NfcSystemLevelSetting is not a shared class used by multiple Settings > screens, so move it out of the org.chromium.chrome.browser.settings > package to org.chromium.chrome.browser.nfc instead. > > Since the classes in org.chromium.chrome.browser.nfc are fairly trivial > to modularize, organize and build to a separate target in > //chrome/browser/nfc as part of go/chrome-hoa efforts. > > Bug: 1052056 > Change-Id: Ia402340b05596ad880f16aef9521003658c1e2a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032785 > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741173} TBR=yfriedman@chromium.org,wnwen@chromium.org,engedy@chromium.org,blundell@chromium.org,twellington@chromium.org,pnoland@chromium.org,chouinard@chromium.org Change-Id: I4b89ae8773c38139c28ea7e1557217fc7abb98a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055589Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741192}
-
Jeff Yoon authored
Follow up to CL 1949847, adding the data deps for host app for * ios/web eg2_tests * ios/showcase eg2_tests Bug: 1019533 Change-Id: Idd71f6fe715356e1dd0100bae3361bce98e8fd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042193 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#741191}
-
Ayu Ishii authored
This change introduces the otp option for credential manager. The shape is as shown below, and is behind the SmsReceiver flag. This implementation piggy backs on top of previous implemented version of SMS Receiver API, now renamed to WebOTP API. navigator.credentials.get({otp: {transport: ["sms"]}}).then((credential) => { let type = credential.type; // "otp" let id = credential.id; // otp string ex. "ABC1234" }); Tested: locally, browsertests, wpt Relevant resources: Explainer: https://github.com/samuelgoto/WebOTPs/blob/master/explainer.md Early discussions: https://github.com/whatwg/html/issues/3745#issuecomment-395327173 Discussed alternatives: https://github.com/samuelgoto/WebOTPs/blob/master/explainer.md#api-alternatives-considered Design Doc for Sms Receiver API(V1): https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit?usp=sharing OT of Sms Receiver API(V1): https://developers.chrome.com/origintrials/#/view_trial/607985949695016961 Bug: 1045233 Change-Id: I4b68f08f2b26047809f6dcf84cbd82245e741f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018331 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#741190}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1c5647025500..951c1df3ce7d git log 1c5647025500..951c1df3ce7d --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tsepez@chromium.org Use Optional<> return in CheckStyleFromCaption(). 2020-02-13 thestig@chromium.org Tidy CPDF_FormControl. 2020-02-13 thestig@chromium.org Fix regression with CheckStyleFromCaption(). 2020-02-13 hikakar@microsoft.com Fix the rendering of scientific symbols correctly 2020-02-13 tsepez@chromium.org Tidy CFX_CSSSyntaxParser, part 2. Created with: gclient setdep -r src/third_party/pdfium@951c1df3ce7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0fe7da575c1bb11c1fa5ffa9b431d41715a9ddb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0715f3d5b5f1..c0ffd42151c6 Created with: gclient setdep -r src-internal@c0ffd42151c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025256,chromium:783819 Tbr: jbudorick@google.com Change-Id: If8418dfb19336fc7e244e1f48f47a0202993c651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055366Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741188}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/503b21fd3203..eceeb201f72b git log 503b21fd3203..eceeb201f72b --date=short --first-parent --format='%ad %ae %s' 2020-02-13 bclayton@google.com third_party/marl: Add mips64 support to BUILD.gn Created with: gclient setdep -r src/third_party/swiftshader@eceeb201f72b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If42b6ec6c26912677fa4074a3f78bb0c7aad63cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055049Reviewed-by:
-
Zhiheng Li authored
Bug: b/149024372 Test: cast_shell_junit_tests Change-Id: I75acbf9adf659f3e61d1855ea6771e895a305fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052246 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741186}
-
Andrew Grieve authored
Causes "git cl format" and "git cl upload" presubmit checks to format changed lines in a review to adhere to our style guide (PEP-8). Bug: 846432 Change-Id: I9330b3786d3a860bcbe79b5b5299b966ac6bd1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989511 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741185}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f912eb7116e9..e61ca55caf34 git log f912eb7116e9..e61ca55caf34 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 ntfschr@chromium.org Devil: tolerate malformed device cache Created with: gclient setdep -r src/third_party/catapult@e61ca55caf34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1051795 Tbr: skyostil@google.com Change-Id: If74931ea3367332b06aaa895ed24bd73637abf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054964Reviewed-by:
-
Katie Dektar authored
This reverts commit 9a8afe6e. Reason for revert: Test is flaky, see crbug.com/1051546 Original change's description: > Enable SkiaCopyOutputScalingPixelTest > > The test should work with SkiaRenderer now. > > Bug: 1047217 > Change-Id: Ib467e836cf7abc3a8d00b606d81ed33470929db2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050616 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740428} TBR=backer@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047217,1051546 Change-Id: I7184e18735d436edb404a0d9f342cef9830ce002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055283Reviewed-by:
-
Antonio Gomes authored
The message is not used. BUG=993189 R=kinuko@chromium.org Change-Id: Ib2d4e8842520381339ceadf0819a436459b17dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051190 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#741182}
-
Asanka Herath authored
The //cc:cc component was directly depending on //components/ukm. This is unnecessary since it really only needs to depend on //services/metrics/public/mojom which it was inheriting via public_deps. Having this unnecessary dependency causes the following dependency chain: - //third_party/blink/public:blink_headers --> - //cc:cc --> - //components/ukm:ukm --> - <<hypothetical component that wants to look at blink_headers>> --> - //third_party/blink/public:blink_headers. This relaxing the //cc to ///components/ukm dependency gives us more flexibility in adding a new dependency to //components/ukm where such a dependency itself is interested in blink_headers. Bug: None Change-Id: I71d19991b8068852cd06d31f79489012325980a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053148Reviewed-by:
-
Eric Orth authored
Original: crrev.com/c/2001144 Revert: crrev.com/c/2050749 Was reverted due to crashes where |ResolveContext::doh_server_availability_| size was not matching up with the number of DoH servers in the config in |current_session_|. Because the config is const in the session and |doh_server_availability_| is only and always set when setting |current_session_|, the most plausible theory I have is that the session pointer comparisons were invalid due to memory reuse (new session but incorrectly recognized as the old session because it has the same pointer). Protected the |current_session_| pointer from reuse via WeakPtr. Not ideal, but DnsSession ownership is already very loose with both ref counting and other WeakPtr instances. Also added a bunch of CHECK validations to help spot similar issues if this continues to or later crashes similarly. Bug: 1022059 Change-Id: Ibf030fa06882f02830bbaa13e45d9669815e9c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050758 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741180}
-
Matt Mueller authored
Bug: 1040681 Change-Id: Iefab63f598fecc3519065b0440815e2d65bb5070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036273Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
henrika authored
Adds support for: - Tracking stream creation sequence using unique ID. - Improves native logging related to usage of fake output streams. - "Stream is alive" marker. - Duration of stream. - Injects logger into PulseAudioOutputStream. - Improves native logs in AudioManagerBase. Example result: https://paste.googleplex.com/6677685310849024 Bug: 1017219 Change-Id: I9ae2d5a87a81e19de15faddfb1cd66250805eaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019243 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#741178}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9ed65aa1904..9ee86e5a4697 git log e9ed65aa1904..9ee86e5a4697 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 ehmaldonado@google.com gerrit-util: Fix GCE check from behind proxy. Created with: gclient setdep -r src/third_party/depot_tools@9ee86e5a4697 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050380 Tbr: agable@chromium.org Change-Id: I38471ada322404d47d77a03a00e407c0c1d33ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054965Reviewed-by:
-
Manu Cornet authored
The idea behind some of the recent refactorings is to split the logic for calculating target bounds and upating the layout to each shelf component instead of doing everything in the shelf layout manager. Previously, some (limited, soon more) work was delegated to the shelf widget's |UpdateLayout| method, but calling that method from the "central" place in the shelf layout manager was omitted. This change reinstates that call. Bug: 1051824, 1050383c Change-Id: Ibcf3bfd26210278ec464f186ae6a0a958f03d644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055392 Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741176}
-
David Bienvenu authored
The policy will allow enterprises who are concerned about the effect of native window occlusion in their environment to disable it easily. Bug: 813093 Change-Id: Ifef8af79652aba4e1433cc5d41585be866296ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032000 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#741175}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7db08fd9..0bee77f5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b67b6c1956a2ccbd35d4c796c22ffa13744c39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054565Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741174}
-
Natalie Chouinard authored
NfcSystemLevelSetting is not a shared class used by multiple Settings screens, so move it out of the org.chromium.chrome.browser.settings package to org.chromium.chrome.browser.nfc instead. Since the classes in org.chromium.chrome.browser.nfc are fairly trivial to modularize, organize and build to a separate target in //chrome/browser/nfc as part of go/chrome-hoa efforts. Bug: 1052056 Change-Id: Ia402340b05596ad880f16aef9521003658c1e2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032785 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741173}
-
Alex Cooper authored
Updates xr_browser_test infrastructure to appropriately grant (or deny) permissions, as well as providing tests with a way to override that. This ensures that tests will keep running when the permissions prompt is enabled by default and can be cleaned up as time permits. Additionally, refactors consent flow tests to a base class and two sub- classes. These sub classes can be used to explicitly test the custom consent flow or permissions prompt behavior. A (local) helper macro was created to indicate which of these tests should be run for both versions versus which tests were specific only to one or the other. To simplify this change (and because the permissions flow is runtime agnostic), consent flow tests are now run against only one runtime. Bug: 1043241 Change-Id: Ifb9040c46993f8b0375383426a4cafa7e342f6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055304 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741172}
-
Adrienne Walker authored
This is part of moving IndexedDB to live in the storage service. This API used by these unit tests needs to communicate over the IndexedDBControl interface instead of directly via IndexedDBContext. Bug: 1015214 Change-Id: Ida9d15282afe0946f14e1d4dc99573500b818769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048028 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741171}
-
Meilin Wang authored
This is a reland of 64cf44e2 Original change's description: > Add a new test case for |AssistantManagerServiceImpl|. > > This CL adds a new test case to ensure we update the supported action > list stored in |AssistantManagerServiceImpl| when ambient mode state has > changed. > > Bug: b/149237062 > Test: run the new unit test added in this change. > > Change-Id: Idc3c538e023cb59e76fb6c71219e4846da6d9c30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969777 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740817} Bug: b/149237062 Change-Id: I56f942df9293808a2411272022fe3cf3923096f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053287Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icdc972be1e6472b957592d49790108253c81a3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055050Reviewed-by:
-
Evan Stade authored
This hooks up app-modal JS dialogs without adding any new APIs. Most functionality is "free" i.e. already componentized, including - alerts, prompts, and confirms (such as onbeforeunload) - anti-spam suppressions ("prevent this webpage..." checkbox) We will want to convert all except onBeforeUnload confirmations to tab-modal, but we'll still need app-modal for onBeforeUnload, so this is a reasonable stepping stone. TBR=twellington@chromium.org Bug: 1025256 Change-Id: I66575619dbfafcc0a575082c23f1e567568c29d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979154 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741168}
-
Shawn Gallea authored
This is no longer needed to reduce headless framerate. https://chromium-review.googlesource.com/c/chromium/src/+/1815049 is used instead. Test NONE Bug: NONE Change-Id: Iba114a91e6ca07a6383303b729cf5d5b415931db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055344 Commit-Queue: Shawn Gallea <sagallea@google.com> Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741167}
-
Jose Lopes authored
The callback (init_cb_) is effectively called only once. This is guaranteed by the std::move(): https://cs.chromium.org/chromium/src/media/blink/multibuffer_data_source.cc?rcl=8d2d53d6df3c7347f9d4c32074540b990a8f1736&l=631 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I1ba81f8b281339cf514baa7f6739425bb9b9988c Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030962 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Alex Turner authored
Currently, the enabled flag is ignored for the AdTracker, which leads to some synchronous requests being erroneously reported as async. When the enabled flag is false, the task should not be reported to AdTracker. Bug: 1051519 Change-Id: Ia42ba7e6117ad2fc59cd95d41fcb8b1c5650a784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045176 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#741165}
-
Piotr Bialecki authored
The approach to performing hit test has changed, the new API that replaces the legacy one is already enabled by default in M81. https://immersive-web.github.io/hit-test/ Change-Id: Ia89921505ae4ed537c28b117808182efbc79396c Fixed: 1051626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050582Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741164}
-
