GitLab

Two little fixes which did not fit in any of the major CLs for the internals page.

BUG=347927

Review URL: https://codereview.chromium.org/232663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262971 0039d316-1c4b-4281-b951-d872f2087c98

Before deleting a profile, cancel all in-progress downloads to prevent a "Do you really want to exit Chrome" popup, which (1) is confusing because the message is not accurate, and (2) prevents a window corresponding to the deleted profile from closing, leaving it in an inconsistent state.

A UI update (warning the user that downloads will be canceled) will follow in a separate CL.

Note: I'm aware that this doesn't address crbug.com/289390 which is another way to trigger the same underlying bug. Working on it...

BUG=336725

Review URL: https://codereview.chromium.org/214523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354405,346626

Review URL: https://codereview.chromium.org/225093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352046

Review URL: https://codereview.chromium.org/231793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262968 0039d316-1c4b-4281-b951-d872f2087c98

The string.h is required only when using the address sanitizer.

Review URL: https://codereview.chromium.org/229973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335764
TEST=build and run the test on snow

Review URL: https://codereview.chromium.org/227613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262966 0039d316-1c4b-4281-b951-d872f2087c98

ChromeNativeAppWindowViews now installs the EasyResizeWindowTargeter
into the content window, not its root window. The root window does not
have a delegate, which means it doesn't handle events on Linux.

BUG=357049
COLLABORATOR=sadrul@chromium.org
TEST=Open Text chrome app. All edges and corners should be draggable to
resize the app.

Review URL: https://codereview.chromium.org/224903022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262965 0039d316-1c4b-4281-b951-d872f2087c98

Added the chromeos::BluetoothRemoteGattCharacteristicChromeOS class which
implements a remote instance of device::BluetoothGattCharacteristic for the
Chrome OS platform.

BUG=360266,340529
TEST=device_unittests

Review URL: https://codereview.chromium.org/228643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262964 0039d316-1c4b-4281-b951-d872f2087c98

This enables permissions bubble policies that rely on user gesture signals for deciding when/how to show bubble UI for permission requests.

BUG=332115

Review URL: https://codereview.chromium.org/185813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262963 0039d316-1c4b-4281-b951-d872f2087c98

Mainly nits related to preference protection.

BUG=349158

Review URL: https://codereview.chromium.org/220203011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262962 0039d316-1c4b-4281-b951-d872f2087c98

Changes TranslateUIDelegate to:
- Take in a TranslateClient and TranslateManager rather than a WebContents.
- Go through TranslateDriver and TranslateClient APIs rather than talking
  directly to TranslateTabHelper.

Moves TranslateUIDelegate into the Translate component.

BUG=335084
TBR=thakis

Review URL: https://codereview.chromium.org/229363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262961 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces an interface that will be used to access all of chrome/ API.
It is implemented by the FaviconTabHelper, and allows moving the
GetFaviconService() method out of the FaviconHandler.

BUG=359095

Review URL: https://codereview.chromium.org/228783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262960 0039d316-1c4b-4281-b951-d872f2087c98

* Added new mode in TrayUser for the case when new account management is
  enabled (--new-profile-management flag). In fact TrayUser is now supporting
  four different modes, depending of states of |multi-profiles| flag and
  |new-profile-management| flag.
* Massive refactoring were made in tray_user.cc to isolate UserCardView
  creation in separate class and make code more clear.
* UI for the cases when new account management is disabled remained without
  changes.

Known issues:
* There are no tests for new UI. Hopefully old UI is covered by tests already.
* New UI is not accessible yet.
* Stub implementation of UserAccountsDelegate is used for backend.

BUG=344844
TEST=manually

Review URL: https://codereview.chromium.org/210903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262959 0039d316-1c4b-4281-b951-d872f2087c98

The webRequestInternal permission was unused, thus:
- Remove the permission webRequestInternal.

While there, also does:
- Remove manual registration of webRequest API and instead rely on automatically generated registration.
- Remove context 'content_script' from webRequestInternal API.

BUG=359964

Review URL: https://codereview.chromium.org/228343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262958 0039d316-1c4b-4281-b951-d872f2087c98

R=dcarney@chromium.org
R=jochen@chromium.org (OWNERS)
BUG=276323

Review URL: https://codereview.chromium.org/230613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262957 0039d316-1c4b-4281-b951-d872f2087c98

The only purpose of this change is to rename some member
variables and accessors in BrowserAccessibility so that in the
subsequent change we can repurpose BrowserAccessibility to
make use of AXNode instead.

There should be no code logic changes here - just look at
browser_accessibility.h, everything else just follows from
that.

BUG=316726

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262673

Review URL: https://codereview.chromium.org/224803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262956 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262955 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff dcarney@chromium.org in case of problems.

TBR=dcarney@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/231793009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262951 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Chrome for ChromeOS build is failing:
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::replaceData(unsigned int, unsigned int, const WTF::String&, WebCore::ExceptionState&)':
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:146:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1934.0_alpha-r1:      newStr.remove(offset, realCount);
chromeos-chrome-36.0.1934.0_alpha-r1:                                     ^
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp: In member function 'void WebCore::CharacterData::deleteData(unsigned int, unsigned int, WebCore::ExceptionState&, WebCore::CharacterData::RecalcStyleBehavior)':
chromeos-chrome-36.0.1934.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit/Source/core/dom/CharacterData.cpp:132:36: error: 'realCount' may be used uninitialized in this function [-Werror=maybe-uninitialized]
chromeos-chrome-36.0.1934.0_alpha-r1:      newStr.remove(offset, realCount);
chromeos-chrome-36.0.1934.0_alpha-r1:                                     ^

Original issue's description:
> Blink roll 171141:171225
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171225&mode=html
> TBR=
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262942

TBR=eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/233003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262950 0039d316-1c4b-4281-b951-d872f2087c98

I was reviewing most of the changes to this subsystem historically.

TBR=rpaquay

Review URL: https://codereview.chromium.org/232203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262947 0039d316-1c4b-4281-b951-d872f2087c98

Changes to extension_function_histogram_value.h require changing
tools/metrics/histograms/histograms/histograms.xml, but this is not
being enforced.

NOTRY=true

Review URL: https://codereview.chromium.org/228643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262946 0039d316-1c4b-4281-b951-d872f2087c98

R=abarth@chromium.org
BUG=345027

Review URL: https://codereview.chromium.org/224683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359970

Review URL: https://codereview.chromium.org/230923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262944 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262943 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171225&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/232453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262942 0039d316-1c4b-4281-b951-d872f2087c98

The Info URL is used to send the user to a landing page when they see a
welcome notification for a synced sending service.

TBR=petewil@chromium.org
BUG=338864

Review URL: https://codereview.chromium.org/228753006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262940 0039d316-1c4b-4281-b951-d872f2087c98

Both base and protocol directories had util.cc files, which confuses
the linker when compiling them into a single static .a lib.

BUG=276739

Review URL: https://codereview.chromium.org/231943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93286
Test=No visible change. Ran the aforementioned test from content_unittests.

Review URL: https://codereview.chromium.org/232253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262937 0039d316-1c4b-4281-b951-d872f2087c98

Instead of ad-hoc DCHECKs of internal state throughout the job's
callbacks, introduce a phase system and add DCHECKs to internal state
getters/setters in terms of it.

BUG=349337

Review URL: https://codereview.chromium.org/229403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262936 0039d316-1c4b-4281-b951-d872f2087c98

If seek happens while requesting data for the inactive chunk, the ack for the data request will call OnDecodeCompleted().
However, the decoder job is waiting for the OnDecodeCompleted() from the active chunk.
Tests:We already have seveal tests covering requesting inactive chunk during seek. This CL should fix the flakiness in there.

BUG=361541

Review URL: https://codereview.chromium.org/227523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262934 0039d316-1c4b-4281-b951-d872f2087c98

In r262636 I deleted the Shutdown() methods from SWRegistration and
SWVersion, but it caused a leak in RepeatedlyObserveStatusChanges.

In the previous code the status change callback (ObserveStatusChanges)
holds a ref to ServiceWorkerVersion, which was ok when we had Shutdown()
(as we could explicitly clear the status change callback there), but
now we don't, so we have cyclic reference there.

I just changed make_scoped_refptr(version) to base::Unretained(version)
when we pass the version to the callback, so that the callback no longer
holds a ref to the Version.

BUG=361504
TEST=ServiceWorkerVersionTest.RepeatedlyObserveStatusChanges with asan/lsan

Review URL: https://codereview.chromium.org/230373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262933 0039d316-1c4b-4281-b951-d872f2087c98

R=zea@chromium.org

BUG=341513

Review URL: https://codereview.chromium.org/228553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262932 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. The
touch factory class & ui::CopyAreaToCanvas function are currently only
supported under X11.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262931 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. The
touch factory class is currently only supported under X11.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262930 0039d316-1c4b-4281-b951-d872f2087c98

Turns out that https://chromiumcodereview.appspot.com/11788005 made it
such that blocking for JavaScript doesn't require ContentViewClient,
just a ContentViewCore. Many places in tests still get the ContentView
in order to create a TestCallbackHelperContainer in order to wait for
JavaScript to execute...

Instead for clients that don't care about waiting themselves for JS to
execute, just do it inside JavaScriptUtils.

BUG=360644

Review URL: https://codereview.chromium.org/231693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262929 0039d316-1c4b-4281-b951-d872f2087c98

I found this while trying to build a target that depends on net.

BUG=None
TEST=ninja -C out/Debug_gn
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/231883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262928 0039d316-1c4b-4281-b951-d872f2087c98

This event code is all currently X11-specific. Remove it from the
ChromeOS-on-Ozone build.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/226413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262927 0039d316-1c4b-4281-b951-d872f2087c98

* Limits the maximum size of the button, truncating text if it can't fit
  (yay for testing with languages that I didn't have translations for
  initially).

* Stops an NPE that can trigger if the user uses the banner to install an
  app, uninstalls the app in the background, then returns to Chrome to
  open the app from the banner itself.

BUG=359208,359199

Review URL: https://codereview.chromium.org/231273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338888

Review URL: https://codereview.chromium.org/201673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262925 0039d316-1c4b-4281-b951-d872f2087c98