- 15 Oct, 2020 9 commits
-
-
Jamie Madill authored
This adds an is_unexpected tag, and handles multiple results (e.g. from retries) correctly. Bug: 931731 Bug: 1138507 Bug: angleproject:5124 Change-Id: I23054010db058eaa9d275c9b5de3052030210024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472338Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817288}
-
Clark DuVall authored
These changes are needed to allow feed to access resources from the feed isolated split. The implementation of the DFM is in the internal change here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3336642 The feed DFM also uncovered a bug in how we were handling feature jars in R8. If multiple features specified a jar that was not in the base module, the jar would only be applied to the first feature that specified it instead of moving to the base module. Bug: 1126301 Change-Id: Iedc67a97358414adfa82e7a199bf5c72b1f47eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469235 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#817287}
-
Toni Barzic authored
It's currently always returning nullptr. BUG=None Change-Id: Ib953cf14ae956309ef6077adb000edbbec8561f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472701Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817286}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I052c6ec2f1bd27625e8ba1567026ccbffd750719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817285}
-
Avi Drissman authored
Removing cross-origin dialogs is being worked on in https://chromestatus.com/feature/5148698084376576. Make sure that relevant UMAs don't expire. Fixed: 1138390 Bug: 1065085 Change-Id: I6cb9c05bb838e065ff98e7b4af9f2d9fcc5adf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472481 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817284}
-
Marc Treib authored
Out of its many past buckets, only two remained, neither of them particularly useful: CANCEL_DURING_CONFIGURE: This is rare, and doesn't seem worth tracking specifically. STOP_FROM_OPTIONS: Similar information is available in Sync.StopSource. Bug: 939752 Change-Id: Ia2392f498aa994880642059a603a23aecdaf4ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467902 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817283}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba4c87c9..b901b8f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbcbd4ec9d6a22136b00466fd65e678e391e8da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817282}
-
Eric Lawrence authored
Today, the NetLog's |constants| data contains the list of field trials that were active when the capture begins. Field Trials may be enabled lazily and will not appear in the NetLog if enabled after logging begins. To ensure that the NetLog reflects all active trials, also record the list of active field trials in the |polledData| info recorded when the capture ends. Bug: 1133396 Change-Id: I94211d1c006882ab4cd28e7dd6e08ac3c6217710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469216 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817281}
-
Etienne Pierre-doray authored
Reset max_allowed_sort_key_ when a worker decides to yield to avoid having many workers yielding for the same task. I considered using compare_exchange_weak but figured that was unnecessary. The drawback is that a worker might overwrite an update and wrongly prevent another worker from yielding. Once it returns though, max_allowed_sort_key_ is updated again so a worker will always *eventually* yield. This causes ShouldYield to be non const. Change-Id: I81bef8e632becba758eec8d96720fa32c4ef78e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453110 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#817280}
-
- 14 Oct, 2020 31 commits
-
-
Muyao Xu authored
Bug: b/170651374, 1117673 Change-Id: Iba8a5c71033514e560bb5b3d1b5274379cbe5245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464788Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#817279}
-
Klaus Weidner authored
This reverts commit f2038e2b. Reason for revert: causes crashes on Android 10+: https://crbug.com/1138664 Original change's description: > Fill in usage flags and sample fields on skia GrVkImageInfo. > > Change-Id: I1da7035e84173f5e9d8021ec3d2639f2ba96bf89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469261 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Greg Daniel <egdaniel@google.com> > Cr-Commit-Position: refs/heads/master@{#817141} TBR=penghuang@chromium.org,egdaniel@google.com Change-Id: Ide84d237760384033a83e71137602cd6718d5683 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473439Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817278}
-
Peter Kasting authored
Bug: 772945 Change-Id: I5729038963db819ab639cc105ae7d6272eb3ea8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472436 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#817277}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61aa96cc7a59..6d2775c5ef51 2020-10-14 vidorteg@microsoft.com Modifying scripts for i18nString localization call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67e18ac6854d7011c194720d27e7957daacdb2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473022Reviewed-by:
-
Aaron Colwell authored
Moving is_guest field from SiteInstanceImpl into SiteInfo since this information should really be part of the security principal represented by SiteInfo. This also cleans up several call sites where a SiteInfo and is_guest flag were being passed in. These have been simplified to only require the SiteInfo now. This change simply moves the field and updates function signatures. There is no change in behavior other than the guest boolean now being considered in all SiteInfo comparisons. This shouldn't result in any observable behavior changes though because guest and non-guest SiteInfo comparisons usually failed anyways because the site_url fields do not match. Bug: 1085275 Change-Id: I7cd264728d1f82ce2dae97193c77a0380ae40cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429605 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#817275}
-
Ryan Heise authored
Change-Id: If8268b5526f9e8c294dd63aa365f650f7e0a0a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472018Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817274}
-
Brian Sheedy authored
Updates the following GPU expectation tags: 1. angle-no-backend is now angle-disabled, as that is more accurate. 2. The Skia Renderer tags now use skia-renderer as a prefix instead of a suffix. Bug: 1111876, 1011107 Change-Id: I3b8ee3175449e4e55eebdd78e575ac2ebcfeaf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472903Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817273}
-
Bao-Duy Tran authored
This is a mock for ComponentExtensionIMEManagerDelegate interface, so had better be named after it with just a prefix "Mock" added, for some little consistency that would facilitate code browsing and readability. It's not quite worth it to shorten "Extension" to "Ext" for small length savings on a test-only thing, while adversely impacting consistency. It's out of scope here to make conciseness improvement to the existing naming scheme of this whole family of interfaces and classes. The rename here also makes it precisely consistent with the names of .h and .cc files where the Mock is declared and defined. Bug: 1134465 Change-Id: Ie8ed0d1ee39813ae722e677c4a58628a8e49d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442649 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817272}
-
Sunny Sachanandani authored
TBR=zmo@chromium.org Bug: 1136971 Change-Id: I0471013bd944851bd23953d7d1e90df4ba79e229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472909 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#817271}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/73b70229af3a..84b70a6e4d93 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f2b8b6e87396 to ff267ca60e14 (2 revisions) 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 435916e544cc to f2b8b6e87396 (1 revision) 2020-10-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4311dd05c883 to 435916e544cc (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ib445bb81fe3a552451171cf1b0d2626e307bfdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473020Reviewed-by:
-
Elly Fong-Jones authored
This involves a bit of restructuring. This change: 1) Introduces ShellSurface::Set{Parent,Container}Internal, which ensure that the minimize/maximize/resize state is correctly updated when these properties change; 2) Makes ShellSurface::parent_ private instead of protected so subclasses can't accidentally change it without using the new internal setter; 3) Has these internal setters and the ShellSurface constructor set the state of CanMaximize/CanMinimize/CanResize Bug: 1075649 Change-Id: I019ce03248eef3aea6ac16c509f2e5d3312fb940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472615Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817269}
-
Bartek Nowierski authored
It performs consistently worse in all situations. Make CHECKED_PTR2_AVOID_BRANCH_WHEN_DEREFERENCING the default variant while at it, because it performs slightly better than the default one. Bug: 1073933 Change-Id: Iacd53766ea83b2e3d0e074e5a85034f51ed1bf9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463089 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817268}
-
wutao authored
Changes in this patch based on new UX spec: 1. Add a spinner in ambientMode page. 2. Adjust spinner size/position in ambientMode/photos page. 3. Gray out radio button groups when ambient mode is off. Screenshot for 1: https://screenshot.googleplex.com/6LdbiNmURdVs5Fo Screenshot for 2: https://screenshot.googleplex.com/3u8CXUtzGsNjE58 Screenshot for 3: https://screenshot.googleplex.com/Bu79xVLQ86Wuu4F Bug: b/170409067 Test: Added new js tests Change-Id: Ib5a98bef70eaa87770afedffa454d70cf88f6176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464903Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817267}
-
Austin Eng authored
This enables WebGPU on Linux behind --enable-unsafe-webgpu and --enable-features=Vulkan. Shared image support requires SkiaRenderer (default on Linux) and Vulkan to be enabled. Bug: 976495 Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817266}
-
Zhaoyang Li authored
Add %c to raw profile filename pattern so coverage data won't lost at program crash. See: https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program Bug: 1090188 Change-Id: I4eab6137a385701186f2c330ce4be35e2694b229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472920Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change adds the ability to stop the propagation of an action, even if it's matched by UserActionMonitor. The motivating example for this change is the interactive tutorial lesson that requests users to press Control. After successfully pressing Control, the tutorial automatically moves the user to the next lesson and reads the text. However, there are cases where the text is never read because ChromeVox cancels speech when Control is pressed. The solution is to add a boolean parameter that can specify whether or not the action should propagate, even if matched. This ensures that speech for the next lesson is not cancelled after completing the interactive Control key lesson. Fixed: 1132944 AX-Relnotes: N/A Change-Id: I6e63f7612b6fdf9aa398d46ff7746d5273aee683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469436Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#817264}
-
Dave Tapuska authored
This removes the somewhat duplicated mouse lock functionality in content::MouseLockDispatcher and uses the blink::PointerLockController solely. Pepper called directly into the content API previously and input was directed to the MouseLockDispatcher before it was sent into blink. Now Pepper calls an API on the WebPluginContainer to request pointer lock (similar to requesting fullscreen). The pointer locked target becomes the plugin container and input is dispatched to the plugin via normal blink input processing. Tested pepper running out/Release/chrome --register-pepper-plugins="out/Release/libppapi_example_mouse_lock.so;application/x-ppapi-example-mouse-lock" ppapi/examples/mouse_lock/mouse_lock.html BUG=1130991 Change-Id: I6452738f4bae33a0d2ad584ba80705d277b103f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458426 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817263}
-
Olivier Yiptong authored
This bumps the flag expiry to M90, when the planned Origin Trial is set to end. Bug: 535764 Change-Id: Id7333ad64cd4ce89073b7409652c0197c311f2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472616 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817262}
-
Sorin Jianu authored
It is incorrect to cast from an HRESULT to a enum class. If further error handling is needed, then additional error information must be propagated out using a different mechanism. Right now, a generic Result::kServiceFailed is sufficient. Bug: 1137623 Change-Id: I0014c6e222de50af2c7854d5aa8c55c3c564db36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472704Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817261}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fa0140b92951..52c1a859d9eb 2020-10-14 natsu@google.com Revert "Revert "Update virlg_hw path to reflect Minigbm"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I98566885b8d1bc3a226f39f325734f9bd6abcf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473021Reviewed-by:
-
chinsenj authored
Currently if a Textfield has a translucent background, the contents of the textfield contains spaces and a user makes a selection, some areas are drawn over multiple times making them slightly more opaque. This CL merges overlapping selection regions when the selection's background is translucent to fix this bug. Test: manual + added test Change-Id: Ic222ab0fba9e2a36f43851620313308057c60bed Fixed: 1134440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460953 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817259}
-
Mounir Lamouri authored
Bug: 1055392, 1125789 Change-Id: Ib4f4064f917e3f4eb1cb2468c1f191ba33ad0281 Fixes: 1055392, 1125789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469462Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#817258}
-
John Williams authored
Bug: 1138469 Change-Id: Idcb06541f74c1795abef7725176aa87b7cab0337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472206Reviewed-by:
-
Charlene Yan authored
Bug: 1116118 Change-Id: I5988c0d37fd9049f3e31e04a19e9b7387114edda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472606Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c924a88e3349..f4bda743ff8d 2020-10-14 johnstiles@google.com Rename SkTArray::reserve to reserve_back. 2020-10-14 michaelludwig@google.com Update image filter debug samples to use new APIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie1a5d4e91490b9b3d0c90ac8083cd28115fd62f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473026Reviewed-by:
-
Eric Willigers authored
testing/gtest/include/gtest/gtest.h is no longer directly included. We also reduce web_applications includes of base/test/scoped_feature_list.h Bug: 1065748 Change-Id: I51303a11f68cf2d94e68dc68cf88dcc3716751de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470058 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#817254}
-
Scott Violet authored
As 87 has branched, this now tests 87, 86 and 85. As we know 84 isn't being used at this point, it's dropped. BUG=none TEST=test only changes Change-Id: I2d5066c5a05465ee70f372ef1766f9978f989e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472445Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#817253}
-
tby authored
We've previously had approvals so that I could LGTM metrics for the chrome knowledge team. We'd like to continue that system under the new split of histograms files if possible, so this CL adds me as owner to the directories we have metrics in. Specifically, those are: - apps/ and ash/ for launcher ml - auto/ for auto screen brightness - local/ for local search service - others/ for the ml service - power/ for power ml Change-Id: I5a7232c363374fb225e0aabd41a9891fe07e44c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466017 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Ben Pastene authored
This reverts commit d1aab4b5. Reason for revert: To fix compile failures after crrev.com/c/2472913 See https://crbug.com/1138151 Original change's description: > Implemented generic-hand-select over OpenXR > > Implemented generic-hand-select using the MSFT hand interaction > extension. > > Change-Id: I25595dfcf05fd0e23fb7ee9484c333321746fa0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469836 > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Lachlan Ford <laford@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#817138} TBR=rafael.cintron@microsoft.com,alcooper@chromium.org,laford@microsoft.com,phle@microsoft.com Bug: 1138151 Change-Id: I33d1dcccf893b79e47738447b8c6c8ac01ae72f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473081Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817251}
-
Yuke Liao authored
This CL runs ui_base_unittests on lacros CQ because according to user report, ui_base_unittests breaks frequently on CI. ui_base_unittests takes ~10 seconds to run, so the overhead to CQ is minimum. Bug: 1134495 Change-Id: I882ff79f94c79752977c0b4b353431c2d7cbb860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472464Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817250}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602633476-69602bad93ac5850796e454db1a842456d0dd6b1.profdata to chrome-win32-master-1602676072-6b1951d9f0e9d329ad053bceb12040099bb1e856.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie0ff5c37e51569add4cac72f13c44d6652214e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471580Reviewed-by:
-
