GitLab

ExternalDataUseReporter class is created with the data use reporting
logic. ExternalDataUseReporter is created in IO thread and moved to UI
thread. It is owned by ExternalDataUseObserver.

BUG=570884

Review-Url: https://codereview.chromium.org/2145863002
Cr-Commit-Position: refs/heads/master@{#406041}

Changes the parent of search widget labels and close buttons in overview
mode to be kShellWindowId_StatusContainer which is still above all
windows but below menus and screen overlays.

BUG=629039

Review-Url: https://codereview.chromium.org/2154323002
Cr-Commit-Position: refs/heads/master@{#406040}

We've seen a sharp augmentation of renderer hangs on Android. This histogram is
meant to help identify the root cause of this renderer hangs, since it's
currently hard to distinguish whether this is happening during normal browsing
or during beforeunload/unload/when the page is closing.

BUG=621303
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2136173003
Cr-Commit-Position: refs/heads/master@{#406039}

BUG=None

Review-Url: https://codereview.chromium.org/2149873002
Cr-Commit-Position: refs/heads/master@{#406038}

BUG=None

Review-Url: https://codereview.chromium.org/2159763002
Cr-Commit-Position: refs/heads/master@{#406037}

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Review-Url: https://codereview.chromium.org/2116583002
Cr-Original-Commit-Position: refs/heads/master@{#405876}
Cr-Commit-Position: refs/heads/master@{#406036}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d2b666834a28..3c2ec02098fa

$ git log d2b666834..3c2ec0209 --date=short --no-merges --format='%ad %ae %s'

BUG=628239

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2162583002
Cr-Commit-Position: refs/heads/master@{#406035}

This should go in after
https://chromium-review.googlesource.com/#/c/349730/ is landed.

Update install-chromeos-fonts.py to install the latest notofonts
and roboto font packages for CrOS.

R=dzhioev
BUG=617281
TEST=OOBE screen still use Roboto
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2043883004
Cr-Commit-Position: refs/heads/master@{#406034}

Fixes a missing lock acquisition from the listener thread when
accessing |channel_|.

Also removes the TSAN suppression for this bug.

BUG=628481
TBR=glider@chromium.org for suppression removal

Review-Url: https://codereview.chromium.org/2158893002
Cr-Commit-Position: refs/heads/master@{#406033}

Double.compare and Long.compare were introduced in api 19, but the
minimum is api 16.  This change uses compareTo instead.

BUG=628711

Review-Url: https://codereview.chromium.org/2157663002
Cr-Commit-Position: refs/heads/master@{#406032}

BUG= internal b/30144624

Review-Url: https://codereview.chromium.org/2154513002
Cr-Commit-Position: refs/heads/master@{#406031}

https://chromium.googlesource.com/skia.git/+log/490c07d77670..6451a0cea600

$ git log 490c07d77..6451a0cea --date=short --no-merges --format='%ad %ae %s'
2016-07-18 robertphillips Add makeSpecial calls to SkGpuDevice GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161533003
2016-07-18 fmenozzi Add filename to gradient scrape
2016-07-18 jcgregorio Revert of remove unused TableMaskFilter (patchset #1 id:1 of https://codereview.chromium.org/2156463002/ )
2016-07-18 bsalomon In GrShape detect that stroked axis-aligned lines are rrects. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151313002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2154313002
Cr-Commit-Position: refs/heads/master@{#406030}

BUG=

Review-Url: https://codereview.chromium.org/2152413003
Cr-Commit-Position: refs/heads/master@{#406029}

Implement a ContentSuggestionsProvider that reads from the
OfflinePageModel, converts to ContentSuggestions and provides those to
the ContentSuggestionsService. Add a chrome-flag to enable the provider
and implement a factory that registers the provider with the service.

The implementation is not usable by users, yet, because extraction of
title, snippet text and image is not implemented. Those fields are
filled with dummy data or left empty. Deduplication, sorting and
discarding are also not implemented.
But the OfflinePageSuggestionsProvider serves as an example for other
ContentSuggestionsProvider implementations and it can be used to test
multiple-section UI implementations.

BUG=628198
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2149453004
Cr-Commit-Position: refs/heads/master@{#406028}

This patch fixes the order of parameters to be correct (progress
comes first).

BUG=588506
R=danakj
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2155893002
Cr-Commit-Position: refs/heads/master@{#406027}

This CL updates the PersonalDataManager to run autofill profile
de-duplication (if enabled) at the appropriate time, depending on
whether autofill profile sync is enabled.

If sync is not enabled, profile de-duplication is run after the
data is initially loaded.

If sync is enabled, profild de-duplication is run after the sync
first becomes active.

In all cases, de-duplication is only run once for a given version
of chromium.

BUG=627519
R=sebsg@chromium.org, mathp@chromium.org

Review-Url: https://codereview.chromium.org/2142123002
Cr-Commit-Position: refs/heads/master@{#406026}

BUG=589586

Review-Url: https://codereview.chromium.org/2132563003
Cr-Commit-Position: refs/heads/master@{#406025}

When building ash_unittests under "simple chrome": cros chrome-sdk gcc
is used. The comment in WindowModalityControllerTest looks like a
multline comment, triggering -Werror=comment.

This CL adjusts the ascii art to avoid triggering that error.

BUG=628667
TEST=ash_unittests builds under "cros chrome-sdk"

Review-Url: https://codereview.chromium.org/2160603002
Cr-Commit-Position: refs/heads/master@{#406024}

The old "egltest" platform set window title to "EGL test" by default.
Would like to have the equivalent for X11.

BUG=internal b/29226425

Review-Url: https://codereview.chromium.org/2156743002
Cr-Commit-Position: refs/heads/master@{#406023}

Most scroll layers in CC update the main thread with changed scroll offsets by
using the did_scroll_callback, which calls into GraphicsLayer to update its
copy of the scroll offset. The exception to this has been viewport layers,
which don't set a did_scroll_callback. Instead, the viewport gets its values
applied in WebViewImpl::applyViewportDeltas.  This was done since viewport
scroll bounds were dependent on page scale and top controls offset so these
values had to be committed atomically.

It turns out, only the inner (visual) viewport's scroll bounds depend on the
page scale. While the outer (layout) viewport's scroll bounds do depend on top
controls, the compositor already clamps the scroll offset to the acceptable
bounds so as long as we apply the top controls delta after the scroll offset
(to prevent the main thread from clamping it again) the outer viewport doesn't
need to be in applyViewportDeltas.

This CL removes the layout viewport as part of applyViewportDeltas and makes it
use the regular did_scroll_callback mechanism. This simplifies the root
scroller implementation which can change which layer is the outer viewport.
Having the outer viewport use the callback avoids some race conditions as to
which layer scroll gets applied to during a change of outer viewport.

I've left the parameter in applyViewportDeltas' signature since that's a large
mechanical change that'll touch many files. This Cl just passes 0 for the
layout viewport scroll delta and a future CL will remove the parameter itself.

BUG=505516
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2144303002
Cr-Commit-Position: refs/heads/master@{#406022}

Also, replace counters with iterators to avoid multiplications

---
Original CL: https://codereview.chromium.org/2145163003/
Original description:
PVer4: Keep track of the smallest hashes not their sizes.
Also, replace counters with iterators to avoid multiplications

BUG=543161
Committed: https://crrev.com/4386b67601ca07f067fa21e21ae7d42dd1430ee3
Cr-Commit-Position: refs/heads/master@{#405662}
---

BUG=543161

Review-Url: https://codereview.chromium.org/2154973002
Cr-Commit-Position: refs/heads/master@{#406021}

Remove [Unforgeable] idl extended attribute in ServiceWorker and CacheStorage.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/897

BUG=627777

Review-Url: https://codereview.chromium.org/2102093002
Cr-Commit-Position: refs/heads/master@{#406020}

BUG=628379

Review-Url: https://codereview.chromium.org/2151113002
Cr-Commit-Position: refs/heads/master@{#406019}

Currently, there can be a situation where if the plugin removes itself
during initialization, the container is destroyed but the placeholder
plugin is not. This patch fixes this issue.

BUG=620515

Review-Url: https://codereview.chromium.org/2151483007
Cr-Commit-Position: refs/heads/master@{#406018}

There was a bad interaction between throttled task queues and
logic in TimerBase::setNextFireTime that could cause setInterval
to stop firing.

If a timer was posted to a throttled task queue after running on
a normal task queue, it was possible for NOW to be in the past.

Logic existed in TimeDomain::ComputeDelayedRunTime to compensate
for this. Usually that worked fine, however the anti-drift logic
in TimerBase for repeating tasks could cause the scheduled run
time (as visible to TimerBase) to fall on the exact same time as
the previous run.  This would cause TimerBase::setNextFireTime
to nop out, which would cause the setInterval to stop firing.

This patch prevents that by changing ThrottledTimeDomain to be based
on RealTimeDomain.  This means Now() is the real time rather than a
periodically updated virtual time.  I.e. it's monotonically increasing.

At the same time I've remove the now useless
TimeDomain::ComputeDelayedRunTime

BUG=625041

Review-Url: https://codereview.chromium.org/2155143002
Cr-Commit-Position: refs/heads/master@{#406017}

Reland of New PaintController under-invalidation checking (patchset #1 id:1 of https://codereview.chromium.org/2156053002/ )

Reason for revert:
The original CL is to discover such bugs. Will mark the test failure in the reland.

Original issue's description:
> Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ )
>
> Reason for revert:
> NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481.
>
> Original issue's description:
> > New PaintController under-invalidation checking
> >
> > This is a follow-up of https://codereview.chromium.org/2107103002/
> > which broke the original under-invalidation checking in
> > PaintController.
> >
> > BUG=596983,510908
> >
> > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
> > Cr-Commit-Position: refs/heads/master@{#405805}
>
> TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=596983,510908
>
> Committed: https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64
> Cr-Commit-Position: refs/heads/master@{#405988}

TBR=chrishtr@chromium.org,pdr@chromium.org,grt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596983,510908

Review-Url: https://codereview.chromium.org/2162603002
Cr-Commit-Position: refs/heads/master@{#406016}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/db420127..3b4db493

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2162553002
Cr-Commit-Position: refs/heads/master@{#406015}

Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the OutputNodeVolumeChanged signals responding from cras, do not pop up the volume bar for such signals.

BUG=625222

Review-Url: https://codereview.chromium.org/2146313005
Cr-Commit-Position: refs/heads/master@{#406014}

Several failures have tracking bugs or were mis-classified.

BUG=483282,627531,624506,626068
BUG=angleproject:1246,angleproject:1268
R=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2146593002
Cr-Commit-Position: refs/heads/master@{#406013}

https://chromium.googlesource.com/chromium/src/+/b5683a83c

BUG=624285
TBR=jgruber@chromium.org

Review URL: https://codereview.chromium.org/2156233002 .

Cr-Commit-Position: refs/heads/master@{#406012}

presentSSLError:forSSLStatus:recoverable:callback: is not implemented
by Tab anymore.

BUG=602298

Review-Url: https://codereview.chromium.org/2146763003
Cr-Commit-Position: refs/heads/master@{#406011}

https://chromium.googlesource.com/skia.git/+log/eaf6d4102258..490c07d77670

$ git log eaf6d4102..490c07d77 --date=short --no-merges --format='%ad %ae %s'
2016-07-18 msarett Test auto merger

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2159783002
Cr-Commit-Position: refs/heads/master@{#406010}

When loading the STHs, the STHSet Component will invoke the
SafeJsonParser up to half a dozen times (one for each STH), which
can have performance implications.

Also update the PostAfterStartupTask documentation to indicate the
task will be posted immediately if called after start-up.

BUG=607946

Review-Url: https://codereview.chromium.org/2140093002
Cr-Commit-Position: refs/heads/master@{#406009}

There is a place in RenderFrameImpl::OnFind where after one find match is found, it reports that single match just to indicate that there is at least one match in the frame. This is useful when searching the frame for the first time, but pretty meaningless during a "find next" request since the whole frame will have already been searched and all of the matches reported beforehand. It's also detrimental since it will temporarily lower the global match count and then have to recalculate various things when it goes back up.

This patch prevents this single match reply during "find next" requests.

BUG=457440

Review-Url: https://codereview.chromium.org/2122263004
Cr-Commit-Position: refs/heads/master@{#406008}

BUG=

Review-Url: https://codereview.chromium.org/2083743002
Cr-Commit-Position: refs/heads/master@{#406007}

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2130443002
Cr-Commit-Position: refs/heads/master@{#406006}

This was introduced in r135340 in an attempt to fix a crash in issue
125969, which it ended up not fixing, but nobody reverted it
afterward.  It doesn't appear to be necessary.

BUG=466297

Review-Url: https://codereview.chromium.org/2145353004
Cr-Commit-Position: refs/heads/master@{#406005}

Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2155193002/ )

Reason for revert:
CL falsely blamed for red layout test. Relanding it.

Original issue's description:
> Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ )
>
> Reason for revert:
> Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it.
>
> Adding aelias & vmiura so they can do a more refined revert on their return from vacation.
>
> Original issue's description:
> > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ )
> >
> > Reason for revert:
> > Reverting change now that we have collected data from telemetry.
> >
> > Original issue's description:
> > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ )
> > >
> > > Reason for revert:
> > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790).
> > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result.
> > >
> > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted.
> > >
> > > Original issue's description:
> > > > Re-enable GPU Rasterization for content with any author defined viewport.
> > > >
> > > > BUG=591179
> > > >
> > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339
> > > > Cr-Commit-Position: refs/heads/master@{#402702}
> > >
> > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG=591179
> > >
> > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4
> > > Cr-Commit-Position: refs/heads/master@{#405750}
> >
> > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=591179
> >
> > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b
> > Cr-Commit-Position: refs/heads/master@{#405974}
>
> TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=591179
>
> Committed: https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d
> Cr-Commit-Position: refs/heads/master@{#405983}

TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org,alexclarke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591179

Review-Url: https://codereview.chromium.org/2161663002
Cr-Commit-Position: refs/heads/master@{#406004}

version_info::Channel is a component, so we can include it in
//extensions and clean up a bunch of messy back-and-forth with //chrome.

BUG=626774
TBR=jam@chromium.org (chrome_content_client include path change)

Review-Url: https://codereview.chromium.org/2141703003
Cr-Commit-Position: refs/heads/master@{#406003}

Calculate the number of event listener invocations that we didn't actually
end up allowing preventDefault to actually execute. The denominator
in this metric is the total number of invocations that we force passive
on.

BUG=625675

Review-Url: https://codereview.chromium.org/2137483003
Cr-Commit-Position: refs/heads/master@{#406002}