GitLab

Cr-Commit-Position: refs/heads/master@{#330469}

(Internal bug 18057068.)

Cr-Commit-Position: refs/heads/master@{#330468}

ChromiumApplication.AndroidEduOwnerCheckCallback() has a stub
implementation that doesn't actually call the passed in callback. This
fixes the stub to actually call the callback with a value of false, which
fixes code that depends on this callback being called.

BUG=489514

Review URL: https://codereview.chromium.org/1132723009

Cr-Commit-Position: refs/heads/master@{#330467}

Foreign sessions is an old feature that showed pages from other devices
on the new tab page.  It has since been removed.  It was added by a
contributor that has since left chrome (dubroy@).

What it used to look like: http://bit.ly/1PLDgea

R=estade@chromium.org
BUG=329637

Review URL: https://codereview.chromium.org/1140813003

Cr-Commit-Position: refs/heads/master@{#330466}

If we're not aggressive about expiring a retro frame (e.g. MISSED frames)
then it's possible to enter a high latency mode often.

BUG=469953

Review URL: https://codereview.chromium.org/1055113004

Cr-Commit-Position: refs/heads/master@{#330465}

Added process_mac.cc with implementations of IsProcessBackgrounded() and
SetProcessBackgrounded().

BUG=460102

Originally Committed: https://crrev.com/e3bb10f7860a1d553c85293bd7d7615c0e7f0fd9
Reverted: https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9

Review URL: https://codereview.chromium.org/989703002

Cr-Commit-Position: refs/heads/master@{#330464}

Looks like the new video rendering path caught a pre-existing bug
with how deferred video underflow is handled \o/

If audio underflowed first, the video renderer's underflow would
still be deferred.  If a Flush() comes in, the VideoRendererImpl
would think it's in the HAVE_NOTHING state and send no update to
its buffering state.

Once Flush() completed and playback was restarted the renderer
would start playback as soon as the audio renderer was ready since
the old buffering state for video was have enough.

The fix is to never defer video renderer underflow if audio has
already underflowed.  I've also added a DCHECK() to make it clear
that the audio renderer is expected to clear deferred underflow for
the video renderer during Flush().

BUG=485324
TEST=new unittest.

Review URL: https://codereview.chromium.org/1148473003

Cr-Commit-Position: refs/heads/master@{#330463}

The binutils headers are used for building LLVM's gold plugin,
so should be downloaded before running update.sh, which in some
configurations builds Clang locally.

BUG=452726

Review URL: https://codereview.chromium.org/1141563003

Cr-Commit-Position: refs/heads/master@{#330462}

TEST=Manually tested both.
BUG=481670

Review URL: https://codereview.chromium.org/1138503005

Cr-Commit-Position: refs/heads/master@{#330461}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/404b3b2..72743b1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1142863003

Cr-Commit-Position: refs/heads/master@{#330460}

This allows files like surface_resource_holder.h and transferable_resource.h to depend on the typedef without depending on resource_provider.h

Review URL: https://codereview.chromium.org/1144523003

Cr-Commit-Position: refs/heads/master@{#330459}

Our rendering path has no reasonable expectation of being able to
render 1000fps content, so these are bad timestamps that end up
wrecking assumptions throughout the rendering pathway.

Instead of trying to guard against these frames everywhere, just
discard them immediately during enqueue.

BUG=488302
TEST=new unittest

Review URL: https://codereview.chromium.org/1142723002

Cr-Commit-Position: refs/heads/master@{#330458}

This CL should make conformance2/state/gl-get-calls.html mostly passing
except for COPY_READ_BUFFER_BINDING/COPY_WRITE_BUFFER_BINDING.

BUG=429053
TEST=conformance2/state/gl-get-calls.html
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1126173003

Cr-Commit-Position: refs/heads/master@{#330457}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/45cd7b0..52fee73

TBR=kbr@chromium.org,yhirano@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1128803008

Cr-Commit-Position: refs/heads/master@{#330456}

Now that 362467 is fixed, VerifyLocalIdToUpdate function is no
longer needed and should be removed. This function was added two
months ago to help diagnose the root cause.

I've verified that there are no new crash dumps with
VerifyLocalIdToUpdate since 44.0.2401.0.

BUG=362467

Review URL: https://codereview.chromium.org/1145453004

Cr-Commit-Position: refs/heads/master@{#330455}

BUG=489088
Test=None, internal change.

Review URL: https://codereview.chromium.org/1146713002

Cr-Commit-Position: refs/heads/master@{#330454}

Previously the picker was allowing multiple source selection. Now
DesktopMediaPickerController sets allowsMultipleSelection to NO in
IKImageBrowserView to disable this feature.

BUG=466997

Review URL: https://codereview.chromium.org/1128353005

Cr-Commit-Position: refs/heads/master@{#330453}

BUG=485381
R=jlklein@chromium.org

Review URL: https://codereview.chromium.org/1140393002

Cr-Commit-Position: refs/heads/master@{#330452}

It seems Bash didn't like the -o variant:

+ [[ -n '' ]]
src/tools/clang/scripts/update.sh: line 701: syntax error in conditional expression

BUG=452726
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1148483002

Cr-Commit-Position: refs/heads/master@{#330451}

BUG=487800

Review URL: https://codereview.chromium.org/1139743005

Cr-Commit-Position: refs/heads/master@{#330450}

Added VisibleContentOpaqueRegion() to the VideoLayerImpl, if
a frame hasn't been set yet, then we don't have an opaque region.

+ test

BUG=460612

Review URL: https://codereview.chromium.org/1134663005

Cr-Commit-Position: refs/heads/master@{#330449}

This patch changes the hash function for the tile map key to use
16 least significant bits from each index. This makes it faster on
systems where sizeof(size_t) == 4.

The collisions would only start happening after a large enough index.

This makes the TilingSetRasterQueueConstructAndIterate test do
about 10% more iterations per second on N4.

BUG=488636
R=enne, danakj

Review URL: https://codereview.chromium.org/1133243010

Cr-Commit-Position: refs/heads/master@{#330448}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3b8b14a..45cd7b0

TBR=kbr@chromium.org,yhirano@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1142873003

Cr-Commit-Position: refs/heads/master@{#330447}

Bugs which simply require disabling of extensions no longer need any
extra work. Simply add the bug description to the GPU Bug list JSON
file and list the extension to disable under "disabled_extensions".

This CL also disabled GL_EXT_disjoint_timer_query for the Nexus 5 and
Nexus 6 under lollypop as a test to be sure it works. Tracing the
GPU no longer causes a crash on these devices under lollypop.

R=zmo@chromium.org
BUG=477514,482067

Review URL: https://codereview.chromium.org/1129693004

Cr-Commit-Position: refs/heads/master@{#330446}

BUG=489429

Review URL: https://codereview.chromium.org/1139823007

Cr-Commit-Position: refs/heads/master@{#330445}

This patch removes a lot of plugin placeholder code from builds that don't support plugins (enable_plugins==0).

BUG=

Review URL: https://codereview.chromium.org/1126073003

Cr-Commit-Position: refs/heads/master@{#330444}

BUG=487286

Review URL: https://codereview.chromium.org/1137463006

Cr-Commit-Position: refs/heads/master@{#330443}

When connecting to a port on localhost which is not yet open, connect fails and udp_socket crashes when trying to send packets. This fixes that.

Review URL: https://codereview.chromium.org/967723002

Cr-Commit-Position: refs/heads/master@{#330442}

1) Select the correct preference name for synced data type.
2) Set the correct field name when converting Wallet specifics to
   dictionary.

BUG=481595

Review URL: https://codereview.chromium.org/1147753002

Cr-Commit-Position: refs/heads/master@{#330441}

According to comment in base/port.h, in Chromium, we force-define
__STDC_CONSTANT_MACROS, so we can just use the regular (U)INTn_C macros from
<stdint.h>.

BUG=138542
TEST=base_unittests
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/1128203010

Cr-Commit-Position: refs/heads/master@{#330440}

BUG=487391

Review URL: https://codereview.chromium.org/1136273003

Cr-Commit-Position: refs/heads/master@{#330439}

There is no functionality behind this flag yet.

I kept the name "force-saving", since this name of the feature is quite established now, although I wonder whether saying "manually save" wouldn't be more understandable in the description.

BUG=484891

Review URL: https://codereview.chromium.org/1140043003

Cr-Commit-Position: refs/heads/master@{#330438}

chrome.printerProvider API's going to stable, so this is not needed
anymore.

BUG=439448, 488661

Review URL: https://codereview.chromium.org/1130933005

Cr-Commit-Position: refs/heads/master@{#330437}

Review URL: https://codereview.chromium.org/1134383002

Cr-Commit-Position: refs/heads/master@{#330436}

Revert of Remove a HistoryNode's children when it navigates to a new document. (patchset #1 id:1 of https://codereview.chromium.org/1139033002/)

Reason for revert:
Caused a large spike in crashes across several bugs:
https://crbug.com/426658
https://crbug.com/488382
https://crbug.com/488421
https://crbug.com/488434
https://crbug.com/488470

Original issue's description:
> Remove a HistoryNode's children when it navigates to a new document.
>
> When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree.
>
> BUG=485385
>
> Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a
> Cr-Commit-Position: refs/heads/master@{#329763}

TBR=japhet@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485385

Review URL: https://codereview.chromium.org/1148473002

Cr-Commit-Position: refs/heads/master@{#330435}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d804fe3..3b8b14a

TBR=kbr@chromium.org,yhirano@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1147733003

Cr-Commit-Position: refs/heads/master@{#330434}

The Chromium Linux Mojo bot's app_tests step started failing here:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/7090
Related to https://codereview.chromium.org/1130353008/

The mojo:view_manager_apptests all crash after passing with:
  [0518/132408:FATAL:x11_event_source.cc(80)] Check failed: display_.

These tests are run headless and shouldn't need an event source.

BUG=NONE
TEST=Bot goes green.
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1125423005

Cr-Commit-Position: refs/heads/master@{#330433}

The oilpan plugin requires trunk clang on Windows, but the asan lkgr bot
uses a pinned, slightly older clang and it times out when using head clang.
Disable the plugin on asan until we have resolved this.

BUG=489123,489123
R=hans@chromium.org, rnk@chromium.org

Review URL: https://codereview.chromium.org/1142733003

Cr-Commit-Position: refs/heads/master@{#330432}

Layout tests generate results in the webkit/ folder which was recently
removed from the chromium tree.

BUG=488288

Review URL: https://codereview.chromium.org/1137683004

Cr-Commit-Position: refs/heads/master@{#330431}

JS messaging to native code for UIWebView is accomplished by adding
and removing an iframe to the window. Some pages interact badly with
this mechanism, including iforgot.apple.com. To circumvent this for
such pages, the functionality in message_dynamic.sendQueue is wrapped
in a function and invoked from window.requestAnimationFrame to delay
message sending.

BUG=470595

Review URL: https://codereview.chromium.org/1132163007

Cr-Commit-Position: refs/heads/master@{#330430}