- 17 Dec, 2020 40 commits
-
-
Mila Green authored
Bug: 1159537 Change-Id: I5595f6fc3fb3efa7cd76175820dbd84d3d1f93fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595976Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838134}
-
Danila Kuzmin authored
Bug: 1156672 Change-Id: I0f56c3ec6674e2040c509ef92793ae7ad6b602f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595034Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#838133}
-
danakj authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2572896 Ensure that SkImageRep is always constructed with a valid bitmap. Instead of constructing an invalid SkImageRep then throwing it away when initializing an SkImage, we add an SkImage::CreateFromBitmap() that will just return a null SkImage directly if the bitmap is null/uninitialized. ImageSkia was creating a null ImageSkiaRep when searching for a representation in order to force use of the nearest one, but it also uses a boolean value to do the same, so stop making a null ImageSkiaRep. Then disallow null/empty ImageSkiaRep and also disallow their transport over mojo. Remove a few tests that were creating invalid ImageSkiaReps to test that they work - as they are no longer valid. Have ImageSkia constructed from ImageSkiaOperations check for the ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as that can still return a null ImageSkiaRep. In that case, the resulting ImageSkiaRep must also be null. And we can do that without trying to perform operations on the (invalid, null) bitmap inside the null ImageSkiaRep. This fixes the tests included in the CL. We no longer try to serialize null or empty ImageSkiaRep since the class itself will not allow it. We do test that we will not deserialize such invalid ImageSkiaReps. And a test is also added to verify we do not allow non-n32 bitmaps to be deserialized in ImageSkiaRep. R=dcheng@chromium.org, sky@chromium.org Bug: 1155258 Change-Id: Ia18360dcd2a59be8c49b7104f01dbdd20bbe6bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596131Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#838132}
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: Iff89c1871ad8c496a9a90dfc2f216d6f2d813a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595428Reviewed-by:
-
adoneria authored
This will help in viewing test logs (if available) on the UI. Currently resultDB API does not pull these logs to be viewable on the build result page (crbug.com/1156255). But the logs are getting uploaded to the isolate server (for example, http://shortn/_bFsAgw8z8K). Bug: 1141075 Change-Id: I346b25740f7525af754f140c0a7e4278f79b5d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593599Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c18efa6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I1016076c840e91d929f6b3ad8426ad680f6da6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597536Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838129}
-
Karandeep Bhatia authored
This is in preparation of queueing API calls to ensure only one session or dynamic rules update for an extension takes place at a time. This will be needed for a shared rule limit between session and dynamic rules. Doc=https://docs.google.com/document/d/1FZuuQkG8Tl4ee_K3Ls37iFhjynqStfDjApPvB1N8qsw/edit?usp=sharing&resourcekey=0-kZHQzo1D3pIDAFgYoTSV5g BUG=1043200 Change-Id: Ib92866b9a707874828d4dcd1d95cb59888f3961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578867 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838128}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 to 89-4342.0-1607345364-benchmark-89.0.4357.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie0b4b650a5acc924ec28c67d2e4e7c20858e1dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838127}
-
Javier Ernesto Flores Robles authored
Worked on this doing pair programming with Sébastien today, and after debugging we found out that the change in the width of the text is what causes the animation to appear like it "jumps". Having the text width to be constant fixes that, and looks good on normal dynamic size fonts. However it does needs scrolling on the bigger a11y fonts. Would like to get your input in the way i'm fixing the bug, as this will decrease the horizontal space for text on iPads. Another issue we found was that on compact height the text is cropped into <1 line, and looks bad. Hiding it fixes that. Fixed: 1005249 Change-Id: I0651ec85ddbb5bbbf30f50518bbb9c6be7f9392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595857Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#838126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id4eada54a8699d7cfe0bd6a5e95032ccf32fb4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595981Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bbf434aef52..f8ca67ef2d09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gayane@google.com,koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gayane@google.com,koerber@google.com Change-Id: Ie9ea5d195b6ff5788c351479ff11229ddbb4f53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596786Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838124}
-
Alexandre Courbot authored
The V4L2 stateful decoder specification says the following about the drain (flush) sequence: The sequence can be only initiated if both OUTPUT and CAPTURE queues are streaming. We are currently not checking this condition, and sending the STOP command unconditionally. This makes us fail to flush properly if the flush event has been requested before the initial dynamic resolution change event has been processed, since the CAPTURE queue is not started before that. This fix by not sending the STOP command if a flush request is received while the CAPTURE queue is not streaming. Then, when the resolution is set and the CAPTURE queue streaming, check if a flush request is pending and execute it at that time. BUG=b:174449972 TEST=android.media.cts.DecoderTest#testEOSBehaviorH264 passes on Trogdor. Change-Id: I7bcb96bd761e36177bbea98df8b0b5da2c7c6791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597242 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#838123}
-
chrome://discardsSebastien Marchand authored
There's a really low contrast between the text color and the background for the header row of the chrome://discards in dark mode. Change-Id: Ia729ba4c4734b652837bb4da2ee2564daa7023ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595619 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#838122}
-
Julian Pastarmov authored
It still mentioned plugins and the "wrench" menu. BUG=none Change-Id: I9a617d43ea7a796e4a92efd2706868ac18412747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597496 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#838121}
-
Chris Mumford authored
Switch IndexedDBContextImpl from using RefCountedDeleteOnSequence to use RefCountedThreadSafe. This change is to eliminate a user-after-free situation which is caused by the recreation of a scoped_refptr *after* the deletion of the IndexedDBContextImpl posted to the the correct sequence for deletion. This fix converts the "delete on sequence" into a "release on sequence", thus avoiding this crash. Bug: 1142712 Change-Id: I74359b515f5c05cdff9104de89691ef1f3d4557e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594289Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#838120}
-
Andrew Xu authored
Currently the bitmap item's border is drawn outside of the image. Instead, the border should be above the image. The description of the issue offers more details. Bug: 1159174 Change-Id: I4143785e957e8d7c2b18c2f1a92ad3bc5a00798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596500Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838119}
-
Alexandre Courbot authored
Even if we have been requested to flush, we may very well receive a dynamic resolution change event before the last buffer of the flush is processed. Therefore, when a buffer with the LAST flag is dequeued, we must check whether a DRC event is pending even if a flush request has been requested before. BUG=b:174449972 TEST=android.media.cts.DecoderTest#testEOSBehaviorH264 passes on Trogdor. Change-Id: I04cf7d0d276cd036a6ea0a4434413ab193b91d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597241 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/804d2150..fc4ac702 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e37534554c05335eb46593917c4b5a97813e23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597421Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838117}
-
Morten Stenshorne authored
Replace TODO with comment. If the inline-size of the contents of the multicol container is 0, an empty overflow rectangle will be produced, even if block-size is non-zero, and we'd fail balancing of blocks that are freely breakable inside, if initial column block-size is 0. The space shortage reporting machinery (which is what we use in subsequent column layout passes) really only works for content that we cannot (or at least don't want to) break inside. We'd also get log2(N)-ish relayouts (where N is the total block-size of the contents). So it looks like we need to keep CalculateColumnContentBlockSize(), after all. I tried to get rid of it here, before I realized that it would cause trouble: https://chromium-review.googlesource.com/c/chromium/src/+/2597308 Add a test that demonstrates this. Note that external/wpt/css/css-multicol/baseline-006.html also tests this, but that's not the main point with that test. Bug: 829028 Change-Id: I24516a5956f9e60f47c87cf51db2683feded1eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595540Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838116}
-
Allen Webb authored
Bug: 874630 Test: chrome builds Change-Id: Id8b141daadfc4fdd3c32f8e6c801586156fa0f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593725Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#838115}
-
Ewann authored
This CL fixes Settings background when kSettingsRefresh flag is disabled. Bug: 922511, 1159765 Change-Id: I24c5a26d0a106408ac00df12f33ea0043e060b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596149 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
The parsing should be done only once per SLD/SRD call. Also: Add test for adding multiple tracks, one at a time - this is used to performance-test the changes. The upper limit of the track count should be adjusted to "reasonable". Bug: webrtc:12176 Change-Id: I95449eac710fcd2dd635e1e632bbb62641db848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531993 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838113}
-
Nina Satragno authored
When an authenticator has the forcePINChange flag on, attempting to set a PIN that is equal to the currently set PIN results in an error. Before attempting to send the new PIN to the authenticator, show the user an error explaining they need to set a new, different PIN. This patch also refactors PIN error handling so it's all handled on AuthTokenRequester now, removing some state from the UI & allowing unit tests to be written. UXW review: go/force-pin-change-ux A follow-up will implement similar logic on the settings page. Bug: 1152510 Change-Id: I00b0726b4ae34c4408df26aaa4ffbd250e03a003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593478Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#838112}
-
Eugene But authored
Bug: 688063 Change-Id: Idf3fdfc8718ebf51755dad67acbac2326eb29428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596523Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#838111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0096403e47fb..25c49a45ff39 2020-12-17 aerotwist@chromium.org [unit test] Register missing events If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I909b648cf6951db39111df3f572cca36105bf32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597406Reviewed-by:
-
Evan Stade authored
This is necessary because WebLayer doesn't store history, or even compile //components/history code. The change also removes the dependency on Profile, replacing it with BrowserContext. TBR=sky@chromium.org Bug: 1147274 Change-Id: Ib8e390500b1b237f6a04d062c835b0603e6eb2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592390Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#838109}
-
Joey Arhar authored
Before this patch, event handlers registered at the target of the event, which get fired during the AT_TARGET event phase, get fired in order of when they are registered without any regard for which handlers are capture and which ones are bubble. This patch fires all capture handlers before bubble handlers during the AT_TARGET event phase. WebKit implemented the same behavior here: https://trac.webkit.org/changeset/236002/webkit I2S: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/30jv38uD_84 Fixed: 1052152 Change-Id: I87752225dbcef7d07fccf9a6999711bdf5fbad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581814 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838108}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b64da3907f76..4052510f0b7a 2020-12-17 johnstiles@google.com Add an "allow-unreachable" flag to CFG basic blocks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I6eb592914492af9fc8adc4276794f7ca92c4708b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596862Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cfecd6b3e2e9..36522931735d 2020-12-17 saklein@chromium.org package_info: Add str and repr to PackageInfo 2020-12-16 benreich@chromium.org drivefs-uprev: Fix version comparison If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I5752d5ab7424002b54151f20881e12c1b52d722e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595193Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da7da798b33..cc9b7694ce3d 2020-12-17 delphick@google.com Merge "metrics: Add tests for modified_rail_slices table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I38670e3f9931ec193ac81f3d779e7a123484467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596788Reviewed-by:
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. A previous CL stored CNAME aliases in net::AddressList during DNS resolution. This change continues the plumbing by adding an accessor to net::ResolveHostRequest/net::HostResolverManager::RequestImpl. We also add a DnsAliasUtility with a static method for sanitizing the alias list, which is called in just after results are set. We moreover add support for host resolution with aliases to MockHostResolver, as this is needed in downstream tests for ConnectJobs, and since the MockDnsClient is currently not hooked up to MockHostResolver, the more realistic simulation path is not as simple to set up. Relevant tests: net:net_unittests out/Default/net_unittests --gtest_filter=*Dns*Alias* Bug: 1151047 Change-Id: I441fe15295f23090b697e1bc31279151f462008f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574974Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838104}
-
Darin Fisher authored
Change-Id: I7b378b8a859cb918281134ded63c01ac24d4675f Fixed: 1159610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596216 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#838103}
-
Clark DuVall authored
This change attempts to force compile dex files on the first launch after an update or if it is detected a split is missing optimized dex. This should mitigate the startup regression seen from isolated splits on OMR1. Bug: 1159608 Change-Id: I05fb7b43a69646b9f541d57820f44c996f9908d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596030Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#838102}
-
Mikel Astiz authored
embedded_setup_chromeos.html is specifically used for ChromeOS tests so let's list some relevant folks as owners. Change-Id: Ifb6ac5537d48dbb099b0741cdff1f399fb033a7f Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595538 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Adds checks and blocks opening incognito tabs when the attempt is not authenticated and the authentication fails. Bug: none Change-Id: Ic7f37c1fc70306812e6b6a214e9129361927e45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593262 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#838100}
-
Allen Bauer authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Bug: 1159563 Change-Id: I43191984eb7555ab6011d23ac8c0ac33a195e26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595733Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#838099}
-
Alex Ilin authored
DetachedResourceRequestTest#testRepeatedIntents fails flakily on "android-pie-x86-rel" bot. Disabling the test on emulators. TBR: lizeb@chromium.org Bug: 1159805 Change-Id: I06e8efd025342d516e24f13231cf6bd1a8afe998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596303 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838098}
-
Titouan Rigoudy authored
This tests the inheritance of both the address space and secure context properties, for two new related cases: - the initial empty document (before about:blank commits) - javascript: URLs In both cases, because no navigation has yet committed into the frame host, the frame host has no `last_committed_client_security_state`. The tests confirm this incorrect behavior, and stand to be changed first once crrev.com/c/2587041 lands, then once again when inheritance is truly fixed. Bug: chromium:1154729, chromium:1126856 Change-Id: Ia2dec4e4b42e517f65891d55e7f391018edfb85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593636 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838097}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012170600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/Lqnbzl4-hoc2WrAL80TsiADU6Of1I2wk_-c35v-9vSkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/175639859 Tbr: media-app@grotations.appspotmail.com Change-Id: I4db694d1f6159daac8fd736c26360effa7389163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595979Reviewed-by:
-
Sebastien Marchand authored
Bug: 1144025 Change-Id: I4708ce31340be0e001ab2f0669305f61262d9512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593653 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#838095}
-
