GitLab

Bug: 912129
Change-Id: I4e0761d1eeed00cfb0594e6ecb50a6e1f41092ef
Reviewed-on: https://chromium-review.googlesource.com/c/1489107
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635663}

This reverts commit e6314175.

Reason for revert: Crashing in TracingProfileBuilder::OnSampleCompleted on Android.

Original change's description:
> [Sampling profiler] Use null for invalid ModuleCache::Module state
> 
> Eliminates the internal null Module state in favor of nullptr.
> 
> Bug: 931418
> Change-Id: I8d7f6f00f5433d189542bceb790ca23c5b97fb4d
> Reviewed-on: https://chromium-review.googlesource.com/c/1478095
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#635242}

TBR=wittman@chromium.org,alph@chromium.org,oysteine@chromium.org,charliea@chromium.org

Change-Id: I6f188e5b05f747d9104f9b96dac71b7603e9507a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 931418, 936099 
Reviewed-on: https://chromium-review.googlesource.com/c/1489515Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635662}

Bug: 935065
Change-Id: I33c99186314f0cd27abd2cb078069028723e29f1
Reviewed-on: https://chromium-review.googlesource.com/c/1484975Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635661}

https://android.googlesource.com/platform/external/perfetto.git/+log/c1b9ea5f3400..c08497af77b7


git log c1b9ea5f3400..c08497af77b7 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 eseckler@google.com Merge "build: Add new protos to libperfetto public_deps"


Created with:
  gclient setdep -r src/third_party/perfetto@c08497af77b7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ia6b027cfea6dffac70e97bf6fa30aedd78d73565
Reviewed-on: https://chromium-review.googlesource.com/c/1489511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635660}

Tbr: reillyg@chromium.org
NoTry: True
Bug: 936065
Change-Id: I373e9801f8de781745dbccb7b16a7c8c47159715
Reviewed-on: https://chromium-review.googlesource.com/c/1489714Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635659}

DrawMode::Vulkan is deprecated in SkiaRenderer. Remove its code paths,
including VulkanContextProvider in viz::OutputSurface.

OutputSurface::GetVulkanSurface is unused and not implemented for any
OutputSurface child class. Remove it as well.

Bug: 934259
Change-Id: I0129c2ee7f06085388d3194a220c182e645f9dad
Reviewed-on: https://chromium-review.googlesource.com/c/1482602Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635658}

Bug: None
Change-Id: I537f11a2213b40d48db4a3f1cec05096d423ce79
Reviewed-on: https://chromium-review.googlesource.com/c/1489105
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635657}

https://webrtc.googlesource.com/src.git/+log/12ae4f4d50b0..695af944c472


git log 12ae4f4d50b0..695af944c472 --date=short --no-merges --format='%ad %ae %s'
2019-02-26 kuddai@google.com Add reentrancy comment for critical section.
2019-02-26 eshr@google.com Log pacer values to verbose log


Created with:
  gclient setdep -r src/third_party/webrtc@695af944c472

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I58750187760ced8222c005ba0d7b34514ee57627
Reviewed-on: https://chromium-review.googlesource.com/c/1489454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635656}

WebStateListObserving can pass a nil newWebState.

Bug: 935603
Change-Id: I1d7361199b2e1f238976c55bac98b7b0221740b6
Reviewed-on: https://chromium-review.googlesource.com/c/1489097
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635655}

This copies what ExtensionRequestProtocolHandler does for the network service path, which is to load extension resources from the internet transparently if the manifest specifies it.

Bug: b/123321526
Change-Id: Iad8a5c525164907ef024fc1bf41825885f26fdba
Reviewed-on: https://chromium-review.googlesource.com/c/1481741
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635654}

We want the default languages (accept languages for Chrome, preferred languages for ChromeOS) to be blocked so that we don't offer translation by default.
This is achieved by:
(1) Giving a default to translate's blocked language pref when initialized.
(2) Resetting empty blocked languages to the (new) default (to fix current users' prefs).

This changes also means that blocked languages aren't empty in tests anymore, and that translate pref registration now requires string resources to be available.
Hence, a few translate behavior tests needed to be adjusted.

Bug: 902354, 872096
Change-Id: I7fae351d85eca47f68325a2acfe3abc5073ce3c7
Reviewed-on: https://chromium-review.googlesource.com/c/1473431Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635653}

The underlying P2PTransportChannel has been updated to the spec
compliant RTCIceTransportState. This change updates the standalone
RTCIceTransport to use this.

Bug: 928081
Change-Id: Ia127c0f5473e49b8c48e8595f8381aa2542e7e2e
Reviewed-on: https://chromium-review.googlesource.com/c/1483943Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635652}

Bug: 926951
Change-Id: I2ada76cfdeb9b2081b01f8ff89f076bc132a4070
Reviewed-on: https://chromium-review.googlesource.com/c/1487529
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635651}

Change-Id: Ic6ce67ced265cf5b3cc9957b92e607b90334b3a5
Reviewed-on: https://chromium-review.googlesource.com/c/1488614
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635650}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9b534ba2cb9..cc2dec20be7e


Created with:
  gclient setdep -r src-internal@cc2dec20be7e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3286cf890fc19623d0c91ca9ff8d16e06d40e121
Reviewed-on: https://chromium-review.googlesource.com/c/1489070Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635649}

This callback will be needed to determine if we should reparent web
contents into an app window on macOS. For the moment, leave the
callback unused in all instances.

Bug: 915571
Change-Id: Ib86415a7a3d1981db817c39dfe7bb3a8b23ed571
Reviewed-on: https://chromium-review.googlesource.com/c/1487917Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635648}

Localizations for the string "Available" were being reused from a
different context, giving us inaccurate translations. This CL adds a
"meaning" field to the string to make it a unique entry.

The issue is tracked at b/123927358.

Documentation for the meaning field is here:
https://www.chromium.org/developers/design-documents/ui-localization#TOC-Using-message-meanings-to-disambiguate-strings

Change-Id: I9f9faa6597a21220cb5d23f5fa3b86f32218e042
Reviewed-on: https://chromium-review.googlesource.com/c/1487697
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635647}

Tbr: dgrogan@chromium.org
NoTry: True
Bug: 936095
Change-Id: Ie40b1d1fec24fae9c0a3154c75e7f71bb1d0b041
Reviewed-on: https://chromium-review.googlesource.com/c/1489633Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635646}

This change assigns:
  proactive-tab-freeze-and-discard
  stop-non-timers-in-background
to fdoray@ for M75 (~April 2019).

Bug: None
Change-Id: Id3018698b3ddb9be6f069c4435056da8c97856e9
Reviewed-on: https://chromium-review.googlesource.com/c/1489093
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635645}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1805a6699248..1a930646662a


git log 1805a6699248..1a930646662a --date=short --no-merges --format='%ad %ae %s'
2019-02-26 drinkcat@chromium.org HACK: Do not upload goma logs


Created with:
  gclient setdep -r src/third_party/chromite@1a930646662a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I3ea13d2ae2a296b9561d350ae5c8633f68fda64e
Reviewed-on: https://chromium-review.googlesource.com/c/1489455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#635644}

Bug: 930926
Change-Id: I9f00d56238325d9b98b80756469ea8307b8ff594
Reviewed-on: https://chromium-review.googlesource.com/c/1488887
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635643}

Up from their faulty 2min timeout.

Bug: 933069
Change-Id: I3ecda356c30166a2267fef022379f341de704051
Reviewed-on: https://chromium-review.googlesource.com/c/1489309Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635642}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Patch is updating enum to @IntDef and upgrading @IntDef inside Cronet with form common with other Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I0ef5412d6fc0aaf48f860da286eb6c0995f0bcdc
Reviewed-on: https://chromium-review.googlesource.com/c/1477125Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#635641}

Following bot results are included.
15722 15734 15743 15752 15760 15769 15771 15778 15790

1 lines were removed and 2 lines were deflaked by consecutive
results since 15701.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: Id76a71e448f042038fa23ab31815e3253aa1214d
Reviewed-on: https://chromium-review.googlesource.com/c/1487431Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635640}

Bug: 923943
Change-Id: I0de67c1481a2396245725fe567af640344135826
Reviewed-on: https://chromium-review.googlesource.com/c/1484075Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635639}

Bug: 928772
Change-Id: I400d7905162643dc7e542812179dd3163e7a0581
Reviewed-on: https://chromium-review.googlesource.com/c/1489100
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635638}

Tbr: hiroshige@chromium.org
NoTry: True
Bug: 936083
Change-Id: I6dfc848edbaa6abe7624cd6763532f6b1564bb05
Reviewed-on: https://chromium-review.googlesource.com/c/1489427Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635637}

Bug: 935572
Change-Id: I4de12ad684bcc2b26138bf21aa1c73f76a554af9
Reviewed-on: https://chromium-review.googlesource.com/c/1489571
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635636}

Mark layout bar as translucent so it doesn't take up space when
we are hiding it.

BUG=935015

Change-Id: I85821d773728b73b7f867af6add4665b7f840cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1487831Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635635}

Resorting the code into snapshot method as to make easier to understand.
Now snapshot will effectively ask for a GetImage in case that the context
is ImageBitmapRenderer.

Adding some comments to html_canvas_element.h to explain the types of
contexts that can be into the html_canvas_element and adding future todo.

Adding test to validate that getDataURL works on the bitmaprenderer context.

Bug: 932266, 838108
Change-Id: I96aa25a3db624a2ddf457ae7349e345955e9ad50
Reviewed-on: https://chromium-review.googlesource.com/c/1481107Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635634}

Bug: 935277
Change-Id: I5992ec261fa91dc2809451a19850c4ac6813228e
Reviewed-on: https://chromium-review.googlesource.com/c/1487178Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#635633}

It's now used for device tests too, so the hard-coded references to
VMs are a bit out of place.

Bug: 866062
Change-Id: I78621e2c615307e3f05a78b5fe40366124a0541b
Reviewed-on: https://chromium-review.googlesource.com/c/1385004Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635632}

This is a multi-valued flag that allows forcibly downgrading the render
path to a different supported mode.  In the default case, the gvr
scheduler will choose the best supported mode.  This change removes the
ability to select a lower quality mode, ensuring that the best
available render mode is selected.

Bug: 932726
Change-Id: I2f374e8de18a11c777939158f393e9b90a22708c
Reviewed-on: https://chromium-review.googlesource.com/c/1487074Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635631}

Change-Id: Ie28c6659ff11b1f2137ffc53323b4569d5283965
Reviewed-on: https://chromium-review.googlesource.com/c/1487197Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635630}

The backend team has asked that we send the total count of files and
directories within archives. This CL adds this information to the
download ping for RAR archives.

Bug: 926586
Change-Id: Id24838c5984a72740ff3776dd26ef49965113d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1487193Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635629}

Change-Id: I6972e64eccf682e9028dcf69991450dd3ecd8319
Reviewed-on: https://chromium-review.googlesource.com/c/1488019
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635628}

Postmortem Bug: https://monorail-staging.appspot.com/p/chromium/issues/detail?id=899293

Bug: 931710
Change-Id: I94c3e321d77890c59987894ce00f16a3d7ec2128
Reviewed-on: https://chromium-review.googlesource.com/c/1479910
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635627}

This patch improves the logic in PaintTextChild so that:
1. Move DrawingRecorder code after the check of
   ShouldPaintTextFragment and have_selection. This matches
   to InlineTextBoxPainter logic order, avoiding
   instantiation of DrawingRecorder if nothing are painted.
2. Check LayoutObject::IsSelected before
   ComputeLayoutSelectionStatus. This matches to legacy
   InlineTextBoxPainter, avoiding a few unnecessary function
   calls when there is no selection on the LayoutObject.

These are not the primary goal of issue 936024, but found
during the review and has positive impacts on blink_perf:
https://pinpoint-dot-chromeperf.appspot.com/job/1184c765340000

Bug: 936024
Change-Id: Idda53c9f41476d6024c6f5855594b3bd7dd35418
Reviewed-on: https://chromium-review.googlesource.com/c/1487432Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635626}

This configures cookie settings in the NetworkContext, based on
non-service code path (defined in WebView's CookieManager). This
refactors the cookie-path logic to a shared location in
AwBrowserContext.

Specifically, this configures the following:

 * save and restore session cookies
 * cookies should persist to disk

This also does some minor refactoring for the HTTP cache, for
consistency.

Bug: 933456, 933457, 902641
Test: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ib53d4cbab8ccdf2f916a256f6d549bea644b6611
Reviewed-on: https://chromium-review.googlesource.com/c/1385492
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635625}

This reverts commit 60cd9d98 now that we
don't need to work around the VC++ bug.

The array was subsequently changed from char[] to StringPiece so it's
not really a revert but an adding back of const to where it used to be,
with somewhat different semantics.

Bug: 934323
Change-Id: I821025578923e91218b8827d1d6cdd3553c252b2
Reviewed-on: https://chromium-review.googlesource.com/c/1484415
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635624}