GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7739016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99901 0039d316-1c4b-4281-b951-d872f2087c98

than 45 secs (and for XP crash if it takes longer than
90 secs).

BUG=95506
TEST=shutdown
R=jar
Review URL: http://codereview.chromium.org/7782017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99900 0039d316-1c4b-4281-b951-d872f2087c98

Add CompositorDelegate as an interface between the compositor and its owner, and implement SchedulePaint through the delegate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7770002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99899 0039d316-1c4b-4281-b951-d872f2087c98

 * Make 'aura' a component, and export Desktop and Window.
 * Events (Key and Mouse) from X Events.
 * Rip non-gtk bits out of gfx/gtk_util into gfx/linux_util

BUG=93934,93933
TEST=none

Review URL: http://codereview.chromium.org/7833016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99897 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r6632: (pdox) Update UPSTREAM_REV to c98f5e2f94f5 to pull in
r6633: (pdox) Roll toolchain DEPS to 6632.
r6634: (eugenis) Another way of killing the browser in browser tests.
r6635: (jvoung) Fix perf log output to match expected syntax on spec2k bots ([] instead of {}).
r6636: (sanga) Pulling back revision 6635 and 6634 due to broken builds.
r6637: (pdox) Revert 6636, which reverted 6635 and 6634, to determine if the build failures are real or flakes.
r6638: (robertm) Better organization of pnacl torture test failures.
r6639: (khim) Bump glibc to 3a982eb
r6640: (jvoung) Change llc triple to use nacl instead of linux.
r6641: (bradnelson) Pulling in newer chrome rev.

BUG=none
TEST=nacl_integration


Review URL: http://codereview.chromium.org/7841016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99896 0039d316-1c4b-4281-b951-d872f2087c98

This makes two changes:
 + Makes sure the selection bound has a minimum size before the controller is
   made visible.
 + Delays updating the touch-selection controller a little bit to account for the
   erroneous selection-change messages from webkit.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7778039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99894 0039d316-1c4b-4281-b951-d872f2087c98

Apply a drop-shadow to make it clear where the desktop edge is.
Fix desktop resize handling to cope respect the scaling setting.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7821017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99893 0039d316-1c4b-4281-b951-d872f2087c98

This is in case they are not in the DLL search path. It tries the default search path first in case D3DX is installed in the regular place. If that fails then it uses an absolute path to where Chrome installs them.

I moved the call to SetErrorMode to be before ANGLE is loaded. Without this, a failing call to LoadLibrary would result in the display of a dialog box.

This is dependent on http://codereview.chromium.org/7831021.

BUG=69610

Review URL: http://codereview.chromium.org/7792078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99892 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7831050/.

BUG=http://code.google.com/p/chromium/issues/detail?id=61022

TBR=scherkus@chromium.org,brettw@chromium.org

Review URL: http://codereview.chromium.org/7739009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94694
TEST=ensure --enable-sync-tabs,--enable-sync-tabs-for-other-clients switches
work. Verify "Open Tabs" on sync setup pane. Verify about:flags describes
"Enable syncing open tabs" accurately. Ensure functionality of
--enable-sync-tabs-for-other-clients still works.
R=tim@chromimum.org,yfriedman@chromium.org

Review URL: http://codereview.chromium.org/7837014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99890 0039d316-1c4b-4281-b951-d872f2087c98

The link URL is used to select between multiple <link rel="chrome-webstore-item">
elements on the page.

To keep track of callbacks, an install ID is generated at the start of each
chrome.webstore.install() call, so that the browser knows which ones to invoke
when an install completes.

Also adds validation of install requesting URL against the item's verified
domain (wasn't done until now since it wasn't testable).

R=aa@chromium.org
BUG=93380

Review URL: http://codereview.chromium.org/7795032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99889 0039d316-1c4b-4281-b951-d872f2087c98

This is an attempt to improve stability on the m14 branch. I will revert this CL right after merging it to m14.

BUG=95592
TEST=Go to about:flags and chrome://flags. Nothing should be there.
Go to about:version, no --begin-flags and --end-flags should be there.

Review URL: http://codereview.chromium.org/7837006

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7841022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99888 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99887 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99885 0039d316-1c4b-4281-b951-d872f2087c98

Start moving code from BrowserMain to content, so that it can be reused by all embedders of content. I've based the refactoring on the existing BrowserMainParts. This is the first step; I didn't want to do it all at the same time because it would be too big. Remaining tasks:-rename the browser_main files in chrome to chrome_browser_main-move the OS specific implementations of BrowserMainParts that are needed for content-finish splitting the remaining BrowserMain function (now that's in TemporaryContinue())BUG=90445
Review URL: http://codereview.chromium.org/7779040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99884 0039d316-1c4b-4281-b951-d872f2087c98

This is an attempt to improve stability on the m14 branch. I will revert this CL right after merging it to m14.

BUG=95592
TEST=Go to about:flags and chrome://flags. Nothing should be there.
Go to about:version, no --begin-flags and --end-flags should be there.

Review URL: http://codereview.chromium.org/7837006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95602
TEST=base_unittests

Review URL: http://codereview.chromium.org/7840017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=new browser test
Review URL: http://codereview.chromium.org/7537030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99880 0039d316-1c4b-4281-b951-d872f2087c98

Confidence ranges were coming in too high and had occasional divide-by-zero leading to CHECK failures. Changed the math and the unit tests to satisfy stricter confidence requirements and remove divide by zero.

BUG=95453
TEST=None

Review URL: http://codereview.chromium.org/7833046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99879 0039d316-1c4b-4281-b951-d872f2087c98

Revert 99440 - Changed Mac, Linux and Win Official Chrome build to drop default app CRXs in the build/installer output.

BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021

TBR=stevet@chromium.org
Review URL: http://codereview.chromium.org/7795038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=When frozen tab becomes reponsive, the Hung Renderer Dialog should disappear.


Review URL: http://codereview.chromium.org/7824039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99877 0039d316-1c4b-4281-b951-d872f2087c98

If the ProfileIOData isn't ever lazily initialized, the URLBlacklistManager will be deleted with the ProfileParams on the wrong thread.

BUG=95510
TEST=sync_integration_tests aren't breaking because of destruction of URLBlacklistManager on the wrong thread


Review URL: http://codereview.chromium.org/7841004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99876 0039d316-1c4b-4281-b951-d872f2087c98

TEST=run with --force-compositing-mode and --show-fps-counter, verify
that the counter shows up on about:blank and not on other about: pages
BUG=95107


Review URL: http://codereview.chromium.org/7779022

TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/7782021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99875 0039d316-1c4b-4281-b951-d872f2087c98

Original issue is codereview.chromium.org/7792022.
Problem was a race between Connection destruction and TerminateAllIO. If TerminateAllIO won the race,
it would call Abort() on a Connection object *after* the BridgedConnection destructor had run, while
~Connection was waiting on the termination lock.  This would cause a purecall exception.

BUG=93829, 19757
TEST=SyncAPIServerConnectionManagerTest, integration tests

Review URL: http://codereview.chromium.org/7841013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99874 0039d316-1c4b-4281-b951-d872f2087c98

To split the ConstrainedWindow feature off of TabContents entirely (moving it
to a helper object on TabContentsWrapper), I'll need to first make each
constrained window TabContentsWrapper aware first. I started just hacking

BUG=95257
TEST=compiles


Review URL: http://codereview.chromium.org/7831051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99872 0039d316-1c4b-4281-b951-d872f2087c98

The contract for Get/PutCurrentFrame() is that you have to return the original frame, not NULL.


Review URL: http://codereview.chromium.org/7795027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99871 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=77376
TEST=none

Review URL: http://codereview.chromium.org/7838015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99870 0039d316-1c4b-4281-b951-d872f2087c98

- Why remove the special case?

WebKit's script controllers have a special-case for the window script object, which deallocates it regardless of reference-count, on the assumption that by the time the relevant call (clearScriptObjects) is made, no callers can remain which hold references to it - this prevents it from lingering indfinitely if the plugin forgets to release it.

WebPluginDelegateProxy has a special-case for handling the window script object, which tries to cope with the case where clearScriptObjects has been called before the plugin is destroyed (which should never happen), by avoiding trying to release the window script object, and instead relying on WebKit deallocating it.

This workaround doesn't actually work; if WebKit is behaving then the object exists at plugin teardown time, and it's safe for code to touch it.  If it doesn't exist any more, then we may still touch it if the plugin tries to script the window, or to release the reference.  Even if neither of those occur, the stub for the object may release it when the last plugin instance's channel is torn-down, before the workaround can be hit.

We still need to explicitly tear-down the window script object's stub if the plugin failed to release it, so that it won't linger and end up being released after WebKit has already deallocated it.

Review URL: http://codereview.chromium.org/7696016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99869 0039d316-1c4b-4281-b951-d872f2087c98

Fixes clients that set CXX to a custom clang, such as ASAN.

BUG=none
TEST=asan bot goes green again.

Review URL: http://codereview.chromium.org/7838013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99868 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91157
TEST=none

Review URL: http://codereview.chromium.org/7837016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99867 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by gideonwald@chromium.org
I'm recreating http://codereview.chromium.org/7840001/
gideonwald can't dcommit and binary files break git cl patch.
So I copied and added his pngcrushed image from the bug.

Patch from Gideon Wald <gideonwald@chromium.org>
BUG=94112
TEST=This change just adds the icon, so there should be no user-visible change yet.

Review URL: http://codereview.chromium.org/7841017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99866 0039d316-1c4b-4281-b951-d872f2087c98

This updates the page listing licenses of third-party
software for R15.

BUG=chromium-os:18058
TEST=no errors from script; manual inspection of page and added/removed packages looks okay to me
TBR=zelidrag

Review URL: http://codereview.chromium.org/7795034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17167
TEST=None


Review URL: http://codereview.chromium.org/7840013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99864 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org


Review URL: http://codereview.chromium.org/7828103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99863 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91491
TEST=none

Review URL: http://codereview.chromium.org/7837015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99862 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://code.google.com/p/chromium/issues/detail?id=94320
TEST= various nacl exmaples, try bots
Review URL: http://codereview.chromium.org/7737013

TBR=nfullagar@google.com
Review URL: http://codereview.chromium.org/7782020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99861 0039d316-1c4b-4281-b951-d872f2087c98

TBR=groby
BUG=91771
TEST=none

Review URL: http://codereview.chromium.org/7789015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99859 0039d316-1c4b-4281-b951-d872f2087c98

The code prior to this CL invoked a copy constructor during static initialization.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98924

Review URL: http://codereview.chromium.org/7785016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99858 0039d316-1c4b-4281-b951-d872f2087c98

dependency on crypto (needed by downloads), http_server (needed by
the debugger), and fix the additional libraries for geolocation so that
they get picked up either by the current target (content.dll) or
the dependent target (content.lib inside chrome.dll)

R=darin@chromium.org
BUG=90442

Review URL: http://codereview.chromium.org/7740064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99857 0039d316-1c4b-4281-b951-d872f2087c98