- 27 Jul, 2018 40 commits
-
-
bsheedy authored
Adds a couple of extra waitForTabPageLoaded to VrBrowserNavigationTest#testIncognitoMaintainsSeparateHistoryStack as a workaround for Incognito tabs reporting page load too quickly, which was causing flakiness. This can be removed once the root cause is fixed. TBR=asimjour@chromium.org Bug: 868506 Change-Id: Ie91a8213e641d9f51dc353d5215e8ac0695db059 Reviewed-on: https://chromium-review.googlesource.com/1153614Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578785}
-
Ben Pastene authored
This prints an error if: - A line begins with '//' or '/*' - A non-comment contains a whitespace And prints a warning if: - A filter file contains both inclusions and exclusions Bug: 868000 Change-Id: I2a04504d3a17f4f7536b529a0e2e626eb6e61f66 Reviewed-on: https://chromium-review.googlesource.com/1153427 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578784}
-
Dmitry Gozman authored
WillSendRequest for main resource happens during BeginNavigation, so we can just skip it during commit time. The logic of saving metrics from DidReceiveResponse has been copied to CommitNavigation. We could get rid of DidReceiveResponse entirely if we were always going through CommitNavigation path, but we sometimes don't (see kWebNavigationPolicyCurrentTab returned from RFI::DecidePolicyForNavigation). Bug: 855189 Change-Id: Ib78bda6e22e4a301adf7c66215568ca6f02fa01d Reviewed-on: https://chromium-review.googlesource.com/1145900 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578783}
-
Jun Choi authored
Create observer interface so that WebAuthN UI components (i.e. ChromeAuthenticaterRequestDelegate and AuthenticatorRequestDialog) can get notified of device discovery. Bug: 866601 Change-Id: I0af544f4c3754bd0b76b6a354833ed12858a0967 Reviewed-on: https://chromium-review.googlesource.com/1147307 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578782}
-
Ben Pastene authored
TBR=jbudorick@chromium.org Bug: 840967 Change-Id: I69e89b0fc3ec3f658cd90e930d0cef7410cd3ae8 Reviewed-on: https://chromium-review.googlesource.com/1152040Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
The following patches change generic baselines, leaving NG-specific baselines stale and making those tests fail on layout_ng bot. This patch updates the NG baselines to keep up with the generic ones. https://chromium-review.googlesource.com/c/chromium/src/+/590273: - http/tests/loading/nested_bad_objects.php - http/tests/loading/preload-picture-nested.html - http/tests/loading/preload-picture-sizes-2x.html - http/tests/loading/preload-picture-sizes.html https://chromium-review.googlesource.com/c/chromium/src/+/1109819 - http/tests/navigation/form-targets-cross-site-frame-get.html - http/tests/navigation/form-targets-cross-site-frame-no-referrer.html - http/tests/navigation/form-targets-cross-site-frame-post.html - http/tests/navigation/form-with-enctype-targets-cross-site-frame.html https://chromium-review.googlesource.com/c/chromium/src/+/1006528 - http/tests/security/xssAuditor/block-does-not-leak-location.html https://chromium-review.googlesource.com/c/chromium/src/+/1147890 - http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html https://chromium-review.googlesource.com/c/chromium/src/+/1142571 - media/video-layer-crash.html - media/video-poster-scale.html - media/video-zoom.html Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id14eb56af7076931dd79c3815854177ca02c5acc Reviewed-on: https://chromium-review.googlesource.com/1153548 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578780}
-
James Cook authored
This is a reland of 2094f015 Reason for previous revert: viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/28406 The test wasn't cleaning up a test-only observer, so it was accessing invalid memory during the test shutdown spin of the message loop. Original change's description: > chromeos: Support a11y caret highlight in shortcut viewer app and mash > > The existing code updates the text input caret highlight by observing > input method state. This works in classic ash because the input method > is shared globally across ash and browser code. This doesn't work with > remote apps because ash can't see the input method in the remote > process. The caret doesn't work in mash because the ash process can't > see the browser's input method. > > Add support for a11y to observe the input method objects created by the > browser's input method driver / bridge. Explicitly forward the > text caret bounds to ash, which then updates the highlight. > > Bug: 867110 > Test: added to ash_unittests and browser_tests > Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72 > Reviewed-on: https://chromium-review.googlesource.com/1151897 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578473} TBR=tsepez@chromium.org Bug: 867110 Change-Id: I47b3b1af6d0bbc7183bbc7248492cb4d6ec3feca Reviewed-on: https://chromium-review.googlesource.com/1152373Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578779}
-
Hiroshige Hayashizaki authored
Bug: 861564 Change-Id: Ia41cf740fc405269307a8c92c85d8aaf4b54c9d1 Reviewed-on: https://chromium-review.googlesource.com/1128541 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578778}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b3bab6ce43ca..d72fd5888686 git log b3bab6ce43ca..d72fd5888686 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 thestig@chromium.org Fix some nits in FPDFEditEmbeddertest. Created with: gclient setdep -r src/third_party/pdfium@d72fd5888686 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I72ed8f9bbebf30397b365f7ce7f41561ce947fe5 Reviewed-on: https://chromium-review.googlesource.com/1153289Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578777}
-
Kenneth Russell authored
Better diagnostics have been added to the test, so expose any flakes that are still happening. Tbr: kainino@chromium.org Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5b1ba714f4854ef87b89f52c6bcfcf7652f06350 Reviewed-on: https://chromium-review.googlesource.com/1153556Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578776}
-
Peter Kasting authored
* Add GetDefaultColor() mapping function to make it easy to fix DCHECKs due to this code using raw _INCOGNITO color constants but ThemeProperties::GetDefaultColor() not expecting them. This is the change that led me to get annoyed and do all the other stuff here. * Convert typedefs to type aliases. * Add TP = ThemeProperties type alias for brevity. * Use =default. * Mark functions that don't touch member variables "static". * Fix wrapping issues. * Because the class here is so long, split it into declaration and definition pieces so it's easier to see what's the API and what's helper functions. * Make the API protected; make helpers private. * Make data members private. Add a const accessor for the one member tests use. Bug: none Change-Id: I4cc058bb29747cfa84835edbc5ce765401e14527 Reviewed-on: https://chromium-review.googlesource.com/1152108Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578775}
-
Donn Denman authored
Fixes a crash just introduce in CL https://chromium-review.googlesource.com/c/chromium/src/+/1045178 when clicking on a search result in the Overlay Panel. This click calls maximizePanel, but the previous CL needed to expose that to ContextualSearchPanel so it was overridden. That simple override was done incorrectly: it should call the super method but calls itself. BUG=868247 Change-Id: I2cabc1585d47f89414808f39c26b900d2e98f206 Reviewed-on: https://chromium-review.googlesource.com/1153442Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#578774}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f12600a8ba80..d795ab891c15 git log f12600a8ba80..d795ab891c15 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 jeremya@chromium.org Use system unzip on macOS 2018-07-27 jbudorick@chromium.org Add --patch_ref to bot_update. Created with: gclient setdep -r src/third_party/depot_tools@d795ab891c15 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865882 TBR=agable@chromium.org Change-Id: I05fa055224a181227579280eb5427a86363e1115 Reviewed-on: https://chromium-review.googlesource.com/1153510Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578773}
-
Peter Kasting authored
* 16 DIP min width * 2.5 DIP minimum padding around favicons * Clamp radius to no more than 1/3 the width of the top of the tab The second and third bullets are subject to change pending further feedback. Bug: 848412 Change-Id: I5d800eb183b6ec2d3cd4933207f51f92b954fc9d Reviewed-on: https://chromium-review.googlesource.com/1152546Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578772}
-
Bailey Berro authored
This change adds a NetworkFileSharesAllowed pref and policy to store whether or not a user is allowed to use the Network File Shares feature. Bug: chromium:757625 Change-Id: Icaf2015a841c31328b8cb36d26c73b2fa09fbcb6 Reviewed-on: https://chromium-review.googlesource.com/1141301 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#578771}
-
Bruce Dawson authored
Handling failures by crashing turns out to work poorly on Windows because it is confusing (it looks like a bug rather than a build failure) and because the process return code ends up being zero, so ninja doesn't realize anything is wrong. This change fixes these problems by detecting write failures and returning an error code. This particular CHECK is being fixed because it is easy to accidentally hit it simply by building Chrome while it is still running. The new error checking is also better in that it verifies that all Bug: 866656 Change-Id: I4303afaa898c85c72bd9d337fe8e19e239f17513 Reviewed-on: https://chromium-review.googlesource.com/1152159 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578770}
-
Allen Bauer authored
Bug: 868169 Change-Id: I9adeed2a4fd8d57d3ae26e7885f66eb3bcfcd85d Reviewed-on: https://chromium-review.googlesource.com/1153581 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578769}
-
Scott Violet authored
The number of shards for browser_tests on "Linux Chromium OS ASan LSan Tests (1)" was increased to 30 a while back, but not mash_browser_tests. This means mash_browser_tests often timeout on the bot. I'm upping the number of shards to be the same for the two. BUG=794372 TEST=none Change-Id: I24dd03bb0c61a65d34dfb290af1269026f9563a3 Reviewed-on: https://chromium-review.googlesource.com/1153549Reviewed-by:
-
Ramya Nagarajan authored
Specifically, this removes NewTabPageUIMd (which inadvertently enabled all UI features), and also removes NewTabPageCustomLinks (which is only available in M69). Bug: 831910 Change-Id: I03bc12477bba7f94576ff9a8f35f12ac3ba62299 Reviewed-on: https://chromium-review.googlesource.com/1153211Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#578767}
-
Kenneth Russell authored
These bots weren't building with these codecs and should have been. In at least one case (Win Builder), the fact that the waterfall bot wasn't building with the codecs represented a mismatch in configuration between the waterfall bot and trybot. This CL affects the configurations of the following machines: chromium.linux:Linux Builder (dbg) chromium.linux:Linux Builder (dbg)(32) chromium.linux:Linux Builder chromium.mac:Mac Builder (dbg) chromium.win:Win Builder chromium.win:Win Builder (dbg) chromium.win:Win x64 Builder chromium.win:Win x64 Builder (dbg) tryserver.chromium.linux:linux_chromium_dbg_32_ng tryserver.chromium.linux:linux_chromium_dbg_ng tryserver.chromium.mac:mac_chromium_compile_dbg_ng tryserver.chromium.mac:mac_chromium_dbg_ng tryserver.chromium.win:win10_chromium_x64_dbg_ng tryserver.chromium.win:win10_chromium_x64_rel_ng tryserver.chromium.win:win_chromium_compile_dbg_ng tryserver.chromium.win:win_chromium_dbg_ng tryserver.chromium.win:win_chromium_x64_rel_ng Bug: 867536 Change-Id: I04584548cb903df49ab1071535612ea151310c88 Reviewed-on: https://chromium-review.googlesource.com/1150450Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/021bad40ff8b..9bf86f07acd5 git log 021bad40ff8b..9bf86f07acd5 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 geofflang@chromium.org Don't sync the read framebuffer on draw calls. 2018-07-27 lrn1986@gmail.com Support EGL_(WIDTH|HEIGHT) in eglSurfaceAttrib(), fixed resize 2018-07-27 jmadill@chromium.org D3D: Return error from getVertexSpaceRequired. 2018-07-27 jmadill@chromium.org D3D: Pass gl::Context to many more functions. Created with: gclient setdep -r src/third_party/angle@9bf86f07acd5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I1ef966bf7450d269cf65820f935cb9ca81e37c81 Reviewed-on: https://chromium-review.googlesource.com/1153508Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578765}
-
Scott Violet authored
This reverts commit 1fa4591e. Reason for revert: In hopes of greening tree. Sample failure from https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/71221 : (see the compile no-op stage) ninja explain: output obj/content/test/nested_message_pump_android.lib doesn't exist ninja explain: obj/content/test/nested_message_pump_android.lib is dirty Original change's description: > Merge all content_shell renderer layout_test code. > > R=dcheng@chromium.org > TBR=jochen@chromium.org > > Currently layout test code is split over: > > - content/shell/test_runner/ (separate component) > Has renderer-side code, is allowed to use content/renderer/, does not > use content/shell/renderer/. > > - content/shell/renderer/layout_test/ (part of content_shell_lib) > Has renderer-side code, makes light use of content/shell/renderer/, but is > not able to use content/renderer/. > > - content/shell/browser/layout_test/ (part of content_shell_lib) > Has browser-side code, makes heavy use of content/shell/browser/, but is > not able to use content/browser/. > > - content/public/test/layouttest_support.h > Header for access to content/renderer/ things and content/browser/ > things. Used by content/shell/renderer/layout_test/ and > content/shell/browser/layout_test/. > > - content/test/layouttest_support.cc > Impls for access to content/renderer/ and content/browser/ things. > > > This patch aims to > 1. Combine the test_runner/ and shell/renderer/layout_test/ pieces of > code so they don't need to use indirections to interact. Their > separation is a legacy of test_runner/ being implemented inside blink > (WebKit) in the past. > 2. Move layouttest_support.h out of content/public/ and the .cc out of > content/test/ to a layout_test-specific code location. > > To do (1), test_runner/* moves to shell/renderer/layout_test/*. This > is fairly straight forward. We remove the TEST_RUNNER_EXPORT macro > as they are now part of a static library. They are left in the > test_runner namespace at the moment. > > To do (2), we move layouttest_support.(cc|h) to > shell/renderer/layout_test/. There are 3 methods in the file that > are called from shell/browser/layout_test/ and use content/browser > so we split those out to shell/browser/layout_test/. > > However this causes a problem that content_shell_lib will depend > on content/{browser,child,renderer}/ via the layouttest_support.cc > file. To avoid this, we > - Move content/shell/renderer/layout_test/* into a separate build > target called //content/shell:layout_test_renderer_lib and we > give it visibility to content/renderer/ and content/child/. > - Move content/shell/browser/layout_test/layouttest_support.* into > a separate build target called > //content/shell:browser_layout_test_support_lib. We don't move all > of content/shell/browser/layout_test/* because of heavy interaction > between it and its parent directory at this time. > - For a few files used by the shell/renderer/ (and shell/) and > shell/renderer/layout_test/ directories, we move them out to a > shared library as well, called > //content/shell:content_shell_renderer_common_lib. > - And for the common/layout_test/layout_test_switches.cc files, > which are used in both, but we'd like to not leak out of > content_shell_lib since they are part of .../layout_test/, we > make a non-public dep on //content/shell:content_shell_common_test_lib > > Ideally, I think we have a separate library for > //content/shell/browser/layout_test > //content/shell/common/layout_test > //content/shell/renderer/layout_test > > But we need better indirection between the content_shell_lib and > the .../layout_test/ code in order to do that. Once it was so, we > would be closer to making it possible to have a content_shell build > target that does not include any test code (and thus truly only uses > the public APIs), and a separate content_shell-like build target > that includes the layout test code. > > Bug: 866140 > Change-Id: Ia39f7385711bdb610948a07fd473ad9b346b82ae > Reviewed-on: https://chromium-review.googlesource.com/1145644 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578734} TBR=dgozman@chromium.org,danakj@chromium.org,dcheng@chromium.org,jochen@chromium.org Change-Id: Ie61b12dcfc00e5c59cf0c5e3137b305d957cb261 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866140 Reviewed-on: https://chromium-review.googlesource.com/1153611Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#578764}
-
Johann authored
R=tomfinegan@chromium.org Change-Id: I926b4d76701861c4351baf6e4982ce0beb962e49 Reviewed-on: https://chromium-review.googlesource.com/1153584Reviewed-by:
James Zern <jzern@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#578763}
-
Gabriel Charette authored
This reverts commit 9442f946. Reason for revert: didn't budge the graph (https://chromeperf.appspot.com/report?sid=d99ad2294f639cf4e0d0bbfa0e9aee1cac5a0352ef9f35d266f375f52466a608&start_rev=1526716391&end_rev=1532706078) Original change's description: > [TaskScheduler] Require constant initialization for g_heartbeat_for_testing > > Somehow r562248 caused a regression whereby it should have been strictly > more performant, the only difference is the potential static > initializer (which if incorrectly initialized could result in it being > non-zero? and somehow cause the timer to be fast?). > Let's try to suppress it. > > R=fdoray@chromium.org > > Bug: 848255 > Change-Id: I21111ddd4c069b9171badc58fc4a1914bb068641 > Reviewed-on: https://chromium-review.googlesource.com/1090794 > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578420} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: I457751dc2d9d410e049685e22cf3f79cf39d3c11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848255 Reviewed-on: https://chromium-review.googlesource.com/1153230Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578762}
-
Klaus Weidner authored
The kMaxArea downsizing logic in WebGLRenderingContextBase::Reshape causes the drawing buffer size to be smaller than the canvas size if the size would exceed 16 MiPixels. See https://crbug.com/445542 for additional background. The GetStaticBitmapImage has two separate implementations that are selected based on the preserve_drawing_buffer attribute. The non-preserving mode returns an image sized to match the drawing buffer, while the preserving snapshot used the canvas size. Change GetImage to use the drawing buffer size also for consistency. BUG=845742 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8cb00444e18f075abde881c5bb155ef039f7a68e Reviewed-on: https://chromium-review.googlesource.com/1153483Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 861564, 782981, 850662 Change-Id: Ib5c1dc874972aadd3223bd4851f0b5aeb695a727 Reviewed-on: https://chromium-review.googlesource.com/1128540 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator for //services/ui/public, and fixes all compile errors after that. After this CL, Mojo interfaces there service starts using base::OnceCallback instead of base::Callback on its return value handling. Bug: 714018 Change-Id: I9a0923249f3bb2b37319a118f742f384c90cf31f Reviewed-on: https://chromium-review.googlesource.com/1151185Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Tom Anderson authored
https://aomedia.googlesource.com/aom.git/+log/ef95278f79fa..4f1fd9640433 $ git log ef95278f7..4f1fd9640 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 thomasanderson Fix build with CFLAGS="-std=c11 -D_GNU_SOURCE" 2018-07-26 yunqingwang Free frame header buffer 2018-07-17 sachin.kumargarg Add ARM Neon optimization of txfm 8x8 2018-07-25 ddvfinite Add compute_stats SSE4_1 and AVX2 code 2018-07-26 jonathan.matthews [normative]Reset quantization params when not set 2018-07-26 deepa.kg Enable sse2 intrinsics for highbd variance calculation 2018-07-25 binpengsmail Refine pingpong buffer in handle_inter_mode 2018-07-25 ranjit.tulabandu Fix issues in interpolation filter selection 2018-07-22 birkbeck Add ifdef in SSE2/AVX2 fft tests 2018-07-25 binpengsmail Speedup motion_mode_rd 2018-07-25 angiebird Fix bug of DO_RANGE_CHECK_CLAMP Created with: roll-dep src/third_party/libaom/source/libaom BUG=427584 Change-Id: I96aac1e87e921bdc4c019c97d06d1884e66b6165 Reviewed-on: https://chromium-review.googlesource.com/1152365Reviewed-by:
-
Tommy Nyquist authored
Up until now, all actions related to in-product help have been considered directly triggered by the user, which is not necessarily the case, as some of them are more a by-product of other actions. This leads to in-product help being very prominent in some of helpful dashboards we have for these types of metrics, and it is swamping other entries. For now, the following in-product help actions are kept: * InProductHelp.Dismissed: * This is kept because it is in fact a user action to dismiss the in-product help. * InProductHelp.ShouldTriggerHelpUIResult.Triggered.IPH* * This is kept because it might very well impact what the user does next, since the UI will look different than for when it is not triggered. In addition, this happens very seldom, so the chances of this swamping the dashboards should be small. The following are marked as not_user_triggered: * InProductHelp.NotifyEvent.IPH* * This might be a user action, but if a feature cares about that, they should add their own specific action. * InProductHelp.ShouldTriggerHelpUI.IPH* * This is very often invoked, but is often a by-product of other actions. * InProductHelp.ShouldTriggerHelpUIResult.NotTriggered.IPH* * This is recorded around the same time as the ShouldTriggerHelpUI, and is also typically a by-product. * InProductHelp.ShouldTriggerHelpUIResult.WouldHaveTriggered.IPH* * This is recorded around the same time as the ShouldTriggerHelpUI, and is also typically a by-product. It is similar to the .Triggered version, but it does not have any effect on what the user sees. BUG=786102 Change-Id: I067d507470c79870e8627ecb1168584b862cf28b Reviewed-on: https://chromium-review.googlesource.com/1137026Reviewed-by: -
Yoshifumi Inoue authored
This patch introduces "EditingNG" runtime enabled feature which implies "LayoutNG" for adapting editing to LayoutNG incremental. Once editing functionalities adapted to LayoutNG, this runtime enabled feature will be removed. Bug: 707656 Change-Id: I3e9edcf9a207e284740d082feb8ef08dbec090a9 Reviewed-on: https://chromium-review.googlesource.com/1152715Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578756}
-
Avi Drissman authored
It's platform convention to show popups as new tabs while in non-HTML5 fullscreen. (Popups cause tabs to lose HTML5 fullscreen.) This was implemented for Cocoa in a BrowserWindow override, but it makes sense to just stick it into Browser and remove a ton of override code put in just to support this. BUG=858929, 868416 TEST=as in bugs Change-Id: I43471f242813ec1159d9c690bab73dab3e610b7d Reviewed-on: https://chromium-review.googlesource.com/1153455Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578755}
-
Hiroshige Hayashizaki authored
Previously, an opaque origin is passed to MainThreadDebugger::ContextCreated() for Paint/Layout worklets, and caused the origins in the context selector shown as "IFrame". This CL passes DocumentSecurityOrigin() instead, which is the origin of the Document that creates the worklets, and thus shows the correct origin. Bug: 866666, 861564 Change-Id: Ic038b3901ed0e301e4d2d9afdf632f7caf6add77 Reviewed-on: https://chromium-review.googlesource.com/1141290Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#578754}
-
Khushal authored
Currently |paint_image_entries_| which keeps track of the content ids being cached for a PaintImage can grow unbounded. Ensure that we keep purging it as the cached entries are removed from the |persistent_cache_|. R=ericrk@chromium.org Bug: 867939 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic43eee96eec42073a3d14512e62d39946585bba4 Reviewed-on: https://chromium-review.googlesource.com/1152492Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#578753}
-
bsheedy authored
Updates the XR instrumentation Markdown documentation to be consistent with the recent refactor. Bug: 863256 Change-Id: I21e2a492ab8e0a776010af9d624e04ef5631314a Reviewed-on: https://chromium-review.googlesource.com/1152515Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578752}
-
danakj authored
A SharedBitmapId must be unique and should only be registered with the display compositor once (and is implicitly unregistered if the CompositorFrameSink is lost that it was registered to). Crash the renderer if it violates this principle on a single CompositorFrameSink so we can help track down why this is happening. R=kylechar@chromium.org Bug: 862584 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I37f36d0e4be20c5313c92e9e3a319803c0a58aaf Reviewed-on: https://chromium-review.googlesource.com/1153467Reviewed-by:
-
Aaron Leventhal authored
When a node is reparented we currently destroy it rather than actually reusing it, causing it to look like a new node. New nodes do not fire change events for name, state, value or live regions. Impact: - We need to reuse nodes if we want them to be able to fire change events when they are reparented at the same time. - Accessibility nodes can be unexpectedly reparented by the layout engine, as shown in the included test. Bug: 469254 Change-Id: I7aec0d7852c712724b97be4a723df3c928720d62 Reviewed-on: https://chromium-review.googlesource.com/1152477 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578750}
-
dpapad authored
Change log: https://github.com/google/closure-compiler/compare/5cae9b78a16a2655627733b66d1c686d5f547925...137c2475944651f45433965afa9f1cddf7d1966b chrome_extensions.js: 03c824e85e7b77bde4e7449ed3727608b05b2acc -> 86f260c5faab5511c3a7111f93d99f6421e1f430 polymer-1.0.js: 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 -> 2efd918e5c4042f956fd76dae0d2714af9dc89ef Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id4f025206a59b5ddcc4797b6b3673ad8db805663 Reviewed-on: https://chromium-review.googlesource.com/1150831Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578749}
-
Cathy Li authored
Bug: 856172 Change-Id: I19d5e6052fb394aba40bde96bfa40762cc7e4e44 Reviewed-on: https://chromium-review.googlesource.com/1152100 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#578748}
-
Xida Chen authored
Right now none of SVG related painters call RecordHitTestData, that's why the "svgline" test case in the compositor-touch-hit-rects.html is failing. This CL adds a RecordHitTestData API in SVGShapePainter. It will fix the failing test. However, any SVG related painters should have such an API. It will be addressed in follow-up CLs together with new test cases. Bug: 853912 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7b8aa3869d8703a38a4f3265e4f1fc2744b6bd6a Reviewed-on: https://chromium-review.googlesource.com/1151616 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578747}
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I8e4af3d60d35a4b4af24267bb9967bca4ac5b5cc Reviewed-on: https://chromium-review.googlesource.com/1150808 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578746}
-
