GitLab

This fixes floats-do-not-fit-on-line.html which was two bugs combined.

1) List-markers shouldn't be positioned next to empty line boxes
   (unless point 2 occurs). This occurs in particular with floats,
   the list marker should follow the text down (which was the
   primary bug here).

2) List-markers should only be positioned next to empty line boxes if
   we are at the "last" line. I believe this includes forced \n breaks.
   We should produce a line box in these circumstances.

This patch also cleans up the "is empty line" logic inside:
NGInlineLayoutAlgorithm. Which was previously inconsistent :).

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I9bdc76a5cc40bf8c15651916594c44fd2383097c
Bug: 636993
Reviewed-on: https://chromium-review.googlesource.com/1136799Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575425}

Bug: 758690
Change-Id: I1776317786a6e11e1c966b15cc1921f03360ffe9
Reviewed-on: https://chromium-review.googlesource.com/1121241Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575424}

The VRMagicWindowProvider in WebVR was handed out on device creation.
For XR, we want to delay the creation of magic window until the
developer indicates that they want a session that requires it. Therefore
we are making it so that the VRMagicWindowProvider is only created and
returned in RequestSession.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I152b2287a05a0524b32c5017bb0a0b6feb0bda6b
Reviewed-on: https://chromium-review.googlesource.com/1108925
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575423}

https://skia.googlesource.com/skia.git/+log/b965fcb47296..c45a5c559365


git log b965fcb47296..c45a5c559365 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 fmalita@chromium.org [skottie] Treat color properties as optional (default black)
2018-07-16 senorblanco@chromium.org GrTessellator: collinear edges during sanitize.
2018-07-16 herb@google.com Device interface uses glyph run list


Created with:
  gclient setdep -r src/third_party/skia@c45a5c559365

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:860655
TBR=bungeman@chromium.org

Change-Id: I491d21ea6bdd24a7af0debf9ce017d957ebd164e
Reviewed-on: https://chromium-review.googlesource.com/1138695Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575422}

Was disabled for non ChromeOS platform in
https://chromium-review.googlesource.com/1006742

TBR=inferno@chromium.org

Bug: 789981
Change-Id: Iab8985e3dd5210bd4ce177cf8f3b60ff63a268d0
Reviewed-on: https://chromium-review.googlesource.com/1138868
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575421}

This fixes inconsistent separator positioning in non-integral scale factors.

Bug: none
Change-Id: I4fe92a4b8206db13478d7a0d3176d77e29435db7
Reviewed-on: https://chromium-review.googlesource.com/1137704Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575420}

Flakes seen in https://goo.gl/WQMoLM

Change-Id: I359c43949c7756e71dffbaade185bd7cb6865e6c
Tbr: twellington@chromium.org
NoTry: True
Bug: 813589
Reviewed-on: https://chromium-review.googlesource.com/1138520Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575419}

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=block%2Ffloat%2F003.html

show that this test has been consistently passing for a while now.

This looks like it was fixed here
https://chromium-review.googlesource.com/1124071 but the Expectations
were not fixed in the main expectations too.


Bug: 810335
Change-Id: Id01dcb0032e57cd191da746275b4ca4d9438c1e6
Reviewed-on: https://chromium-review.googlesource.com/1138733Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575418}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: I175756ba23f535eb4987b3385c72ab3744ea6ad7
Reviewed-on: https://chromium-review.googlesource.com/1133382Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#575417}

https://chromium.googlesource.com/angle/angle.git/+log/419acc8f4f3b..242c4fe86801


git log 419acc8f4f3b..242c4fe86801 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 jmadill@chromium.org Vulkan: Store ProgramVk shaders in ShaderInfo.
2018-07-16 jmadill@chromium.org Context: Fix missing "setErrorSet".
2018-07-16 jmadill@chromium.org Vulkan: Implement "default" vertex attributes.


Created with:
  gclient setdep -r src/third_party/angle@242c4fe86801

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ibc7281ca1edc71a7c748e9abc91b4bc3b333ea6e
Reviewed-on: https://chromium-review.googlesource.com/1138414Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575416}

Committing properties now updates the property values such that tests
can query for the values and validate state.

BUG=839487
TEST=Ran unittests

Change-Id: I71fd77937d09fdcf36d4ccd10345c5997c6022e4
Reviewed-on: https://chromium-review.googlesource.com/1120691
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575415}

- Invoke the SeatbeltExecServer in content::LaunchTests, which is the entrypoint
  for test child processes when not using bundled binaries. This is how the V2
  sandbox is engaged in test environments.
- Use the base::mac::BaseBundleID() for the seatbelt parameter, rather than the
  OuterBundle()'s CFBundleIdentifier. The MachPortBroker uses the former ID.

Bug: 689306
Change-Id: I075fa97df87b29b27556dd6edadb717d5742ee60
Reviewed-on: https://chromium-review.googlesource.com/1136525Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575414}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values:

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Additionally there are done some other trivial cleanups.

Change-Id: I06079828b3941d88bde1cc21985462b464098d57
Reviewed-on: https://chromium-review.googlesource.com/1135531
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575413}

Bug: 830892
Change-Id: I0621b9b69cd84e539231e535562f7c34b75fa1ca
Reviewed-on: https://chromium-review.googlesource.com/1136941
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575412}

Change-Id: I79a90c7476221c0481e81abad16f4612682d0e26
Reviewed-on: https://chromium-review.googlesource.com/1136865Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575411}

Bug: 859849
Change-Id: I88b4dc690cef0d482bb9f4a49a9aa7b688e8ae45
Reviewed-on: https://chromium-review.googlesource.com/1136470Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575410}

Add test cases for GetPDFDocInfo() and GetPDFPageSizeByIndex(). Since
these tests exercise PDFium with V8 enabled, there needs to be
additional calls to code in gin/v8_initializer.h.

Change-Id: I24e2ed21b850a7e1fb65ebb0c0c8948447641710
Reviewed-on: https://chromium-review.googlesource.com/1136015
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575409}

Chromium Embedded Framework sometimes uses an in-memory user-data-dir,
so the DevToolsActivePort file is not a viable option for them. We
think it is likely that other Chromium variants, present or future,
may have trouble with the DevToolsActivePort file, so this should
make things easier for them.

Also, fix testConnectToRemoteBrowser to
1. Have retries so it passes in the case of a race condition
for port allocation.
2. Prevent a race with Chrome during teardown.
   -- Note that this race was causing the user-data-dir to
      not be deleted at the end.

Bug: 863247
Change-Id: I506be26fc2e282b7194afd88afd02efcec65e880
Reviewed-on: https://chromium-review.googlesource.com/1137440
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575408}

Bug: 862307
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19f4051c152b0933d3142f734e9a253bea2b577d
Reviewed-on: https://chromium-review.googlesource.com/1137257Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575407}

GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash is
failing intermittently on macOS in general, not just on the ASAN bot.

Bug: 861956
Tbr: bsalomon@chromium.org
Tbr: ethannicholas@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib1c2e4f165c8f658e354559e62eea1b34d825ab4
Reviewed-on: https://chromium-review.googlesource.com/1138742
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575406}

Right now, with surface sync off on Android, we will defer commits
any time there's a size change, even if we've evicted the current
surface.

Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b
Bug: 848292, 672962
Reviewed-on: https://chromium-review.googlesource.com/1121098Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575405}

Experiments here didn't really pan out - we would need APIs from the
platform that aren't going to implemented any time soon - if ever. So
we can remove this code.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I58e9d29bf6589cf5900667828f32af3bc98012d8
Reviewed-on: https://chromium-review.googlesource.com/1128254Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575404}

This reverts commit 73716e90.

Reason for revert: Causes assertions in CTS tests because data can be null - see http://crbug.com/864152

Bug: 864152

Original change's description:
> Add histogram to measure usage of '#' in WebView loadData APIs
> 
> The goal is to compare how often this histogram is logged with the
> existing kDataUriHasOctothorpe UseCounter for WebView, in order to
> determine what API path we might want to modify when doing a compat
> fix. The belief is that the histogram and UseCounter should be
> roughly comparable because the histogram will only be recorded at most
> once per site load (because the loadData APIs cause a site load).
> 
> Bug: 823666
> Change-Id: I0ce63b8c86bc3bcd02d3b10ab7a38112fb520439
> Reviewed-on: https://chromium-review.googlesource.com/1112045
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575268}

TBR=boliu@chromium.org,rkaplow@chromium.org,torne@chromium.org,tdresser@chromium.org,smcgruer@chromium.org

Change-Id: Ic09f8689505c5e5bafdb052970f993428bac5e78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823666
Reviewed-on: https://chromium-review.googlesource.com/1138519Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575403}

Right now we clip(GL_SCISSOR) the display buffer based on the physical
pixel size of the display. The pixel size we send to the ui compositor
is the size we receive from the platform window(the display in Chrome
OS). However, this may not be what we want if the platform has some
fractional scale applied.

UI elements have their sizes set in DIP. If some UI element (ui::Layer)
has its size set to the DIP size of the display, their scaled size
(the pixel size after applying device scale factor) after rounding may
not match the physical pixel size of the display. This difference may
lead to 1px lines left unclipped. This happens in the case of the shelf
whose width is set to the width of the display. For a device like eve
where the internal display has a physical resolution width of 2400px,
if a device scale of 1.8 is applied, the DIP width of the display
becomes 1333. We set the bounds of the shelf to this. Now when we do
the actual paint, we scale the shelf to its physical pixel size which
is ROUND(1333*1.8) = 2399. At the same time the compositor will clip
things at width 2400. This difference is what gives the shelf a 1px
gap.

A proper way to fix this is to scale ui::Layer bounds such that it
snaps to the parent's or displays edge similar to what pixel canvas
does in views::View. However, that is a large change. In the meantime
this patch sets the correct physical pixel size for the compositor so
that correct clipping happens.

Bug: 843354
Change-Id: Ic9e055c0ba39d85a7297809baf946398bf09f40a
Component: UI compositor, pixel canvas, scaling, HiDPI
Reviewed-on: https://chromium-review.googlesource.com/1130495Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575402}

since it's included in screen_size_dependent_tests.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ida1867fd77e401909ea21e3bdce491158759ff05
Reviewed-on: https://chromium-review.googlesource.com/1133898
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575401}

When the user activates the omnibox popup, the popup suggestions have favicons and bookmark stars when appropriate. Selecting one (either because one is selected by default or by using the arrow or tab keys), displays the suggested match in the omnibox textfield. Previously, when the selected suggestion had a favicon or bookmark star icon, the omnibox would display the url or search icons. There is still a discpreency between omnibox and omnibox popup suggestion icons; with material refresh active, search suggestion icons will display the default search icon (magnifying glass) whereas the omnibox will display the default search provider's icon if available (`G` for Google).

Bug: 856755
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5874d72d0bde711fb3870a1ab0fd1f6e5c699eb8
Reviewed-on: https://chromium-review.googlesource.com/1124671
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575400}

R=piman@chromium.org

Change-Id: Ifabb4482142a43e158d8c6ff06b94d18531a7ee9
Reviewed-on: https://chromium-review.googlesource.com/1138734Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575399}

Change-Id: I9c3d675b9b694090a99f20d49b963d8dba6d038a
Tbr: sandersd@chromium.org
NoTry: True
Bug: 864018
Reviewed-on: https://chromium-review.googlesource.com/1138417Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575398}

This change moves the GamepadSharedMemoryReader class to
third_party/blink/renderer/modules/gamepad. Its instance is now
created in relevant Device*Dispatcher methods with a LocalFrame*
passed to be used for Mojo interface creation.
Since the GamepadMonitor interface request is now made on a frame, its
registration was moved to RenderFrameHost and
content_browser_manifest.json was updated accordingly.

Blink-related updates:
- DISALLOW_COPY_AND_ASSIGN -> WTF_MAKE_NONCOPYABLE

Bug: 612330
Change-Id: Ie3821f1bc75e4b4086f69db0eaf7cf88d65716a8
Reviewed-on: https://chromium-review.googlesource.com/1101841Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575397}

This CL improves tests in external/wpt/longtask-timing by:
* Increasing the length of a longtask from ~51 to ~60 to prevent a
coarse performance.now() granularity from affecting the tests.
* Wrapping the long tasks or iframes containing longtasks inside onload
handlers to ensure that the PerformanceObserver is registered by the
time the longtask is executed.

Test: third_party/blink/tools/run_web_tests external/wpt/longtask-timing
--iterations=1000 did not produce flakes.

Bug: 796668
Change-Id: Ic2ce59f7d221566f5443da9e9c7d36c7bd7bbe6f
Reviewed-on: https://chromium-review.googlesource.com/1138725
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575396}

Currently, we send an empty string as a resource loading hint to the
renderer when doing previews resource loading hints optimization.
This CL changes the browser's behavior to send the resource loading
hints that are provided by Previews UI service.

The CL also enables browsertest to modify the list of hints that are
sent to the renderer. This will be used in a browsertest in a subsequent
CL to verify that subresources that match the pattern are not loaded.

Bug: 856243,856247
Change-Id: I29a393dd37090fcb8dc5706669e88e0ae91f47db
Reviewed-on: https://chromium-review.googlesource.com/1136885Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575395}

Now webrunner::FrameImpl creates WebContents and a WindowTreeHost.

Also moved FrameImpl and ContextImpl classes to //webrunner/browser
(because they run in the browser process).

Bug: 852145
Change-Id: Ic1f3e453342f182e28bbf971fae011a671bee105
Reviewed-on: https://chromium-review.googlesource.com/1135836Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575394}

One-pager describing this refactoring: https://goo.gl/24gkCb

This is a follow-up to the crrev.com/574691
This patch:
- renames content::PermissionManager into content::PermissionControllerDelegate
- renames BrowserContext::GetPermissionManager() into BrowserContext::GetPermissionControllerDelegate
- renames content::TestBrowserContext::SetPermissionManager into TestBrowserContext::SetPermissionControllerDelegate

R=dgozman
TBR=boliu, scottmg, xunjieli, spang, thestig
BUG=631464

Change-Id: I01ca186635898d250877e7462a731e47ffae31c3
Reviewed-on: https://chromium-review.googlesource.com/1136858
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575393}

Optimization part 2 of ~3

This is in preparation for a follow-on change that will change
RenderTextHarfBuzz::ShapeRun to take a single CommonParams, and a list
of all runs that share these parameters.

To that end, pull out explicit use of RenderTextHarfBuzz::common, and
pass the CommonParams explicitly, wherever possible.

Bug: 862773
Change-Id: Ia349c23ad58ab590c8ec6f05c6a9f1dcc253ab57
Reviewed-on: https://chromium-review.googlesource.com/1137891
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575392}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d75ef78a..4fb310a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4b3e4572f651fd34977ded01d5a5a301af033ae0
Reviewed-on: https://chromium-review.googlesource.com/1138720Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575391}

Bug: 862163
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ied380807f9f57998d04e2ffddd004048568f0f9f
Reviewed-on: https://chromium-review.googlesource.com/1136724Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575390}

This patch fixes max-content size when the line has floats
outside of its content box.

In such case, ComputeContentSize computes a negative value
for |floats_inline_size|. Such |floats_inline_size| should
not affect max-content size.

This patch applies the same fix as r570350 (CL:1113094) to
NGInlineNode.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5495e56fb3cf6777a4fd308b61f5eb6e484d03af
Reviewed-on: https://chromium-review.googlesource.com/1138594
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575389}

This fixes a failure mode where we shutdownVR after handling the VR NFC
broadcast, and fail to properly cancel VR entry.

Also does some other random cleanup of comments/visibility.

Bug: 862829
Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b
Reviewed-on: https://chromium-review.googlesource.com/1138726Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575388}

This comment was added in https://chromium-review.googlesource.com/c/chromium/src/+/834758 but the test has been fixed since then.

Bug: 621126
Change-Id: I22f77f9548bef8741e9aaf7325346c860efca292
Reviewed-on: https://chromium-review.googlesource.com/1138724Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575387}

See https://www.w3.org/TR/webauthn/#sec-authenticator-data. AFAIU, the
spec is not exactly clear whether or not to set this bit from a user
verifying authenticator. It says that the bit should be set if the
user is "present", which is defined as having successfully completed a
"user presence test". User presence test is defined separately from user
verification test (which is what Touch ID does). Logically, a user
verification test always includes a user presence test, but the spec
doesn't say so explicitly.

Regardless of what the spec says, setting both bits seems less likely to
confuse server implementations IMO. A naive server e.g. might *just*
check for the UP bit, and if it is not set reject the response, even
though the UV bit is set. Hence, we should probably set both.

Bug: 678128
Change-Id: I02be366dba324e4f9b83ba0d354a674242fc72dc
Reviewed-on: https://chromium-review.googlesource.com/1137216
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575386}