GitLab

Adds two new methods: AlignedAlloc and AlignedFree for creating and
destroying dynamic aligned allocations respectively.  Also adds a
helper class, ScopedPtrAlignedFree, for use with scoped_ptr_malloc.

AlignedAlloc uses posix_memalign for OS X (now that we're targeting
10.6), Linux and _aligned_alloc() on Windows.  Android and NaCl use
memalign() since they do not expose posix_memalign() and memalign()
is safe to use with free() on those platforms.

Also hacks around a bug in Visual C++ where __alignof will sometimes
return zero:
http://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types

BUG=none
TEST=base_unittests + new test, trybots.

Review URL: https://chromiumcodereview.appspot.com/10796020

TBR=dalecurtis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10817021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148016 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10810063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148015 0039d316-1c4b-4281-b951-d872f2087c98

Replaced the regex in IntroDataSource with an HTML parser.

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10810047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148014 0039d316-1c4b-4281-b951-d872f2087c98

* Add promo_type_. For now this is hardcoded to ntp_notification_promo, but we'll also allow bubble_promo soon.
* Store promo preferences in a dictionary, in a list, in a promo object. This reflects the structure of the promo as we receive it over the wire.
* Add ClearDeprecatedPrefs.
* Fix logic of CheckForNewNotification, HandleViewed and HandleClosed. These now call InitFromPreferences.
* Add better tests for HandleViewed and HandleClosed. Get rid of TestPrefs.

BUG=123061
TEST=unit tests.

Review URL: https://chromiumcodereview.appspot.com/10790089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148013 0039d316-1c4b-4281-b951-d872f2087c98

This addresses image quality issues when to a high-resolution device from a high-DPI but lower resolution client.  In this case Chromoting would down-scale to the plugin's DIP dimensions, only for Chrome to up-scale to device dimensions.

Follow-up CLs will add DPI information to the FrameConsumer interface, and try to optimize the plugin's up-scaling mode.

BUG=133349,135089


Review URL: https://chromiumcodereview.appspot.com/10785041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148012 0039d316-1c4b-4281-b951-d872f2087c98

switch mediaGalleries to .idl api definition

BUG=none
TEST=manual
TBR=asargent

Review URL: https://chromiumcodereview.appspot.com/10800083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148011 0039d316-1c4b-4281-b951-d872f2087c98

Win8 SDK xinput import lib pulls xinput1_4.dll, but we want to use 1_3, so load it manually.

R=cpu@chromium.org
BUG=113035


Review URL: https://chromiumcodereview.appspot.com/10781023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148007 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the implicit -lppapi and pthread in the Makefiles.  Since ppapi lib 
does not exist on the host (on NaCl it's actually a linker script), we need to 
create a bogus ppapi.lib for host Pepper development.  In addition, on Windows we
do not have a pthread library so we create a mini pthread library to support the
examples.


This CL also fixes tries which are broken on Windows.

Review URL: https://chromiumcodereview.appspot.com/10815039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132370
TEST=No behavioural change expected.


Review URL: https://chromiumcodereview.appspot.com/10661058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=jscompiler reports no warnings.


Review URL: https://chromiumcodereview.appspot.com/10796097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148004 0039d316-1c4b-4281-b951-d872f2087c98

All towards the goal of upstreaming our NTP version.

BUG=138245

TEST=


Review URL: https://chromiumcodereview.appspot.com/10797053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148003 0039d316-1c4b-4281-b951-d872f2087c98

Add a new TrayBarButtonWithTitle class which can be used for both audio and brightness UI for toggle audio/brightness state.
Clip the extra empty space around left/right bar images so that the bar image would not have too much empty space around itself.
The new audio/brightness slider will be implemented in another cl.

BUG=122832
TEST=The new mute segment should show up and work on uber tray bubble.
TBR=oshima@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10808080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148002 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148000 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10808091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147999 0039d316-1c4b-4281-b951-d872f2087c98

This adds a function for formatting a base::Time as an RFC
3339 date/time, e.g. "2012-07-03T12:30:34.318Z".  This
function complements the existing
gdata::util::GetTimeFromString(), and is needed for a later
contacts-related change.

BUG=128805
TEST=added


Review URL: https://chromiumcodereview.appspot.com/10790124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147998 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the following bugs:
 * Getting the length of translated shader source failed on pending compilation
 * Getting the translated shader source failed on pending compilation
 * Getting the translated shader source after a new source is set

Small refactoring:
 * Put an enum in ShaderInfo for storing the compilation state

BUG=137758


Review URL: https://chromiumcodereview.appspot.com/10812002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147997 0039d316-1c4b-4281-b951-d872f2087c98

Implemented the api_index.html and experimental.html pages using an
api_list_data_source.

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10815042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147995 0039d316-1c4b-4281-b951-d872f2087c98

We move the setuid sandbox "client" code to its own location in
/sandbox/linux/suid/client and we create a SetuidSandboxClient class
to use it.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10807059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138139
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10704241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ran "git status"
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10805077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147991 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147990 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for upstreaming the instrumentation tests,
we need these components first.

BUG=136687
TEST=


Review URL: https://chromiumcodereview.appspot.com/10796031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147989 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new methods: AlignedAlloc and AlignedFree for creating and
destroying dynamic aligned allocations respectively.  Also adds a
helper class, ScopedPtrAlignedFree, for use with scoped_ptr_malloc.

AlignedAlloc uses posix_memalign for OS X (now that we're targeting
10.6), Linux and _aligned_alloc() on Windows.  Android and NaCl use
memalign() since they do not expose posix_memalign() and memalign()
is safe to use with free() on those platforms.

Also hacks around a bug in Visual C++ where __alignof will sometimes
return zero:
http://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types

BUG=none
TEST=base_unittests + new test, trybots.

Review URL: https://chromiumcodereview.appspot.com/10796020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147988 0039d316-1c4b-4281-b951-d872f2087c98

and job id wherever possible


BUG=138602
TEST=

Review URL: https://chromiumcodereview.appspot.com/10808086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147987 0039d316-1c4b-4281-b951-d872f2087c98

[Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPLEMENTED()s from official builds.

Includes:
1) Allowing overridding of android_ndk_sysroot (addition of "%" in
variable name).
2) Disable NOTIMPLEMENTED output for official builds (see base/logging.h)
3) Add clang build configurations
4) Remove unnecessary cflags from regular build.
5) Include crtbegin_so.o and crtend_so.so for _type=="loadable_module"
which is needed for ppapi_tests.

BUG=137569


Review URL: https://chromiumcodereview.appspot.com/10808042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147986 0039d316-1c4b-4281-b951-d872f2087c98

Some minor fixes that were bugging me:
- TemplateDataSource now uses the correct path and does not depend on catching
  an exception
- LocalFileSystem was caching files forever with the new FileSystem interface,
  now it doesn't
- Added some logs for exception handling.

BUG=131095

Review URL: https://chromiumcodereview.appspot.com/10808065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147985 0039d316-1c4b-4281-b951-d872f2087c98

Moved ExtensionEventRouter, ExtensionEventRouterForwarder,
ExtensionBrowserEventRouter into extensions namespace and renamed them
appropriately. Also some header file gardening.

BUG=137115, 117261


Review URL: https://chromiumcodereview.appspot.com/10696208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10806056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147983 0039d316-1c4b-4281-b951-d872f2087c98

Spend around 2 days with reproducing the problem, checking out the underlying code, and discussing with others (see bug for more info) without further insights. Since the bug is gone with v22 and we might get more data if it crashes later, we hope that this is an adequate solution for the problem (even though it is not satisfying).


BUG=134465
TEST=NONE and not reproducible


Review URL: https://chromiumcodereview.appspot.com/10790058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147982 0039d316-1c4b-4281-b951-d872f2087c98

Store profile prefs and deprecate service-local storage.
(in preparation for new Sync Invalidation API integration)
Add kChromeToMobile[DeviceList|Timestamp] pref strings.
Add RegisterUserPrefs() static method and standard call.
Update/rename GetMobiles() and rename HasMobiles().
Update Mac unit test; misc minor cleanup and refactoring.

BUG=102709
TEST=Updated unit test; no Chrome To Mobile regressions.

Review URL: https://chromiumcodereview.appspot.com/10808068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147981 0039d316-1c4b-4281-b951-d872f2087c98

We get in trouble because FileBrowserEventRouter creates gdata system service
early on (before we setup test service factory). When we create test system
service, the old one gets shutdown and destroyed, but they both use the same
gdata cache root path (which is created and destroyed async).

This patch avoid use of GDataSystemServiceFactory::SetTestingFactoryAndUse,
which cannot be called before an system service instance is already alive
(created early on by FileBroserEventRouter).

the flakiness was introduced by https://src.chromium.org/viewvc/chrome?view=rev&revision=147208

TEST=RemoteFileSystemExtensionApiTest.*
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10805034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147980 0039d316-1c4b-4281-b951-d872f2087c98

There's already a TODO about why this is necessary and how the new API is not
sufficient.

BUG=137676
TEST=compiles


Review URL: https://chromiumcodereview.appspot.com/10802043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147979 0039d316-1c4b-4281-b951-d872f2087c98

You know what's better than passing back PIPELINE_OK and not-PIPELINE_OK? A boolean.

BUG=126067
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10808087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147978 0039d316-1c4b-4281-b951-d872f2087c98

Update tests to work with VSC.

I'll land this after http://codereview.chromium.org/10795027/ is landed.

I kept active_root_window_ because we're planning to create a launcher per display, and I'm going to use it to decide on which display the status bubble will be shown.

BUG=123160
TEST=Updated tests, plus added new test cases to ExtendedDesktopText.ConvertPoint

Review URL: https://chromiumcodereview.appspot.com/10790090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147977 0039d316-1c4b-4281-b951-d872f2087c98

Message loop captured in constructor is not the UI loop. Get a UI message loop
proxy in the ExecuteParams constructor and use that instead.

BUG=138087
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10815057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147976 0039d316-1c4b-4281-b951-d872f2087c98

The bounding box is the smallest axis-aligned rectangle that encloses all the
bounding-boxes of all the touch-points in the gesture.

BUG=none
TEST=existing aura_unittests

Review URL: https://chromiumcodereview.appspot.com/10808083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147975 0039d316-1c4b-4281-b951-d872f2087c98

These are required by the Android find-in-page implementation. Further patches
will introduce automatic conversion from WebKit::WebFloatRect to gfx::RectF.


BUG=136762
TEST=new case added to base_unittests


Review URL: https://chromiumcodereview.appspot.com/10818011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147974 0039d316-1c4b-4281-b951-d872f2087c98

Two is the fewest number of allowed buckets. Should be fine for these.

R=dominich@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10805063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147973 0039d316-1c4b-4281-b951-d872f2087c98

1- The US locale is sometimes "en" and sometimes "en-US"
2- Users that hit "don't bug me" where shown the same toast again when we ran the toast twice in a row. Now we compare the prefix of the experiment witht the 'client' prefix if equal it means we already toasted this user with this same experiment.

BUG=130169
Review URL: https://chromiumcodereview.appspot.com/10802063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147972 0039d316-1c4b-4281-b951-d872f2087c98

Old value: 2048   New value: 2400 (50ms at 48kHz)
This will use WASAPI low latency back-end for examples that ask for
recommended sample buffer size starting from 2048 samples.
BUG=http://code.google.com/p/chromium/issues/detail?id=138110
TEST=tbd:manual click test on lower end vista machine

Review URL: https://chromiumcodereview.appspot.com/10805031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147971 0039d316-1c4b-4281-b951-d872f2087c98