GitLab

CL number 2 in a series of CLs to optimize the creation and showing of
Chrome OS App Launcher.

This CL modernizes the code, and removes a lot of wasted cycles.

CPU Duration savings in creating and showing the launcher for the first time after login:
  On peach_pit:
    - Old: 39 ms.
    - New: 34 ms.
  On kevin:
    - Old: 46 ms.
    - New: 40 ms.

BUG=631516

Review-Url: https://codereview.chromium.org/2701123002
Cr-Commit-Position: refs/heads/master@{#453267}

BUG=None

Review-Url: https://codereview.chromium.org/2714293002
Cr-Commit-Position: refs/heads/master@{#453266}

BUG=675285

Review-Url: https://codereview.chromium.org/2686393002
Cr-Commit-Position: refs/heads/master@{#453265}

https://skia.googlesource.com/skia.git/+log/ab8e02a4dee7..578f064a60b6

$ git log ab8e02a4d..578f064a6 --date=short --no-merges --format='%ad %ae %s'
2017-02-24 csmartdalton Add msaa flag and UI to viewer

Created with:
  roll-dep src/third_party/skia

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2718113002
Cr-Commit-Position: refs/heads/master@{#453264}

BUG=657733

Review-Url: https://codereview.chromium.org/2711783008
Cr-Commit-Position: refs/heads/master@{#453263}

R=hcarmona@chromium.org
BUG=693373
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716233002
Cr-Commit-Position: refs/heads/master@{#453262}

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2706333004
Cr-Commit-Position: refs/heads/master@{#453261}

Previously when some new baseline files are under new directories,
Git.untracked_files() returned the untracked directories, without
the new baseline files, causing the new baseline files not added.

Add '--untracked-files=all' paramter to 'git status' command to
show untracked files under untracked directories.

BUG=676748

Review-Url: https://codereview.chromium.org/2713383002
Cr-Commit-Position: refs/heads/master@{#453260}

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG=693735
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/645770e4019b..90835c8a63de

$ git log 645770e40..90835c8a6 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 chiniforooshan tracing: introduce TraceStream for large traces

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2720733003
Cr-Commit-Position: refs/heads/master@{#453258}

Existing users can continue to split modules by gn targets by passing
--split-project to generate_gradle.py, although that flag will not
receive the same maintenance going forward, consider it deprecated.

This coalesces java and resource dependencies into the same build.gradle
file for each apk and junit target specified (test apks still get folded
into the apk_under_test target).

Speeds up sync/builds by 10x to 1-3 seconds. Paves the way for using
more of android studio's build steps, since they'll now take 1-3 seconds
rather than 10+ seconds each time.

BUG=620034

Review-Url: https://codereview.chromium.org/2708133002
Cr-Commit-Position: refs/heads/master@{#453257}

HarfBuzz requires the current axis coordinates to perform correct mark
placement. Now that Skia provides the required API [1] we pass them from
Skia to HarfBuzz.

[1] https://skia-review.googlesource.com/c/8861/

TEST=Currently manually using Noto Sans Arabic, TODO issue 693065
BUG=674879

Review-Url: https://codereview.chromium.org/2698043005
Cr-Commit-Position: refs/heads/master@{#453256}

This is no longer needed as the app has been turned off.

BUG=None
TEST=None
R=jschuh@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2711003003
Cr-Commit-Position: refs/heads/master@{#453255}

Remove unnecessary collection view -reloadData call in -viewWillAppear.

BUG=686770

Review-Url: https://codereview.chromium.org/2714363002
Cr-Commit-Position: refs/heads/master@{#453254}

BUG=682421
TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment*

Review-Url: https://codereview.chromium.org/2716383002
Cr-Commit-Position: refs/heads/master@{#453253}

MIPS64 requires IAS to be explicitly set.

Few important mips64 related changes were missing in Clang.
With Clang roll to r295762 they are included and
clang does not crash anymore.

Now that build is ok we can switch to IAS as well.

BUG=None.
TEST=gn gen out-gn/mips64-clang --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" is_clang=true mips_use_msa=false"
     ninja -C out-gn/mips64-clang system_webview_apk

Review-Url: https://codereview.chromium.org/2720833002
Cr-Commit-Position: refs/heads/master@{#453252}

* Separate params in feature for small and large screens
* Exposed in chrome:flags
* See bug for screenshots

BUG=688338

Review-Url: https://codereview.chromium.org/2714723002
Cr-Commit-Position: refs/heads/master@{#453251}

(patchset #5 id:80001 of https://codereview.chromium.org/2709563002/ )"

This reverts commit 08c967e8.

The cell selection and reload logic was incorrect.
If the same cell was selected again, two identical indexPaths were
passed into -reloadItemsAtIndexPath:.

BUG=686770

Review-Url: https://codereview.chromium.org/2716773003
Cr-Commit-Position: refs/heads/master@{#453250}

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator.
The zoom animator will resize the VC's view to a small rect.
However, that rect is smaller in height than the sum of the
height constraints on the subviews of the tab_container.

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify
the zoom animator at this time.

BUG=

Review-Url: https://codereview.chromium.org/2717133002
Cr-Commit-Position: refs/heads/master@{#453249}

PnaclTranslationCacheEntry has a non-thread-safe ref count, and usually
bound to IO thread. However, disk_cache::BackendIO may be destroyed on
CACHE thread, and may drop a reference on it. That causes a data race
on the unprotected ref count.

BUG=688072

Review-Url: https://codereview.chromium.org/2722513002
Cr-Commit-Position: refs/heads/master@{#453248}

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2711783003
Cr-Commit-Position: refs/heads/master@{#453247}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0dae245e..4ed8f7ed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2719973002
Cr-Commit-Position: refs/heads/master@{#453246}

When a password field is autofilled, the value is not accessible to JavaScript
until the user clicks or types in the page. To keep track of this, the frames
report such user gestures, and ChromeAutofillClient distributes such a signal
to all other frames in the same WebContent, via their common
AutofillDriverFactory.

This does not work when a new frame is added later, because the browser process
does not keep track whether the user gestures were seen already. Newly added
frames never learn about the user already having clicked in the page.

This CL fixes that by modifying AutofillDriverFactory to remember the
user gestures and notify also drivers added later. The flag is reset on main
page navigation.

The CL also makes parts of the AutofillDriverFactory API public, as long as they
do not modify the drivers map. This results in a slight reordering of methods.

BUG=669045

Review-Url: https://codereview.chromium.org/2603623002
Cr-Commit-Position: refs/heads/master@{#453245}

https://pdfium.googlesource.com/pdfium.git/+log/1d7018e92d31..717a4fc857d6

$ git log 1d7018e92..717a4fc85 --date=short --no-merges --format='%ad %ae %s'
2017-02-24 thestig Remove some pointless checks and assignments.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2723513003
Cr-Commit-Position: refs/heads/master@{#453244}

This finishes moving memory instrumentation code from TracingController
to its own location in //services/resource_coordinator.

BUG=679830
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2694083005
Cr-Commit-Position: refs/heads/master@{#453243}

ScopedPlatformHandle encapsulates ownership of one of various types
of platform-specific resource handles including POSIX file descriptors,
and Windows handles.

The purpose of this type is to have a consistent representation of such
resources for the sake of safe ownership semantics across various API
boundaries, relegating platform-specific details to either the code which
initially acquires the resource or the code which actually uses it.

BUG=None

Review-Url: https://codereview.chromium.org/2705743002
Cr-Commit-Position: refs/heads/master@{#453242}

This test does not need a full FindInPageController, so that is removed from the
test fixture.  Additionally, the find in page unittest files are moved from
ios/chrome/browser/web to ios/chrome/browser/find_in_page.

BUG=691073

Review-Url: https://codereview.chromium.org/2711513002
Cr-Commit-Position: refs/heads/master@{#453241}

This CL adds a variations parameter for launching renderer in WebAPK
process. When enabled, WebAPK would launch Chrome's renderer process as
its own process; otherwise, WebAPK would launch Chrome's renderer
process as Chrome's process.

BUG=692627

Review-Url: https://codereview.chromium.org/2716493002
Cr-Commit-Position: refs/heads/master@{#453240}

This patch adds the necessary logic to allow the user to use the
Payment Method Selection Screen to select the credit card to send to the
website.

BUG=679835

Review-Url: https://codereview.chromium.org/2711973002
Cr-Commit-Position: refs/heads/master@{#453239}

Change log statements from ui/display/manager/chromeos/ that were being
logged in Chrome OS devices unnecessarily. Remove a VLOG(1) added by me
to observe the fix to a bug on beta channel. I believe the bug is fixed
and this isn't necessary anymore. Also change a LOG(WARNNING) to
VLOG(2) for unmatched touchscreen displays. Not all displays are
touchscreens, so this shouldn't be a warning.

BUG=682079

Review-Url: https://codereview.chromium.org/2721633002
Cr-Commit-Position: refs/heads/master@{#453238}

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2700823002
Cr-Commit-Position: refs/heads/master@{#453237}

https://skia.googlesource.com/skia.git/+log/61b721c449d0..ab8e02a4dee7

$ git log 61b721c44..ab8e02a4d --date=short --no-merges --format='%ad %ae %s'
2017-02-27 halcanary SkGradientShader: Fix multi-byte-read-stack-use-after-scope
2017-02-27 mtklein Drop SkRasterPipelineBench N to 15.

Created with:
  roll-dep src/third_party/skia
BUG=694098

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2717363002
Cr-Commit-Position: refs/heads/master@{#453236}

This single callback replaces UrlHashChanged and HistoryStateChanged.

BUG=692331
TEST=page gets translated after same document navigations.

Review-Url: https://codereview.chromium.org/2711363003
Cr-Commit-Position: refs/heads/master@{#453235}

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2703803002
Cr-Commit-Position: refs/heads/master@{#453234}

Merge the addBeginTime and addEndTime methods into a single method
addInstanceTime (that takes a BeginOrEnd argument.) Migrate callers to
the new method, getting rid of SVGSMILElement::handleConditionEvent in
the process.
Also inline some trivial functions in SVGAnimationElement.

BUG=641437

Review-Url: https://codereview.chromium.org/2712343004
Cr-Commit-Position: refs/heads/master@{#453233}

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257

Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1c1bd4d..b369f97

$ git log 1c1bd4d..b369f97 --date=short --no-merges --format=%ad %ae %s
2017-02-27 tommi@webrtc.org Remove extra call to TimeUntilNextProcess from within Process.
2017-02-27 kthelgason@webrtc.org iOS AppRTCMobile: Fix SocketRocket bug
2017-02-27 henrika@webrtc.org Simplifies FineAudioBuffer by using rtc::Buffer
2017-02-27 tommi@webrtc.org Revert of Use TaskQueue in IncomingVideoStream (patchset #10 id:320001 of https://codereview.webrtc.org/2716473002/ )
2017-02-27 tommi@webrtc.org Fix race in INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO
2017-02-27 tommi@webrtc.org Use TaskQueue in IncomingVideoStream instead of the PlatformThread + event timer approach.
2017-02-27 sprang@webrtc.org Fix race condition in VideoSendStreamTest.ChangingTransportOverhead

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2723503002
Cr-Commit-Position: refs/heads/master@{#453231}

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714973002
Cr-Commit-Position: refs/heads/master@{#453230}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a75c463e8416..645770e4019b

$ git log a75c463e8..645770e40 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 achuith Disable testEnsurePCv1Cold and testEnsurePCv1WarmFromScratch

Created with:
  roll-dep src/third_party/catapult
BUG=694722

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2720693005
Cr-Commit-Position: refs/heads/master@{#453229}

https://pdfium.googlesource.com/pdfium.git/+log/eb38d63ba8a8..1d7018e92d31

$ git log eb38d63ba..1d7018e92 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 dsinclair Whitespace change

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2715263002
Cr-Commit-Position: refs/heads/master@{#453228}