- 08 Jul, 2020 40 commits
-
-
Yuki Shiino authored
Implements the V8 context initialization with using the new binding generator of IDL interfaces. Bug: 839389 Change-Id: Ic8972b7f654ea80a328db3c4be40b2b7780bafc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282838 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#786189}
-
David Jean authored
These metrics should not expire since they are tracked for regression. Bug: 1100372 Change-Id: I7dacfc3cedd3966f8610209d84014abd6a86d973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283348Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#786188}
-
Kyle Horimoto authored
Before this CL, WiFi configurations would sync even if a policy explicitly prohibited them from being synced. This was due to a naming issue: "osWifiConfigurations" vs. "wifiConfigurations". The bug was due to the migration of this type from normal browser sync to OS sync. Bug: 1101036 Change-Id: I5604526b85a41d24013eee5765bfbf46ee65ba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285927 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#786187}
-
sandromaggi authored
Before this change we lost autofill error details when the Autofill action itself succeeded but the RequiredFieldsFallbackHandler did not. Bug: b/160651587 Change-Id: I6a72e36e01117ae428a7add4cc6bdfe6af2ad6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283593 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#786186}
-
Ted Choc authored
BUG=1044616 Change-Id: I4d47b2430379626beab226c7c7d0f2e68cf53033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284388Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786185}
-
Gyuyoung Kim authored
This CL cleans up unnecessary uses of below header files, - interface_ptr.h - interface_request.h - threadsafe_interface_ptr.h - associated_interface_ptr.h Bug: 955171, 1035484 Change-Id: I8a157f618b6bb100f212fe35cf437f3864aa6dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594004320-2e826e0a02d03f5d95b06057ee6fb0c871fea712.profdata to chrome-win32-master-1594169954-cd07ad6b204758d03bed8bf845cd0c0bb5f93bcd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I565fee1197d6522a90fc00932d56c6d1ccfed833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786183}
-
Daniel Hosseinian authored
Capitalize Epson CUPS color values to potentially fix a problem where the Epson filter is not detecting the color mode and prints data intended for color in monochrome. Bug: 1081705 Change-Id: Ic192d9809dca2101988fe00da7decc5b1002de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285180 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Hesen Zhang authored
Bug: 1066556 Change-Id: Iaee901e0071dc39144e369dca07409bbfd6f8421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283325 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786181}
-
Ken Rockot authored
This fixes some edge cases which can cause SharedRemote to either block unnecessarily on its bound sequence or fail to block as intended on its bound sequence, depending on how it's constructed and called into. We want to repurpose the underlying Remote's sync waiting behavior when the SharedRemote makes a sync call from the bound sequence, but when a call is made from any other sequence, the SharedRemote must implement its own waiting mechanism. This change ensures that SharedRemote configures its underlying Remote to disable sync waiting by default, and it's selectively re-enabled only around any (potentially nested) sync calls made from the bound sequence. Fixed: 1102921 Change-Id: I603e48e38d859c43d7b732a91445314714ea0591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286051 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786180}
-
Rune Lillesveen authored
All tests fail because we don't implement Media Queries level 4. Bug: 962417 Change-Id: I37b1fe0de77af96573e4124e6cce2778e3dd39b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283220 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#786179}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Fix a few lint errors along the way. Bug: 1009837 Change-Id: I01943e6090fa4103f7464f5d01f4003af9f5948e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285918Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786178}
-
Alex Danilo authored
CL:2201336 swaps a native <select> control for a <div> that emulates select behavior and allows it to be styled with CSS. Add support for using the left and right arrow keys which behave the same as up and down in a real <select> control. Bug: 1097454, 1002410 Change-Id: I854b794e8bb34200a83cf3a3f11ff4ed007808bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282831 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#786177}
-
Bruce Dawson authored
JSONPerfTest.StressTest was crashing on x86 builds. Debugging showed that it was hitting an OOM failure and analysis showed that this was because some iterations of the test required more than 4 GB of memory. No memory leaks were seen. This lowers the maximum depth from 12 to 10 which drops the memory required from ~6 GB to ~250 MB, and the time from 58 seconds to 4. This should be enough to avoid Android timeouts so this change also re-enables the test for Android. Bug: 906686 Change-Id: I1114159da9ffb1a0694810d5686bba42ca671327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283966 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#786176}
-
Alan Cutter authored
This CL changes installReplacementWebApp() to no longer require the installed site to have a service worker or be display standalone. The previous restrictions were from a time when "web apps" and "PWAs" had a stronger distinction that needed to be upheld. Now they are blocking efforts to migrate hosted apps over to web apps. This CL plums the bypass_service_worker_check option through the web app install flow so the Extension API can bypass that check. All other callsites are left untouched. To reflect this change LoadWebAppAndCheckInstallability() has been renamed as LoadWebAppAndCheckManifest(). Bug: 1096868 Change-Id: Iff5d5584fa247d465aa367f6e426402969064747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275993Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786175}
-
Brandon Jones authored
This change shares a single XrInstance between the XRRuntimeProvider, OpenXrStatics, OpenXrDevice, OpenXrRenderLoop, and OpenXrApiWrapper. The instance is actually owned by the OpenXrStatics, which is in turn owned by the OpenXrDevice when one exists, and the XRRuntimeProvider otherwise. In terms of thead safety, the XrInstance will only be destroyed by the OpenXrDevice destructor, which also owns the OpenXrRenderLoop and explicitly shuts it down. Most methods which take an instance don't have any threading concerns, but even so once we have a render loop we don't make any calls against the instance from the OpenXrDevice thread until the render loop is shut down. Bug: 1100577 Change-Id: I2fc326e17c1faf3915e8eafddf23055ccd9a5639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278534 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786174}
-
Tsuyoshi Horo authored
Bug: 970083, 1103107 TBR=agrieve@chromium.org,aluo@chromium.org,tiborg@chromium.org Change-Id: Ic4abb6624fa8ea12d430ecadf9716c63d5ac6874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286073Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786173}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6152ea9adc21d92502d8fcb42e5343ce196288d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286152Reviewed-by:
-
Yuki Shiino authored
There is no need to have a dedicated map from WrapperTypeInfo* to v8::FunctionTemplate just only for V8 context snapshot. Removes the special casing only for V8 context snapshot. Bug: 839389 Change-Id: Idacbf5290498098b13f63d6ea0e7f4203664adc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284517Reviewed-by:
-
Bartek Nowierski authored
This is a continuation of crrev.com/c/2275886. If PA-Everywhere and tagging for CheckedPtr were to be enabled, this test would've failed. By switching to aligned root, we're making it pass in all situations. Bug: 1092288, 998048 Change-Id: Ib638818cc1e433c937c3c6fd375a492f5b3b22ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282837 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
Added tests for at start/end of paragraph before a list marker and rich comments to other paragraph tests A test is being added for testing whether a list marker (both Legacy Layout and NG Layout) is correctly recognized as a paragraph boundary. Also took the opportunity to add several comments to other paragraph tests that might have been unclear or complicated. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1090454 Change-Id: I69d49cb7acd6a4e55bad56914072c6e2b95dd2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283590Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786169}
-
Yoshifumi Inoue authored
This patch changes |LinkHighlightImpl::Paint()| to use |NGInlineCursor| only for LayoutNG tree to avoid hitting |DCHECK()| when runtime enabled feature LayoutNG disabled but LayoutNGFragmentItem enabled, e.g. linux_layout_tests_layout_ng_disabled bot. This is follow-up of the CL[1] which makes |LinkHighlightImpl::Paint()| to use |NGInlineCursor|. [1] http://crrev.com/c/2097777 [NGFragmentItem] Stop using rounded rect for link highlight when <a> has nested inline Bug: 707656 Change-Id: If1b4c052510a76f58bb8016cb9110479709bd82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286090 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786168}
-
Alex Danilo authored
CL:2201336 swaps out the native <select> control for a <div> that implements the same functionality so that it can be styled for files-ng. Add keyboard navigation when the control is collapsed to allow changing the filtered options without expanding the control. Fires a change event if the selection is changed with the control closed so that the filtered name gets updated correctly. Bug: 1097454, 1002410 Change-Id: Ic2e8c06ef309e4cd1090dc9a48622bf92c7e3666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282829 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Ken Rockot authored
This adds a new ConnectivityMonitor object to NetworkQualityEstimator. ConnectivityMonitor tracks all pending network requests throughout their lifetime while the host device is connected to a Wi-Fi network. If a long period of inactivity (configurable, default 2500 ms) is detected across all requests, ConnectivityMonitor takes note of this as a potential connectivity issue. If the new ReportPoorConnectivity feature is enabled, this issue is reported immediately to the OS (Android only, for now) as a network failure. ConnectivityMonitor also watches for network changes. If it suspects a connectivity issue and the network switches, we record a new NQE.ConnectivityMonitor.TimeToSwitchNetworks metric as the time delta between the original failure detection (regardless of whether it was reported to the OS) and the actual network change. This CL serves as the basis for an experiment to understand how OS connectivity reporting in Chrome may impact network failure recovery. Bug: 1079380 Change-Id: Ieecb2bf1be1cc9cb17496b5493204e4f0e3c0ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275340 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#786166}
-
Roman Sorokin authored
Fixed: 1075620, 1100368 Change-Id: I019110d70a613f50f7d8d16910b9c117bbcc6bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248187Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786165}
-
Luke Sorenson authored
Bug: 1099420 Test: Not necessary. Change-Id: I384df5ad2f2775484138fff11bc98b7a01b8bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268200Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#786164}
-
Curtis McMullan authored
The resizable vk metrics will expire in the next few months. This CL is simply extending their expiry date by one year. Bug: 1102475 Change-Id: Iea55442a5a6230e37e8ac4a964c4b9befa1aa630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282544Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I71bd5a231eaa46cbd30a67ac84a05f8dccb8f244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286463Reviewed-by:
-
Trent Apted authored
Currently, when opening files from the ChromeOS file manager, users see an error trying if the file is from an MTP device or an ARC++ "document provider" mount under the media virtual folder (e.g. "Pictures"). See https://crbug.com/895479 for details about document provider. An approach added in r778183 was to check for a "/provided" path prefix, but this only works for some non-native filesystem types on ChromeOS. Generalise it by asking storage::ExternalMountPoints to lookup the "virtual" path, which contains the path components necessary to extract the filesystem type. Use remains restricted to chrome:// WebUIs on ChromeOS. The code is still covered by tests added in r778183 (i.e. SystemWebAppManagerLaunchDirectoryFileSystemProviderBrowserTest.*). https://crbug.com/1102287 tracks making testing of android volumes possible outside of the files app. Bug: 1099474 Change-Id: I37a0239dec4d9b7c6bba866302db00b5d84941b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279413Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#786161}
-
Tsuyoshi Horo authored
This reverts commit 3557d7dd. Reason for revert: Caused failing on builder "linux-chromeos-chrome" Bug: 1103100 Original change's description: > Assistant: ensure single generic error message > > Assistant processing v2 introduced a situation that allowed > multiple error messages to flush to the screen due to > AssistantInteractionControllerImpl::OnTtsStarted being > called multiple times. > > Add AssistantResponse::ContainsUiElement to check if duplicate > error elements already exist before adding more. > > Bug: b/158499400 > Change-Id: Ia90199ef8b733132fd5433ca47bb7905926b2f6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258196 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#785935} TBR=xiaohuic@chromium.org,dmblack@google.com,updowndota@chromium.org,wutao@chromium.org,meilinw@chromium.org,jeroendh@chromium.org,cowmoo@chromium.org Change-Id: I596b799de09518816642de2c86398849939f5d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/158499400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286531Reviewed-by:
-
Liquan (Max) Gu authored
Before: PaymentRequestImpl implements PaymentRequest After: ComponentPaymentRequestImpl implements PaymentRequest, and delegate the implementation to PaymentRequestImpl. Bug: 1102522 Change-Id: I3e3ea0b6a0abb12f4efa983dc8ee697117f40095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285243 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#786159}
-
Hazem Ashmawy authored
WebViewCollectNonEmbeddedMetrics feature flag has been removed in crrev.com/c/2252082 and there is no need to test this config any more. Bug: 1001185, b/157911640 Test: N/A Change-Id: I1c94b1c24f8b8a488eef94f4ccd5697ca2043643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283210 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#786158}
-
Toby Huang authored
This CL adds browser tests to parent_permission_dialog_view_ browsertest.cc for the Parent Permission and the Extension Install Blocked By Parent dialogs launching from the extension Management API. This CL also adds unit tests to management_api_unittest.cc for the same two dialogs launching from a background page, where there's no active web contents. Bug: 1083275 Change-Id: I34db7aee30d5153b8dbc348572522e0f16555d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220816 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786157}
-
jchen10 authored
This takes into account the color spaces of pixel data from ImageBitmap being encoded into VideoFrame. Bug: 897297 Change-Id: I5ee5b77eb067ce8f5cec91dbd584a1553f6e91f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272134 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#786156}
-
Mansi Awasthi authored
Original CL: http://crrev.com/c/2275981 Revert: http://crrev.com/c/2284446 Reason for revert: Builder: Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/b8875468439609281712 The failures were caused as |push_button.is_read_only| was not initialized in TestButtonNodeCreation before usage. This CL fixes this issue. Original description: This CL creates button nodes using PdfAccessibilityButtonInfo sent from plugin process and inserts them in the PdfAccessibilityTree. This CL also includes test to validate the creation of button nodes in PdfAccessibilityTree. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng Bug: 1030242 Change-Id: Id821ea02f92c20b5f5eb3190e4d878c6bd52edea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284505Reviewed-by:
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786155} -
mhasank authored
Introducing cloud dpc error enum values to be used for showing helpful error messages on the UI BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: I8bb83f7366260f1a09223e2791e5cfab7e94ca68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268468 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I030e23a8532cc0ce73ca1f0b73893a0c717a2676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286469Reviewed-by:
-
Victor Costan authored
Change-Id: I94dbcfd3e5114b23433900397ec023c5d7513545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281551 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8c11a5b522cd68c7cce8ccbf30a146a9459cbbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286460Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e2efe33ef0e..90b0c9e859ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1075380,chromium:1090060,chromium:1090397,chromium:1093366,chromium:1094282,chromium:1102355,chromium:1102832 Tbr: horo@google.com Change-Id: I68f907df94425a06e5ae137922a747d99d6fe3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786150}
-
