- 17 Jul, 2017 40 commits
-
-
Dirk Pranke authored
Bug: Change-Id: I5c9448c739e21c05177b12d9d86a6b84561968df Reviewed-on: https://chromium-review.googlesource.com/572432Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487103}
-
Devlin Cronin authored
IPC messages related to extension bindings (such as API method calls or event listener changes) sent by the renderer differ depending on if it's a call for a main thread context or a service worker context. The call sites differ based the context type as well as whether or not native bindings are enabled. This makes these messages confusing, and causes duplicate logic. Introduce an IPCMessageSender class to handle sending the IPC messages to the browser. There are two flavors of IPCMessageSender - one for the main thread, and one for the worker thread. This message sender can be used from both the native bindings implementation as well as the js implementation, allowing us to abstract out more of the details. In this first patch, introduce the IPCMessageSender class (in its two flavors) and use it for API method request dispatching. This allows us to perform a couple of cleanups: - We get rid of the SendRequestIPC method we curried into the NativeExtensionBindingsSystem, and - We get rid of the ServiceWorkerRequestSender (instead of subclassing the RequestSender, we can pass in the IPCMessageSender, which can be either for the main thread or a worker thread). Bug: 653596 Change-Id: I406aba07945f6da4b7a8ab0b9d1788aa21385f96 Reviewed-on: https://chromium-review.googlesource.com/570947Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487102}
-
Mohamad Ahmadi authored
- Correctly validates and deduplicates the URL-based payment methods according to the specs: https://www.w3.org/TR/payment-method-id/#dfn-validate-a-url-based-payment-method-identifier - Also captures the canonical text of the URL instead. Bug: 602666 Change-Id: I3ba0a8684be1e2e4f769ca551f9cbbf82e3eed36 Reviewed-on: https://chromium-review.googlesource.com/572853 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487101}
-
Tao Bai authored
- Add flag to indicate whether secure context is required in autofill_agent. - Set flag for WebView autofill. BUG=741809 Change-Id: Ibd3e896cfc96f0498fb47a2fb59cc52be6a25feb Reviewed-on: https://chromium-review.googlesource.com/568406Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#487100}
-
Peter Kotwicz authored
BUG=None Change-Id: I640ee75a03a6b9bce6a5200b50b2d3baad47e482 Reviewed-on: https://chromium-review.googlesource.com/574568Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487099}
-
Tommi authored
BUG=689520 Change-Id: Ib34ee776f40c25b4d4306d54a7bd50756107e13c Reviewed-on: https://chromium-review.googlesource.com/570998 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487098}
-
Yash Malik authored
The transient security warnings would show when WebVR mode was set but before the first WebVR frame which meant that the warnings would show on top of the splash screen. Bug: 743196 Change-Id: I15d5e77b5f853e3d3654ff187c7dcb08327a5bbf Reviewed-on: https://chromium-review.googlesource.com/572283Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#487097}
-
Yash Malik authored
Bug: 740259 Change-Id: Ida1bcb3796359b09bed88143f339fae3c00edda1 Reviewed-on: https://chromium-review.googlesource.com/571946Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#487096}
-
Eric Seckler authored
Bug: 696439 Change-Id: Ib57bd3c95ce734d8a26c798f43fbfa94fcf3a67a Reviewed-on: https://chromium-review.googlesource.com/574531 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487095}
-
Ran Ji authored
Apk size reduces 2kb compare with previous. Bug: 736039 Change-Id: I4fe73fda4e9771cf34b830c3df16e3bca9a468c8 Reviewed-on: https://chromium-review.googlesource.com/570515Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcNetHostImpl. BUG=672829 TEST=Ran try. Change-Id: I4236b93a52b45b4e0ef34fe0fc72ceb124aac063 Reviewed-on: https://chromium-review.googlesource.com/572671Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487093}
-
Leonard Grey authored
Looks like dladdr is quite slow on macOS[1]. Previously, we were calling it on every frame when walking the stack, which led to sampling tasks taking longer than the sampling interval. Because of this, a full burst of samples took longer than the actual exercise of most browser tests, but continued activity on the sampling task runner kept the browser alive on each test. This change caches the address range of modules, and uses this to look up the module for a given IP, only falling back to dladdr on miss. On my machine, this is roughly a 50% improvement (sample individual test goes from 3.3s to 1.8s, whole suite is hard to judge because of how long it takes, but it's quite a bit faster.) Hopefully, this will allow us to turn browser tests back on. [1] Possible reason: https://bugzilla.mozilla.org/show_bug.cgi?id=996802 Bug: 531673 Change-Id: Iad069b0f715c5c7d3b630e9caabf3a8275ef5494 Reviewed-on: https://chromium-review.googlesource.com/571277 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487092}
-
Daniel Bratell authored
Both DocumentTest and HTMLFormControlTest uses a local MockValidationTestClient class for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then they will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: If1f2d22fca4c5f7b3ad662f6ae746cef4baf48c3 Reviewed-on: https://chromium-review.googlesource.com/574174 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#487091}
-
Daniel Bratell authored
LocalFrameViewTest, HTMLVideoElementPersistentTest and PaintLayerScrollableTests all use a local MockChromeClient class for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: Ibd6c9d17e1e8dfbe42cbb254344e52a81ce48788 Reviewed-on: https://chromium-review.googlesource.com/574176 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
chaopeng authored
This issue is caused by couple reasons: 1. aura overlay scrollbars are visible (opacity=1) at initial state. 2. page is a not scrollable, then become scrollable. 3. SetScrollable and ScrollbarAnimationController creation may come from separate commit and no promising order. We use needs_show_scrollbars in layerImpl to indicate the layer need to call SAC::DidRequestShowFromMainThread. If the SetScrollable call happens before SAC and from separate commit then: - first commit: 1. In TreeSynchronizer::PushLayerProperties, pending tree push to active tree SetScrollable, set needs_show_scrollbars because bounds change or scrollable flag change. then reset needs_show_scrollbars in the layer of pending tree. [1] 2. In HandleScrollbarShowRequestsFromMain, skip because SAC not found. - second commit: 1. In TS::PushLayerProperties, pending tree set the needs_show_scrollbars(false) to active tree, then call SetScrollable and quick return because no bounds change or scrollable flag change. 2. In HandleScrollbarShowRequestsFromMain, skip because needs_show_scrollbars is false. In this patch, we only push needs_show_scrollbars to active tree when needs_show_scrollbars is true. So we do not use the reseted value to override the value we keep for next pick up. [1] https://chromium.googlesource.com/chromium/src/+/a7c2ee628552ec6a9d624dcd1b78442991615715/cc/layers/layer_impl.cc#329 Bug: 740795 Change-Id: I15089ba357a67b3336bb251ce19cb2f7bf5953ba Reviewed-on: https://chromium-review.googlesource.com/568815Reviewed-by:
Weiliang Chen <weiliangc@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#487089}
-
Peter Kotwicz authored
This CL: - Removes the Tab#getUrl() empty check. The check originates from a bad refactor in https://chrome-internal-review.googlesource.com/c/45524 (It was originally introduced in https://chrome-internal-review.googlesource.com/c/44162/) - Removes the WebappInfo#isInitialized() check. WebappActivity#initializeUI() is never called when WebappInfo#isInitialized() is false. BUG=None Change-Id: I68bfae6c25d3f5103863c3138cbd9088570c0c60 Reviewed-on: https://chromium-review.googlesource.com/572386Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcDownloadsWatcherService. BUG=672829 TEST=Ran try. Change-Id: I1004dfa57616778463f36e86c3cc46295d8c9627 Reviewed-on: https://chromium-review.googlesource.com/571567Reviewed-by:
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true Change-Id: Iacf34f92e55a58c518f48bc2451cb7034d370c16 Reviewed-on: https://chromium-review.googlesource.com/574630Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487086}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ceb5bb0..c6e2620a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I180c4329127f835e6e95d5d1fa8e48bd45f8afa8 Reviewed-on: https://chromium-review.googlesource.com/574567Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487085}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/3a4ebcc7c490..f768baf129fc $ git log 3a4ebcc7c..f768baf12 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Let CPDF_MeshStream::ReadVertexRow return a vector Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ibfec7eb954dbb3874c58fdee951e4dc54432dd65 Reviewed-on: https://chromium-review.googlesource.com/574459 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487084}
-
Yipeng Wang authored
Bug: 674250 Change-Id: I2c8c38e680da2357abe39146571937fc369c4778 Reviewed-on: https://chromium-review.googlesource.com/558206 Commit-Queue: Yipeng Wang <yipengw@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487083}
-
David Bokan authored
This reverts commit 8448024f. Reason for revert: This likely introduced a container-overflow: crbug.com/742520 Original change's description: > Unregister cc scrollbar when registering new one > > We previously DCHECKed that we could never register a new scrollbar > against a scroll layer that already has a scrollbar. i.e. We expected > that the old scrollbar would be unregistered prior to registering the > new one. > > RootScroller can break this assumption on Android. On Android, the > global rootScroller (i.e. OuterViewport) is prevented from creating > its own scrollbars, instead inheriting the VisualViewport-created > scrollbars. In other words, the VisualViewport creates a pair of > scrollbars and they get re-assigned to whatever the current outer > viewport is. > > This means that when we change the global rootScroller (for context see > core/page/scrolling/README.md), the previous rootScroller now creates > its own scrollbars and the VisualViewport scrollbars get registered to > the new rootScroller. This then creates a race between moving the > VisualViewport scrollbar registration and new scrollbar registration on > the old rootScroller. > > Long-term, the outer viewport shouldn't own the scrollbars but for now > it doesn't hurt to just unregister the scrollbar if we notice the > scroller already has scrollbars registered. > > Bug: 739738 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I99e8a95881e7dad19c0318a661da80f441b97b19 > Reviewed-on: https://chromium-review.googlesource.com/562018 > Reviewed-by: Weiliang Chen <weiliangc@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486086} TBR=bokan@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739738, 742520, 742678 Change-Id: I1134e17dcb04a3a2cc50f07ecbc0fc79cc74f344 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/574547 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Mikhail Pozdnyakov authored
This patch introduces the Sensor.ConfigureReadingChangeNotifications() method to substitute SensorConfiguration.suppress_on_change_events. Rationals 1. This functionality is not a part of sensor configuration (like sampling rate or accuracy) so better to be decoupled from SensorConfiguration. 2. Code simplification: no need to increment/decrement suppress_on_change_events_count_ at every start()/stop() call. Bug: Change-Id: I55ee9250d6810f36fb6586be1b10923e36b71075 Reviewed-on: https://chromium-review.googlesource.com/536937Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#487081}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/d4b678751117..e3e9628ecf86 $ git log d4b678751..e3e9628ec --date=short --no-merges --format='%ad %ae %s' 2017-07-16 bsalomon Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I373bbd72f3353b03a14c481467a041a8f48dfb3d Reviewed-on: https://chromium-review.googlesource.com/574458Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487080}
-
Ned Nguyen authored
This CL also update tools/perf/page_sets/data/.gitignore to make sure the file would not be checked in by mistake again. Bug: 744545 Change-Id: I63ca35ea2f3ba4e5c8a51f0f58a66eecad0710a4 Reviewed-on: https://chromium-review.googlesource.com/574455Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#487079}
-
Han Leon authored
Using wpt-import in Chromium d3ae6e94. TBR=qyearsley@chromium.org No-Export: true Change-Id: I51eb23df0d6b06bfc0facb34e1f3605089d79c35 Reviewed-on: https://chromium-review.googlesource.com/574249Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#487078}
-
Anthony Vallee-Dubois authored
Bug: 742329 Change-Id: I73b2043c63f814d0394ed745eb6b1e55814db339 Reviewed-on: https://chromium-review.googlesource.com/570982 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#487077}
-
Daniel Bratell authored
"using namespace" in global scope introduces a lot of symbols into the current scope and does not work well with jumbo. In case of WTF you can also equally well just write a WTF:: prefix. Bug: Change-Id: Id615f60151e0bc46cfe2a5e9a6a9313c412f1344 Reviewed-on: https://chromium-review.googlesource.com/570446 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487076}
-
Mythri Alle authored
We plan to merge v8.browse and v8.runtimestats benchmarks into a single benchmark. So, enable the memory metric on the v8.runtimestats benchmark. Though the expectedQueueingTimeMetric is alredy enabled on v8.runtimestats* it requires v8.compile trace events to work correctly. Also enable v8.compile category for the expectedQueueingTimeMetric. The only other metric tracked by v8.browsing and not by v8.runtimestats.browsing is the v8 executionMetric. This is not required since the runtimeStatsMetric is a super set of the executionMetric. Bug: chromium:690921 Change-Id: I574c8c27515d3a62dc6d94c759be0eed32543f20 Reviewed-on: https://chromium-review.googlesource.com/574171Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#487075}
-
Yipeng Wang authored
This CL deletes all JNI registration calls under chrome/browser/ui since the JNI registration is automatic now. Change-Id: Id3a0bf6fe0d3bdc413e878324b732979ce0536fc Reviewed-on: https://chromium-review.googlesource.com/572189Reviewed-by:
-
Duc Bui authored
The header file was added when adding signals that mark the start/end of session restore (https://codereview.chromium.org/2935183002). Bug: 661774 Change-Id: I4cfa262281ceb880e76cf99a84b319119e7261e1 Reviewed-on: https://chromium-review.googlesource.com/573488 Commit-Queue: Duc Bui <ducbui@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487073}
-
Daniel Bratell authored
ng_block_layout_algorithm_test and ng_constraint_space both use a local function ConstructConstraintSpace for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the functions will collide. This patch gives the functions unique names. R=fs@opera.com Change-Id: I3941094aad201b7ec6796d63664da8cfba8056c3 Reviewed-on: https://chromium-review.googlesource.com/574237Reviewed-by:
-
Daniel Bratell authored
There are several classes in frame which have use of for instance EXPECT_POINT_EQ and EXPECT_SIZE_EQ. The problem (beyond duplicating code) is that in jumbo builds those defines collide. This patch moves the shared macros to core/frame/FrameTestHelpers.h. There are also equally named macros in cc/test/geometry_test_utils.h but those work on gfx::Rect/gfx::RectF which is not quite API compatible (different character case). R=fs@opera.com Change-Id: I60cb7eff533e4dccc796937a027ec090071cd5c2 Reviewed-on: https://chromium-review.googlesource.com/574179 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Daniel Bratell authored
There is a gtest namespace ::testing and a helper namespace in blink called ::blink::testing. If both are visible to the compiler, ::blink::testing will be used first and classes in ::testing will not be found. This happens in jumbo builds so we better be more specific. R=fs@opera.com Change-Id: I4da27383432226191b0fcb72f3c54784698f0262 Reviewed-on: https://chromium-review.googlesource.com/574488Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/42102420c02a..d4b678751117 $ git log 42102420c..d4b678751 --date=short --no-merges --format='%ad %ae %s' 2017-07-13 ccameron Make SkImage_Lazy cache its result from onMakeColorSpace Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4829ae1403c2cb91fb0f738ee66fdf117fe1ff9d Reviewed-on: https://chromium-review.googlesource.com/574208Reviewed-by:
-
Daniel Bratell authored
Normal jumbo_target has the wrong default configs for components so this adds a new jumbo_component that has the right default configs. Bug: 713137 Change-Id: I32fd2d015162d85b7ff07d5515489b9e33cfb987 Reviewed-on: https://chromium-review.googlesource.com/571790Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487068}
-
Daniel Bratell authored
Both InterpolableValueTest and InterpolationEffectTest use an identical class for value testing. These classes collided in jumbo builds where they were compiled in the same translation unit. This patch moves the class to AnimationTestHelper.h and changes its name to be more descriptive now when it isn't as close to where it is used anymore. Also changing the name of the kDuration constant that interfered with blink::kDuration. R=fs@opera.com Change-Id: Ic90cec2972f5464d7932b2ba91994273968e87c4 Reviewed-on: https://chromium-review.googlesource.com/574489Reviewed-by:
-
Daniel Bratell authored
IdleDeadlineTest and ScriptedIdleTaskControllerTest both use similarly names mock classes, MockScheduler, MockThread and MockPlatform which collide in jumbo builds where they are merged into the same translation unit. This patch gives the classes unique names. R=fs@opera.com Change-Id: I305cb3fbdfbd3b3b6fc7c18e8c3ceccf89da863e Reviewed-on: https://chromium-review.googlesource.com/574487Reviewed-by:
-
Daniel Bratell authored
PageOverlayTest and PrintContextTest both use a local mock test class named MockCanvas for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique names. R=fs@opera.com Change-Id: Icfcb2b4b553e50e08cb6ac56712e4e9aa5f2b69e Reviewed-on: https://chromium-review.googlesource.com/574349Reviewed-by:
-
Daniel Bratell authored
There is blink enum class LineBreakType used to correctly layout text. That makes it unsuitable to use the same name in a unit_test since they may collide, and actually will collide in jumbo builds. This patch changes LineBreakType to NewlineType R=fs@opera.com Change-Id: I3c5ae6ea5b6e199990c8b51c3a55eb1d17a8f19e Reviewed-on: https://chromium-review.googlesource.com/574238Reviewed-by:
-
