- 01 Mar, 2019 40 commits
-
-
Robbie Gibson authored
This value is needed in extensions, so we can use NSUserDefaults to store it. Bug: 913958 Change-Id: I4cacfb56c62e84e97a6529797bb97473715b5eb0 Reviewed-on: https://chromium-review.googlesource.com/c/1488911Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#636918}
-
Wenzhao Zang authored
Follow-up work for https://chromium-review.googlesource.com/c/chromium/src/+/1493084 Also remove some outdated comments. Bug: None Change-Id: I5c01528a334d2924b80f9fa4954777795d847fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1496517Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#636917}
-
James Cook authored
I'm going to fork them to create a material design version of this dialog and I don't want to pollute the main c/b/resources/chromeos directory. Bug: 927732 Test: browser_tests SetTimeWebUITest.testChangeTimezone Change-Id: I5463a76d3da6d7784635ec9126c4ac64186f219d Reviewed-on: https://chromium-review.googlesource.com/c/1496491 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#636916}
-
Lei Zhang authored
Change-Id: I149eac32914985224986fe569959054934980b8e Reviewed-on: https://chromium-review.googlesource.com/c/1497193Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636915}
-
Christopher Cameron authored
This issue is best docuemnted in https://crrev.com/31183. The best repro is to - Nativate to https://crbug.com/25462 - Download test.html - Open test.html from the downloads bar - Tab-drag test.html out, and hold the drag for at least 5 seconds The implmenetation of this functionality effectively uses WebContentsViewCocoa (via cancelPreviousPerformRequestsWithTarget and performSelector) as a weak pointer for WebContentsViewMac. This is not the right tool for the job, and is guaranteed to not work when WebContentsViewCocoa is in another process. Change this to use a weak pointer for weak pointer functionality. Merge WebContentsView::IsEventTracking and CloseTabAfterEventTracking into a single function. Bug: Cleaning up WebContentsView Change-Id: I215744f048d5c49be00ae94ecdbfdbbdbd62415a Reviewed-on: https://chromium-review.googlesource.com/c/1492754Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636914}
-
Elly Fong-Jones authored
This flag isn't needed any more, but the feature still is, per email discussion with mpearson and jdonnelly. Bug: None Change-Id: I59cf49bef661245da9c40115b626875e351bd4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1496559 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#636913}
-
Nicolas authored
When the Network Service is enabled, LBS failed to download sitelists for file:// URLs. This CL fixes the issue. Bug: 936160 Change-Id: Iae19b7d9798236f35f7a8c525569b4cb241296c5 Reviewed-on: https://chromium-review.googlesource.com/c/1495575 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636912}
-
Lei Zhang authored
Update callers that relied on the default argument. Modernize code along the way. Change-Id: I5486202a2b740e9451cf737b54549168419f4493 Reviewed-on: https://chromium-review.googlesource.com/c/1495813 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#636911}
-
Gabriel Charette authored
This is a simple one and gets rid of a redundant call to TimeTicks::Now() thanks to the new API :) Bug: 885371 Change-Id: I3dccde418849992ad0bce18297c79eea6f98f072 Reviewed-on: https://chromium-review.googlesource.com/c/1485125 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#636910}
-
Yi Gu authored
See linked bug for details. TBR=lushnikov@chromium.org NOTRY=true Bug: 937416 Change-Id: If8c917fa804d9def71a5bf5ec24da85ae02fd840 Reviewed-on: https://chromium-review.googlesource.com/c/1497127Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636909}
-
kylechar authored
Move all checks for if a OverlaySurfaceCandidate is potentially valid into CanHandleCandidate(). Also simplify CheckOverlaySupport() a bit. Add a test that exercises DrmOverlayManger caching to ensure that request for overlay validation gets sent at the right time. Bug: 930173 Change-Id: I1d0705b76c1b2ba806a207b9e2ba55d161ae60d6 Reviewed-on: https://chromium-review.googlesource.com/c/1495740Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#636908}
-
Bryan McQuade authored
This change removes the previous_committed_source_id_ member. This member was used to retain the source id of the last committed navigation as a new navigation was completing. This member is only used in one place, and it's possible to remove it by deferring updating of the last_committed_source_id_ until after that code completes. Change-Id: I18811c048ce07590c5dd2fa4bb273b7ad5a53628 Reviewed-on: https://chromium-review.googlesource.com/c/1491892 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#636907}
-
Nicolás Peña Moreno authored
This CL adds a UMA metric for the type of content that was used for the largest content paint. Change-Id: I3ee520fa2e45f00a68ad405320010de0247b41bc Reviewed-on: https://chromium-review.googlesource.com/c/1489413 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#636906}
-
Daniel Rubery authored
To ensure the data is populated for SBER users, but not regular users, add a unit test. Bug: 922226 Change-Id: Ia8af7e347bcfe546d8f3af5d5c53aa8067d4a3ee Reviewed-on: https://chromium-review.googlesource.com/c/1495367 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636905}
-
ssid authored
This reverts commit 9866f6ae. Reason for revert: ApkMerger script is fixed in cl: https://chromium-review.googlesource.com/c/chromium/src/+/1496316 Original change's description: > Revert "Make sure unwind tables are added for 32 bit libraries in arm64 monochrome" > > This reverts commit 200a953f. > > Reason for revert: Breaking official build due to APK merge. > > Original change's description: > > Make sure unwind tables are added for 32 bit libraries in arm64 monochrome > > > > The assets were not added since we checked "can_unwind_with_cfi_table" > > value, which depends on "build_secondary_abi" build arg. So, explicitly > > add the asset for 64-bit monochrome apk, which contains 32 bit library. > > > > BUG=924842 > > > > Change-Id: I6488d5c4e5a80787735c5b09134b013a87b5c553 > > Reviewed-on: https://chromium-review.googlesource.com/c/1432836 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625789} > > TBR=ssid@chromium.org,agrieve@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 924842 > Change-Id: Ic8e542cc1cf52f24b7866c1620ac764bf2f92672 > Reviewed-on: https://chromium-review.googlesource.com/c/1439074 > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626505} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 924842 Change-Id: I36b5cd2ab479f3038e3c31a69fe70aacef4db618 Reviewed-on: https://chromium-review.googlesource.com/c/1496275 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#636904}
-
Lily Chen authored
Relanding since use-after-free bug is fixed in https://crrev.com/c/1489098 Original CL description: > A network error should be reported if the resource fetch is aborted > before it is complete: > https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors > > This CL adds NEL error generation (with report type ERR_ABORTED) for > any HttpNetworkTransactions destructed without previously generating a > success or error report. This guarantees that every > HttpNetworkTransaction results in a NEL report. Successes are reported > after receiving valid headers (if the response code is 4xx or 5xx, or > if the body will not be read, or on a redirect), or after completely > reading the body. Any other outcome is reported as an error. > > Bug: 934000 > Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7 > Reviewed-on: https://chromium-review.googlesource.com/c/1480195 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634834} Bug: 934000, 935209 Change-Id: I9a73a7a9ed24e5b536b7ff7bb80a79523bf58f4a Reviewed-on: https://chromium-review.googlesource.com/c/1491905Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#636903}
-
Liquan(Max) Gu authored
Currently, FCP++ is only collecting results from the main frame. This CL will enable it to collect results from subframes, including OOPIFs in particular. This CL also simplify the size calculation. Originally, we intersect the mapped visual rect with the viewport rect. This step is actually unnecessary, because LocalToAncestorVisualRect() has already included the viewport clipping. For OOPIF, this CL adds an extra step upon the normal work flow. Visual rects of OOPIF live in the main frame space, but they are not clipped by the main frame viewport. So we add MapToVisualRectInTopFrameSpace, which do the viewport clipping. Bug: 934318 Change-Id: I5f91815cafdadd68a01bc1cdd5d8cf009a6e4fbe Reviewed-on: https://chromium-review.googlesource.com/c/1481574 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636902}
-
Xida Chen authored
In the case when a GestureScrollBegin comes without a GestureTapDown, and that when the both |allowed_touch_action_| and |active_touch_action_| have no value, it could crash at line 139 which tries to access the value of |active_touch_action_|. This CL fixes that and adds unit testing. Bug: 904648 Change-Id: Id4bc2a79f8716ed43981a77278d82d3539fc9a5e Reviewed-on: https://chromium-review.googlesource.com/c/1495354Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636901}
-
Lei Zhang authored
- Better explain ownership semantics. - DCHECK the code runs on the UI thread. - Use base::TimeDelta in more places. - Pass non-POD objects by const-reference. - Add an OWNERS file. - Fix nits. Change-Id: Iaa41d368882c08a56977ee418416c31e2bdc46dc Reviewed-on: https://chromium-review.googlesource.com/c/1496538Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636900}
-
Kevin Ellis authored
Bug: 647554 Change-Id: Iea93d45c4ba4a5473718eedaf8bb59fd9047f864 Reviewed-on: https://chromium-review.googlesource.com/c/1491695 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636899}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4eb13c7..b520e5d8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I73d0153ed2c0b2a2e01c6368059a527bf5a495da Reviewed-on: https://chromium-review.googlesource.com/c/1496479Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636898}
-
Yi Gu authored
TBR=jsbell@chromium.org NOTRY=true Bug: 864994 Change-Id: I4db690a3651a870019d4224cd80d19a23f2909b5 Reviewed-on: https://chromium-review.googlesource.com/c/1497075Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636897}
-
Yi Gu authored
TBR=rdevlin.cronin@chromium.org Bug: 937355 Change-Id: Iff1fba0c257a3bd517fc1e5d66109e3a48418dc7 Reviewed-on: https://chromium-review.googlesource.com/c/1497120Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636896}
-
Nektarios Paisios authored
This adds browser tests in the renderer that exercise the image annotation logic. They make use of a mock image annotation service and try to load a handful of pages with images, some of which dynamically modify their visibility. Bug: 934145 R=katie@chromium.org, dmazzoni@chromium.org Change-Id: I78dbccf08cf5260775b04b8cc06499ed3c349f1c Reviewed-on: https://chromium-review.googlesource.com/c/1480823Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636895}
-
Marijn Kruisselbrink authored
Also clean up ArrayBufferBuilder API by removing functionality that was only used by FileReaderLoader: - Calling ToArrayBuffer more than once. Now this method is renamed and passes ownership of the internal buffer isntead. - Building fixed size array buffers. - Converting the array buffer to a string. Bug: 936889 Change-Id: Ib0fd1014ad012d6b615fc9f4dc5c7ba1a58839b0 Reviewed-on: https://chromium-review.googlesource.com/c/1495036Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636894}
-
Yi Gu authored
Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fservice-workers%2Fservice-workers-force-update-on-page-load.js TBR=hhli@chromium.org NOTRY=true Bug: 937378 Change-Id: I0ec581ee4cad72171592394f1f72052758b9b4bd Reviewed-on: https://chromium-review.googlesource.com/c/1497174Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636893}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8962ac298f14..d7ccfee2ef7c Created with: gclient setdep -r src-internal@d7ccfee2ef7c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9af5545defea1fb83d5594ac73267a8936397fba Reviewed-on: https://chromium-review.googlesource.com/c/1496102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636892}
-
Shakti Sahu authored
Enabling download infobar by default on TOT. The feature will be 100% rolled out via finch in M73. Also assigned owners to the feature flag. Change-Id: I8b18ccae55678223045bd862f1d9cd98b8d211f6 Reviewed-on: https://chromium-review.googlesource.com/c/1495046Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636891}
-
Peter Kasting authored
Bug: 842296 Change-Id: Ic6bdb850fca1914ec5163f10fcc063d382b331e8 Reviewed-on: https://chromium-review.googlesource.com/c/1495797 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#636890}
-
Tony de Luna authored
This cl adds an observer that listens for guest mode policy changes and show/hides the Guest Mode button. This only affects the OOBE flow. Non-OOBE Lock screen already hides Guest Mode button if policy is updated. Bug:936600 Change-Id: I12f541d22b6877328c2d6351774e620e3c18e166 Reviewed-on: https://chromium-review.googlesource.com/c/1492953 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#636889}
-
Alex Leung authored
On Android, the renderer delay is incorrect after pausing. During multizone, the leader will send a resume command with an incorrect time adjustment, which causes the follower to incorrectly throw away existing audio data. There will be no playback on the follower until new data is sent. To fix this: 1. Invalidate renderer delay when resuming from pause. Prevents the resume command from being sent until we have a real timestamp. 2. Update the renderer delay from JNI when calling FeedDataContinue. Bug: internal b/126619604 Test: Tested on real device with soba. Change-Id: I27ccdac4f54a82e1cbfa295590a88b14e22fb7fc Reviewed-on: https://chromium-review.googlesource.com/c/1496313Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#636888}
-
Matt Menke authored
This CL renames "pending" requests in ClientSocketPoolBase::Request to "unbound" requests, after the introduction of the notion of "bound" in https://chromium-review.googlesource.com/c/chromium/src/+/1481900 This is a separate CL to keep the CL it's on top of more focused. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: I9ed0e4e4cd5e87be2d2b032fdd98313f420a621b Reviewed-on: https://chromium-review.googlesource.com/c/1487791 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#636887}
-
Robert Ogden authored
Adds a generic constructor to widget.TextBubble to accept a String so that formattable string resources can be used in TextBubbles. This CL is 2 of 4 to move the DataSaver "Chrome saved you XX data" from a snackbar to an IPH. Bug: 878337 Change-Id: I35b04641bcd680fa4eaa527f265b4c7f33f6ddd1 Reviewed-on: https://chromium-review.googlesource.com/c/1492472 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#636886}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/2d403737b88f..503cb8e63a06 $ git log 2d403737b..503cb8e63 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 marpan vp9-rtc: Set init noise level based on resoln 2019-02-28 marpan vp9-rtc: Reduce thresholds for skip golden 2019-02-26 jianj Set segment ID from ROI map if enabled. 2019-02-27 marpan vp9-rtc: Change init level of denoiser & noise level 2019-02-27 marpan vp9: Remove unused function in cyclic refresh 2019-02-27 marpan vp9-rtc: Add cyclic_refresh condition to segment reset 2019-02-27 marpan vp9-rtc: Modify skip golden mode check for 1 layer 2019-01-31 paulwilkins Change to direction of scan for GF only group boost. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I556f92b49302693bd32de47234c81bbe63fd6a97 Reviewed-on: https://chromium-review.googlesource.com/c/1496487 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#636885}
-
Sebastien Marchand authored
WMIRefresher is created during the creation of SystemMonitor on the UI thread, it is then used only in a MayBlock sequence. Change-Id: I7a14f59272a7ac6170c25e15518f31bfbc9f4870 Reviewed-on: https://chromium-review.googlesource.com/c/1493157 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#636884}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a1924739029e..dd1e37e31d68 git log a1924739029e..dd1e37e31d68 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 bclayton@google.com SpirvShader: Begin unary and binary ops. Created with: gclient setdep -r src/third_party/swiftshader@dd1e37e31d68 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126870789,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I04991288a1fb4051323daa38cd6b1e0e38f69a0a Reviewed-on: https://chromium-review.googlesource.com/c/1496896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636883}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/d50a88f50782..7a61cf37d6a0 $ git log d50a88f50..7a61cf37d --date=short --no-merges --format='%ad %ae %s' 2019-02-23 vadimsh Update httplib2 0.9.2 -> 0.12.1. Created with: roll-dep src/tools/swarming_client Fix client side SSL issues some people have been observing. R=sergiyb@chromium.org Change-Id: I72e40ec935d68f5a443d5a970457a598251b30cb Reviewed-on: https://chromium-review.googlesource.com/c/1496080Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636882}
-
Lei Zhang authored
- Make RenderProcessBlockedStateChanged() private. - Modernize new and NULL usage. Change-Id: I91fd842c3fbfc7eff1a89142d09cfe3e55430993 Reviewed-on: https://chromium-review.googlesource.com/c/1496242Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#636881}
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: Ibb9ec7c516dc70618481d89f4da6d224b9c3212c Reviewed-on: https://chromium-review.googlesource.com/c/1477852 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#636880}
-
Antonio Gomes authored
|StyleSheetContents::import_rules_| is of type HeapVector<Member<StyleRuleImport>>. Its members will always resolve |import_rules_[index]->IsFontFaceRule()| to false (once StyleRuleBase::IsImportRule() is the one that resolves to true. This CL removes the if-block that checks that altogether, allowing the removal of the remaining DEFINE_STYLE_RULE_TYPE_CASTS occurrence. Note: This was caught because trying to use To<StyleRuleFaceRule> failed to compile. ../../third_party/blink/renderer/platform/wtf/casting.h:102:10: error: non-const lvalue reference to type 'blink::StyleRuleFontFace' cannot bind to a value of unrelated type 'blink::StyleRuleImport' return static_cast<Derived&>(from); ^ ~~~~ R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I6bbf992b3654601a50fc68b18961de79899d5284 Reviewed-on: https://chromium-review.googlesource.com/c/1496056Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636879}
-