- 16 Oct, 2019 40 commits
-
-
Primiano Tucci authored
ui_devtools/connector_delegate.h #include-s perfetto_service.mojom.h. This means that whoever includes connector_delegate.h needs to be able to include perfetto_service.mojom.h. In turn this means that the dependency on tracing needs to be in public_deps not just in deps. Concretely this is preventing to switch some of the objects that the mojo typemap refers to into compile-time generated files (the CL that is doing so is [1]), because the targets that depend on ui_devtools don't see the transitive dep required by the header. This fixes it (tested by manually rolling [1] into chrome). [1] https://android-review.googlesource.com/c/platform/external/perfetto/+/1106801 Bug: 1006776 Bug: b/132880619 Change-Id: Ic5d3cccd9bce3b77ebea69259cbe7e415d963b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863791 Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706369}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0c1cb510. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I862085f6c15608c0cb5bd5e2451d1e3807496d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863444Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706368}
-
Tsuyoshi Horo authored
When I implemented SignedExchangeDevToolsProxy (crrev.com/c/1025492), we need to use callback to get the frame_tree_node_id. It was because when Network Service is not enabled the ID is not available while handling prefetch requests on the IO thread. But now, we don't need to support non-NetworkService mode (crbug.com/934009). So we can stop using callback. Bug: 934009 Change-Id: Idf5bfa1b59ce3499b8e9f27659a044ec52765dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863064 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#706367}
-
Alice Wang authored
Move DisableNativeTestRule from the package org.chromium.chrome.test.ui to org.chromium.chrome.test and simplify the SigninManagerTest. Bug: 1007903 Change-Id: I0829f0d7e11fd32b36d40e439ca9dd1a235e7676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857326 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#706366}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/480cfc4a..74f3784d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieda2cf7597f6ecc20288e9f63a9d9efd33c00f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864869Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706365}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b9ebe58e380..14dd70757eb0 git log 0b9ebe58e380..14dd70757eb0 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 036463457e5f..9097eeb5359b (8 commits) Created with: gclient setdep -r src/third_party/angle@14dd70757eb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None Change-Id: I474f79f1a8df218821592b10983da66f9b2e972c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706364}
-
Sigurd Schneider authored
We report the <script>function foo() {}</script> as completely uncovered, and this caused the CoverageModel to determine that the coverage report from the back-end did not change anything (used bytes did not increase). However, the coverage report from the back-end might have added the script to the CoverageModel's entries in the first place. In such cases, the coverage list view was not properly updated. This CL adds an update notification whenever a CoverageURLInfo is first created as well (independent of whether used bytes are zero). Bug: chromium:1004203 Change-Id: I458e14725a10a25087e443b2c509dc444d4bf997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864675 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706363}
-
Miyoung Shin authored
This CL converts TLSClientSocket{Ptr, Request} in chrome, components, content, extensions, jingle and services to the new Mojo type, and uses pending_receiver<TLSClientSocket> in proxy_resolving_socket.mojom and tcp_socket.mojom. Bug: 955171 Change-Id: I452a077d853eabe4d5e6a7af52fc5b1df72c1676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852350 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#706362}
-
Mikel Astiz authored
Committing Nigori may run into server-side errors, and bundling other datatypes in the same commit can cause other clients to never be able to decrypt the data. Similarly, committing Nigori has privacy implications, so to be on the safe side, it's preferable to complete a Nigori-committing cycle first, before proceeding with other commits. This is specially relevant in the experimental USS codepath. Integration tests are improved in this patch to be more strict, but actually they also pass prior to the CommitProcessor changes in this patch. Bug: 922900 Change-Id: Idad1d8cd0fa9eaa77534e99488a95d1359de807b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862922 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706361}
-
Caleb Rouleau authored
This is a reland of 37d44dbb Original change's description: > [Benchmarks] Smoke tests lay groundwork for move to story_filter. > > This change > https://chromium-review.googlesource.com/c/catapult/+/1839176 > makes it so that expectations config is passed to story_filter.py > using the project config (sometimes referred to as the > "environment"). This change lays the groundwork for that future > change. Until that change is committed, this is a no-op change. > > This change first requires this catapult-side change > https://chromium-review.googlesource.com/c/catapult/+/1854882 > to make sure that we don't pass an invalid argument to > GetRunOptions(). > > > Bug: 985103 > Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706080} TBR=crouleau@chromium.org Bug: 985103 Change-Id: I4add85016cbe95c31632e54b51d3b9c4deb2cbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864672Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706360}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome::mojom::AppShim, AppShimHost and AppShimHostBootstrap interfaces. Bug: 955171 Change-Id: I2005c0c18d37badeb0522d2a1ab2904f1856836e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831757Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#706359}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9fad2fbcc49..44806300adbd git log b9fad2fbcc49..44806300adbd --date=short --no-merges --format='%ad %ae %s' 2019-10-16 perezju@chromium.org Revert "[Telemetry] Refactor expectations code into story_filter.py." 2019-10-16 jbudorick@chromium.org devil: add support for adb push --sync behind a flag. 2019-10-16 dberris@chromium.org Fix actual stats computation 2019-10-15 crouleau@chromium.org [Telemetry] Refactor expectations code into story_filter.py. Created with: gclient setdep -r src/third_party/catapult@44806300adbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:985103,chromium:922145,chromium:1011273,chromium:985103 Change-Id: I0d53453d840695b47372789c08fa9a6e2772af57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864575Reviewed-by:
-
Benoît Lizé authored
This adds very simple multi-threaded PartitionAlloc tests, by having a separate thread repeatedly allocate and free from the same allocator as the main test one. This is not intended to be a rigorous and extensive performance test, but to validate and evaluate options to make multi-threaded scenarios better in PartitionAlloc. In particular, the output is very noisy, as it heavily depends on scheduling decisions (as the spinlocks we use are not even remotely fair/priority aware). Example output on Linux, Xeon "Haswell" 2.6GHz: [ RUN ] MemoryAllocationPerfTest.SingleBucket *RESULT MemoryAllocationPerfTest single bucket allocation (40 bytes): = 28790830 runs/s *RESULT MemoryAllocationPerfTest single bucket allocation (40 bytes): = 34 ns/run [ OK ] MemoryAllocationPerfTest.SingleBucket (2883 ms) [ RUN ] MemoryAllocationPerfTest.SingleBucketWithCompetingThread *RESULT MemoryAllocationPerfTest single bucket allocation (40 bytes): = 97388 runs/s *RESULT MemoryAllocationPerfTest single bucket allocation (40 bytes): = 10268 ns/run [ OK ] MemoryAllocationPerfTest.SingleBucketWithCompetingThread (2239 ms) [ RUN ] MemoryAllocationPerfTest.SingleBucketWithFree *RESULT MemoryAllocationPerfTest single bucket allocation + free (40 bytes): = 42599320 runs/s *RESULT MemoryAllocationPerfTest single bucket allocation + free (40 bytes): = 23 ns/run [ OK ] MemoryAllocationPerfTest.SingleBucketWithFree (2000 ms) [ RUN ] MemoryAllocationPerfTest.SingleBucketWithFreeWithCompetingThread *RESULT MemoryAllocationPerfTest single bucket allocation + free (40 bytes): = 593330 runs/s *RESULT MemoryAllocationPerfTest single bucket allocation + free (40 bytes): = 1685 ns/run [ OK ] MemoryAllocationPerfTest.SingleBucketWithFreeWithCompetingThread (2529 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucket *RESULT MemoryAllocationPerfTest multi-bucket allocation: = 9683520 runs/s *RESULT MemoryAllocationPerfTest multi-bucket allocation: = 103 ns/run [ OK ] MemoryAllocationPerfTest.MultiBucket (4143 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithCompetingThread *RESULT MemoryAllocationPerfTest multi-bucket allocation: = 250140 runs/s *RESULT MemoryAllocationPerfTest multi-bucket allocation: = 3997 ns/run [ OK ] MemoryAllocationPerfTest.MultiBucketWithCompetingThread (23626 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFree *RESULT MemoryAllocationPerfTest multi-bucket allocation + free: = 51287040 runs/s *RESULT MemoryAllocationPerfTest multi-bucket allocation + free: = 19 ns/run [ OK ] MemoryAllocationPerfTest.MultiBucketWithFree (2016 ms) [ RUN ] MemoryAllocationPerfTest.MultiBucketWithFreeWithCompetingThread *RESULT MemoryAllocationPerfTest multi-bucket allocation + free: = 690414 runs/s *RESULT MemoryAllocationPerfTest multi-bucket allocation + free: = 1448 ns/run [ OK ] MemoryAllocationPerfTest.MultiBucketWithFreeWithCompetingThread (6374 ms) The results with a competing thread are very unstable from run to run, but always at least an order of magnitude worse than without a competing thread. Bug: 998048 Change-Id: I086d5559e6fd6b10db61cf20d0f5df0e855020c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859989Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706357}
-
Roman Sorokin authored
Needed to align button 1 (w/o text) similar to other buttons Bug: 1004974 Change-Id: I02be47fc9c865805566182f6982c49341cf26bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862914Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706356}
-
Alexey Baskakov authored
Decouple icon pixel data from icons meta-description. In the new web app system we store icon pixel data separately. This change will allow us to forward declare WebApplicationIconInfo and use a collection of WebApplicationIconInfo structs in utility functions even if we don't have full WebApplicationInfo data. See dependent CLs for examples of improvements: https://chromium-review.googlesource.com/c/chromium/src/+/1861443 Bug: 860583 Change-Id: Ia4fcfc55c6b8e45cf1261dac9649491bc53333ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859807 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
The former component no longer exists. Change-Id: I96d62847c908a97dff82b1ebce1cefbb0a7c6c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847341Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706354}
-
Benoît Lizé authored
The feature is not used anymore, remove the histograms and the collection code. Bug: 1006991 Change-Id: Ic5f8f703ebdd7b6ae4c91441179f9fab0f7fb479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862444Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706353}
-
James Cook authored
Add the new syncer::ModelType entries for Chrome OS system preference sync. These follow the existing convention of not being wrapped in platform ifdefs. Add support to PrefServiceSyncable for registering prefs in the new categories. The new registration flags are wrapped in ifdefs, since it doesn't make sense for non-Chrome OS platforms to register Chrome OS system prefs. Add a base::Feature SplitSettingsSync to control whether the new model types are actually used for syncing. This must stay disabled until the server-side protobufs have been deployed to production. Add unit tests for PrefServiceSyncable for the new categories. There are no user visible changes. A design doc is linked from the bug. Bug: 1013466 Test: added to components_unittests Change-Id: Ice645292353c91dbd6c27a305bed95bd99ed9ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859884 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#706352}
-
nancy authored
Built_in_apps is used to replace the internal apps. However, InternalDataSource is still used for the continue reading and release notes, which is confusing. So move the continue reading to Built_in_apps, and AppSearchProvider should depend on AppServiceDataSource for all apps' search and recommended. InternalDataSource and InternalAppResult are removed to avoid duplicate code. All the related code from InternalDataSource and InternalAppResult has been moved to AppServiceDataSource and AppServiceAppResult. Also GetInternalAppNameByAppId is removed, because no one uses it. It should be removed by CL:1851890. This CL is the preparation for the CL:1816256, which moves the internal app list to Built_in_apps. BUG=1013540 Change-Id: Ic3087807fe520ff5a1ffcb200cb1cf459b42e2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847698 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706351}
-
Ramin Halavati authored
Traffic annotation auditor binary is updated for linux and windows. Bug: 1005537 Change-Id: Ia131fe6430f0031d20dce0f627599eb639a58ded TBR: nicolaso@chromium.org Change-Id: Ia131fe6430f0031d20dce0f627599eb639a58ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864669Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#706350}
-
Mathias Bynens authored
This patch adds support for emulating timezones through the Sensors drawer. It’s based on the idea that emulating geolocation without also emulating the local timezone (and vice versa) is detectable, and therefore the two should be tied together for more robust emulation. Boring but useful test/demo page: https://mathiasbynens.be/demo/timezone Video: https://www.youtube.com/watch?v=pIpN_AuV4AI Design doc: https://goo.gle/devtools-timezone-emulation Bug: chromium:993628 Change-Id: I5ef867ac2723a341444ab1ee04a26c0fa9a9d62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860014 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#706349}
-
Peter Kasting authored
This reverts commit b25e7445. Reason for revert: The ink drop path here was not the same as the highlight path; in particular, the ink drop path is manually mirrored, while the highlight path is auto-mirrored. Reverting since this results in the wrong appearance in RTL. Original change's description: > Add HighlightPathGenerator to TabCloseButton > > Replaces OnBoundsChanged override which resulted in a lot of path > generation (per-tab + frame) while opening new tabs or resizing the > window. > > Also removes a ::GetInkDropMask() override which just generated the same > path. > > Bug: chromium:1007546 > Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 > Auto-Submit: Peter Boström <pbos@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705972} TBR=ellyjones@chromium.org,pbos@chromium.org Change-Id: Ic7bd1312d452c828877669db89af45ac59160455 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864393Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706348}
-
Tim Schumann authored
This reverts the proto changes from commit d70c086c. Reason for revert: Server side code has a lot of dependencies that need to be cleaned up first. Original change's description: > Sync: Delete deprecated SUPERVISED_USERS and _SHARED_SETTINGS data types > > These two types are deprecated and can be removed. Note that > SUPERVISER_USER_SETTINGS and SUPERVISED_USER_WHITELISTS are *not* > deprecated. > > This includes removing the ModelType enum entries, removing the fields > in the EntitySpecifics proto, and deleting the specifics proto files. > > Bug: 965503 > Change-Id: I53038fdc28ed8518cd99d4a4769b5f1f52d3e94b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824882 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700687} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965503 Change-Id: If5d1ee616f2ca4daefe69fd1e0ad3a516d726675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863789Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Yang Guo authored
Bug: chromium:1014840 Change-Id: Idb98dcf0888fdecb74dad6f43163daa7a81c2302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864670 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Roman Sorokin [CET] authored
This reverts commit 05103cd7. Reason for revert: Broke OOBE pin keyboard, reverting in favor of CL:1862914. See bug for details Original change's description: > [CrOS Settings] Fix number alignment on PIN keyboard. > > Each button on the keypad includes space for a number as well as the > letters which represent the numbers (e.g., "ABC" for 2, "DEF" for 3). > However, since 1 does not have any associated letters, its alignment was > incorrect and noticeably different from the rest of the buttons. > > This CL fixes this alignment issue by aligning the number to the top of > the button and the letters to the bottom of the button. > > Fixed: 1004974 > TBR: stevenjb@chromium.org > Change-Id: I9be7be402b853cbf6ba76985151f77a0696ac13b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854638 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704900} TBR=stevenjb@chromium.org,khorimoto@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ida1e2ecc148859f38ae4b6075daa5a412453d707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863793Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706345}
-
Jinsuk Kim authored
https://crrev.com/c/1844341 implemented security requirements to BottomSheet-based Preview Tab. This CL ports it to OverlayPanel version, which is required to start stable experiment. Bug: 968567, 1007499 Change-Id: Id6bdb73a9038c9cf81db89afbd4881417d61d4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859423 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706344}
-
Sergio Villar Senin authored
In order to remove the dependency, the web_loading_behavior_flag.h file was moved to third_party/blink/public/common/loader. Since the file is no longer in the public/platform/ directory we are also renaming it loading_behavior_flag.h (and the enum defined in that file to LoadingBehaviorFlag). Bug: 1008303 Change-Id: I61141aacb431e6c53a2cde7beaeb091ea9eeac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844951 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Idf76d2ff85d63c7b26775c3fd9241892d31ff764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862494 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Peter Boström authored
Removes OnBoundsChanged overrides and unnecessary path updates. Bug: chromium:1007546 Change-Id: I78e1d2207c318d6b48bcf9825ad4064db97ed209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861140Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706341}
-
Huanzhong Huang authored
This to a great extent prevents the knob animation on every opening of an incognito ntp. Bug: 967668 Change-Id: Ib99ba020b419d8c9aed2c910049d2662a3850d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855962 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#706340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b3a883db586..7274850f96f2 git log 2b3a883db586..7274850f96f2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2d0e5b554d4f..0b9ebe58e380 (2 commits) 2019-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 083c52f7..fbf280c2 (475 commits) Created with: gclient setdep -r src/third_party/skia@7274850f96f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None Change-Id: I85cd5637e065977f5db13818c38f9a2a59e309d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864510Reviewed-by:
-
Peter Kasting authored
This reverts commit 2dd2b245. Reason for revert: Seems to have broken android-archive-rel compile, though this may be exposing some pre-existing bad dependency elsewhere: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5717 Original change's description: > [DevUI DFM] Change install flow to use NavigationThrottle. > > Previously, DevUI DFM installation used BrowserURLHandler to modify > DevUI URLs to chrome://dev-ui-loader, whose host performs DFM install > flow by calling C++ API via JavaScript. On install success, the page > forwards to the original DevUI URL. > > A flaw of the old flow was that it allows for URL "laundering", where a > compromised chrome:// page may use chrome://dev-ui-loader's ?url= query > param to access another chrome:// page, thereby bypassing potential > restrictions (e.g., referrer or origin). > > Another problem is that BrowserURLHandler does not run when a webpage is > restored on Chrome restart. This causes crbug.com/1013522, where DevUI > pages fail to load because resource load was not triggered. > > This CL uses NavigationThrottle to re-implement the DevUI DFM install > flow as DevUiNavigationThrottle. This solves the above problems, and is > simpler. Additional changes: > * Add i18n support to the install error page messages. > * Add extensive unit tests for DevUiNavigationThrottle. > > Bug: 927131,987040,1013522 > Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706329} TBR=creis@chromium.org,huangs@chromium.org,thestig@chromium.org,dbeam@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: I7eff36d7e01c31a76f39250a255d27972b0962d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927131, 987040, 1013522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864392Reviewed-by:
-
Timothy Loh authored
This CL tidies up PluginVmLauncherViewBrowserTest, removing the use of inheritance to observe state changes and instead allowing the class under test to have a callback which it calls upon completion. The newly added functions will also be used for an upcoming autotest private API, allowing the installer to be run from tast. Bug: 1006664 Change-Id: I3abb2d0fd08d0988c140dbb564c70a02929d1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863063Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25741699ee0e..febc913dd024 Created with: gclient setdep -r src-internal@febc913dd024 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I591f774147df7415e8d9cfa6245f764298ce44ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706336}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a6896a8b. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 36ebfbe5 "Stop using private properties for data properties of cross-origin properties" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic4421de2e1007d7190287fd91534a6215525bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863443Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 1014812 Change-Id: Id1ce9a48778fa71e188a35bc24d6191cb583e19d Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864752Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#706334}
-
Gyuyoung Kim authored
OnMediaRemoterCreated has still been using old Mojo types. This CL applies pending_remote and pending_receiver to the function. Bug: 955171 Change-Id: Iefbf6465dfd43940f4f0a9c46c28a1f4f2012ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829633Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Pérez authored
This reverts commit 37d44dbb. Reason for revert: Catapult roller failing with: AttributeError: type object 'StoryFilterFactory' has no attribute '_expectations' https://chromium-swarm.appspot.com/task?id=47eb08c183837510 Original change's description: > [Benchmarks] Smoke tests lay groundwork for move to story_filter. > > This change > https://chromium-review.googlesource.com/c/catapult/+/1839176 > makes it so that expectations config is passed to story_filter.py > using the project config (sometimes referred to as the > "environment"). This change lays the groundwork for that future > change. Until that change is committed, this is a no-op change. > > This change first requires this catapult-side change > https://chromium-review.googlesource.com/c/catapult/+/1854882 > to make sure that we don't pass an invalid argument to > GetRunOptions(). > > > Bug: 985103 > Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706080} TBR=perezju@chromium.org,crouleau@chromium.org,rmhasan@google.com Change-Id: I9cdcf778d4feaa3ab4d1dd1bd5385b53e99e4f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864671Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 1014810 Change-Id: I1fb23439d996e8142353a05f6cc18c07ea3d0095 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863068Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I654114143b038a86cc813bd5ce57508260abed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864551Reviewed-by:
-
