GitLab

Previously a single object MediaStreamUIController was used to control UI for
all streams. Replaced it with a per-stream MediaStreamUIProxy that simplifies
code in many places.
Also moved media request queueing logic from content layer to chrome. Now
different types of requests may be queued differently (e.g. there is no
reason to block screen capture requests on webcam infobar).

This change was previously landed in 197222 and reverted in 197242

TBR=vrk@chromium.org

Review URL: https://codereview.chromium.org/16342002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204044 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204043 0039d316-1c4b-4281-b951-d872f2087c98

R= siggi@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16357020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204041 0039d316-1c4b-4281-b951-d872f2087c98

This moves media_transfer_protocol targets into:
device/media_transfer_protocol/media_transfer_protocol.gyp

So it's consistent with what we have done with bluetooth and usb
directories/targets.

R=bryeung@chromium.org,miket@chromium.org,thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16142004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204040 0039d316-1c4b-4281-b951-d872f2087c98

Add an explicit test comparing pids to ensure that the browser has restarted - this fixes a race.

BUG=244579
TEST=manual
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16332003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204039 0039d316-1c4b-4281-b951-d872f2087c98

> Don't track whether a resize ack is pending during layout tests
> 
> Unlike normal operation, in layout tests the renderer can request a synchronous
> change of its size. The renderer and the browser therefore often run out of
> sync. However, it's important that the renderer always acks a resize request
> from the browser.
> 
> Previously, I tried to track the size the browser expects the renderer to have
> in the renderer, however, this turns out to not work when the compositor is in
> hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
> not the browser is expecting resize acks during layout tests
> 
> BUG=244369
> 
> Review URL: https://chromiumcodereview.appspot.com/16285005

Breaks fast/hidpi on windows

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/16326004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204038 0039d316-1c4b-4281-b951-d872f2087c98

These always pass and just output the results for now.
BUG=chromedriver:10
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15979030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204037 0039d316-1c4b-4281-b951-d872f2087c98

These cases weren't caught by the automated pass and/or needed to be
solved in another way than using .get().

BUG=245942
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/16226028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204036 0039d316-1c4b-4281-b951-d872f2087c98

- Use a base::hash_map instead of a std::map for the
  SimpleBackendImpl::EntryMap type, to reduce heap usage.

  This saves 3 pointers/node on Android, since there is no
  need for an ordered map here.

- Avoid creating a new closure on every call to
  SimpleIndex::PostponeWritingToDisk. Each base::Bind() call
  creates a new heap-allocated reference-counted object.

  Given that this function is called for every mutating
  operation on the index, it's a good idea to get rid of it.

  Since the called function and its argument never change,
  create the closure only once and reuse it on every
  write_to_disk_timer_.Start() call.

- Avoid performing one extra lookup and one extra call
  to PostponeWritingToDisk() in SimpleIndex::Remove().

- Remove un-necessary temporary string creations and a tiny
  typo.

R=felipeg@chromium.org, gavinp@chromium.org, pasko@chromium.org, pliard@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14877019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246359
R=pfeldman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16360007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204033 0039d316-1c4b-4281-b951-d872f2087c98

This CL is only the Chromium part of the whole change, i.e. does not include Android changes.

BUG=148796

Review URL: https://chromiumcodereview.appspot.com/15937004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204032 0039d316-1c4b-4281-b951-d872f2087c98

Adds a test and removes the ChromeOS-specific notification
that previously existed only for notifying the
EulaAcceptedNotifierChromeos class.

BUG=245437
TEST=New unit test, no functionality change.

Review URL: https://chromiumcodereview.appspot.com/16129004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204031 0039d316-1c4b-4281-b951-d872f2087c98

With the chrome download path, when onDownloadStarted() is called, we close the tab if it is blank.
The close call come too early as onDangerousDownload() has not been called yet.
This CL sends the filename and mimeType to java side to check if we can close the tab or not.
Also, if the tab is closed after user validates the dangerous item, the onDownloadComplete() should send a message to the app, rather than tab.

BUG=244052

Review URL: https://chromiumcodereview.appspot.com/16140026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204030 0039d316-1c4b-4281-b951-d872f2087c98

TEST=manually
BUG=240739

Review URL: https://chromiumcodereview.appspot.com/15700014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204029 0039d316-1c4b-4281-b951-d872f2087c98

FileRef and FileIO both convert base::PlatformFileInfo to PP_FileInfo. I ran
into this while I was about to reimplement the same thing in the FileRef
refactor, and figured I may as well break out this simple refactor to its own
change.

BUG=

Review URL: https://chromiumcodereview.appspot.com/16140025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204027 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=571
TESTED=gcc scale.cc
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/16361008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/16336013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204024 0039d316-1c4b-4281-b951-d872f2087c98

function to compare emails instead of doing a string compare.

BUG=244408

Review URL: https://chromiumcodereview.appspot.com/15896026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204023 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204022 0039d316-1c4b-4281-b951-d872f2087c98

Before this fix, OneClickSigninSyncStarter didn't detect when the Browser object it points to was closed. It could then cause a crash by making calls on the destroyed Browser object. OneClickSigninSyncStarter now observes the browser list to detect when the Browser it points to is closed.

BUG=235439

Review URL: https://chromiumcodereview.appspot.com/16092009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245453
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/15979033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177605
TEST=compiled

Review URL: https://chromiumcodereview.appspot.com/15815002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204019 0039d316-1c4b-4281-b951-d872f2087c98

r757 -> r774

This fixes a recent breakage regarding the name of the
ncval executable changing.

It also brings in several other changes from naclports
but none should directly effect any of the packages included
in the SDK.

BUG=None
TEST=build_sdk.py --build-ports
R=binji@chromium.org

Review URL: https://codereview.chromium.org/16224009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204018 0039d316-1c4b-4281-b951-d872f2087c98

First step of a larger refactor to push some of the logic from the
AsyncPixelTransferDelegate to the AsyncPixelTransferManager. This
CL moves a lot of files (async_pixel_transfer_delegate_* -->
async_pixel_transfer_manager_*) and introduces some Manager wrappers.
There is no functional change.

BUG=240504

Review URL: https://chromiumcodereview.appspot.com/16325018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204017 0039d316-1c4b-4281-b951-d872f2087c98

- UI part of ProxyConfigServiceImpl is moved to UIProxyConfig and UIProxyConfigService.
- ProxyConfigServiceImpl uses NetworkStateHandler instead of NetworkLibrary except for the legacy migration of device proxy settings.
- UI code continues to use NetworkLibrary for now.

BUG=234982
TBR=willchan@chromium.org (for trivial but reviewed change in net/proxy/proxy_config.*)

Review URL: https://chromiumcodereview.appspot.com/14846004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241938
R=piman@chromium.org

Review URL: https://codereview.chromium.org/16360018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204015 0039d316-1c4b-4281-b951-d872f2087c98

Unlike normal operation, in layout tests the renderer can request a synchronous
change of its size. The renderer and the browser therefore often run out of
sync. However, it's important that the renderer always acks a resize request
from the browser.

Previously, I tried to track the size the browser expects the renderer to have
in the renderer, however, this turns out to not work when the compositor is in
hidpi mode. Instead of trying to fix this up somehow, just ignore whether or
not the browser is expecting resize acks during layout tests

BUG=244369

Review URL: https://chromiumcodereview.appspot.com/16285005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204014 0039d316-1c4b-4281-b951-d872f2087c98

This is a less aggressive patch than the description below. The original was reverted for breaking the Android tests bot (https://codereview.chromium.org/16299003).

Removes check install step and moves it into the device status check. This will allow us to examine Android install speeds, which have recently caused timeout problems when installing large APK's. Unlike the original CL, low install speed only causes a warning (i.e. does not fail the step). The step fails if the battery of an online device is less than 5%.

BUG=230970, 224004, 242237

---------------------------------------------------
Original CL:
Move CheckInstall to device status and fail on low install speed and battery.

Removes the recently added CheckInstall step and moves the checking to the
device status check step. Recently, devices will install very slowly causing
tests to fail with device problems. We have also seen battery issues. The new
device status check step will fail if any devices install unreasonably slow
(i.e. < 800 KB/s) or have critically low battery level (i.e. < 5%).

BUG=230970, 224004, 242237

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203587

Review URL: https://chromiumcodereview.appspot.com/16110005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204013 0039d316-1c4b-4281-b951-d872f2087c98

In this specific case, expired Online Wallet instruments.

R=groby@chromium.org,estade@chromium.org
TBR=aruslan@chromium.org
BUG=168680
TEST=unit_tests and manual

Review URL: https://chromiumcodereview.appspot.com/15961007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204012 0039d316-1c4b-4281-b951-d872f2087c98

This policy may disable incognito mode, or set it to enforced (i.e. disable
non-incognito windows). This change introduces a CHECK that prevents any code
paths from opening a disabled window type; such code paths should still be
fixed, but this CHECK prevents working around the policy.

BUG=244246

Review URL: https://chromiumcodereview.appspot.com/15670011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244956
TEST=manual
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/16290009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204008 0039d316-1c4b-4281-b951-d872f2087c98

R=dsinclair
NOTRY=True
BUG=232925

Review URL: https://chromiumcodereview.appspot.com/15736032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204007 0039d316-1c4b-4281-b951-d872f2087c98

If the user flings down a page while the page is still loading, we may
hit a situation where the fling animation stops at the bottom edge of
the content, pauses while the loading proceeds and then continues once the
content grows taller. This results in a jarring pause in an otherwise
continuous animation.

This patch fixes the issue by preventing the fling animation from trying
to scroll beyond the content edge. In other words, as soon as the
content overscrolls on a specific axis, we prevent the fling animation
from scrolling on that axis again.

BUG=244376
TEST=InputHandlerProxyTest.GestureFlingStopsAtContentEdge

Review URL: https://chromiumcodereview.appspot.com/16156002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204006 0039d316-1c4b-4281-b951-d872f2087c98

This code is simple/test/mock implementations of APIs to use in DumpRenderTree,
webkit_unit_tests, and various other bits of unit test code around the codebase.
Nothing here is used for test_shell since there is no test_shell any more.

This moves the code to webkit/support/ along with the rest of DRT/w_u_t support
code. Hopefully we'll be able to delete most of this soon along with
DumpRenderTree. In the meantime this simplifies webkit/

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203242

Review URL: https://codereview.chromium.org/15946006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=246460
TEST=existing DriveMetadataStoreTest

Review URL: https://chromiumcodereview.appspot.com/15954013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204004 0039d316-1c4b-4281-b951-d872f2087c98

Since not all net error codes can be mapped onto Android error codes,
at least provide a minimal description for the client.

Review URL: https://chromiumcodereview.appspot.com/15979017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222350

Review URL: https://chromiumcodereview.appspot.com/16236003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203998 0039d316-1c4b-4281-b951-d872f2087c98

> Introduces the default sound for notifications.
>
> Currently no one is using this but will be used soon.
>
> BUG=164248
> R=dewittj@chromium.org, jhawkins@chromium.org
>
> Review URL: https://codereview.chromium.org/15896033
>
> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203991 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mukai@chromium.org, sreeram@chromium.org

Review URL: https://codereview.chromium.org/16359012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203997 0039d316-1c4b-4281-b951-d872f2087c98

These cases weren't caught by the automated pass and/or needed
to be solved in another way than using .get().

BUG=245942
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/16207005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203996 0039d316-1c4b-4281-b951-d872f2087c98