GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f2539d5..070e010

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1155463002

Cr-Commit-Position: refs/heads/master@{#330925}

Allows MemoryDumpProvider(s) with dump-time constraints (mostly GC
allocators) to create out-of-band MemoryAllocatorDump(s) and merge
them during the onMemoryDump callback.

So far, the architecture of MemoryDumpProvider expected to never
instantiate ProcessMemoryDump(s) directly, but just fill up the
one passed as argument to the onMemoryDump(ProcessMemoryDump*)
callback.
This, however, doesn't cover the cases of dumpers that cannot dump
at arbitrary times (i.e. during onMemoryDump callback) and
need to pre-fill the dump stats before the actual callback
comes.
A concrete case of this are dump providers for garbage-collected
allocators (specifically BlinkGC) where some of the stats can be
collected only during the GC.

BUG=466141

Review URL: https://codereview.chromium.org/1151603004

Cr-Commit-Position: refs/heads/master@{#330924}

Revert of Enable more benchmark_smoke_unittest coverage (patchset #4 id:100001 of https://codereview.chromium.org/1144193002/)

Reason for revert:
Reverting due to flaky perf tests (see crbug.com/490130 for details).

Original issue's description:
> Enable more benchmark_smoke_unittest coverage
>
> Previously, benchmark_smoke_unittest has a heuristic to pick
> a benchmark for smoke testing if the benchmark uses a test
> in measurement directory.
> This patch removes that check, and instead provide a black
> list of benchmarks module that we exclude the
> benchmark_smoke_unittest to avoid high CQ time.
>
> This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module).
>
> On my local linux machine, this increases the cycle time of
> benchmark_smoke_unittest from 20s -> 1m7s.
>
> BUG=490130
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4
> Cr-Commit-Position: refs/heads/master@{#330909}

TBR=sullivan@chromium.org,dtu@chromium.org,nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=490130

Review URL: https://codereview.chromium.org/1143363006

Cr-Commit-Position: refs/heads/master@{#330923}

They are intended to be FYI checks. If they are ignored at upload
time, submitting should still work.

BUG=

Review URL: https://codereview.chromium.org/1147103002

Cr-Commit-Position: refs/heads/master@{#330922}

Do *not* grant permissions to extensions that come in via Sync disabled due to a permission increase.

Follow-up to http://crrev.com/1136543003

BUG=484214

Review URL: https://codereview.chromium.org/1150573002

Cr-Commit-Position: refs/heads/master@{#330921}

Reason for this when build with Memory Sanitizer it causes delay between CallJS('...') and actual JS execution. In this particular case Chrome tries to CallJS('doReload') due to frame loading error. After that it loads offline Gaia and then function |doReload| starts to execute which causes hiding offline Gaia;

BUG=475516

Review URL: https://codereview.chromium.org/1151513002

Cr-Commit-Position: refs/heads/master@{#330920}

Increased the spacing between oauth-enroll-attribute-prompt-message and gaia-input-card.

Review URL: https://codereview.chromium.org/1148113002

Cr-Commit-Position: refs/heads/master@{#330919}

Adds unit tests for the proximity_auth::BluetoothLowEnergyConnectionFinder
class.

BUG=485123

Review URL: https://codereview.chromium.org/1129983004

Cr-Commit-Position: refs/heads/master@{#330918}

Enterprise admins would liked to control apps that will be installed for their users.
To allow admins to don't track and block OEM apps one by one disable OEM apps installation.

BUG=486862
TEST=manual

Review URL: https://codereview.chromium.org/1144033003

Cr-Commit-Position: refs/heads/master@{#330917}

Disable DomSerializerTests.SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc on
Mac because it fails in a CHECK of
sequence_checker_.CalledOnValidSequencedThread() (see crbug.com/488495)

TBR=ellyjones@chromium.org,jam@chromium.org
BUG=488495

Review URL: https://codereview.chromium.org/1145303005

Cr-Commit-Position: refs/heads/master@{#330916}

This matches downstream, where we build a universal binary, and then run tests on the 64-bit iPhone 5s simulator and the 32-bit iPad Retina simulator.

BUG=490189

Review URL: https://codereview.chromium.org/1150753002

Cr-Commit-Position: refs/heads/master@{#330915}

WebRTC 9229:9238
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ead3df8..b7c7010

Libjingle 9227:9240
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/88eeffa..dd7a408

R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/1151683002

Cr-Commit-Position: refs/heads/master@{#330914}

On iOS when user chaneg the device locale, we update the list of search
engines keeping the currently selected search engine unchanged. This is
done by removing all other search engines, and then adding the new ones.

BUG=None

Review URL: https://codereview.chromium.org/1149623002

Cr-Commit-Position: refs/heads/master@{#330913}

This CL fixes an issue where shadows were larger than
ShadowValue::GetMargin(). This caused certain shadows to clip to the
view boundaries which looks bad.

BUG=489533

Review URL: https://codereview.chromium.org/1123393007

Cr-Commit-Position: refs/heads/master@{#330912}

Changes in the src/cc directory can often affect the layout tests in Blink
however Chromium commit queue doesn't run these tests by default. This leads to
breakages being discovered only when the Blink dep is rolled into Chromium.

By adding the following line to the CL's description the Blink tests will be
run in addition to the normal Chromium tests;
 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

BUG=483372
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1142393002

Cr-Commit-Position: refs/heads/master@{#330911}

This is where things get complicated.

NTP4 had a most visited pane.  It showed your top sites.
So does the current NTP; so I'm trying to remove everything
that deals with most visited tiles on NTP4 without accidentally
breaking the same named thing on the current NTP.

Here's what used to exist that I'm trying to remove:
http://bostandjiev.com/Content/Google/chrome.jpg

Here's what currently exists that I'm trying not to break:
http://cdn.ghacks.net/wp-content/uploads/2013/04/chrome-new-tab-page.jpg

BUG=329637

Review URL: https://codereview.chromium.org/1129903008

Cr-Commit-Position: refs/heads/master@{#330910}

Previously, benchmark_smoke_unittest has a heuristic to pick
a benchmark for smoke testing if the benchmark uses a test
in measurement directory.
This patch removes that check, and instead provide a black
list of benchmarks module that we exclude the
benchmark_smoke_unittest to avoid high CQ time.

This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module).

On my local linux machine, this increases the cycle time of
benchmark_smoke_unittest from 20s -> 1m7s.

BUG=490130
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1144193002

Cr-Commit-Position: refs/heads/master@{#330909}

Cr-Commit-Position: refs/heads/master@{#330908}

This extends the js2gtest template and uses it for the gtestjs
unit tests.

BUG=None

Review URL: https://codereview.chromium.org/1145113002

Cr-Commit-Position: refs/heads/master@{#330907}

Revert of [Cast] Compute utilization metrics and add performance overlay. (patchset #2 id:40001 of https://codereview.chromium.org/1148233002/)

Reason for revert:
Reverting due to compile failure on Google Chrome Mac builder:
../../media/cast/sender/h264_vt_encoder_unittest.cc:282:38: error: no viable conversion from 'Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'Callback<void (scoped_ptr<media::cast::SenderEncodedFrame>)>'
  VideoEncoder::FrameEncodedCallback cb = base::Bind(
                                     ^    ~~~~~~~~~~~
../../base/callback.h:358:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'base::Callback<typename internal::BindState<typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunnableType, typename internal::FunctorTraits<void (MetadataRecorder::*)(scoped_ptr<EncodedFrame, DefaultDeleter<EncodedFrame> >)>::RunType, internal::TypeList<typename internal::CallbackParamTraits<MetadataRecorder *>::StorageType> >::UnboundRunType>' to 'base::Callback<void (scoped_ptr<media::cast::SenderEncodedFrame, base::DefaultDeleter<media::cast::SenderEncodedFrame> >)> &&' for 1st argument
class Callback;

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Mac&number=1293

Original issue's description:
> [Cast] Compute utilization metrics and add performance overlay.
>
> Adds computation of two frame-level utilization metrics to the software
> VP8 encoder in Cast: deadline utilization and lossy utilization.  The
> first is a measure of how long the encoding of each frame takes compared
> to the frame duration.  The second is a measure of the complexity of a
> frame, in terms of the quality versus encoded size trade-off.
>
> In a future change, these utilization metrics will be sent as feedback
> signals to the producer of the video frames, allowing the producer to
> adjust data volumes based on the consumer's capability throughout a
> session.  See bug for more details.
>
> Also, this change adds an overlay display, where frame-level performance
> metrics are rendered in the lower-right corner of each video frame just
> before it is sent.  This provides an "on screen display" of end-to-end
> system performance.  This is turned on with a command line argument:
> --vmodule=performance_metrics_overlay=3
>
> BUG=156767
>
> Committed: https://crrev.com/d9e741512cd6ea56cefd0173b371d0dd29f0cce5
> Cr-Commit-Position: refs/heads/master@{#330896}

TBR=hubbe@chromium.org,miu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=156767

Review URL: https://codereview.chromium.org/1143363005

Cr-Commit-Position: refs/heads/master@{#330906}

BUG=486739

Review URL: https://codereview.chromium.org/1133613007

Cr-Commit-Position: refs/heads/master@{#330905}

For these directories, much better reviewers are available.

BUG=None

Review URL: https://codereview.chromium.org/1142383004

Cr-Commit-Position: refs/heads/master@{#330904}

BUG=481153,157073
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1144413003

Cr-Commit-Position: refs/heads/master@{#330903}

This avoids the string allocation when searching for a char* in a
std::map<std::string>.

CommandLine now maintains a parallel map of StringPieces that reference
the strings in |switches_|. StringPiece is trivial to construct from a
string, and only requires a strlen to construct from a char*.

On a profile with 2 extensions, HasSwitch is called ~12k times during
startup. In an ideal situation (no paging/cache pressure), the
string allocation under Windows takes ~137ns on a Xeon E5-2690 @
2.9Ghz. A strlen on a typical switch takes about 50ns, and 91% of calls
pass a char*, so there's a net saving of at least
(137 - 0.9 * 50)ns * 12k = 1.1ms from a typical startup with this
hardware. For context, Startup.BrowserMessageLoopStartTimeFromMainEntry
is typically 280-300ms on the same hardware, so we should get a ~0.4%
improvement.

BUG=472383

Review URL: https://codereview.chromium.org/1063933002

Cr-Commit-Position: refs/heads/master@{#330902}

BUG=490213

Review URL: https://codereview.chromium.org/1150563004

Cr-Commit-Position: refs/heads/master@{#330901}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/07b5cd0..25e200f

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1145323004

Cr-Commit-Position: refs/heads/master@{#330900}

Since we can't rely on the modifier flags on ChromeOS, we can't use them
as a way to detect stuck modifier keys. This means that some actions
(including locking the screen) will result in Ctrl and Shift being stuck,
effectively regressing crbug.com/464534.

BUG=337509,484329

Review URL: https://codereview.chromium.org/1145863002

Cr-Commit-Position: refs/heads/master@{#330899}

BUG=489701

Review URL: https://codereview.chromium.org/1146693003

Cr-Commit-Position: refs/heads/master@{#330898}

BUG=

Review URL: https://codereview.chromium.org/1143243004

Cr-Commit-Position: refs/heads/master@{#330897}

Adds computation of two frame-level utilization metrics to the software
VP8 encoder in Cast: deadline utilization and lossy utilization.  The
first is a measure of how long the encoding of each frame takes compared
to the frame duration.  The second is a measure of the complexity of a
frame, in terms of the quality versus encoded size trade-off.

In a future change, these utilization metrics will be sent as feedback
signals to the producer of the video frames, allowing the producer to
adjust data volumes based on the consumer's capability throughout a
session.  See bug for more details.

Also, this change adds an overlay display, where frame-level performance
metrics are rendered in the lower-right corner of each video frame just
before it is sent.  This provides an "on screen display" of end-to-end
system performance.  This is turned on with a command line argument:
--vmodule=performance_metrics_overlay=3

BUG=156767

Review URL: https://codereview.chromium.org/1148233002

Cr-Commit-Position: refs/heads/master@{#330896}

chrome/installer/util used to depend on chrome:resources but was apparently never used. This causes a problem because chrome_watcher.dll depends on installer_util, and chrome:resources depends on the omnibox mojo target. To get this dependency "right" we would have to link all of mojo system into chrome_watcher.dll. It is properly dead-code stripped (I checked) but this still seems undesirable.

I removed the dependency and also made //chrome/installer/* "gn check" clean. There were some other unnecessary deps and header file uses.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1148173002

Cr-Commit-Position: refs/heads/master@{#330895}

This was added in http://crrev.com/16233, but will no longer be needed
once https://codereview.chromium.org/1139273002/ fixes the test.

BUG=488585

Review URL: https://codereview.chromium.org/1131263011

Cr-Commit-Position: refs/heads/master@{#330894}

BUG=369661
TEST=NavigationControllerBrowserTest.UniqueIDs

Review URL: https://codereview.chromium.org/1139823006

Cr-Commit-Position: refs/heads/master@{#330893}

AMP had a bug outputting results if the output stream was too
large. Therefore, we only were outputting test results for failed
tests. This issue has been fixed (b/18981674) and this CL is to
enable full test result outputting on AMP.

BUG=

Review URL: https://codereview.chromium.org/1023803002

Cr-Commit-Position: refs/heads/master@{#330892}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/88a27231..048c4866

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1150853002

Cr-Commit-Position: refs/heads/master@{#330891}

- Return canonicalized email from GetUserEmail because sign-in
  manager gives back the Gaia email which is not necessarily the
  same as the one used on the login screen;
- Sign-in manager gives empty user email when underlying refresh token
  is revoked. Bail out in this case.

BUG=489890

Review URL: https://codereview.chromium.org/1149873003

Cr-Commit-Position: refs/heads/master@{#330890}

BUG=489636
TEST=n/a

Review URL: https://codereview.chromium.org/1142873004

Cr-Commit-Position: refs/heads/master@{#330889}

Having load_library_from_zip_file end with "_file" causes a GYP
exception when the value is overriden.

BUG=488135

Review URL: https://codereview.chromium.org/1142353003

Cr-Commit-Position: refs/heads/master@{#330888}

BUG=420315
TEST=unit test

Committed: https://crrev.com/27e044cfc5c2a43b6c575508aca64763bfa2deba
Cr-Commit-Position: refs/heads/master@{#330713}

Review URL: https://codereview.chromium.org/1147563002

Cr-Commit-Position: refs/heads/master@{#330887}

Replacing "he/she" with "they".

BUG=none
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/1145373002

Cr-Commit-Position: refs/heads/master@{#330886}