Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Apr, 2018 5 commits
    • Dominick Ng's avatar
      Migrate showing the intent picker from ArcNavigationThrottle to AppsNavigationThrottle. · 7fa990ed
      Dominick Ng authored 
      This CL moves the code responsible for displaying the intent picker UI
on Chrome OS from ArcNavigationThrottle to the app-platform-generic
AppsNavigationThrottle class. There should be no functional changes.

The supporting AppInfo type is migrated to apps_navigation_types.h to
allow other app platforms to make use of it.

Future CLs will migrate the
ArcNavigationThrottle::AsyncOnIntentPickerClosed method to
AppsNavigationThrottle, so that apps of different types can have UMA
recorded.

BUG=824598
TBR=sky@chromium.org

Change-Id: I875cd4d59f7ac562eaeba973fa67daf3a213f136
Reviewed-on: https://chromium-review.googlesource.com/981834
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarDavid Jacobo <djacobo@chromium.org>
Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547879}
      7fa990ed
    • Eugene But's avatar
      Fixed status label width for in-progress download. · 9c25fd77
      Eugene But authored 
      Previously status label was resized by calling sizeToFit. sizeToFit does
not play well with autolayout and overrides the existing constraints.

This CL creates statusLabelTrailingConstraint which anchors the label
to close button or to action button (when download is not in progress
and action button is visible).

The test was updated to force the view load, so setting up constrains
do not fail in the test.

Bug: 827641
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2d84d6ba041d85bfd7cee9290c76c56a8f68c8b8
Reviewed-on: https://chromium-review.googlesource.com/988750
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avataredchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547878}
      9c25fd77
    • Ella Ge's avatar
      Windows contextmenu events should fire on long tap · aa4f1763
      Ella Ge authored 
      On Windows, we send context menu when long press gesture is released.
Previously context menu event is sent on long press gesture. On Windows,
context menu was held in last_context_menu_params_ and wait for next
GestureTap event.

In this Cl, let contextmenu events send on GestureLongTap on windows.
So there is no need to store the last_context_menu_params_ for windows,
remove related code.

Because we still want to handle text selection on longpress but only
move context menu event to long tap, remove setting caret on long tap
because that will break text selection quick menu on windows.

Bug: 748480
Change-Id: If5372e30d08473dfeded0fe133f32f7d6ca43328
Reviewed-on: https://chromium-review.googlesource.com/960964Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547877}
      aa4f1763
    • Dominick Ng's avatar
      Zero-check the AppBannerInfoBarDelegateAndroid native pointer. · 4c8da33a
      Dominick Ng authored 
      There are a number of crashes which seem to come from the Java-side
AppBannerInfoBarDelegateAndroid#OnInstall method calling the native-side
method after its AppBannerUiDelegate object has been cleared. The crash
manifests as a segmentation fault when accessing a std::unique_ptr
member.

This CL zero-checks the native pointer in the Java-side
AppBannerInfoBarDelegateAndroid prior to calling to native.
https://crrev.com/c/959409 attempted to address the crashes by reordering
the destruction procedure of AppBannerInfoBarDelegateAndroid, but this
did not catch all of the crashes.

BUG=819434

Change-Id: Ibb5dbe322ab705173bba3835702fdd27b0e2adcc
Reviewed-on: https://chromium-review.googlesource.com/991312Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547876}
      4c8da33a
    • Dominick Ng's avatar
      Migrate generic throttle code from ArcNavigationThrottle to AppsNavigationThrottle. · 59497f7b
      Dominick Ng authored 
      This CL moves the generic Chrome OS intent picker navigation throttling
behaviour from ArcNavigationThrottle to AppsNavigationThrottle.
AppsNavigationThrottle::MaybeCreate now returns an instance of
AppsNavigationThrottle, and ArcNavigationThrottle now handles showing
the intent picker UI and querying ARC++ for apps. This CL should have no
functional changes.

Follow-up CLs will migrate the showing the intent picker UI to
AppsNavigationThrottle, and rename ArcNavigationThrottle. The renaming
was not done in this CL for ease of review. Strictly speaking,
ArcNavigationThrottle is still a semantically correct name; the main
reason for renaming is to avoid confusion with subclasses of
content::NavigationThrottle.

BUG=824598

Change-Id: I82c6e48cf7929701ea9f59cf811c4b7de70fd49a
Reviewed-on: https://chromium-review.googlesource.com/974622
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Reviewed-by: default avatarDavid Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547875}
      59497f7b
  3. 03 Apr, 2018 35 commits