- 22 Oct, 2020 40 commits
-
-
Reilly Grant authored
It appears that in addition to returning "AccessDenied" when attempting to enumerate GATT characteristics Windows can also return "AccessDenied" when trying to open a service. This patch avoids failing service discovery entirely by simply ignoring such inaccessible services. Bug: 1058849 Change-Id: If4cf178bb30a12305cdadbc379922302c14671c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099762 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819726}
-
Hayato Ito authored
external/wpt/webdriver/tests/maximize_window/maximize.py>>test_fully_exit_fullscreen is flaky on linux. TBR=kyleju@chromium.org Bug: 1141282,977228 Change-Id: Ib331f9ddc12ffc82883d2aaee777d512817cdc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490911Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819725}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ice9c926c22a79d0f4ddf9d1f8fdeba64f67ebec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491602Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819724}
-
Hiroshige Hayashizaki authored
Path restriction check https://w3c.github.io/ServiceWorker/#path-restriction shouldn't be done for non-top-level module scripts. Bug: 1136775 Change-Id: Id75fd427aaceca189324335fae1efb37f5df7c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462947 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#819723}
-
Koji Ishii authored
r796465 crrev.com/c/2344431 changed |HandleOverflow| to call |HandleTrailingSpaces| only if |shape_result| is not nullptr. crbug.com/1139513 found that this change caused M86 to hang. M87 and later has a new trailing space code in r807457 crrev.com/c/2412307 and that the symptom is not observed. However, this indicates that we may hang if we go to the codepath in any other conditions. This patch: 1. Reverts the behavior to M85/86. 2. Change the function to take the pointer of |shape_result| instead of ref to indicate it can be nullptr. |HandleTrailingSpaces| needs |shape_result| only under certain condition, and the current assumption is that the combination will not occur. Change-Id: Ide9f48e14657c8e3c893fd506fee8412216df25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489730Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819722}
-
Hayato Ito authored
CrossPlatformAccessibilityBrowserTest.NonInteractiveChangesAreBatched is flaky on linux. TBR=dmazzoni@chromium.org,dtseng@chromium.org,kschmi@microsoft.com Bug: 1141280 Change-Id: I44cd6e694a99a51a8fea2103ce0345f65f282da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491571 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Minggang Wang authored
As a part of the Onion Soup project, this patch moves SyncLoadResponse from content/renderer/loader/ to third_party/blink/public/platform/. Besides, this patch moves `context_for_redirect` out SyncLoadResponse. SyncLoadResponse will be moved to blink/renderer/platform/loader/fetch/url_loader finally. Bug: 1110032 Change-Id: I258a23f5874ce72f2b962ce05a48ff272b718302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480703Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
The metrics are no longer in use. CL that removed the metrics: https://webrtc-review.googlesource.com/c/src/+/189783 Bug: chromium:1140067,chromium:1140071,chromium:1140073,chromium:1140076 Change-Id: Ieaa5a9aafc87b3d76e741f68a3d8d5ccbe90d647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485059Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#819719}
-
Peter Kotwicz authored
This CL switches fetch_all_androidx.py to use urllib.request.urlopen() instead of requests.get() because requests is not a built-in python module. BUG=1064277 Change-Id: I2b3d21f904a708283c3ccb1072460443d4e08e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490727 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819718}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d86ca92685bb..337086da0b11 2020-10-22 thestig@chromium.org Remove lots of unused CMYK code. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::kCmyk`. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::k8bppCmyk`. 2020-10-21 thestig@chromium.org Remove `FXDIB_Format::k1bppCmyk`. 2020-10-21 tsepez@chromium.org Use IsOpaqueImage() in CFX_DIBitmap::MultiplyAlpha(). 2020-10-21 thestig@chromium.org Remove parameter from CFX_WindowsDIB::LoadFromBuf(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I24e9cbfa39013d0012192d817f474c7154cdfd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819717}
-
Tal Pressman authored
The IPCs to create/destroy the Render* objects were already moved to AgentSchedulingGroup, but until now it delegated the implementation to RenderThreadImpl. This CL moves the actual implementation to AgentSchedulingGroup. Bug: 1111231 Change-Id: I5ade91a18c72882781eba159b9708aea7f857945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485659 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#819716}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/982bf51c4052..c3fb4c6d3915 2020-10-21 kmarshall@chromium.org Use "web_engine_with_webui" for Fuchsia telemetry testing. 2020-10-21 chonggu@google.com Move Fuchsia version into GetOSVersionDetailString If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092729 Tbr: skyostil@google.com Change-Id: Ib5b3845f4106889e6e4c5fb6b093303e3135f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489737Reviewed-by:
-
Adam Rice authored
If an HTTP/2 WebSocket server closed a stream with no error there it would trigger a DCHECK in WebSocketSpdyStreamAdapter::OnClose, due to an assumption that this method would not be called with an OK status. Accept the OK status and translate it into an ERR_CONNECTION_CLOSED. Also add a unit test for this condition. BUG=1139140 Change-Id: Iaa25ba45606f388d15b377154a6d2273d006fb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489104 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819714}
-
Nicholas Hollingum authored
crrev.com/c/2277694 introduced unadjusted mouse motion to cros, but this support is still experimental and should only be enabled behind a flag. We add a flag to the UI code s.t. the value will only be set if the flag is. Bug: 1131208 Change-Id: Idef231451bea0c8e718a3631ef46bb199f18e231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483982Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#819713}
-
Yu-Hsuan Hsu authored
Make linux-chrome able to qeury audio devices from libcras. BUG=b:167938737 Change-Id: Ic6452f8104f8c0e114d6eb990236eb6e18d2f4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483542 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819712}
-
Yuly Novikov authored
This reverts commit accbbb4f. Reason for revert: fixed in crrev.com/819493 Original change's description: > conformance/rendering/multisample-corruption.html flaky in WebGL1 and 2 > > TBR=kbr > > Bug: 1004581 > Change-Id: I027e384cea1233e7fcc948d7989c22b286d7b381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473160 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817321} TBR=ynovikov@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004581 Change-Id: Ibea2b7e4ed6c9f88ab21f58518ca3685046d828b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491002Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819711}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I5f9b1acc0bdee2a8de592b9e185eb4244023a462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491137Reviewed-by:
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests and browser_tests. Change-Id: I4a302a38cf48060352477f48775aa5d2a0f27b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#819709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6029e464cf93..2e1091e0ef69 2020-10-22 cnorthrop@google.com Tests: Add FIFA Mobile trace 2020-10-21 cnorthrop@google.com Tests: Add KartRider Rush+ trace 2020-10-21 syoussefi@chromium.org Vulkan: Faster check for vertex attribute aliasing 2020-10-21 cnorthrop@google.com Tests: Add Marvel Contest of Champions trace 2020-10-21 sugoi@chromium.org Revert "Allow rendering to half float in ES2 contexts when possible" 2020-10-21 geofflang@google.com GL: Use ANGLE_GL_TRY when setting pixel pack and unpack state. 2020-10-21 sugoi@google.com Allow rendering to half float in ES2 contexts when possible 2020-10-21 geofflang@google.com Expose glGetTexLevelParameter{if}v before ES 3.1. 2020-10-21 jmadill@chromium.org Test Runner: Command line sharding args override env. 2020-10-21 jonahr@google.com Disable TransformFeedbackTest.NonExistentTransformFeedback* 2020-10-21 jonahr@google.com Add dlopen_fuchsia.h as exception in export_targets.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132514,chromium:1140113,chromium:1140531 Tbr: jonahr@google.com Test: Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGLTest: Test: angle_perftests --gtest_filter="*fifa_mobile*"Test: Test: angle_perftests --gtest_filter="*marvel_contest_of_champions*"Test: Test: angle_perftests --gtet_filter="*kartrider_rush*" Change-Id: I949ef152fd6a5ae20534c665f245272c618fdbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491342Reviewed-by:
-
David Van Cleve authored
Currently, TrustTokenKeyCommitments has a bug where we compare an iterator from |additional_commitments_from_command_line_| to another iterator from |commitments_|, due to a typo when landing the original logic. This CL corrects that error. This undefined behavior could be part of the reason why we're seeing TrustTokenKeyCommitments.KeysFromCommandLine failing flakily on Android. Bug: 1140418 Change-Id: I3322104707cb62b1e53ec1ac22979dd647a8934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485784 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#819707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87996d2e7b98..d56c381aa518 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817,chromium:1124054,chromium:1137566,chromium:1138495,chromium:1138536,chromium:1138554 Tbr: hayato@google.com Change-Id: I64c005eae5dfc51fc7547645f35a5a4d0125543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819706}
-
Matt Menke authored
Add NIK parameter to ReportingService::ProcessHeader(). TBR=msramek@chromium.org Bug: 993805 Change-Id: I04448b4da9bfad52f9ae0cd6863b19b0e572a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485172 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819705}
-
Marc Treib authored
Bug: 1138277 Change-Id: Ie3114eca1654afd305fcd3bb260a181a07228085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484706 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#819704}
-
David Van Cleve authored
absl::variant was recently approved for general Chromium usage. This CL adds it to the Blink symbol allowlist. (I had a union I wanted to implement in the child CL and remembered `variant` had recently been approved. I'm not familiar with the criteria for permitting/forbidding symbols in Blink, so I wouldn't be too surprised if it turns out we don't want `variant` in Blink.) R=dcheng Bug: None Change-Id: I0885ef203472bcdb17481423d88eeb2add801766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442230 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819703}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Idd9e4ccbba9303439145d8e884b3e3c008bb5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491183Reviewed-by:
-
David Van Cleve authored
This CL updates the Trust Tokens issuance helper to read key commitments and understand when the issuer at hand is requesting that the issuance operation be mediated by the operating system instead of sent directly to the issuer's server. The CL: - adds a new delegate class to abstract away actually executing issuance locally (not yet implemented); - for now, has TrustTokenRequestHelperFactory provide a stopgap always-fail delegate; - updates TrustTokenRequestIssuanceHelper's logic to be able to delegate operations locally; - adds a new response status to trust_tokens.mojom to communicate the successful local execution of a Trust Tokens operation (i.e., no need to send the request onward to the server); and - adds a new base::FeatureParam associated with the Trust Tokens feature, gating local Trust Tokens issuance requests. Test: Expands TrustTokenRequestIssuanceHelper unit tests Bug: 1130252 Change-Id: I1bf4e96ea65555d2ad24c5b7b18f95d1791d73b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432862 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Kent Tamura authored
It was possible that FormController::RestoreAllControlsInDocumentOrder() twice: 1. ScheduleRestore() is called. A task to run RestoreAllControlsInDocumentOrder() is scheduled. 2. RestoreImmediately() is called. It runs RestoreAllControlsInDocumentOrder(). 3. The scheduled RestoreAllControlsInDocumentOrder() runs. If FormControlState objects remained after the first call, the second call might restore them to incorrect elements. RestoreAllControlsInDocumentOrder() should check did_restore_all_ flag. Bug: 1138598 Change-Id: I6eb45ae31407905741d3b8c0c28b01b1f07f8dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488945 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#819700}
-
Hayato Ito authored
AboutFlagsHistogramTest.CheckHistograms is flaky on linux. TBR=asvitkine@chromium.org,ellyjones@chromium.org Bug: 1141271 Change-Id: Ifbda96854d6b9658dd27c5d1f90f92e39347fd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491701 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Shubham Aggarwal authored
We prefer having constant default values to be listed alongside the data member declaration instead of in the constructor. This is a purely stylistic change and should not have any functional effect. Change-Id: If4ad7be6e73ff52e92258452fe86a7b3a7f790b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490860Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819698}
-
Alexander Dunaev authored
This CL enables the test that was X11-only. Bug: 1109112 Change-Id: I5fdafac9de0715f8400dad9a5a724f50128db09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466758Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Hoch Hochkeppel authored
Adding a class to represent the Windows StorageFileStatics class within tests, as well as basic unit tests to validate the test class behaviors. The class behaves similarly to the Windows equivalent, except it includes gtest validations for expected usage, schedules all async operations through a ThreadTaskRunner, and does not implement methods that fall outside the expected usage. Bug: 1035527 Change-Id: Ia3439718cb02773e7a6c6835adcdbc807f47a383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491050Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819696}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/0ce070474164..8f7c80347dc6 2020-10-21 sarahmashay@google.com [validation] Improve CTS test wrapper. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I91c4c617b0424687924e2e4e907c9a58c17af91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491125Reviewed-by:
-
Joel Hockey authored
On the first time in each FilesApp session that a file is deleted, the current contents of the related trash are checked and any files older than 30d are permanently deleted. Bug: 953310 Change-Id: I8d34c3333152bc690652d070bff0d2f34b6ef1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490960 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#819694}
-
Joel Hockey authored
In order to interoperate with other crostini file managers, we will use $HOME/.local/share/Trash as the crostini trashdir, and also prefix all Paths with the $HOME remote mount path. Bug: 953310 Change-Id: I6148dfcc5d240ae1959d0bf00698b882822b97e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477706 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Matt Menke authored
Add NIK parameter to ReportingService::QueueReport(). Bug: 993805 TBR: msramek@chromium.org Change-Id: Ie3181f2a1ae43e0dd7c38833a3d364d63ef8ce3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485392Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Chan Li authored
It breaks "Build Recipes Tester" Bug: 1141272 Change-Id: I24708d22aea1852ddb08fe105d48c65727738d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491681Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819691}
-
Tomasz Tylenda authored
This is a follow-up on a comment in crrev.com/c/2463051. In nss_context.cc we make GetNSSCertDatabaseForProfile take OnceCallback instead of RepeatingCallback. This is possible, because the callback will be used only once in GetCertDBOnIOThread. We then make all callers use base::BindOnce. BUG=764795 TESTED=build Change-Id: I9120f3c4d0ff70be2dc6c146295a40cc4db17bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484069Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#819690}
-
Brian Sheedy authored
Adds/ignores some additional tags that were found being produced by GPU tests. Bug: 1111876, 1011107 Change-Id: I859b6f61ff9011819daf3fe73811456b352ee1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481908 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
These tests do not intend to have failed navigations, but they actually failed silently, mostly due to 404s because of bad URLs. Soon (after crrev.com/c/2487024 lands) these tests will actually fail and result in error pages. See navigation-dev thread for more context: https://groups.google.com/a/chromium.org/g/navigation-dev/c/WbNkf2alpPU/m/2tQQ-cXWBgAJ Bug:1133115 Change-Id: Ib75a04aa90635b9eb778ce2da56fcee83965b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483748 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819688}
-
Nic Hollingum authored
This reverts commit b6deb469. Reason for revert: Deterministically breaks linux-chromeos-dbg, e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20956 Original change's description: > cbui crostini: refactor away CrostiniAppRestartView > > This change removes CrostiniAppRestartView, replacing it with: > * Construction and configuration of a bare View + DialogDelegate pair > * A pair of public functions that create and show this dialog > > This change also adds some unit test coverage for this dialog to > ensure that I didn't break it when doing this refactor. > > Bug: 1075649 > Change-Id: I7de0e2386de14aa6aec8917c630f64a69df26832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819545} TBR=ellyjones@chromium.org,joelhockey@chromium.org Change-Id: I230664fa24b78125632310bf05edd6a3d219f18b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490971Reviewed-by:
Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#819687}
-
