- 18 Jun, 2019 40 commits
-
-
li authored
supported_proivder_type will be used to change the behavior of OPEN_APP action and Android media action. Currently, we always send ANDROID_APP as supported_provider_types which enables launching media intent. The plan is to rollout in M77 instead of M76. This changes will be cherrypicked into M76 to disable the feature in M76 and enable with a finch experiment. Bug: b:135487605 Test: Manual Change-Id: Ia07ccf425126be9433c7d4043f3780dd39107713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663396Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670132}
-
Mark Cogan authored
This CL removes unneeded includes from tab.h and tab.mm, and removes unneeded dependencies from tabs/BUILD.gn. Forward declarations were added to tab_private.h and tab_view_delegate.h to correct for types that were coincidentally included alongside them. Change-Id: I8ba0a260cede6212935308414f46a28c47db1ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664073 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#670131}
-
Yasmin authored
Bug: 972063 Change-Id: Iae4119912493dcc796eb7d7d5b0e2502442b6f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663138Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670130}
-
Ian Kilpatrick authored
This uses a rare-data pattern to reduce the size of a layout result. On 64-bit machines this is almost a 50% reduction (120 -> 64). On 32-bit machines I think this reduces it to 48. There is a slight (~1%) performance regression on microbenchmarks due to this change. Bug: 962108 Change-Id: Ia673fa34b986f851c53b6becc44025e16891d12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648887 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670129}
-
Daniel McArdle authored
Now invoking CRLSet::CheckSPKI, CRLSet::CheckSerial, and CRLSet::IsExpired(). Change-Id: Id4586bfbd42e45d7d917822cf2a30ef6d1eafa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648826 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#670128}
-
Darwin Huang authored
This reverts commit 3fb285c9. Reason for revert: "This does break tests in 32-bit/dbg/linux, but that's a config we don't care about and that we're removing the bot for. The previous clang had codegen issues on arm64/ios which is a platform we do care about" Original change's description: > Revert "Roll clang 362913:363450." > > This reverts commit 76c3585f. > > Reason for revert: The clang roll is causing a lot of test failures from interactions with Skia, and causing reduced test coverage/red bots. > > Original change's description: > > Roll clang 362913:363450. > > > > Ran `tools/clang/scripts/upload_revision.py 49b965079b18f8aa485dd1156dd088d40b7ee465`. > > > > TBR=hans > > > > Bug: 974267 > > Change-Id: If292a3e2317da54558f02275a84aefead03aad9d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660964 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669515} > > TBR=thakis@chromium.org,hans@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 974542 > Change-Id: I0feae2b830dfada03388d77f366934825497516a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663740 > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669965} TBR=thakis@chromium.org,hans@chromium.org,huangdarwin@chromium.org Change-Id: I58b4ee33151f0b905ecfa48e5e83f6b5f2f44263 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664992Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670127}
-
Morten Stenshorne authored
This is about an undocumented quirk. I raised https://github.com/whatwg/quirks/issues/46 for it. LayoutNG currently cannot handle this situation, because we don't store the inline-size to use in replaced percentage resolution (only the block-size). However, I find it hard to believe that there'd be any specific expectations to how this is supposed to work if a table cell has a definite block-size, and a descendant establishes an orthogonal writing-mode root. So just ignore it and use regular percentage size resolution in these cases. Bug: 967069 Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#670126}
-
Becca Hughes authored
value_or seems to be causing a crash when we call UpdateForegroundColor. If we remove them then this should fix the crash. BUG=974866 Change-Id: Iead32cb863ae28fe10cb66552edc89af74ca0cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664635 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#670125}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df7d31c06e36..c0d17117afe9 git log df7d31c06e36..c0d17117afe9 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 lalitm@google.com metrics: Fix metric protos Created with: gclient setdep -r src/third_party/perfetto@c0d17117afe9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iedab37405bf4ec81e715e3c168ce26edd3791aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670124}
-
Ryan Sleevi authored
These metrics are used for internal dashboarding. BUG=975870 Change-Id: Ieae3e7ca5e89cad391912b0d2c2b9c5e88aa9569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663077Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#670123}
-
Sébastien Marchand authored
This reverts commit 343f32e3. Reason for revert: crbug.com/976241 Original change's description: > Hook up the delay load failure function in the renderer processes. > > This allows getting a crash report when failing to delay load a DLL. > > Example of the stack trace that this will provide: > chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28] > chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939] > chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\content\renderer\renderer_main_platform_delegate_win.cc @ 37] > chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305] > chrome_child!RtlUnwind+0x470 > chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164] > chrome_child!blink::DWriteVersionSupportsVariations+0x7f > chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc > > Bug: 970893 > Change-Id: I922d5a3f7e62c7e25f954405bedd967678dd7a50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655909 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669339} TBR=dcheng@chromium.org,wfh@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 970893 Change-Id: I6a7dfd2ae97d6538d65888c04d8af36a356ae7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663363Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#670122}
-
Mason Freed authored
This reverts commit 9d54112e. Reason for revert: This was only needed for Beta. Original change's description: > Fix the use of RENDERER_SKIA_VK where it isn't supported > > Prior to this CL, the build was broken for Windows Arm64 and > Windows x86, and Jumbo/non-Jumbo builds. See comment at [1]. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1660122 > > Change-Id: I2cc0a84dd94f119c11a556c9670c261ca3086e6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660958 > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669408} TBR=ericrk@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I28b154a5154edabd7779661bea67c047b109da3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663176Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#670121}
-
Danton Vu authored
See the video here: https://photos.app.goo.gl/VMTsEWxSmzfqfuGJ6 When there's only one window, the highlight is movable with keyboard arrow keys. It shouldn't animate, or the animation should be different (bump for example). R=sammiequon@chromium.org Bug: 970319 Test: manual Change-Id: I8c43c7fdedc5ba042f7c0ae1eb2032602ada033c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663533 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#670120}
-
Dominik Röttsches authored
Carry over a few known expected fonts we have in font_fallback_win.cc on the Blink side. Bug: 947059 Change-Id: I9811ac33cc2bc65d35df283999812080ac93bc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664148 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#670119}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c34d993b62a5..f91aeb259e09 git log c34d993b62a5..f91aeb259e09 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 egdaniel@google.com Move a bunch of gpu files out of include/private and into src/gpu. 2019-06-18 borenet@google.com [infra] Fix Go builds 2019-06-18 fmalita@chromium.org [skottie] Add support for motion tile phase 2019-06-18 rmistry@google.com [skottie-wasm-perf] Command line application to measure perf 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ed2c978cdeef..d7303797becf (1 commits) 2019-06-18 rmistry@google.com [skottie-wasm-perf] Date.now() has millisecs precision, we need microsecs Created with: gclient setdep -r src/third_party/skia@f91aeb259e09 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I268282c25f891873ae426e2180a3c800fdb76232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663683Reviewed-by:
-
Jérôme Lebel authored
-[SigninInteractionControllerTestCase testDismissSigninFromSettings] -[SigninInteractionControllerTestCase testDismissAdvancedSigninSettingsFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromBookmarks] -[SigninInteractionControllerTestCase testDismissAdvancedSigninBookmarksFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromRecentTabs] -[SigninInteractionControllerTestCase testDismissSigninFromRecentTabsFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcher] -[SigninInteractionControllerTestCase testDismissSigninFromTabSwitcherFromAdvancedSigninSettings] -[SigninInteractionControllerTestCase assertOpenURLWhenSigninFromView:tapSettingsLink:] Related to: crrev.com/c/1626860 Change-Id: Ice0e675926141d2a6b59fdeba3a3f80d8215bd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664551Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#670117}
-
Matt Falkenhagen authored
Removes: * ServiceWorker.URLRequestJob.FallbackedRequestMode * ServiceWorker.URLRequestJob.MainResource.Result * ServiceWorker.URLRequestJob.MainResource.StatusZeroError * ServiceWorker.URLRequestJob.Subresource.Result * ServiceWorker.URLRequestJob.Subresource.StatusZeroError This is dead code following the launch of S13nServiceWorker. Bug: 975818, 975435, 975331, 926114 Change-Id: Ia75a4627e7c0d7bc872e9e2f4bccb4fdd1abecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663458 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670116}
-
Pavel Yatsuk authored
Currently sync state is requested from AndroidSyncSettings. This class only reflects local Android sync settings and doesn't get updated if sync is disabled for dasher account by domain administrator. ProfileSyncService#canSyncFeatureStart is the correct method to check if sync is enabled. Correspondingly IdentityDiscController should observe sync state through ProfileSyncService.SyncStateChangedListener. BUG=976089 R=mastiz@chromium.org,twellington@chromium.org Change-Id: Ibe1913c6743d1c6438945f0391ac8a21bfb03f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663376Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#670115}
-
Jarryd authored
Change-Id: I711684a8eb8d87a512851b7d2165ec15d7001775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663372 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#670114}
-
Bryan McQuade authored
Now that amp_page_load_metrics_observer has been updated to use the new loading behavior based logic, we can migrate the custom AMP UKM observer back into this file, so all AMP metrics are tracked in a single location. This is just a cleanup/refactor, with no change in logic. Change-Id: Id50bbbddd4301f8f852f3ea16c3e50ef0eb8b4ba Bug: 939333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643649 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#670113}
-
Vasilii Sukhanov authored
The password manager team doesn't look at it. Bug: 975214 Change-Id: I96117b5e082f70a4b2860ba17ce02737b57a58ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664146 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Antonio Gomes authored
Driven by CL. The removed whitelisted files seem not needed anymore. BUG=None R=blundell@chromium.org Change-Id: I53dc5264c6bf4faa1da6e1b74e2be8ff4c9627f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664570 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#670111}
-
Kristyn Hamasaki authored
Updated protocol and CSSAgent to send matched style to the front end from UI Devtools. This will allow for the feature of grouping properties in the elements pane. Bug: 973698 Change-Id: I3895a6c0b5beaf3c988e20afcf3cf90d50541560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657352Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#670110}
-
Lei Zhang authored
Defer to M77, as we will evaluate the entire PrintPreview.PageCount family of histograms. BUG=965239 Change-Id: I83af8b4e297283cfed05aa47be47d234b2254426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663557Reviewed-by:
-
Yi Su authored
//ios/web/web_state/ui/favicon_util* are responsible for parsing the js message that contains favicon URLs. This CL moves them into //ios/web/favicon. Bug: 942244 Change-Id: I9c326d924d2915b5a851590e39c13133793363c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663508Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#670108}
-
Nicolas Ouellet-payeur authored
All the histograms are set to expire in 1 year. Since most histograms didn't have an expiry date yet, this CL also adds one. Bug: 975169 Change-Id: I6294b0c47795a96d3f131e94f1151c689d01480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664513Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#670107}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/27c30ec671..8f11724067 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/27c30ec671..8f11724067 Manual change: Abseil is migrating to ABSL_ prefixed thread annotations, in order to do so, a backwards compatible absl/base/internal/thread_annotations.h has been created (with unprefixed thread annotations). This file is excluded from this CL because unprefixed thread annotations are problematic to Chromium and they were in fact prefixed by [1] during every roll. [1] - https://cs.chromium.org/chromium/src/third_party/abseil-cpp/rename_annotations.sh?l=130-165&rcl=0ec2bec15811f730af0ad00cb3a30b9bc86d821d Bug: None Change-Id: Idc60ee93f6354f70e1d24114836d8b4ce8ea9179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663135 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#670106}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59919fb1..17007c11 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55900a8d12d19e9db7e795eb50660d47e5f7043b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663889Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670105}
-
Adam Raine authored
RegisterMainThreadDocumentPaint definition now handles the case where a definiton registered on the worklet thread is different from a definiton on the main thread with the same name. In this case, the reference in document_definiton_map_ is set to null. Bug: 948761 Change-Id: Ic969e2faf09c66013d79ab9ae8966befdf263432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662531 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670104}
-
Devlin Cronin authored
These metrics are useful in tracking general extension usage, and serve as user and ecosystem signals. They should never expire. Mark the following histograms as never-expiring: Extensions.HasPermissions_Install3 Extensions.HasPermissions_Load3 Extensions.IncognitoAllowed Extensions.InstallType Extensions.LoadAll Extensions.LoadApp Extensions.LoadAppExternal Extensions.LoadExtension Extensions.LoadExtensionExternal Extensions.LoadExternal Extensions.LoadHostedApp Extensions.LoadPackagedApp Extensions.LoadPlatformApp Extensions.ManifestVersion Extensions.NonWebstoreLocation Bug: 975615, 975602, 975508, 975464, 975451, 975413, 974957 Change-Id: I33f98aa1753c197b171415cc28ffdd13cbfb870b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663319Reviewed-by:
-
Vasilii Sukhanov authored
The histogram shows if someone uses import. Bug: 975614 Change-Id: I63f8288449e11d1cd8e2a0f48dd380c5dcc99e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663418 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL sets two histograms of LargeIconService to never expire as these histograms proved to be really useful when planning UX changes in the past. The favicons landscape in the wild changes constantly and thus it is better to keep recording this to have up-to-date measurements. Bug: 975727 Change-Id: Iedf282fbfb4d16435776111f3e37f5e6d77eb3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663130Reviewed-by:
-
Daniel Vogelheim authored
Bug: 933300 Change-Id: I58e72faa9f5cdbd0390c84842cc5d5641d0b7d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634880Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#670100}
-
Ryan Sleevi authored
This histogram was introduced when it was not guaranteed that the Android trust store would be available at the "AndroidCAStore" KeyStore, which was needed for determining if a given CA was part of the system base image. The combination of CTS, plus Chromium moving to use the //net/data/ssl/root_stores index as a cross-plat way of determining known root largely obviates the concerns. BUG=975152 Change-Id: If9211e6ed22f45042380bcce25b9ccd28057b707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663078Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#670099}
-
Scott Haseley authored
The recently added (crrev.com/c/1435840) frame scheduler best effort task queue was missing a couple initialization steps, namely the frame scheduler was not associated with the task queue and the FrameTaskQueueController::TaskQueueCreated was not called on the task queue. This can prevent frame scheduler policy changes from being applied to this task queue and potentially other subtle bugs. This CL adds the missing initialization steps and adds test coverage for initialization of this task queue and the recently added inspector task queue. Change-Id: Iedb2c1e1bc778bce51c5d72748eb743dc3dd6f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639544Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#670098}
-
Sky Malice authored
Bug: 974861 Change-Id: Ib56b8f6e260e1fd4d7c1f3ad3732450fe55eb2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663019Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#670097}
-
Stephen Chenney authored
Updating scroll offsets from CC to Blink leads to mismatched offsets when the property tree is not actually committed, as is the case when deferring commits for Paint Holding. Disable scroll offsets when not committing to avoid this issue. Bug: 952585 Change-Id: Ief8fa51386d856d9c7fca7283900c94f397531c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663378Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#670096}
-
Henrique Nakashima authored
These metrics are still needed and will be needed for the upcoming experiment of OfflinePrefetch in Reduced Mode, which should be in M77. Bug: 974915 Change-Id: I74ed0c3761657685dadba1f122d4a3c9c10bff8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663033 Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Bug: 973441 Change-Id: Ie3c81ca941d4fca2673c230ea12539fc9482b127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663360 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#670094}
-
Hirokazu Honda authored
VideoPixelFormatToGfxBufferFormat() crashes if a given pixel format is not supported by the function. The function should allow to be called with an unsupported pixel format because Chrome may try to create NativePixmap with VideoPixelFormat that doesn't have equivalent gfx::BufferFormat. Bug: chromium:971943 Test: None Change-Id: Ia7a9761352919e891e1589e26c4deaab2f66ccf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655568 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#670093}
-
