- 23 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/659a8ea9f3a9..3367690414ae git log 659a8ea9f3a9..3367690414ae --date=short --no-merges --format='%ad %ae %s' 2019-08-23 dneto@google.com GN build: enable HLSL in Glslang (#789) Created with: gclient setdep -r src/third_party/shaderc/src@3367690414ae The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I93fd65ae2ac50c7cc39ed6047886c952ada87867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690084}
-
Xing Liu authored
This CL adds a few metrics for user impression updates in notification scheduling system. TBR=dtrainor@chromium.org Bug: 963298 Change-Id: I2707ebec3df1b371e23c2d99eb132a55b7c716aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764322 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#690083}
-
Evan Stade authored
Despite the general-sounding name, this was only sent by ChromeUserManagerImpl after the list of device local accounts changed, or after cleaning up some ephemeral accounts. This changes ChromeUserManagerImpl to use NotifyLocalStateChanged() in those cases. This CL also cleans up the prefs a bit: 1. the pref name "LoggedInUsers" is shared between UserManager and ChromeUserManagerImpl, instead of duplicated. 2. the "PublicAccounts" pref, aka kDeviceLocalAccounts, is renamed and more documentation is added to clarify its use. A test is added to verify that it's functioning as intended. TBR=bartfab@chromium.org Bug: 268984 Change-Id: Id99b6a11e51058c0e0d36fc294846c102abf6b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758938Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#690082}
-
Matt Menke authored
It never really worked in the H2/QUIC case, returning the bogus HTTP/1.1 headers instead, didn't return anything in the cache case, and didn't return anything until a request was actually sent, which could (and did) lead to misuse. Fortunately, with the advent of the NetworkService, it's now only used in tests, so can fairly easily be removed. Bug: 455744 Change-Id: I1bc0c69acbf85409a71faed774c02baefc4f08a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769048Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#690081}
-
Tibor Goldschwendt authored
This target will be used in future CLs to generate APKS archives for bundle smoke tests. Bug: 989654 Change-Id: I1ba0063d7c9ce93ec60a4403ce3ca158c36b3451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768919 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#690080}
-
Mitsuru Oshima authored
Bug: None Test: No functional change Change-Id: I0ee6f733246f3e4473e8837842e66b67a7a3532b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703365 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690079}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7d425404bf4..83c24aa8a1cd git log d7d425404bf4..83c24aa8a1cd --date=short --no-merges --format='%ad %ae %s' 2019-08-23 jmadill@chromium.org Vulkan: Reference Context fences in FenceSyncVk. 2019-08-23 geofflang@chromium.org Only log D3D11 annotations from the thread used to initialize the annotator. Created with: gclient setdep -r src/third_party/angle@83c24aa8a1cd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:995888,chromium:972914 Change-Id: I94829e7d277cf94bba8d30a6af99893cdd546e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690078}
-
Brian Geffon authored
Change-Id: I7278157e2135a4cdcc34a10c2ce2a983288889b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768784Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#690077}
-
Sanket Joshi authored
This change adds functionality to move the color selection ring through the color well and hue slider via keyboard input. The user can press the up/down/right/left arrows to move the ring in the corresponding direction. The user can also press ctrl+[arrow key] to perform an accelerated movement. The accelerated movement is particularly useful for the color well as it takes time to navigate from one end of the color well to the other with just the standard keyboard movement. Bug: 994437 Change-Id: Idfef70adf443f8576f83dc9e6c9347a0d320b768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757159 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#690076}
-
Rodney Ding authored
Bug: 951807 Change-Id: Iea14dadc17791f222fb3206eff67d9293e4285e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764318Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#690075}
-
Evan Stade authored
This patch changes SessionManagerObserver::OnPrimaryUserSessionStarted to notify for non-primary user sessions as well. This makes it align with NOTIFICATION_SESSION_STARTED. Two notification observers are updated: - LocaleChangeGuard - first_run.cc (some dead code is also deleted) On[Primary]UserSessionStarted(), and NOTIFICATION_SESSION_STARTED, are different from UserSessionStateObserver::OnActiveUserChanged in that they are called when the UI is fully ready. This is appropriate for the two observers that are updated in this CL, both of which want to show UI right after login. Bug: 268984 Change-Id: Iac5ba9541e99a74a29758db6e3c678e1dcbfa630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767494Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#690074}
-
Dominik Laskowski authored
OutputProtectionImpl may create (via OutputProtectionProxy) an OutputProtectionDelegate with a null aura::Window* if the RenderFrameHost is no longer alive while responding to a Mojo request. Run failure callbacks in that case. Bug: 987051 Test: None (sporadic crash with no repro steps) Change-Id: I0b854aacdcdb553e349416cff76662d273d17e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737367 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#690073}
-
Sofiya Semenova authored
based on the area rank of the URLs and not on their navigation scores. Bug: 995600 Change-Id: I2f043cf1859b0b335b0f672b9ffc2b93c3e65c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761429Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Sofiya Semenova <sofiyase@google.com> Cr-Commit-Position: refs/heads/master@{#690072}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b408a71b6999..fad1fa1b3234 git log b408a71b6999..fad1fa1b3234 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 jorgelo@chromium.org usergroup_baseline: Fix OWNERS 2019-08-23 saklein@chromium.org UprevVersionedPackage: Add new version to output. Created with: gclient setdep -r src/third_party/chromite@fad1fa1b3234 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia63aa99d17ed4d5ace2e1ac7cda22e0500d6dedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690071}
-
Jacob DeWitt authored
Update the test API with a new controller role kControllerRoleVoice which allows simulating voice input when using the mock WMR wrappers. The test is just simulating a voice select and makes sure the event is registered by the JS. Bug: 990892 Change-Id: I78d1f765780b42eb571fe290f6d61f664e3298f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769050 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#690070}
-
Patrick Monette authored
Bug: 993029 Change-Id: I5d284c84ac16b1ac6ba708481d283402a88140cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764401Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#690069}
-
Maggie Chen authored
This reverts commit 2f859102. Reason for revert: <This CL causes access violation crashes in gpu::GpuInit::InitializeAndStartSandbox> Original change's description: > Fix a GPU watchdog V2 DCHECK in GPU initialization > > A DCHECK is triggered in GpuWatchdogThreadImplV2::Arm() during GPU > initialization. Whenever there is an error, GpuInit::InitializeAndStartSandbox() > exits earlier. watchdog_thread_->OnInitComplete() is not called in those cases > and arm_disarm_counter_ gets messed up. > A new class GpuWatchdogInit is created to call OnInitcomplete() in the destructor. > OnInitComplete() will never be missed at the end of InitializeAndStartSandbox(). > > Bug:949839, 995372 > > Change-Id: I1a107df0ca48409ff2252260ea41de643fa39b6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762879 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689343} TBR=zmo@chromium.org,magchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949839, 997119 Change-Id: I80de6494321557a4aaaa0eaa8f335b8b558e9664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769221Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690068}
-
Alex Cooper authored
Currently it returns a promise, but per the spec it should be void. Bug: 997305 Change-Id: If8af8e9e184209f5baafd4210ac58b358c7469eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768552 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#690067}
-
Patrick Monette authored
Also exposed accessors for the dev tools token and renamed WorkerNode::GetType() to GetWorkerType() to better differentiate with the graph node type. Bug: 993029 Change-Id: I951c222dc107fb0337712c3c202e6876b68a17d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769177Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#690066}
-
Patrick Noland authored
Bug: 996947 Change-Id: Ic5d588456dd807e7658557d66e3bf4670b11b16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766457Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#690065}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iba2b15f31402631ba7a84d7c8538237c03e490c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690064}
-
Reid Kleckner authored
Apparently is_asan = true implies win_console_app = true. Fix for https://crrev.com/689827 TBR=jam@chromium.org Change-Id: I422b59c25d4c1f99d5328ab1809c0f1733e96c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769223Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#690063}
-
Brandon Maslen authored
This will enable starting the implementation of the Storage Access API behind these flags. Bug: 989663 Change-Id: I790b107ea52a28796c69729dc7cd417fd9d08d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763266 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#690062}
-
John Chen authored
Remove negative filter for tests that have been fixed or disabled by Selenium, and move one test to ready-to-run filter. See https://crbug.com/chromedriver/2858#c3 for more details. NOTRY=true Bug: chromedriver:2858 Change-Id: If75d34c83e2b5bea70b27f7c8ef780fcbe3786fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769528 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#690061}
-
Will Harris authored
Whether to enable/disable is checked on the launcher thread in content. But the actual flag is only accessible on the main thread from chrome, so the plumbing in render_process_host and content_browser_client exists to wire these two together. BUG=750886 TEST=set policy, check renderers start without CIG. Change-Id: I2ea2286d9e244734abe15b9f8beb62b3f97ffd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758589 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#690060}
-
Tommy Li authored
This CL just addresses some minor leftover cleanups from this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1761063 Bug: 995393 Change-Id: I099d20fdf5ff593e22c392f74f6f937dea4c97b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768667Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#690059}
-
Majid Valipour authored
The virtual test suite was removed in [1]. These expectations files are no longer needed. [1] https://chromium.googlesource.com/chromium/src/+/31676667da8670621530457a4b5ea1a10eafe585 R=pdr@chromium.org Bug: 989251 Change-Id: I74cba4ce4f8ddf4d2e5d7c7ad11016292d9022dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769520 Auto-Submit: Majid Valipour <majidvp@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690058}
-
Dave Tapuska authored
Spec change https://github.com/whatwg/html/pull/4787 This change marks navigations from the renderer indicating if they are originating from script. If they are from script (as opposed to the back and forward button default event handlers) they will be subject to the top level navigation sandbox flag. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/jOa27iZPJtg/2ArNlXIBBAAJ BUG=705583 Change-Id: I5169b54df63a30e252566398b139a7db187eaa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729530Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#690057}
-
Antonio Gomes authored
... since both callee and caller sites run on the same thread (assured by THREAD_CHECKER). This was spotted by jbroman@ in [1] [1] https://crrev.com/c/1768778/5/third_party/blink/renderer/modules/mediastream/apply_constraints_processor.cc#b23 BUG=704136 R=guidou@chromium.org, jbroman@chromium.org Change-Id: Ifd9f06a490a469926acb778917ba23aaf11f9927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768787 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#690056}
-
Gayane Petrosyan authored
When opening the color picker second time, it is init by |customize.customColorPicked| and therefore selecting the same color doesn't trigger color change event. Reset |customize.customColorPicked| the same time when rest of the color picker related values are reset. Bug: 997120 Change-Id: I494c0a718c0389986de9014603b41754d0299ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769297Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#690055}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a0ed070aa0c7..9313874349dd git log a0ed070aa0c7..9313874349dd --date=short --no-merges --format='%ad %ae %s' 2019-08-23 egdaniel@google.com Rename GrContextOption fReduceOpListSplitting to fReduceOpsTaskSplitting. 2019-08-23 mtklein@google.com track SkNoPixelsDevice's origin 2019-08-23 reed@google.com remove redundant rect methods 2019-08-23 senorblanco@chromium.org Dawn: implement a ring buffer for uniform uploads. 2019-08-23 csmartdalton@google.com Don't pass around renderTargetContexts from onFlush callbacks Created with: gclient setdep -r src/third_party/skia@9313874349dd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I512d3e7f3ab3a49018ee7bca8ff015fb1b2eb75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690054}
-
Bret Sepulveda authored
If a tab wants to move to model index to the left of the leftmost tab in a group, where it should end up in TabStripLayoutHelper::slots_ is ambiguous. If it is in the same group as the grouped tab, it should go to the right of the header so the group remains contiguous. But if not, it should go to the left. To disambiguate this case, GetSlotIndexForTabModelIndex now takes the group of the tab at |model_index| as a parameter. It cannot look up the Tab* in TabStrip::tabs_ in the general case, since it might be called in the middle of processing a MoveTab or RemoveTab, where the model indices have already been updated in that data structure. Bug: 989964 Change-Id: I2f35218d01c8398e6e024096bd35244ca67ca330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764181 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#690053}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3726d98. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iedef9a3ff0deea645f9057457767b15988398eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768786Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690052}
-
Naoki Fukino authored
This adds a list of external storages (e.g. USB sticks) in Settings > Device > Storage management > External storage preference. Each entry for an external storage has an toggle switch. If a user enables the switch, the corresponding storage becomes visible to Android apps, which means that Android apps can read/write files on the storage. The list of enabled storage's UUIDs will be kept in a preference. design doc: go/arc-visible-external-volumes Bug: 954228 Test: Manual test on with multiple USB devices attached to Kevin. Change-Id: I75abc8b527c8fdf35d0b325338845603558f53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763553Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#690051}
-
Rouslan Solomakhin authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JwSN1yEVvnk Bug: 861704, 967867 Change-Id: I1b58befba0838a6a14762e8846c10c8a4a752ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756764 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#690050}
-
Brandon Jones authored
Bug: 996949 Change-Id: Ifd918931d1c4a8ad976655230efb1f5e70f53956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766601Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#690049}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9499165e..be1d8500 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40732f8d6ea0e164034695705840ad43e3712749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768785Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690048}
-
enne authored
This reverts commit 9c5df46a. Reason for revert: timing out tests Original change's description: > Enable a new SYSTEM background tracing mode. > > This mode will allow us to set up a background scenario and deliver > triggers to the system when something interesting is happening. Which > will allow us to only upload traces that are of interest. > > Bug: 979583 > Change-Id: Ic48ea08e3f9fafccaf045847cc0ddfa76d11611c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760736 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689563} TBR=avi@chromium.org,oysteine@chromium.org,eseckler@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979583,997206 Change-Id: I51889cecfdc1ac392fb199b1a190b14880801e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768981Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#690047}
-
Hesen Zhang authored
- Support IconConverter to return a bundle of success result and data. Bug: 963290 Change-Id: I50d2908047aa1554d7d3c5a3ba2f1bf913c03d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762819 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690046}
-
Sebastien Marchand authored
The service stores a Mojo interface pointer in a TLS slot for each thread that want to use this service. This is invalid because the InterfacePtr class has sequence affinity and is thread hostile. Bug: 995459 Change-Id: Icd1912998a11aa198415ec2657771a1cb57fa54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762486Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#690045}
-