- 22 Oct, 2019 40 commits
-
-
Nico Weber authored
This reverts commit b51cfae0. Reason for revert: Breaks deterministic bots, https://crbug.com/1016240 Original change's description: > Update Crashpad to 661a07a41b8809b9df32914c11542a0c76e709d5 > > 2fb4e9e6a432 mac: Update the process_types version of > dyld_all_image_infos for 10.15 > c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST() > d8f85829b07b linux: fix split stack test > 7289acb78a6d linux: don't assume vdso exists > 47a342133d60 linux: use boringssl in chromium > 661a07a41b88 linux: add deps for boringssl in chromium > > Change-Id: Iae1ed525a228c4de3b879ac06097fd026ea01004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869397 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707418} TBR=jperaza@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I211945fef0f4949c747771e10dc9584da2d0355d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871832Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708310}
-
Min Qin authored
This reverts commit d6c08063. Reason for revert: This CL is coupled with https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1999437, so please wait for both to land Original change's description: > Revert "Move some java download files to chrome/browser/download/android" > > This reverts commit 4812124d. > > Reason for revert: Suspect causing build failure android_arm64-builder-perf > https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/122367 > > Original change's description: > > Move some java download files to chrome/browser/download/android > > > > This CL moves the DirectoryOption and DownloadDirectoryProvider.java > > > > BUG=1013759 > > > > Change-Id: I78bef333bed85a4e34a70843caaf37ef1dbfa7de > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867192 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#708254} > > TBR=dtrainor@chromium.org,qinmin@chromium.org > > Change-Id: I6f219a56fe4ad9e4e5cde3b8acfca4c045a5bfc7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1013759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873281 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708299} TBR=dtrainor@chromium.org,qinmin@chromium.org,eirage@chromium.org Change-Id: Ie92a0b729d234ff50fabc4cd4ae0affaf51e9ce9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874327 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708309}
-
Fabrice de Gans-Riberi authored
Add fast/text/small-caps-aat.html to SmokeTests to ensure no further regression. Bug: 1015566 Change-Id: Ic36dd110ae1667aa5c37cef7a24768aaee2dad97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868982Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708308}
-
siyua authored
Logic for the dialog: 1. Show dialog when user has opted in, and after card verification starts. 2. If card is not eligible for fido, fall back to CVC, close the dialog. Card unmask prompt will be shown next. 3. If card is eligible for fido, close the dialog after card information is filled to the form. Uploaded screenshot in bug comment 21 Bug: 991037 Change-Id: Ibb32a03c491039664b0875ea40cc750f304e21b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834822Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#708307}
-
Vikas Soni authored
Re-enable AImageReader on ARM GPUs since few bug fixes related to memory regressions have been landed and we expect those fixes might have also fixed the crashes we were seeing with ARM GPUs. Will need to revert this CL if it causes crashes. Since the crashes are not reproducible locally, there is no other way to test this expect removing the GPU family from the blacklist and hence enabling it on ToT. Bug: 1013797 Change-Id: I3402d049e06824284c3b9836fd05ebe03754b43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873393Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708306}
-
rbpotter authored
Since we have decided to instead migrate to Polymer 3: - Remove the HTML imports polyfill from downloads, extensions, and Print Preview - Remove test changes that were made to support the polyfill - Remove changes to optimize_webui.py that were made to optimize pages using the polyfill Bug: 925517, 965770 Change-Id: I531bd3cf7814cb3ca5a32aa80b38f4e1ec16ede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873146Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708305}
-
Tommy Li authored
No one likes the current confirmation dialog. Begin experimentation without one. This CL puts in a new flag that can swap on and off the confirm dialog. The flag is set up so that there is NO confirm dialog by default. This is the same as how the NTP version: ConfirmNtpSuggestionRemovals. Bug: 1016514, 929477, 1205 Change-Id: If158e10da3fbdccc847aafe5221fad57c5c3639b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872182 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#708304}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I956cb37b753b2983f90dd4750dfdb7e692c2d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873917 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708303}
-
Christopher Thompson authored
This also adds unit-tests for SecurityStatePageLoadMetricsObserver. Bug: 1016105 Change-Id: I0bcb5720a1c489632a762e40ed93b7ec4f239bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873211 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#708302}
-
Anastasia Helfinstein authored
This change is an overhaul of how navigation between elements onscreen is handled. The design doc can be found at go/cros-switch-navigation. TL;DR each time we enter or exit a group, we construct an SARootNode for the group and an SAChildNode for each of its children. This is instead of dynamically calculating the elements of the group on each navigation event. Bug: 1011630 Change-Id: I264c1c3c9ef36fcb0d98327cd2e5fcc671b7f9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843214Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#708301}
-
Andrew Grieve authored
Small build speed improvement. Bug: 937005, 1016846 Change-Id: I126ec5fbd3652f843bfb56b185cae8209bf6fe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874186Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708300}
-
Ella Ge authored
This reverts commit 4812124d. Reason for revert: Suspect causing build failure android_arm64-builder-perf https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/122367 Original change's description: > Move some java download files to chrome/browser/download/android > > This CL moves the DirectoryOption and DownloadDirectoryProvider.java > > BUG=1013759 > > Change-Id: I78bef333bed85a4e34a70843caaf37ef1dbfa7de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867192 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708254} TBR=dtrainor@chromium.org,qinmin@chromium.org Change-Id: I6f219a56fe4ad9e4e5cde3b8acfca4c045a5bfc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873281Reviewed-by:
-
Jamie Madill authored
This reverts commit 2b7ca8e2. Reason for revert: Failed again https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%2032%20Vk%20Release%20%28Pixel%202%29/85753 https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%2064%20Vk%20Release%20%28Pixel%202%29/81952 Original change's description: > [base] Ensure that tests don't change the thread priority (reland). > > This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1804786. > The difference is that we don't check thread priority in > angle_deqp_tests_main, as these tests do change thread priority > on purpose. > > This CL verifies that the thread priority is normal when a test process > is launched and before/after each test. The goal is to avoid having > tests that assume they run at normal priority be disabled because of > other misbehaving tests (e.g. https://crbug.com/931706). > > TBR=sky@chromium.org,michaelpg@chromium.org,thakis@chromium.org,eseckler@chromium.org > > Bug: 931706 > Change-Id: I92a827d014278b1f5b3504f48c2441ad2e83bc65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865405 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708194} TBR=sky@chromium.org,gab@chromium.org,thakis@chromium.org,fdoray@chromium.org,zmo@chromium.org,michaelpg@chromium.org,eseckler@chromium.org Change-Id: Ie5084dea77cd119cd4e901c254c11d6f4dceefcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873501Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#708298}
-
Steven Bennetts authored
This WebUI does not appear to be referenced anywhere in the code. 'requestFlashInfo' is unimplemented. Bug: 1015978, 615739 Change-Id: I0cc34d01aa602d7669bfbd1473ae4ba14c898e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872927 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This histogram counts the number of backtracks performed in a single regexp execution. V8 CL: https://crrev.com/c/1873696 Bug: v8:9892 Change-Id: I6a49f0ea961c1f8b94a1fb1c6ced3605e226b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871601 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#708296}
-
Andrew Grieve authored
* Fully disables dex merging for library targets, speeding up builds. * Introduces sharding into incremental installs, dramatically speeding up launch times. * E.g. instead of ~250 dex files to load, shards into ~25 files. Bug: 937005, 1016846 Change-Id: I9a206145be196af61e55c4a25dcce3fbceb7190c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874046 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2c8b5c637028..7b3cc35cb6e5 git log 2c8b5c637028..7b3cc35cb6e5 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 enga@chromium.org D3D12/Vulkan: Insert storage buffer barriers between compute pass dipatches Created with: gclient setdep -r src/third_party/dawn@7b3cc35cb6e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic132fdb46c1e31235a37005961ab647079fcb1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708294}
-
Richard Knoll authored
Before: Number initiated from <origin> After: Number from <origin> Bug: 1016771 Change-Id: I5e8bf255c42b3fa2c86cd0d564f63bc500045346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871602Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708293}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13a8e162476b..a043b2ba46b9 git log 13a8e162476b..a043b2ba46b9 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 thaloun@chromium.org Support case where win32socketserver's window class is not unregistered properly. 2019-10-22 gustaf@webrtc.org AnalyzeReverseStream with StreamConfig 2019-10-22 kron@webrtc.org Add per frame decode time histograms for 4k/HD and VP9/H264 Created with: gclient setdep -r src/third_party/webrtc@a043b2ba46b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/140961297,chromium:1007526 Change-Id: I98321daa4f025b92f013ca794a90a158bc48df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873494Reviewed-by:
-
Ken Rockot authored
Bug: 977637 Change-Id: I3571dc612fe3d2c1e99094e1a65c755411ec09e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867442 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708291}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I549acc341bed90899ae9da460faa5cbb7d68216e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873127 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Ian Struiksma authored
Test recipe capture_update_pass_nexon expects the username to be stored on password update, which will only happen with new feature. Updating test code to ensure the feature flag is set on test setup. If it is preferred to not use this feature in the tests for now, let me know and I will update the test recipe. Bug: 959776 Change-Id: I306886fbb9daa0e434e5011ebd6aa80c1dfeac5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872732Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#708289}
-
Eric Karl authored
In cases where a SurfaceDrawQuad's root render pass was not merged into its parent, we did not correctly handle cases where the root render pass represented a subset of the SurfaceDrawQuad's area. This was possible in OOPIF cases where the root render pass was clipped to visible bounds. This CL adjusts the root render pass so that it always represents the full SurfaceDrawQuad area. While it's possible to hit this bug without de-jelly, this is much more common with de-jelly, so the change is restricted to reduce merge risk. A follow-up will implement this change more generally. Bug: 1016677, 995965 Change-Id: If733065277128d53f0b59483f167d177aa777f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873277 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#708288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f2b86c54d32..2638f3d44b02 git log 9f2b86c54d32..2638f3d44b02 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 bsalomon@google.com rename atlassize->atlasdimensions 2019-10-22 robertphillips@google.com Add creation-time POD memory pool for GrOps 2019-10-22 kjlubick@google.com [canvaskit] Expose various canvas features 2019-10-22 michaelludwig@google.com Revert "Enable Programs (formerly GLPrograms) test for other APIs" Created with: gclient setdep -r src/third_party/skia@2638f3d44b02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I0bbec02dd3d16355b6fa0e2249b390b4f4c126e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873492Reviewed-by:
-
liberato@chromium.org authored
Bug: 1016831 Change-Id: I11664e3a43e3eafae8fbc4db48d507e94cc119d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872576 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708286}
-
Joe DeBlasio authored
This CL removes everything Chrome-side for updating the Safety Tips component. It also addresses some nits in the proto file identified during internal review. See go/safety-tips-component-update for the updated instructions. Bug: 994270 Change-Id: Ic8d2b1573315f124728845078556307496e62f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873270 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708285}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0ce88df477b017468f27baa466f1744b6fa03eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873493Reviewed-by:
-
Lukasz Anforowicz authored
chrome.tabs.update is treated as renderer-initiated to address omnibox/url spoofing problems (see r698617). All renderer-initiated navigations need to have a non-null |initiator_origin| - the extension origin is used in case of chrome.tabs.update. The problem fixed by this CL, is that without explicitly specifying LoadURLParams::source_site_instance, the old SiteInstance of the navigated web contents might be used. In particular, when navigating a tab with https://example.com to about:blank, reusing the SiteInstance of https://example.com means that about:blank (with an origin associated with the extension) would commit in a process locked to https://example.com - this is undesirable from Site Isolation perspective. The CL fixes the problem above, by making sure that chrome.tabs.update populates LoadURLParams::source_site_instance in a way consistent with 1) initiator_origin and 2) the BrowserContext of the target tab. Note that when discussing this CL, we've explicitly decided against setting the |initiator_origin| to the (old/current) origin of the target tab. This is because such initiator would prevent the extension from being able to use chrome.tabs.update to navigate to non-web-accessible-resources owned by the extension. Additionally, using the origin of the target tab is subject to races with other navigations of the tab that might be happening in parallel. Note that this CL does *not* change the fact that using chrome.tabs.update to navigate a non-extension tab to about:blank will commit an *opaque* origin (with precursor set to the extension origin), rather than committing about:blank with the (non-opaque) extension origin. This aspect of behavior is not changed because: 1. There are no compelling reasons to make a change at this point. 2. Changing this behavior is possible when chrome.tabs.update is called from an extension frame in the same BrowserContext as the target tab (in this case |source_site_instance| can be set to the SiteInstance of the extension frame calling chrome.tabs.update). Unfortunately sometimes there is no extension frame (when chrome.tabs.update is called from an extension service worker) and sometimes the target tab is in a different BrowserContext (e.g. in an Incognito profile). Relevant tests: - (new) ExtensionApiTest.TabsUpdate_WebToAboutBlank - (new) ExtensionApiTest.TabsUpdate_WebToNonWAR - IncognitoApiTest.Incognito - ServiceWorkerBasedBackgroundTest.FilteredEvents - ServiceWorkerBasedBackgroundTest.TabsEvents Change-Id: I31b298d9a118de45ba4a255d2384d82f029c8b7a Bug: 991607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850355 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708283}
-
Steven Bennetts authored
This isn't a huge gain, but it's something, and I'm not aware of any reason not to compress these. Bug: 965089 Change-Id: I3931f406f7d78b8e01ed25324dfa89f675874ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872993 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708282}
-
Manas Verma authored
Even if the user has opted-in for FIDO authentication, an expired card should invoke the CVC prompt in order to update the expiration date. Bug: 949269 Change-Id: I814a21113d13187520260535c47d57b1bb1e5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869759 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
-
rbpotter authored
third_party/polymer/v1_0/minify_polymer.py was using --in-html and --out-html arguments to Polymer bundler when minifying polymer. These arguments are no longer valid in bundler v4, so the script was broken by: https://chromium-review.googlesource.com/c/chromium/src/+/1857568 Update the script to work with the new version of bundler. Bug: 921285 Change-Id: I52f82ef3cfb36ec79c61e69aec7185098d19226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873372Reviewed-by:
-
Yue Zhang authored
* Add one indicator line below dialog title to show that the title is editable. The line is grey by default and blue when editing title. * When user exits editing mode with an empty string as title, restore the default "# tabs" title in both dialog and tab switcher. Bug: 1001738, 1014004 Change-Id: Id6c13f887f2f6ce5aaa5f50a237e38ddb6cd341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863109 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708279}
-
Peter Kotwicz authored
This CL disables TrustedWebActivityTests#testStatusBarColorCertificateError() TrustedWebActivityTests#testToolbarVisibleCertificateError() TBR=pkotwicz,alexilin BUG=1016743,1016746 Change-Id: I74ac6eb22c98d561d2ab03589eea3b7b51176786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874190Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708278}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1b1491b05a2..e6207efbf4c2 git log e1b1491b05a2..e6207efbf4c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 tneda@google.com Merge "perfetto-ui: uncollapse tracks with heap profiles" 2019-10-22 treehugger-gerrit@google.com Merge "Allow messages from corp.google.com origins" 2019-10-22 treehugger-gerrit@google.com Merge "perfetto-ui: Fix async_slices track queries" Created with: gclient setdep -r src/third_party/perfetto@e6207efbf4c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icdf4d33ae2660a4dc45c46987bef8764819eeb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873287Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 246 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-19. Change-Id: Ia4e161c7125b8d76f4d480716a8bbe19b9cb53e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872809 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#708276}
-
Ella Ge authored
This reverts commit 516cf22e. Reason for revert: compile failure on windows https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/6356 Original change's description: > Reland: SuperSize: 3x speedup by minimizing string allocations > > Use runtime endianness check to avoid system-dependent header files. > > Bug: 1011921 > Change-Id: I1870db11d986eb8a805c5105ed67750cb8ce2c96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873395 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708269} TBR=agrieve@chromium.org,jaspercb@chromium.org Change-Id: I98b4abcfdfff28bbad60b11c4cd406b4ff89c6ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873722Reviewed-by:
-
Allen Bauer authored
It was virtual at some point, but never overridden. The virtual was removed in a previous CL, which rendered its intent as moot. Change-Id: Ia6c4ac1a5cd657e0ccc682508b35fc652e4b7e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872754 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#708274}
-
Mohamed Amir Yosef authored
Primary keys of the login database are used as storage key for Password USS Sync. Currently, they are recycled and hence are causing Sync to commit entities with wrong client tags. This CL fixes that by adding the AUTOINCREMENT flag to the primary key column. Since the SQLTableBuilder is currenly only used for creating PasswordManager databases, and for simplicity, this CL is restricting the primary key to be a single INTEGER column. Bug: 1016718,902349 Change-Id: I931826547b92566f631b4ca12b53039be3ceb491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872099 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708273}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62b5cdc733cc..8017a6a7fc26 git log 62b5cdc733cc..8017a6a7fc26 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org use enumerate in a few more places 2019-10-22 vapier@chromium.org virtualenv_wrapper: fix string handling Created with: gclient setdep -r src/third_party/chromite@8017a6a7fc26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2377d22ef65ad8e146e9a4510a46d1c35b095cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872934Reviewed-by:
-
Synthia authored
If user click on Cancel button in dialog,then Dialog should be disapper and display a error message Bug: 1006820 Change-Id: I5a75da76c4b5403a824f49855f9f939de74bd984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860734Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708271}
-
