- 28 May, 2013 40 commits
-
-
dewittj@chromium.org authored
This splits NotificationDelegate into two interfaces: * message_center::NotificationDelegate, and * ::NotificationDelegate. message_center::NotificationDelegate handles click events, whereas ::NotificationDelegate has a RenderViewHost that can be used to download images. This will support adding message_center::Notification objects directly, including all the binary bits of their image notifications. BUG=174164 Review URL: https://chromiumcodereview.appspot.com/15582004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202591 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202590 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@google.com authored
Suppress flaky memory leak in DeclarativeContentRulesRegistryTest.ActiveRulesDoesntGrow on Chrome OS BUG=244446 R=timurrrr@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16060003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202589 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151226:151259&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/16092005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202588 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
In order to do this we moved the FaviconChangeDetails struct into c/b/favicon, which bookmarks is already allowed to depend on, as well is history. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/15275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202587 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
This is a resubmit of https://codereview.chromium.org/15505003 TBR=avi BUG=96594 Review URL: https://codereview.chromium.org/15740023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202586 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=chromium:133291 TEST=Still compiles. Review URL: https://chromiumcodereview.appspot.com/15199006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202585 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This patch is suspected in making the page_cyclers noisier. BUG=244189 > [Telemetry] Make telemetry faster on win7. > > This makes unittests run much faster on win7. It is actually bearable now. > > DNS for localhost is slow (ie. 1s per request) when ipv6 is enabled on win7. > > BUG=None > TEST=python tools\telemetry\run_tests > NOTRY=True > > Review URL: https://chromiumcodereview.appspot.com/15787005 TBR=tonyg@chromium.org Review URL: https://codereview.chromium.org/16133005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202584 0039d316-1c4b-4281-b951-d872f2087c98
-
ajuma@chromium.org authored
The kDisableThreadedAnimation flag, which actually disables cc-driven animations regardless of whether we're using a compositor thread, is currently set for all layout tests. We need to set this flag in single thread mode (which is the default for layout tests) since, in this mode, cc-driven animations cause never-ending invalidation, causing tests to fail. However, when threaded compositing is enabled, cc-driven animations do not cause never-ending invalidation. This CL makes us only disable cc-driven animations when in single thread mode. This is a prerequisite for creating a virtual test suite for animations that uses threaded compositing and threaded animation. BUG=244266 Review URL: https://chromiumcodereview.appspot.com/15939004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202583 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
BUG=244231 Review URL: https://chromiumcodereview.appspot.com/15684005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202582 0039d316-1c4b-4281-b951-d872f2087c98
-
wjia@chromium.org authored
The buffer handling in OpenSL is: 1. enqueue the buffers; 2. wait for a callback; 3. inside the callback, read out the PCM data of current buffer and enqueue one buffer (it's the same buffer in this case). 4. go to step 2. Current implementation has several problems: a. When buffer #1 (not buffer #0) is read first time, it doesn't have PCM data recorded by the device. b. There are 2 buffer worth of time delay. c. There are racing condtion since both OpenSL and AudioInputController hold the same buffer. BUG=243506 R=xians@chromium.org Review URL: https://codereview.chromium.org/15941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202581 0039d316-1c4b-4281-b951-d872f2087c98
-
shawnsingh@chromium.org authored
BUG=240946 Review URL: https://chromiumcodereview.appspot.com/15051011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202580 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
EnterpriseWebStoreName and EnterpriseWebStoreURL were an attempt at supporting organization-specific app collections. There are now better ways to do this that don't require invasive Chrome changes, so retire the two policies. BUG=chromium:178938,chromium:240648 TEST=Still compiles and passes tests. TBR=jochen@chromium.org, estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/14813039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202579 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
gyp_chromium.py contained a Python 2.6 Windows bug workaround which turns out to be harmful with Python 2.7 since it will just include itself without doing anything. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/14670009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202578 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@google.com authored
BUG=244437 R=timurrrr@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15658008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202576 0039d316-1c4b-4281-b951-d872f2087c98
-
dmikurube@chromium.org authored
BUG=244163 R=bulach@chromium.org, glider@chromium.org, peria@chromium.org Review URL: https://codereview.chromium.org/15511005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202575 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
BUG=229762 R=nkostylev@chromium.org Review URL: https://chromiumcodereview.appspot.com/16091004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202573 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
The approach is slightly different from my proposal in the bug so that we have more configuration options as well as backwards compatibility with Chrome M25. This change introduces two new policy lists that allow admins to whitelist URLs to get no-prompt access to capture devices via URLs or URL patterns. The pattern matching is applied only to the security origin of the URLs. The behavior of the existing AudioCaptureAllowed and VideoCaptureAllowed is reverted back to how it was prior to r180416. This means that admins must use the whitelist to allow device access without prompt. If no match for a URL is found in the whitelists, the default behavior is determined by the [Audio|Video]CaptureAllowed policy value. BUG=225045 Review URL: https://chromiumcodereview.appspot.com/15738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202572 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@google.com authored
BUG=244420 R=timurrrr@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15912008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202567 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
This is a revert of issue https://chromiumcodereview.appspot.com/14471033/ BUG=234231 Review URL: https://chromiumcodereview.appspot.com/15891005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202566 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
This was necessary prior to m27, now on stable channel. BUG=177053 Review URL: https://chromiumcodereview.appspot.com/16000002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202564 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
This patch now also always calls MakeVirtuallyCurrent during initialize and MakeCurrent, such that the next context will always restore. The context state is restored only if the API has changed or the virtually current context has changed, so we should never skip calling MakeVirtuallyCurrent. BUG=241188 Review URL: https://chromiumcodereview.appspot.com/15841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202561 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
There are situations like running tests where it's not necessary to run envsetup.sh. However, build/android/pylib requires adb to be in the path. Rather than requiring envsetup, it can be smart enough to set the path itself. BUG=242960 Review URL: https://chromiumcodereview.appspot.com/15891002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202558 0039d316-1c4b-4281-b951-d872f2087c98
-
henrika@chromium.org authored
My CL https://codereview.chromium.org/15563004 broke this test. http://build.chromium.org/p/chromium.memory.fyi/ Failure notification for "memory test: media" on "Chromium Mac (valgrind)(1)". Please see if the failures are related to your commit and take appropriate actions (e.g. revert, update suppressions, notify sheriff, etc.). http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/20942 Revision: 202536, 202537, 202538, 202540, 202541, 202542 Blame list: eseidel@chromium.org,glider@chromium.org,henrika@chromium.org,kinuko@chromium.org,mtomasz@chromium.org,tzik@chromium.org BUG=see details above TEST=media_unittests --gtest_filter=AudioInputVolumeTest.InputVolumeTest* in Debug mode on device with audio hardware R=xians@chromium.org Review URL: https://codereview.chromium.org/15688007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202557 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=222876 TBR=bruening NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16151002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202555 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
BUG=241737 Review URL: https://chromiumcodereview.appspot.com/15738020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202554 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch aligns the gear menu's top with the horizontal line from the Files.app's window's header. TEST=Enter Files.app, click on the gear button. BUG=239300 Review URL: https://chromiumcodereview.appspot.com/16132003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202553 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
Otherwise, if there's e.g. still a download in flight, we might open a new window after closing all windows but before starting the next test BUG=111316 R=marja@chromium.org Review URL: https://chromiumcodereview.appspot.com/16074003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202552 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
This CL added an Esc key handler to the search box, which sets the focus to main view (the file list or the thumbnail grid) when the search box has no query. BUG=239307 TEST=manually Review URL: https://chromiumcodereview.appspot.com/16018008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202551 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
BUG=96684 TBR=bruening@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15975006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202550 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202549 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Not having full coverage yet. Preliminarily adding tests necessary for resolving bug 244316. BUG=147728 Review URL: https://chromiumcodereview.appspot.com/15939005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202548 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
This CL splits out quota related callbacks to separate file. After this CL lands, quota_types.h is only depended file from non-browser directory. TBR=markusheintz@chromium.org Review URL: https://chromiumcodereview.appspot.com/15892009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202547 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=bsalomon@google.com Review URL: https://codereview.chromium.org/15824004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202546 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
We only need the webkit test plugin during layout tests BUG=242291 R=abarth@chromium.org Review URL: https://chromiumcodereview.appspot.com/15820007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202545 0039d316-1c4b-4281-b951-d872f2087c98
-
ygorshenin@chromium.org authored
BUG=244175 TEST=interactive_ui_tests:CaptivePortalWindow* Review URL: https://chromiumcodereview.appspot.com/15780006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202544 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202543 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
As all of the code are browser-specific. BUG=239710 R=kinaba@chromium.org Review URL: https://codereview.chromium.org/16010006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202542 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151204:151225&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/16072004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202541 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
This CL add GetGlobalLimitedUsage to UsageTracker and replace GetGlobalUsage in QuotaManager with limited usage version. BUG=220029 TEST=existing test should keep green Review URL: https://chromiumcodereview.appspot.com/15907004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202540 0039d316-1c4b-4281-b951-d872f2087c98
-