- 26 May, 2020 40 commits
-
-
Benoit Lize authored
Record the sum of CPU overhead of discarding in the first 5 minutes of a renderer lifetime, and the total disk footprint, with and without overhead. Bug: 1029320 Change-Id: I5aa9d1df4fd2aefa4dcd180c378fe462e7297a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209136 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771747}
-
Jit Yao Yap authored
A TestExtensionRegistryObserver is used to wait for the in-session extension to be ready before calling the Javascript test function. Bug: 1075511 Change-Id: I77837f14782f63c69628e3364edaf0a41c99843a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212277Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#771746}
-
Stepan Khapugin authored
AppState's |window| is confusing in multiwindow world. It is equivalent to AppState.foregroundActiveScene.window. Remove it to avoid confusion. Bug: none Change-Id: I3d5c0f10df07050f90380d14133f406ab541d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193991 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#771745}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I1ef2b3b1256b33ab458ec6316416836de9b5638d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215400 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771744}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2863ba211be1..b12011da35a3 2020-05-26 tvanderlippe@chromium.org Revert "Use terser rollup plugin" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6713c048b7d428e131bdd5ba8646f1517a174fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771743}
-
Abhijeet Kandalkar authored
Various classes inside arc/mojom directory expose Init() method to establish a connection using ConnectionHolder. This CL ports all arc/mojom/*.mojom files and full duplex mojo connection implementation in ConnectionHolder class which uses Type trait to return whether instance type instantiating ConnectionHolder class has Init() method. Bug: 955171, 978694, 1035484 Change-Id: I46a592dfb34f09e7db29d09b2b78772ba2d64eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868870Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#771742}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5afa89dd. With Chromium commits locally applied on WPT: 9c36a269 "Reduce cross frame messages in feature-policy-nested-subframe-policy.https.sub.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I94bb02ebb2363b3244e7420f58f3c1f510ae0338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215420Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771741}
-
Ramin Halavati authored
OTR profile API is updated in ProfileState. This CL does not result in any behavior change. Bug: 1060940 Change-Id: Ib1550147ecf9662c02265c55302f75cd489227d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212273 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#771740}
-
Gauthier Ambard authored
Fixed: 926041 Change-Id: Ib40621f5039fcc6440968a397da1438aca7fbb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215841Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#771739}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9046a4247505..43b6446650dc 2020-05-26 taylori@google.com Merge "Allow invalid task state for conversion" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I23c77a37d702d06c1d44dad47c9da43be7e828d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771738}
-
Anqing Zhao authored
After some improvement and additional verification, I'd like to enable these browser tests again to see if thery are still flacky. They always pass during the local test. Bug: 1044417, 783450 Change-Id: Ibcab2d4f8921ab8a98ce968c6771929353238f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215043Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#771737}
-
Anqing Zhao authored
The browser tests for KioskAppManager are flacky. Adding more verification to locate the root cause. Bug: 1044417, 783450 Change-Id: I8189bcbb276ebabc0fa1bd8a5c5a210b03dee671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213575 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771736}
-
Yoshifumi Inoue authored
This patch changes "paste-sanitize-crash-1.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I92299572cc59067d340a8295e9dbf50fcf0f1a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215784 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771735}
-
Yutaka Hirano authored
Bug: 1086372 Change-Id: I033d8eb552a0162de3b316664bcf29f896763658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215657Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771734}
-
Andreea Costinas authored
On slow networks, |SystemClockSyncWaiter| times-out before tlsdate syncs the system clock. This CL increases the time to wait for the system clock updated signal to 45 seconds, which allows tlsdate to try at least seven TCP retransmissions attempts. Note that RFC 1122, section 4.2.3.5 recommends at least 100 seconds for the TCP timeout. BUG=chromium:540686 TEST=none Change-Id: Ie0ff1f55ec2fc2c6d4a67f764af39464f411c4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214941 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771733}
-
Anqing Zhao authored
The class content::MessageLoopRunner class has been deprecated for a long time. Not 100% sure if this is related to the flaky tests, but nothing to lose replace them with the recommanded one - base::RunLoop. Bug: 1044417, 783450 Change-Id: I969f32550c7f1679c8dc398b9b1c17da97b4d137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214943Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#771732}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590465515-9ef099e12f3ab5051489e8b99894f13fb77c0985.profdata to chrome-win32-master-1590479866-bd3b364dec503175394de5d27879ac865b50ea38.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I36c2c37ec2e247f5bc9f4129f0ed990bac8a0522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771731}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590465515-790c6cf05617ff0779c93cfed8e1f71b6e306b53.profdata to chrome-mac-master-1590479866-02719b24a518e7640038fc4f4eebb5b489becebf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic631ccec5bf2820994c5956d9266a0f63baea9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771730}
-
Alexey Baskakov authored
Apps in sync install are being installed and should be hidden for most subsystems. OnWebAppInstalled() notification will be send out later. Bug: 1086301 Change-Id: Ib02ad64eaf5a35053843bc32360091be1eb48a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215392 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#771729}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd6ecc479f9e..2863ba211be1 2020-05-26 beaufort.francois@gmail.com Show error if manifest icon src is empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie042291bfd6da7b7b09cf6c370d68ccac2c383ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771728}
-
Guido Urdaneta authored
Also enable the GFD extension in tests so that all the metadata and type fields are reported correctly. Drive-by: test cleanups. Bug: 1069295 Change-Id: I9ffb5c9874c9f8556785a0664ee010d3912f866a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207162Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#771727}
-
Jana Grill authored
Bug: 924497 Change-Id: I5c3d74e0f7e92662dc7138f0f7739ded544fe38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207464Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#771726}
-
David Staessens authored
This CL adds usage documentation for the new video_encode_accelerator_tests, providing in-depth information on how to run the encoder tests. TEST=gitiles BUG=953114 Change-Id: Iaacaa2e6c79417e69eedced9c21b63ed9f483f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060437 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#771725}
-
Eric Willigers authored
The flag FeaturePolicyJavaScriptInterface has been stable since 2019-01. Bug: 703703 Change-Id: I261da132dbabf1d3f0a04931afa3deafb74b4867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206867Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#771724}
-
Benoit Lize authored
PartitionAlloc's alignement guarantees are not explicit anywhere, which is problematic to support aligned allocations properly. This in turn is required to broaden its use across the codebase. This CL doesn't change the behavior, but documents the existing one. Bug: 787153 Change-Id: Id3502081c5bf92f9f820ef1e992e56e1add92374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210422 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#771723}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5db4a28e..2bc8f192 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34b3c62a2ca4681537014cfe8127894a3d518f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215686Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771722}
-
Giovanni Ortuño Urquidi authored
Some apps, like Release Notes, are hidden from the app launcher, search, etc. This CL ensures this setting is correctly migrated to BMO. Fixed: 1086068 Change-Id: I47401753240da830f1f488dc6909e01912cec5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215385 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#771721}
-
Jinsuk Kim authored
This CL injects EphemeralTabCoordinator object into the tab delegate factory instead of instantiating it directly. This fixes a problem of creating one coordinator per each tab. Bug: 1064207, 1084731 Change-Id: I78187e2476410a4fcfe3efa85b51884640e1c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214802Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#771720}
-
Yoshifumi Inoue authored
This patch changes "select-out-of-floated-contenteditable.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ic2b7ebe39d80c00c5659db3110f53bed97314942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215767 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771719}
-
Rune Lillesveen authored
We incorrectly parse properties like background-image as page descriptors. This CL makes sure we at least don't trigger fetches for such urls. Bug: 1086264 Change-Id: I32f2262fae46cafdd57f1cf2baa825d6bef32389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215323Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771718}
-
Marina Ciocea authored
This reverts commit dbff1601. Reason for revert: Suspect for failures on Linux TSan starting with build https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/55141 Original change's description: > indexeddb: refactor special storage policy > > Special storage policy is a dynamic, complicated, browser-only data > structure that IndexedDB needs to query on shutdown to determine whether > or not to delete particular session-only directories (or not delete > protected directories). Because shutdown is time-sensitive, this > chooses to push updates to policies based on active origins (i.e. > origins that IDBFactories have been created for). > > This is the IndexedDB equivalent of this local storage change: > https://chromium-review.googlesource.com/c/chromium/src/+/1945940 > > Bug: 1015214 > Change-Id: I18f65a6416be508b298e8046d4d6c20c2e56b1f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203146 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771144} TBR=dmurph@chromium.org,enne@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015214, 1086138 Change-Id: I2dccf1105ca01971bfcade267e36191ff2f5c15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213529Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771717}
-
Nnamdi Theodore Johnson-Kanu authored
- Forks TestLifetimeBrowserProxy into test_os_lifetime_browser_proxy.js - create new os_settings_v3_browsertest.js Bug: 1045266 Change-Id: I4500646fda8e8208d7bc63b405594592f9a7fce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190976 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#771716}
-
Colin Blundell authored
This ensures that the autofill framework won't kick off autofill in the URL bar. The user could still manually trigger autofill by long-pressing on the URL bar and selecting the autofill prompt that pops up. That seems not necessary to fix as that flow will not be possible in the WebLayer embedder. If it were to be fixed, it would need to be fixed at the level of the shared AutofillActionModeCallback. Bug: 1083479 Change-Id: I468b7e729139747479b0f5f6a641a3345fc007af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212125Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#771715}
-
Yutaka Hirano authored
Bug: 1086353 Change-Id: I4613a1271a985a9e01b6652c34dcb27cb6f83859 Tbr: ricea@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215654Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#771714}
-
Alice Wang authored
This CL adds JNI code to open account picker bottom sheet in the web sign-in flow. Bug: 1041876 Change-Id: I3dcdeb0ae8ec9960362bae5ebcfbf2999d126bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204021 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#771713}
-
Dominick Ng authored
Call TestWebAppProvider::Start() in the tests to stop the App Service waiting for web apps to be published. BUG=1082884 Change-Id: I051a43fa56e739e22e9b1a70e6edf58f0a49b600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214587Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771712}
-
Hitoshi Yoshida authored
This CL updates some IDLs to catch up each spec. There are no or tiny behavior changes. Bug: 839389 Change-Id: I7710fcb259e404608955545817fc38cb1f751d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213660Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#771711}
-
Kent Tamura authored
This CL ports TextAlignmentForLine() and AdjustInlineDirectionLineBounds() of LayoutRubyBase and LayoutRubyText to LayoutNG. This CL doesn't affect production because new behavior is behind a disabled runtime flag. Bug: 1069817 Change-Id: I5e09f0a46ff505f15daccea11f13c66444dc9876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214589 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771710}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c203f436263..17c11a2291ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yhirano@google.com Change-Id: I1e96e97b230500e5af0f1fb289ad7c1e7bedf062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e61a29bd9b4..bd6ecc479f9e 2020-05-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2280600f8cfe4b0779c6e64e0bd077c42a8108c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771708}
-