GitLab

Prevents any calls into the native bridge once release() has been
called on MediaCodecBridge. I've also reordered some member
variables of the bridge to match their lifetime.

BUG=873094
TEST=none

Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0
Reviewed-on: https://chromium-review.googlesource.com/1171836Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582398}

Excluding some large size data in third_party/catapult/ that are not needed
in running the telemetry tests.

R=kbr@chromium.org,nednguyen@chromium.org

Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578
Bug: 872521
Reviewed-on: https://chromium-review.googlesource.com/1166261Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582397}

Bug: 873124
Change-Id: I5f5f5af481e9f8e31a1dab141b9b4dac93acc121
Reviewed-on: https://chromium-review.googlesource.com/1171742Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582396}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5429bacaf530263c0fe78c4403624d6773d12866
Reviewed-on: https://chromium-review.googlesource.com/1171858Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582395}

This moves the PageAlmostIdle and SiteCharacteristicsDatabase features to their
own experiment so they can easily be shipped to Beta only.

Change-Id: I56c65e4ffb8b389b502a8c03d661ca2c26a66abe
Reviewed-on: https://chromium-review.googlesource.com/1168107Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582394}

This will allow us to differentiate between "running" and "active".
The logic to set this properly depending on status will come in a
separate CL.

Note that no shelf item is ever marked as STATUS_ACTIVE yet, so
this CL has no effect on behavior.

Bug: 805612
Change-Id: I50f985d66659bd35e2b59ab19a898ae5a3634179
Reviewed-on: https://chromium-review.googlesource.com/1170394
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582393}

It looks like an oversight that they weren't run on this configuration
previously.

Tbr: geofflang@chromium.org
Bug: 872302
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I77e4e175a449cea70254dcc3bab8ea3686fc74d9
Reviewed-on: https://chromium-review.googlesource.com/1168464Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582392}

This patch changes the container that the new tab animation runs in
when Duet is enabled. The container changes position from running on
top of the toolbars to running beneath them (since the bottom toolbar
is a persistent fixture). This would negatively impact the top toolbar
if there were still icons there (since the top toolbar has an
appearance animation to compensate for the tab appearing on top of
it). However, since there are no icons, it is not an issue.

Bug: 852012
Change-Id: I19422b70844f3fd45e7d9318a3c9c9768b407991
Reviewed-on: https://chromium-review.googlesource.com/1171819
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582391}

These are mirrors of the existing release bots

Bug: 867725
Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
Reviewed-on: https://chromium-review.googlesource.com/1159172
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582390}

Sometimes when sharing temporary offline pages, we fail to create the
content URI.  If we do, fall back to sharing by URL with the URL of the page.

Bug: 871697
Change-Id: Ie2e895fd708fdf4e5e992ebc2317ee49fd5bcee3
Reviewed-on: https://chromium-review.googlesource.com/1168587Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582389}

This CL updates the layout of the streamlined sign-in screen and the
consent bump screen to accommodate last changes to mocks.

Bug: 814728
Change-Id: If8f2cdaf39ba175ca60584f9015a4b2ccaf23217
Reviewed-on: https://chromium-review.googlesource.com/1171226Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582388}

Change-Id: I3c0930f22e7ff3ff72611bfb70415b3e122f398e
Reviewed-on: https://chromium-review.googlesource.com/1171378Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582387}

The "Restore default shortcuts" and "Restore default background" options
are swapped when navigating with arrow keys.

Bug: 872978
Change-Id: I6078a6fb0a004a81e321a39f08e1f024bf53e9e1
Reviewed-on: https://chromium-review.googlesource.com/1170195
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582386}

This will host the ExploreSites datastore as well as the downloader.

BUG=867488

Change-Id: Ifff84b6c8316033929ccbd52c32c2f175af117c8
Reviewed-on: https://chromium-review.googlesource.com/1169588Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582385}

third_party/ is excluded, except for third_party/WebKit and
third_party/blink.

This is uncovered by:
https://chromium-swarm.appspot.com/task?id=3f2afb7b4290f910

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie17ea50e7f6aba3538acb488df92b4926b52f4c4
Reviewed-on: https://chromium-review.googlesource.com/1170441Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582384}

Change-Id: Ib6bcee51114a9fcb05aacd9079d52b65356e18d2
Reviewed-on: https://chromium-review.googlesource.com/1171680
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582383}

https://pdfium.googlesource.com/pdfium.git/+log/e1a7e8589a8c..f36a4644b828


git log e1a7e8589a8c..f36a4644b828 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 rharrison@chromium.org Remove direct calls to time
2018-08-10 rharrison@chromium.org Add proxy for syscall time
2018-08-10 tsepez@chromium.org Remove |typedef struct| in favor of just |struct|.
2018-08-10 tsepez@chromium.org Consolidate const_casts<> in FXFT_Get_Name_Index()
2018-08-10 thestig@chromium.org Make CFX_ImageTransformer::CalcData's bitmap non-const.
2018-08-10 thestig@chromium.org Fix a JBIG2 decoding regression.
2018-08-10 thestig@chromium.org Remove deprecated flags from fpdf_progressive.h.


Created with:
  gclient setdep -r src/third_party/pdfium@f36a4644b828

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:871848
TBR=dsinclair@chromium.org

Change-Id: I22721ff61265f49fddd6ffc647ef37cc2f70bc0c
Reviewed-on: https://chromium-review.googlesource.com/1171442Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582382}

I increased shards for some tests took time on
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/59189

Bug: 868114
Change-Id: I9ae5c80e0fe641f8946e0d00d8a322721d2de079
Reviewed-on: https://chromium-review.googlesource.com/1170922Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582381}

Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and
dereferencing it. To better document the fact that these calls (properly, in most cases)
assume the layout object contains style, they should be replaced with calls to the StyleRef()
function, which dereferences the pointer.

Bug: 872508
Change-Id: Id6a04871c12a2c09d1029ca5aa04ae49099f7fd0
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1171144Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@google.com>
Cr-Commit-Position: refs/heads/master@{#582380}

Since SampleOrderingSpec::MAY_SHUFFLE is the only one used in production
code, there is no need to specify the SampleOrderingSpec parameter hence
SampleOrderingSpec enum is also retired.

Bug: 851163
Change-Id: Ie9bf7c39d036db55b1533c4fe3b3f3293a2a8dbf
Reviewed-on: https://chromium-review.googlesource.com/1171584
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582379}

Disalbing the CATransactionGPUCoordinator caused memory corruption bugs
to go away.

Fix two potential bugs:

1.  Don't post tasks (and potentially change the reference count) inside
    CATransactionGPUCoordinator's constructor. Do this in a separate
    explicit Init function.

1a. Move this initialization to the end of GpuProcessHost:Init (instead
    of being at the beginning of the constructor).

2.  Make CATransactionCoordinator explicitly retain PostCommitObserver
    (which includes CATransactionGPUCoordinator). This fixes a bug
    whereby at shutdown, destroying not-yet-executed posted tasks caused
    the CATransactionGPUCoordinator to be destroyed while the
    CATransactionCoordinator still had a raw pointer to it.

Bug: 871430
Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75
Reviewed-on: https://chromium-review.googlesource.com/1171657
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582378}

Change-Id: I100542f77eb1ebebf28db6c716733467be61c209
Reviewed-on: https://chromium-review.googlesource.com/1168503Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582377}

Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6
Reviewed-on: https://chromium-review.googlesource.com/1169693
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582376}

Before this CL, DevTools would crash the browser if it did not get a response in
5 seconds. This timeout is too low for Windows. On Catapult perf tests on
Windows, it takes ~3 seconds for the GPU process to respond on average, and
sometimes it takes more than 5 seconds.

Bug: 873112
Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213
Reviewed-on: https://chromium-review.googlesource.com/1170584Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582375}

This will be used by both oobe and settings.

Bug: 873229
Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5
Reviewed-on: https://chromium-review.googlesource.com/1171243
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582374}

https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs
will be empty after this CL

TBR=fdoray@chromium.org

Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49
Reviewed-on: https://chromium-review.googlesource.com/1171108Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582373}

-Use originalURL if provided to dedupe against history.
-Fix "typo" for corpus restrict request param (I missed it was renamed).
-Sanitize title, provide default match data.

Bug: 873290
Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3
Reviewed-on: https://chromium-review.googlesource.com/1171550Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582372}

We've seen cases where Cast discovery code fails to pick up services
from the ServiceDiscoveryDeviceLister, whereas chrome://inspect
(CastDeviceProvider) is able to do so. Since Cast discovery's
ServiceDiscoveryDeviceLister is only created once and is long-lived,
this suggests it has gone into a bad state after a prolonged period.
Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister,
which gets created/destroyed when the inspect page is loaded/unloaded.

To mitigate this issue, this patch uses the ForceDiscovery() signal to
recreate a new ServiceDiscoveryDeviceLister in DnsSdDeviceLister
and kick off the discovery using the new object, and to clear the set
of services in the cache. This puts DnsSdDeviceLister in a clean state
which will the current set of services to get through to the Cast
discovery code.

Bug: 850770
Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463
Reviewed-on: https://chromium-review.googlesource.com/1166022
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582371}

VisibilityChanged() tests the is_visible_ member before it's been set to any
value.

BUG=none
TEST=none
TBR=xiaohuic@chromium.org

Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2
Reviewed-on: https://chromium-review.googlesource.com/1171553Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582370}

This changes the GetAssertion operation for the Touch ID authenticator
to locate credential IDs in the keychain at the beginning of the
request. If no matching credential exists, the user is not prompted for
a fingerprint. A method to locate a credential by ID is extracted from
the existing code and moved into the Keychain class.

This is done in anticipation of adding the WebAuthn UI. With the new UI,
GetAssertion requests will only be sent to the Touch ID authenticator,
if we know a matching credential ID to exist in the keychain.

Bug: 871370

Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b
Reviewed-on: https://chromium-review.googlesource.com/1163927
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582369}

Bug: 620034
Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b
Reviewed-on: https://chromium-review.googlesource.com/1169425
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582368}

Also, generally increase the timeout for layer tree tests.  Most things
don't need this, however the GL versions of pixel tests end up spending
quite a bit of time to compile shaders.  When run in parallel, this
only exacerbates the problem and tests can time out.  Be more generous
so that folks stop turning off these tests.

Bug: 872733
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88
Reviewed-on: https://chromium-review.googlesource.com/1171377Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582367}

Bug: 871812
Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
TBR: mgiuca
Reviewed-on: https://chromium-review.googlesource.com/1171681Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582366}

This CL finishes up the rest of the work of refactoring the audio
playback logic on iOS.

Bug: 868088
Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d
Reviewed-on: https://chromium-review.googlesource.com/1166339
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582365}

Bug: 870732
Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7
TBR: mgiuca
Reviewed-on: https://chromium-review.googlesource.com/1171738Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582364}

This is platform convention.

BUG=869564
TEST=as in bug

Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe
Reviewed-on: https://chromium-review.googlesource.com/1164307Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582363}

Changes:
Make the suggestion chip text length no longer than 192dip.

Bug: 872948
Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9
Reviewed-on: https://chromium-review.googlesource.com/1171676
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582362}

IWYU: std::unique_ptr needs <memory>. This fixes the libstdc++ build:

    In file included from ../../base/test/scoped_mock_clock_override.cc:5:0:
    ../../base/test/scoped_mock_clock_override.h:39:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
       std::unique_ptr<base::subtle::ScopedTimeClockOverrides> time_clock_overrides_;
            ^~~~~~~~~~

Bug: 818294
Change-Id: I3b92e51f2565b42869cf2400dd4d3654e112f0fb
Reviewed-on: https://chromium-review.googlesource.com/1170837Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#582361}

This change allows the Captured Sites Automation Framework to replay
interactions on iframes. As part of this change, I switched the
automation framework to trigger the autofill popup by clicking on an
input field instead of pressing the 'DOWN' key, which does not work in
automation on some iframes.

Also included in this change is a fix I made to address the issue that
calling 'ASSERT' inside a test function does not abort the test.

Change-Id: I15b30f878f04cb3ee2935879c2da4c474442ab27
Reviewed-on: https://chromium-review.googlesource.com/1161603
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582360}

In some situations the next Time Window Limit was not calculated correctly, this
caused the TimeLimitController to recalculate the time limit constantly.

Bug: 873228
Change-Id: I6b88792aa6849774778d85d8dea2695192acc172
Reviewed-on: https://chromium-review.googlesource.com/1171114Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#582359}