- 23 Jan, 2020 40 commits
-
-
yilkal authored
This CL makes sure that navigation has committed in SupervisedUserNavigationObserver::DidFinishNavigation before trying to access the RenderFrameHost that hosted the navigation. Bug: 1042620 Change-Id: I8258023537c769338c82e54927d38107759b1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008317Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734566}
-
Anupam Snigdha authored
Previously we used to report the client rectangle instead of actual control bounds of the focused editable element. With this change, we are fetching this data from the focused editable element's bounding client rect and sending this info to TSF. Bug: 1043424 Change-Id: I20e18e3ec4e861311636ced9dc97d0a82f49838d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008774 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734565}
-
Fernando Serboncini authored
Bug: 1044993 Change-Id: I14c8c09b04aba9c2e81f76792f6f9f9a8e7fbd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017042 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#734564}
-
Trent Begin authored
Add TimezoneInfo to mojom file to keep it in sync with Chrome OS. Bug: 1030361 Test: browser_tests --gtest_filter=DeviceStatus* && chromeos_unittests Change-Id: Ide7cf1bdd7dcb1b17369125048bb4742298a14bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013218 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734563}
-
Jan Wilken Dörrie authored
This change adds a JNI bridge for the BiometricAuthenticator and implements BiometricAuthenticator::CanAuthenticate() in a backwards compatible way. Bug: 1031483 Change-Id: I273aa655879c4abfb0afedd841744a53f914c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012024 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#734562}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: I1af5ea914f2e4ffef7069f53f984c8d69cb99eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015607Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734561}
-
Avery Musbach authored
Bug: None Change-Id: I51a8ef2deb6f9c569e03dd6d8680e896c7a24ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016340Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#734560}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdd73e095cd4..48655cfdbfd9 git log cdd73e095cd4..48655cfdbfd9 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 minyue@webrtc.org Send absolute capture time through audio coding module. Created with: gclient setdep -r src/third_party/webrtc@48655cfdbfd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic3049f1ff76f02183d8114802cccce6f529d7539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734559}
-
Ahmed Mehfooz authored
Bug: 960116 Change-Id: I2e6868f2ec1873273614cfe1ae902714dd882df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015572 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#734558}
-
Sebastien Lalancette authored
This reverts commit 8fd76b23. Reason for revert: Failing on bots. Bug: 1045071 Original change's description: > Add browser tests for smart card SAML login > > Provide test coverage for the scenario where a new user authenticates > via SAML using a smart card (or, generally speaking, using a security > token via an extension using the chrome.certificateProvider API). > > This also provides some test coverage for the <security-token-pin> > Polymer element used on the Login Screen. > > Bug: 1033936 > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734510} TBR=antrim@chromium.org,alemate@chromium.org,emaxx@chromium.org,hendrich@chromium.org,fabiansommer@google.com Change-Id: Ibfff9d60cd3ed0d2470435e67b3fd563c98c888a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016971Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734557}
-
Robert Sesek authored
Bug: 1042912 Change-Id: I64b0e5c0e9f6c36e9fdb7dd7d766e6a78a5f5734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015364 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734556}
-
manukh authored
Drive suggestions display icons corresponding to their type. We currently display specific icons for docs, sheets, slides, forms, pdfs, images, and videos. Other types (e.g. folders) display the generic drive icon. Apparently, some users search for folders often. To distinguish folder results, this CL adds the folder icon for folder results. These icons are the same as those displayed on drive.com. This CL also adjusts the image and slide icon colors to match those used on drive.com. Bug: 1032663 Change-Id: I555baa5d3dc4027cc399d8fb6e1507c5204586f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016906Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#734555}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. These keys are dynamic, so this CL uses a grandfathered KeyPrefix to generate them. Bug: 1022108 Change-Id: I3ce28a329619d144130d60c9fad275518129b232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005374Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734554}
-
Ian Kilpatrick authored
This fixes the above testcase, marked as failing in: https://chromium-review.googlesource.com/c/chromium/src/+/2015101 Essentially a flex-item, if it has any %-block-size children, needs to mark itself as depending on %-block-size, as its definiteness can change. See note in ng_physical_container_fragment.cc as this is a *little* too broad, as we should only check if the definiteness changes, not the percentage block resolution size. Bug: 845235 Change-Id: I78120f5dd65186ef9ad597f8a5717923cfa49144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016634 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734553}
-
Dave Tapuska authored
Define synchronous APIs on mojo to handle the appropriate dialog messaging. Move this solely into blink, the API is still exposed on the ChromeClient to still support PopupOpeningObservers. Introduce LocalFrameHostInterceptor on the content/public/test side to help support stubbing out the LocalFrameHostInterface. Move handling of Javascript dialogs in test_runner to the browser side. Some code already existed, the logging is just moved from the renderer to browser side. BUG=1039695 Change-Id: I2596c4a9ad35027e3ffde1c29b1525114c2cdfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994604 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734552}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=vitaliii@chromium.org Bug: 1042208 Change-Id: I3ad84430894a8b0bd355680007ee07cebf5a46e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014976 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734551}
-
Mike Wasserman authored
Plumb the internal display id to populate the Screen.internal attribute. Follows the primary display id and Screen.primary attribute pattern. This requires the ScreenEnumeration experimental flag to be enabled: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Test with this demo: https://github.com/michaelwasserman/window-placement-demo Bug: 994889 Test: getScreens()[i].internal returns an accurate value. Change-Id: I71ed5eb8b164eff6f2f5d93a7a400e69df219490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015555 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#734550}
-
James Cook authored
Today, all Chrome OS users must consent to sync during login. For the SplitSettingsSync project we want to allow them to use their device without consenting to browser sync. However, Chrome OS always sets the IdentityManager primary account during login, which implies sync consent. We would like to switch to using the "unconsented" primary account, which exists whether or not the user has consented to sync. However, there are a large number of places in the Chrome OS code that use GetPrimaryAccount() to get the "main" user's account ID, email or tokens. Add a command line switch that skips setting the primary account during login and instead directly sets the "unconsented" primary account. This allows me to manually test to identify areas that need to change. Convert some login and ARC ToS code to use the unconsented primary account. This is a no-op if the switch isn't set, because without the switch the primary account and unconsented primary account are the same. Bug: 1042400 Test: existing automated tests, also sign-in and ARC++ work on device without the switch set Change-Id: Idfeece6ac79b97a102111fb165062614a81f5a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001018 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734549}
-
Sorin Jianu authored
The certificate tool needs an un-tagged, Authenticode-signed binary for unit testing purposes. This binary comes from the official Google Update build, where it is used for a similar purpose. BUG=1031734 R=waffles CC=agl Change-Id: I2fb5299bd7434ebdfa147f38a69959e7860427df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015804 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#734548}
-
Abhijeet Kandalkar authored
This CL removes old legacy IPC to adopt new mojo types. It also removes unwanted implementations form RenderFrameImpl class. The goal of this CL is to tell renderer to perform the given action on the media player location at the given point in the view coordinate space. Bug: 1040105 Change-Id: I4b52e1352dc69f433bf8c965459bbd8b060c6f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002488Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#734547}
-
Nate Fischer authored
This separates developer mode state from the mechanism for plumbing developer mode information. These were previously tied together (we examined the enabled state of the ContentProvider which provided flags over IPC), but we observed an issue on Android Q related to disabling and re-enabling a ContentProvider in the same process. Instead, DeveloperModeContentProvider is always enabled and exported, and we examine the state of DeveloperModeState, which is a dummy component we never launch. While this creates slightly more complex code, this significantly simplifies the runtime behavior, because we no longer need to worry about functional code falling into a non-recoverable disabled state. We use an <activity-alias> as the dummy component because it requires the least amount of boilerplate, and there's little harm if the user somehow successfully launches this component. This also includes temporary workaround code: because the previous versions explicitly disabled the ContentProvider, and PackageManager persists this across upgrades, we need to explicitly reset the component state. To make potential future migrations easier, this updates the disableDeveloperMode() to set the component to DEFAULT rather than DISABLED. Bug: 1041943 Test: Manual - try enabling and disabling developer mode on Android Q Test: Repro the bug with buggy APK, upgrade to this APK, UI works Test: Disable dev mode with buggy APK, upgrade to this APK, UI works Change-Id: I410f36fa590026ddc53837f076e6b5912fa075f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005973Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734546}
-
Takumi Fujimoto authored
Set the controller type to kMirroring so that local mirroring sessions don't show up in Global Media Controls. Bug: 1043302 Change-Id: Ib667dae4afc3b078b6aaa7b76618024cf0de1810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007318 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734545}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I9953fbcbd08b61ac98b77be0d838649534a671a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014917 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734544}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: I951945d01287beb4c2f57357da575ec093fa89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015170 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#734543}
-
gogerald authored
Bug: 1045018 Change-Id: I7be550116de433e73fc8c61001110edca9f8e594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017045Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#734542}
-
Jit Yao Yap authored
crrev.com/c/1877088 updated the default behavior of web dialog views to close when the Escape accelerator is pressed. This CL updates the login screen extension UI dialog to not close when receiving the accelerator. Bug: 957573 Change-Id: I72d283f38dd95af6d3909d5c2871b46880117d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014961 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734541}
-
Charlie Harrison authored
These are useful to have around for a while longer. Bug: 1034588 Change-Id: Iaddeed9b331e10d2b9409c1ec0273fa5146cbb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015739 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#734540}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 707e7c14. With Chromium commits locally applied on WPT: 0cbea1f0 "SharedWorker: Add meta.url WPT for SharedWorker with type 'module'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ie763c7bae19d091bb94dd8c9b0e56699c62f42bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017122Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734539}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/261523f9..1b20535e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28adf7d618e11bd8edfbcc4cbeec1887e8874a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017102Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734538}
-
Askar Aitzhan authored
Change the dates to 2021-03-01 for all of them: 1. Because the feature "Cloud Policy over FCM" is not yet released to prod 2. For all of them to be consistent Bug: 1043709, 1043709 Change-Id: I2443e056dd22c141834e9402f7ba0cddbf34ca36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012023Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#734537}
-
Patrick Noland authored
This prevents an NPE that can happen when the IPH controller is initialized after ChromeTabbedActivity#initializeToolbarManager. Since the IPH controller is initialized in a posted task, it's not robust to rely on its initialization order; the simplest solution is to make it responsible for screenshot monitoring directly, avoiding the possibility of an NPE entirely. Bug: 1044888 Change-Id: I6eb4e255cffac998d1bd9e821df73cc90b8d0b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016905 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734536}
-
Benjamin Beaudry authored
This is a reland of 4ccbed03 It got reverted because I forgot to run the Win7 bot and fix the failing tests. Original change's description: > Fix selected state when focused for ARIA gridcell and treeitem > > Before this change, focused gridcell were perceived as selected by ATs. > This is because we assumed that a focused gridcell was also selected, > but that can't be the case. > Gridcells are mentioned here, but all ARIA grid roles and treeitem were > affected by this misinterpretation of the specs. > > According to ARIA 1.0 and above, all ARIA grid cells, rows and columns > are selectable, but not necessarily selected. We can't assume a > relationship between the focused state and the selected state as they > are completely independent. We can only do so when the aria-selected > attribute is implied or required. To the best of my knowledge, it only > is implied and/or required for: > - ax::mojom::Role::kListBoxOption: > - ax::mojom::Role::kMenuListOption: > - ax::mojom::Role::kTab: > > This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). > This method was implemented following the ARIA specs, so that only the > elements with an implied and/or required aria-selected attribute value > are also marked as selected when focused. > > Bug: 1030378 > Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#734001} TBR=kschmi@microsoft.com TBR=aleventhal@chromium.org Bug: 1030378 Change-Id: I43bb335cf19f3a9b64f0505c97299133503a3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015139 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734535}
-
Chris Lu authored
This flag will be used to build out support for scoping FullscreenController to a Browser while keeping the current BrowserState-scoped logic as default. Bug: 790886 Change-Id: Iac1811181a6313271561ffecae306fe4b7b94684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007314 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734534}
-
Stepan Khapugin authored
Moves a bunch of methdos and properties that aren't used in MainController to SceneController and updates call sites. Bug: none Change-Id: Ib5b26f5cd402cb435426f23f060c53dac522104a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012382 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734533}
-
Ben Mason authored
Bug: 1044636 TBR: pauljensen so we can green up the builders Change-Id: I59d296744a6b7481262315db2a66d173a39cf4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016879Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#734532}
-
sebsg authored
Bug: 747064 Change-Id: I4a921a4e33890c751d144c4d257aa83444b47caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015800Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734531}
-
Maksim Moskvitin authored
The test is flaky on various platforms. Bug: 1028968 Change-Id: Ib4d54d0d3625b26e3ac93bc016905c9d3bf44a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017324 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734530}
-
Xianzhu Wang authored
ScrollingCoordinator::UpdateCompositorScrollOffset (renamed from UpdateCompositedScrollOffset) now updates cc scroll tree's scroll offset instead of cc::Layer's. cc::Layer::SetScrollOffset will be limited for layer tree mode only. We need to update the scroll tree's scroll offset immediately (instead of during PrePaint or Paint) because the scroll offset will be used to calculate the new scroll offset with the impl-side scroll delta applied before blink's document lifecycle update. Bug: 1043147 Change-Id: Ic50847da2c8c74cfc2f1cbfda4f5decbf8be466e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013653Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734529}
-
Sigurdur Asgeirsson authored
Keeping track of the average write rate on the instrumented message pipe will allow reasoning on whether there's a spurt of messages coming through, or whether the unread quota protocol implementation is stalling somehow. Likewise the additional cumulative counts and the lifetime will shed some light on the usage of the abused interfaces. Bug: 1011441 Change-Id: I9e3d2b1fcfe2a264208108d2c7ff3cdc4dd11e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013480 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#734528}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10e83a92760c..b04d7c55bff1 git log 10e83a92760c..b04d7c55bff1 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 petermarshall@chromium.org Only call Debugger.setAsyncCallStackDepth while debugger is enabled 2020-01-23 aerotwist@chromium.org [Global] Update refs to Persistence.isolatedFileSystemManager 2020-01-23 tvanderlippe@chromium.org Migrate sdk/ to import cross-module 2020-01-23 aerotwist@chromium.org [Global] Update refs to UI.viewManager & UI.zoomManager 2020-01-23 tvanderlippe@chromium.org Migrate workspace/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@b04d7c55bff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1010534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4969fe4faca21c6a8e788dd98b9dfbc0b1de9302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734527}
-