GitLab

For the mustash project we're eliminating ash-to-chrome delegates because
ash will run in its own process.

Instead of delegating back to chrome to look up a string, do the lookup
directly in ash.

Collapse the string with an existing page info string with almost-identical
text. This saves a little binary size and allows the string to be used in
both chromeos ash code and non-chromeos extensions webui code in chrome.

BUG=724305
TEST=ash_unittests, manual tests of IME menus

Review-Url: https://codereview.chromium.org/2911303003
Cr-Commit-Position: refs/heads/master@{#476314}

Triggering and policy move to LoadingPredictor, instead of being in
ResourcePrefetchPredictor. As a consequence, rename
ResourcePrefetchPredictorObserver.

BUG=715525

Review-Url: https://codereview.chromium.org/2887133003
Cr-Commit-Position: refs/heads/master@{#476313}

Refactoring DownloadManager::DownloadURL to add proper network traffic
annotation. All changed files have received a NO_TRAFFIC_ANNOTATION_YET
tag instead of proper annotation and will be annotated in next CLs.

BUG=656607
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2860593003
Cr-Commit-Position: refs/heads/master@{#476312}

A few timeouts were missed. Removing them from the filter while the cause is
investigated offline.

TBR=sky@chromium.org
TEST=mash_browser_tests
BUG=678687

Review-Url: https://codereview.chromium.org/2913233002
Cr-Commit-Position: refs/heads/master@{#476311}

now it's available there.

BUG=722885

Review-Url: https://codereview.chromium.org/2914203003
Cr-Commit-Position: refs/heads/master@{#476310}

BUG=657041

Review-Url: https://codereview.chromium.org/2917883002
Cr-Commit-Position: refs/heads/master@{#476309}

Bug: 702102
Change-Id: I2fd9c78208b95b9401f8099e2311b595817670ee
Reviewed-on: https://chromium-review.googlesource.com/520182Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476308}

It is an empty target that was there for compatibility with GYP.

Nothing uses it anymore and thus it can be removed now.

The changes to the build side were already done here ->
https://chromium.googlesource.com/chromium/tools/build/+/1ba4afe62e56408169d479018801c04a2d8335ec

BUG=601920

Change-Id: I442368cc860dce8778fd0d064ef99bb3a854be11
Reviewed-on: https://chromium-review.googlesource.com/516982Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476307}

BUG=728116
TEST=crash no longer repros

Review-Url: https://codereview.chromium.org/2919593005
Cr-Commit-Position: refs/heads/master@{#476306}

This CL makes MainActivity#getStartUrl() and
WebApkUtils#getHostBrowserPackageName() share code.

BUG=None
NOPRESUBMIT=true

Change-Id: Ic6aa3f1a959a0f342979aa24c9c7bdcea293983d
Reviewed-on: https://chromium-review.googlesource.com/517563
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476305}

All GetPartAsBytes() callers request data from the beginning of the buffer,
so the method doesn't need a position argument.  Then it essentially turns
into GetAsBytes(), and we can consolidate the two.

(the hidden motivation here is to remove SharedBuffer random-access
semantics, to facilitate future refactoring).

BUG=728627

Change-Id: I63f9ff2f87a01cc4980d38526531dc9118dd87c8
Reviewed-on: https://chromium-review.googlesource.com/519682Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476304}

When a recording does SaveLayerAlpha followed by a single drawing op
and a Restore, we can optimize that as drawing the single op with a
modified alpha. When we can't do this optimization, we were sometimes
throwing away the bounds of the SaveLayerAlpha. This would make a
different set of calls for SaveLayerAlpha-Draw-Draw-Restore vs
SaveLayerAlpha-Draw-Restore, where the latter would not use the
bounds but the former would.

Because we were dropping bounds, we've accrued code that gave
incorrect bounds and relied on them being dropped. I've fixed that
in PaintGeneratedImage in this CL to give correct LayoutTest results.
This change is verified by layout tests such as
http/tests/csspaint/background-image-alpha.html
which would fail with this CL if we didn't make the change, as this
CL would cause us to clip things outside the incorrect bounds.

BUG=671433
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2914863003
Cr-Commit-Position: refs/heads/master@{#476303}

If the active tab is currently null (e.g. Chrome Home NTP is showing)
use OfflinePageBridge#getForProfile() rather than
OfflinePageBridge#scheduleDownload() to avoid the need for a
WebContents.

BUG=725375

Change-Id: I8fb5778402a0e107f481e8a49a5a264876967ac6
Reviewed-on: https://chromium-review.googlesource.com/520622Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Theresa Wellington <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476302}

This CL adds an animation that keeps the resuming Activity hidden for 500ms while 
starting up to allow time for us to draw the black overlay, also added in this CL,
and prevent 2D UI from being shown while entering VR.

This also performs some cleanup around VR entry (now that it's even more async than
before) to ensure that we don't continue trying to enter VR after we try to exit
VR (like when the activity is paused, etc.).

Bug: 728148
Change-Id: I344ad661b632bde74764b134e9d9f70f6258d68d
Reviewed-on: https://chromium-review.googlesource.com/519483Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476301}

Only CrHome is implementing this feature and requires it to be enabled
by default.

In order to disable it on demand for other platforms, the feature is not
deleted (yet).

BUG=703994

Review-Url: https://codereview.chromium.org/2920773002
Cr-Commit-Position: refs/heads/master@{#476300}

The view.width and view.height return the viewport width and height
*excluding* any classic scrollbars. These values are in CSS pixels. The
current implementation of these functions would subtract out the
scrollbar thickness but failed to apply browser-zoom to the scrollbar
(it does correctly apply pinch-zoom though). This patch scales the
subtracted thickness by the browser-zoom factor.

Bug: 728460
Change-Id: I35a3a033ac2909e4191da12cad173ace492f4218
Reviewed-on: https://chromium-review.googlesource.com/520666Reviewed-by: David Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476299}

Setting min_size to 32px for fetching favicons from a Google server
increased failure rate in Chrome M60 3x.

This CL is an emergency fix (merge candidate) to be able to proceed with
rollout of this feature in M59. The CL:
 - sets enforced min_size in LargeIconService to 16px,
 - specifies desired_size in SnippetArticleViewHolder as 32px, and
 - fixes a minor bug in ContentSuggestionsService that blocked 
   propagating desired_size to LargeIconService.

Bug: 728518
Change-Id: I9347fe239a58777c4b1d97ceded19e7587f54e28
Reviewed-on: https://chromium-review.googlesource.com/521082Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476298}

Per https://codereview.chromium.org/2902603002/#msg28, we are only going to
enable network time queries on non-ChromeOS desktop browsers.

BUG=725232

Review-Url: https://codereview.chromium.org/2911263002
Cr-Commit-Position: refs/heads/master@{#476297}

This was added back in crrev.com/329674 and appears unused.

R=mgersh@chromium.org
B=716108
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2918663005
Cr-Commit-Position: refs/heads/master@{#476296}

https://chromium.googlesource.com/angle/angle.git/+log/63d8c26..9216a6e

BUG=chromium:727318

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Iea289d65c9904d1b956e1e39a2e2c4e100778ad7
Reviewed-on: https://chromium-review.googlesource.com/519643Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476295}

FrameView was renamed LocalFrameView which broke our perf tests.
This patch updates the trace names to use LocalFrameView. The
indentation in this patch follows the javascript style guide.

The perf unittests (benchmarks.blink_perf_unittest.BlinkPerfTest) had
a bug where GetRepresentativeNumber was missing parens which is how
this got through.

BUG: 728011
Change-Id: I48ec4efd38ec82338143f931364e7d203a0c771c
Reviewed-on: https://chromium-review.googlesource.com/520711Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476294}

And instead uses ViewTracker

BUG=727934
TEST=covered by tests

Change-Id: Ib9a1f6c894d91053526c85d81ee3a2be849ff955
Reviewed-on: https://chromium-review.googlesource.com/520266
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476293}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=hashimoto@chromium.org

Review-Url: https://codereview.chromium.org/2907223002
Cr-Commit-Position: refs/heads/master@{#476292}

Preparing PresentationController to be used from modules/remoteplayback/

BUG=517102
TEST=run existing tests

Change-Id: I14f1c431eea6bbf4722f2568393c1bb5d8d45d85
Reviewed-on: https://chromium-review.googlesource.com/518682
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476291}

leftView bug appears fixed in iOS 9 and 10.

BUG=546295
TEST=make sure tapping near (usually 50px to the right) the omnibox leftView (page info) doesn't incorrectly fire it.

Review-Url: https://codereview.chromium.org/2917703003
Cr-Commit-Position: refs/heads/master@{#476290}

Stories are flaking with occasional WPR redirect errors.

Bug: 726301
Change-Id: I6df1767a4a069dc9a76c4f56432f21f04c9516ce
Reviewed-on: https://chromium-review.googlesource.com/516708Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476289}

Crash team is preparing to switch stats from being tracked using
histograms to the stability proto. We would like to be confident that we
will not lose accuracy when migrating the old stability proto metric to
a new histogram.

Bug: 726513
Change-Id: I0e3b6eac219b731e9eb815723e882c7d45bfdbe4
Reviewed-on: https://chromium-review.googlesource.com/517864Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476288}

https://skia.googlesource.com/skia.git/+log/3f3075819f24..baf41bd1c8d9

$ git log 3f3075819..baf41bd1c --date=short --no-merges --format='%ad %ae %s'
2017-05-31 iannucci Convert last step.context stragglers.
2017-06-01 borenet Fix missing CIPD package for Valgrind perf bots
2017-05-31 mtklein reland: We can mask load and store with just AVX
2017-05-31 robertphillips Disable deferred proxies for M60 branch

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ibf8637cad87af9bd8590800d87bcd92a53651a97
Reviewed-on: https://chromium-review.googlesource.com/520713Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476287}

For some reason 8.3 now requires documentation to accept the license.

BUG=

Review-Url: https://codereview.chromium.org/2873863002
Cr-Commit-Position: refs/heads/master@{#476286}

The VirtualKeyboardTray button was attaching to a KeyboardController instance
that was being replaced without attaching itself as an observer to the new one.

BUG=726273
TEST=manual

Review-Url: https://codereview.chromium.org/2916653002
Cr-Commit-Position: refs/heads/master@{#476285}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=justinlin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2914593002
Cr-Commit-Position: refs/heads/master@{#476284}

Many of these are only one or two pointers large anyway (e.g. AtomicString,
Vector), so using the heap doesn't save memory, and just adds a pointer
indirection to each access.

Change-Id: If63b228bd0b5f8040c7b13134f063c1e26322f85
Reviewed-on: https://chromium-review.googlesource.com/519846Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476283}

RenderWidgetHostViewGuest resends unconsumed GestureScrollUpdates to
its embedder (via BrowserPluginGuest::ResendEventToEmbedder) which
are then individually wrapped by RenderWidgetHostImpl with
GestureScrollBegins and GestureScrollEnds. Hence OverscrollController
(a) sees a GestureScrollEnd immediately following every
GestureScrollUpdate and ends the overscroll gesture, and (b) does not
see GestureScrollUpdates consumed by the plugin, so
OverscrollController starts an overscroll gesture even though the
content of the plugin was scrolled. Also, OverscrollController does
not have a chance to filter the plugin's gesture events, so even if
an overscroll gesture has started, the plugin can start consuming
scroll updates again.

We now notify OverscrollController (as well as the Mac history
swiper) of the ACKed gesture events from the plugin, so that it
can update its state correctly and allow it to filter the gesture
events of the plugin. They also ignore the wrapper
GestureScrollBegins and GestureScrollEnds as they do not indicate
the beginning/end of the user's gesture.

Note that OOPIF-based guests do not use this resending logic. They
instead rely on RenderWidgetHostViewChildFrame's scroll bubbling
logic. Ensuring this is correct w.r.t. overscroll is being tracked
in crbug.com/713368 .

BUG=694393
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2815823003
Cr-Commit-Position: refs/heads/master@{#476282}

This is needed to be able to run disk_cache_perftest on the platform.

This just uses the Linux implementation, but provides a syscall wrapper
since NDK won't provide one at the API level we build for.

BUG=722885

Review-Url: https://codereview.chromium.org/2885423002
Cr-Commit-Position: refs/heads/master@{#476281}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=finnur@chromium.org

Review-Url: https://codereview.chromium.org/2915523002
Cr-Commit-Position: refs/heads/master@{#476280}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2911893003
Cr-Commit-Position: refs/heads/master@{#476279}

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2908973003
Cr-Commit-Position: refs/heads/master@{#476278}

Story is failing consistently on mac retina bot.

TBR=nenguyen@google.com

Bug: 728576
Change-Id: I6706b20a0465300f969a720c6f23170fab5d8eb5
Reviewed-on: https://chromium-review.googlesource.com/521047Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476277}

This CL adds new GooglePlayInstallResults to better determine the install
failure reason when IPlayInstallService#installPackage() fails immediately

BUG=718475

Review-Url: https://codereview.chromium.org/2906363002
Cr-Original-Commit-Position: refs/heads/master@{#475537}
Review-Url: https://codereview.chromium.org/2917543002
Cr-Commit-Position: refs/heads/master@{#476276}

Currently the results for "blink_gc" in the summary struct are always 0
since we don't actually call the BlinkGC dump provider as it is not
whitelisted. This whitelists the dump provider so we start getting
results.

Bug: 726753
Change-Id: I5228253fcce1baf0ee738d87c70e95ac1c6f9281
Reviewed-on: https://chromium-review.googlesource.com/518115
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476275}