GitLab

This wasn't caught because it's not compiled by default.

BUG=

Review-Url: https://codereview.chromium.org/2037213003
Cr-Commit-Position: refs/heads/master@{#397879}

Review-Url: https://codereview.chromium.org/2034303003
Cr-Commit-Position: refs/heads/master@{#397878}

Since we are persisting our GCM Network Manager task across reboots,
we need to switch to a type of time that will work reliably across
reboots.

We consisered SystemClock.elapsedRealtime, but we think that bad UMA
samples will be more likely from reboots than the user adjusting
wall clock time.

BUG=612325

Review-Url: https://codereview.chromium.org/2037213002
Cr-Commit-Position: refs/heads/master@{#397877}

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Review-Url: https://codereview.chromium.org/2037983003
Cr-Commit-Position: refs/heads/master@{#397876}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a352c80b..9ceb2d30

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2036273003
Cr-Commit-Position: refs/heads/master@{#397875}

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977

Review-Url: https://codereview.chromium.org/1969263004
Cr-Commit-Position: refs/heads/master@{#397874}

Fixes a regression from https://codereview.chromium.org/2009853002
IDK why it matters or if it relates to [still] broken window dragging.

TODO: Fix wallpaper picker dragging (not broken by same CL)...

BUG=557405
TEST=wallpaper picker shows for "Set wallpaper..." in mash.
R=markdittmer@chromium.org,sky@chromium.org,sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2037013003
Cr-Commit-Position: refs/heads/master@{#397873}

Adding logic to add a column if there wasn't one when upgrading.

BUG=615549

Review-Url: https://codereview.chromium.org/2019333008
Cr-Commit-Position: refs/heads/master@{#397872}

There is no pattern in //components of organizing individual
components by logical module. This patch moved
//components/ui/zoom to top-level under //components.

BUG=615568

Review-Url: https://codereview.chromium.org/2019423005
Cr-Commit-Position: refs/heads/master@{#397871}

BUG=613685

Review-Url: https://codereview.chromium.org/2037223002
Cr-Commit-Position: refs/heads/master@{#397870}

"frame-src" is deprecated, and is replaced by "child-src".

BUG=81636, 336788

Review-Url: https://codereview.chromium.org/2012393003
Cr-Commit-Position: refs/heads/master@{#397869}

This will make the Maps test work on Android bots on the commit queue.

BUG=616297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2037933003
Cr-Commit-Position: refs/heads/master@{#397868}

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568

Review-Url: https://codereview.chromium.org/2030193002
Cr-Commit-Position: refs/heads/master@{#397867}

Adds a simple Interstitial API.

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2039613002
Cr-Commit-Position: refs/heads/master@{#397866}

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923

Review-Url: https://codereview.chromium.org/2031833002
Cr-Commit-Position: refs/heads/master@{#397865}

https://boringssl.googlesource.com/boringssl/+log/bbd43b5e90c073a3c8b719d538a273fe683b9944..0fc7df55c04e439e765c32a4dd93e43387fe40be

TBR=svaldez@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2034043003
Cr-Commit-Position: refs/heads/master@{#397864}

This consolidates the certificate parsing from various places in
verify_certificate_chain.cc into a single class that pre-parses all the
important information.
The relevant places are all changed to use the new ParsedCertificate
class, and TrustStore is separated into its own file.

BUG=410574

Review-Url: https://codereview.chromium.org/1976433002
Cr-Commit-Position: refs/heads/master@{#397863}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ccb73566fef2..71d985b3c851

$ git log ccb73566f..71d985b3c --date=short --no-merges --format='%ad %ae %s'

BUG=546021,616832

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2039653002
Cr-Commit-Position: refs/heads/master@{#397862}

Types such as RefPtr<P> provide a custom isEmptyValue function in their
HashTraits. This fixes the std::pair HashTraits to support using such
types in a std::pair.

Review-Url: https://codereview.chromium.org/2042453002
Cr-Commit-Position: refs/heads/master@{#397861}

If a node becomes invalid, the cursor snaps to the nearest valid ancestor.
Fixing this uncovered a lot of places where we were assuming that a cursor's
node must be valid, but it's possible that even with this new check that
a cursor could still be invalid, so I added checks in a lot of places.

BUG=613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007183002
Cr-Commit-Position: refs/heads/master@{#397860}

Revert of Mark some AwContentsClientFullScreenTest tests flaky. (patchset #2 id:20001 of https://codereview.chromium.org/2011453002/ )

Reason for revert:
Avoid disabling these tests on CQ

Original issue's description:
> Mark some AwContentsClientFullScreenTest tests flaky.
>
> BUG=614318
>
> Committed: https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341
> Cr-Commit-Position: refs/heads/master@{#395588}

TBR=torne@chromium.org,mvanouwerkerk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=614318

Review-Url: https://codereview.chromium.org/2039463004
Cr-Commit-Position: refs/heads/master@{#397859}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

This wasn't included in the original CL because the clang tool got
confused when processing this file. It turns out true and false can be
macros!

BUG=581865

Review-Url: https://codereview.chromium.org/2041513002
Cr-Commit-Position: refs/heads/master@{#397858}

NativePixmap unittests were incorrectly using TEXTURE_2D target.

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Review-Url: https://codereview.chromium.org/2038133004
Cr-Commit-Position: refs/heads/master@{#397857}

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513

Review-Url: https://codereview.chromium.org/2024303003
Cr-Commit-Position: refs/heads/master@{#397856}

We'd like to be able to fully serialize CompositorFrames over
mojo. CompositorFrameMetadata has a
cc::ViewportSelection(Bound), which closely resembles
gfx::SelectionBound. This CL works towards unifying these
structs to reduce code duplication.

BUG=611802
TBR=piman@ for content changes.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2030033003
Cr-Commit-Position: refs/heads/master@{#397855}

The combined wm/shell now needs ash/resources too.

BUG=616265
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2039633002
Cr-Commit-Position: refs/heads/master@{#397854}

BUG=609122

Review-Url: https://codereview.chromium.org/2010633004
Cr-Commit-Position: refs/heads/master@{#397853}

https://chromium.googlesource.com/skia.git/+log/adf5afa628ad..69df0206252c

$ git log adf5afa62..69df02062 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 bungeman Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR.
2016-06-03 bungeman Unref GrXPFactory.
2016-06-03 cblume SkMipMap::ComputeLevelSize to return SkISize
2016-06-03 csmartdalton Don't use complex blend mode for shapes gm
2016-06-03 cblume Plumbing mipmaps to the point of creation.
2016-06-03 robertphillips Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack

BUG=578304,578304

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2032133004
Cr-Commit-Position: refs/heads/master@{#397852}

R=eae@chromium.org,atotic@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2010683002
Cr-Commit-Position: refs/heads/master@{#397851}

This test initializes the USB service and calls GetDevices() to exercise
the native USB device enumeration path on all platforms. Since we cannot
guarantee that a particular piece of hardware is connected the result
of this call is not checked. Tested enabled by --enable-gadget-tests
provide deeper converage when matching hardware is available.

BUG=None

Review-Url: https://codereview.chromium.org/2032303003
Cr-Commit-Position: refs/heads/master@{#397850}

This method (and support for alternate interface settings in general)
was only added in API level 21. We must assume that only the default
alternate interface will be reported in older API levels.

BUG=617032

Review-Url: https://codereview.chromium.org/2041553002
Cr-Commit-Position: refs/heads/master@{#397849}

Also updating comments/error output:
BrowserLauncherItemController -> BrowserShortcutLauncherItemController.

BUG=NONE

Review-Url: https://codereview.chromium.org/2039543002
Cr-Commit-Position: refs/heads/master@{#397848}

Style guide requires explicit constructors.

Prior to this patch, a T* can be passed into a function that requires
a scoped_nsobject<T>, and the object will be released but not retained.

Also make the copy constructor that takes a different typename more
generic, allowing for different types (e.g, subclasses) in addition to
different traits.

Clean up all instances where we relied on this behavior.

BUG=

Review-Url: https://codereview.chromium.org/2028823003
Cr-Commit-Position: refs/heads/master@{#397847}

A reference to capturing_net_log_ was passed into the base class constructor
and used before it was fully initialized. For the derived class the initialization
of the members happens stronly after the base constructors completed.

This fixes a bug found by UBSan Vptr.

BUG=617206

Review-Url: https://codereview.chromium.org/2042493002
Cr-Commit-Position: refs/heads/master@{#397846}

The `window` object is a more natural place for the visualViewport API. The
original concern was causing breaking changes since this would clash with any
variable in the global scrope called `visualViewport` but a search through
httpArchive found that this is unlikely to be an issue.

BUG=595826

Review-Url: https://codereview.chromium.org/2025393003
Cr-Commit-Position: refs/heads/master@{#397845}

BUG=598021
R=agl@chromium.org, estark@chromium.org, lgarron@chromium.org

Review URL: https://codereview.chromium.org/2034843003 .

Cr-Commit-Position: refs/heads/master@{#397844}

Most uses of "hover" become "highlight", but SetHovered still refers to
the logical state of mouse hover so that remains unaltered.

BUG=none

Review-Url: https://codereview.chromium.org/2034963002
Cr-Commit-Position: refs/heads/master@{#397843}

BUG=614277, 543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2031833003
Cr-Commit-Position: refs/heads/master@{#397842}

Remove kSyncInputForSyncCompositor switch and all code behind it. M51
shipped without it and looks fine, so remove all the code.

BUG=545628

Review-Url: https://codereview.chromium.org/1974133002
Cr-Commit-Position: refs/heads/master@{#397841}

BUG=458193

Review-Url: https://codereview.chromium.org/2033883002
Cr-Commit-Position: refs/heads/master@{#397840}