- 18 Nov, 2020 40 commits
-
-
Patrick Brosset authored
In the DevTools flex tooling project, we want to be able to control how the empty space (created by justify-content, align-content and gap properties) look. We want to do so in a way that allows to highlight just one, or several of them. So this CL simply adds the required properties to the corresponding CDP types as well as handling of this data so it goes to the overlay frontend. Bug: 1139949 Change-Id: Ibfbd33531f3f2018447d113807f3878b823cfd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539742 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#828846}
-
Kevin Marshall authored
Handles the crasher in which the metrics recorder channel is disconnected while additional metrics are being gathered. Test: cr_fuchsia_base_unittests Bug: 1147146 Change-Id: Iff987933233bd1565ed052b1ca1e1225b30e782d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538331 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#828845}
-
Wez authored
Publishing the fuchsia.web.FrameHost introduces the possibility that it causes the main web.Context to be created before the list of CORS- exempt headers has been fetched. This can prevent headers being applied based on UrlRequestRewriteRules, breaking later users of that Context. StartComponent() is split into the public API which verifies arguments and triggers fetch of the CORS exempt headers list, if necessary, and a separate internal part called when the headers are available, which actually creates the FrameHostComponent, or PendingCastComponent. Bug: 1150488 Bug: b/173386485 Change-Id: I2f294e9f0acbf43c971004882461c0f38a4c37b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547580 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828844}
-
Stephen McGruer authored
The lack of __init__.py was failing the import in resource-timing/SyntheticResponse.py, which then caused external/wpt/resource-timing/resource-timing-level1.sub.html to timeout. Bug: None Change-Id: I8dc2c9f9d439c7c2c1cbaad9225f24563eb0e99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546993 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#828843}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..d361e6028c27 2020-11-18 primiano@google.com Merge "test data: Add chrome_memory_snapshot.pftrace" 2020-11-18 treehugger-gerrit@google.com Merge "metrics: Add camel-case mapping for modified RAIL mode names" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icdc6cf1da231cde2786ac9462c92f581a934ab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828842}
-
David Tseng authored
It is generally bad practice to send the tts engine an empty string. This change will try to identify all call sites or scenarios where this occurs. If many such instances occur, a allow list (for now) with bugs filed against owners should be added. R=dmazzoni@chromium.org Change-Id: Ie08dd07e07bf43419aadde83786e5724dd196f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538035 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828841}
-
Nina Satragno authored
It's flaky. Tbr: masonfreed@chromium.org Bug: 1150475 Change-Id: I772bf0577ba5d2772340731e7384779238e6734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547383 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828840}
-
Robbie McElrath authored
This reverts commit d5f58580. Reason for revert: A CL this depends on got reverted Original change's description: > [WebLayer] Create FragmentHostingRemoteFragmentImpl > > This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl > and MediaRouteDialogFragmentImpl, replacing them with a Context that > hosts the fragments instead. This is possible now that we've landed > the bytecode rewriting that changes the return type of > Fragment.getActivity() from FragmentActivity to Activity. > > Bug: 1123216 > Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828649} TBR=sky@chromium.org,finnur@chromium.org,estade@chromium.org,rmcelrath@chromium.org Change-Id: I2b83becfef2a92bd878bf32ae3aa5b750853a752 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547783Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#828839}
-
Anton Bikineev authored
Layout partition is not thread safe. Bug: 11297512 Change-Id: I4c5f7e5a8c181bd1dc9781d1e79ee9101f61c15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547442 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828838}
-
Dave Tapuska authored
The case where a LocalFrame (A1) had an intermediate LocalFrame (A2) owning a RemoteFrame (B1) wasn't covered. The notification was sent only to the LocalFrame root's remote frame descendants. Iterate the frame tree going over LocalFrame but stopping when we encounter a LocalFrame root. BUG=1149775 Change-Id: I1d9f3d51685fd08794335fb93b103db930b24cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543130 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828837}
-
Mario Sanchez Prada authored
By mistake, I added a selection_clipboard_buffer_available member to the end of the IPC struct traits for blink::RendererPreferences, but such member was already present a few lines above, which is a mistake. Looking into the issue today, I realized that the reason I didn't see was that it was guarded by defined(OS_LINUX) || defined(OS_CHROMEOS), along with system_font_family_name, which is not exactly correct since the right guard would have been defined(USE_X11) || defined(USE_OZONE). This CL simply removes the declaration from the original place and leaves the one added in the CL that introduced the duplication [1], which has the member added inside the right guards. [1] https://crrev.com/c/2445499 Bug: 1102442 Change-Id: I9f02705ce1e07ca76f7581cbb8b2b37034650b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544947Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#828836}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iae6d832f2fec2f0a146fb08828fa077f4846162d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828835}
-
Chan Li authored
Bug: 1108016 Change-Id: If209efabc72acd684ce2a34100844d6fc6dda8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542823 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#828834}
-
Yi Xie authored
DiskMountManager depends on dbus calls to cros-disks. A recent change crrev.com/c/2422018 blocked access to internal disks through cros-disks. BUG=b:173102552 Change-Id: I4c368f3f934371bbb3d5a777a82fdf3721d67eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537535Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Yi Xie <yixie@chromium.org> Cr-Commit-Position: refs/heads/master@{#828833}
-
Nancy Wang authored
There are other app icon badgings, e.g. pause badge, block badge, the current UpdateAppBadging is used to update the notification badging only, so rename the related function names. BUG=1144384 Change-Id: I7ec07dc7687bd55cb3566b423665cded9714b95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545336 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828832}
-
edchin authored
This reverts commit cac286db. Reason for revert: This should have been landed after the CL to move the password_store_signin_notifier_impl. Original change's description: > Revert "[ios][PhishGuard] Port code to ios_chrome_password_store_factory" > > This reverts commit 8d720de8. > > Reason for revert: Compile failure on ios-device > > 'components/password_manager/core/browser/password_store_signin_notifier_impl.h' file not found > > https://ci.chromium.org/p/chromium/builders/ci/ios-device/172358 > > Original change's description: > > [ios][PhishGuard] Port code to ios_chrome_password_store_factory > > > > Design doc: go/bling-phishguard > > > > The password_store_factory had already been forked between > > //chrome and //ios. This CL ports password reuse detection code > > from //chrome into the //ios implementation. > > > > Runtime changes are behind the kPasswordReuseDetectionEnabled > > feature flag. > > > > Bug: 1147962 > > Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748 > > Commit-Queue: edchin <edchin@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828562} > > TBR=vasilii@chromium.org,edchin@chromium.org > > Change-Id: I2286176790447a0dc192c01a6f4a888699f77c70 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546302 > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828566} TBR=vasilii@chromium.org,edchin@chromium.org,qjw@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1147962 Change-Id: I5771528c764e83a7ce50f382eb65b93097283c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546172Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828831}
-
Erik Språng authored
Bug: 1143271 Change-Id: I1b24f23d1e3749bf4a4283b38f79a607129180cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544547 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828830}
-
Xianzhu Wang authored
Bug: 936906 Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828829}
-
Andrey Zaytsev authored
Since the downstream code uses PrivacyPreferencesManager, left a class with a single getInstance() method. Bug: 1132805 Change-Id: Ia1d2d9861c5a4782bb374d09fd36107d0ee2580c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543936 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#828828}
-
Kyle Horimoto authored
When a NearbyConnectionBrokerImpl object is deleted, invoke DisconnectFromEndpoint() if a connection had been established during the lifetime of the object. Specifically, if OnConnectionInitiated() has been called but OnDisconnected() has not, we disconnect. Bug: 1149770, 1106937 Change-Id: I1c805475400d84d87092fbfafae20f0c48b7208c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545670Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828827}
-
Kent Tamura authored
- Remove DEFINE_DOCUMENT_TYPE_CASTS() macro It's not used. - Remove DEFINE_TRACK_TYPE_CASTS() macro It's not used. - Remove DEFINE_TYPE_CASTS() for PresentationConnectionAvailableEvent The code generated by this DEFINE_TYPE_CASTS() are not used. This CL has no behavior changes. Bug: 891908 Change-Id: I8a60227c042f85c7d25184258e105b1ba2a9eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546393 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828826}
-
Luke Zielinski authored
This is the first stage of replacing the existing linux-wpt-payments-fyi-rel builder with this new 'input' builder. The next set of CLs will switch to using 'input' instead of 'payments' in wpt-importer smoketests. Bug: 1127055 Change-Id: I2f3aab01e99991733cc2f936d729dbb21e666b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545286Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828825}
-
Michael Checo authored
- Will be updated to adhere to the spec in the future. Screenshot: http://shortn/_17jazhYXnr Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: I55770ae52546b055f77766eb31644d3218ec8658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530452 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828824}
-
ckitagawa authored
Use slightly wider tiles, but request fewer at a time. This should reduce memory overcommit. On low mem devices don't request more than 1 tile at a time. Bug: 1144768 Change-Id: I115524c5a226487675d040d37865e0a858abf28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546964Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#828823}
-
Yulun Wu authored
Note: Classic shelf colors can now be safely removed. https://bugs.chromium.org/p/chromium/issues/detail?id=1146464 Bug: 1145356 Change-Id: If106ff7954e0b1c6f8b4136dd89fac3ceb7b075e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545489Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828822}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ef7e206b9a2..fcc4e85f3c0b 2020-11-18 bsalomon@google.com Remove SkYUVAInfo::PlanarConfig If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I2c8318582bbb31e98a7a000e432ad4f37f690e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547145Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828821}
-
Saurabh Nijhara authored
The browsertest related to javascript blacklist is moved into url_blacklist_policy_browsertest. Bug: 1149970 Change-Id: Ifa5a946907389d335b3f83f87fd3ce9e6d388af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544723 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828820}
-
Nikita Podguzov authored
What in fact happened before: * Test suite is instantiated * New TestingBrowserProcess is created * ScopedTestingLocalState is created and substitutes browser local state * If the test case is not the first one, no DlpRulesManager initialization happens. This also means that PrefChangeRegistrar is bound to the destroyed object. This led to the situation that after first successful test run DlpRulesManager stopped receiving policy updates and failed on all other test suites. To fix this, we need manually delete instance of DlpRulesManager after the test run, so it initializes itself correctly for next test. Ideally, instead of using DlpRulesManager as a singletion we could transfer its ownership to one of more general policy objects. We wouldn't need to delete the instance manually in that case. Bug: 1131392 Change-Id: Ifa51f1c0d68a900d6ab62b19504148814844bbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547241Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828819}
-
edchin authored
Design doc: go/bling-phishguard This CL moves the Impl file so that it can be compiled on iOS as well. Bug: 1147962 Change-Id: Icbdb4cfc0a06b79a11012230700d676f5408e8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544070 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828818}
-
Stephen Nusko authored
This has been flaky since being added in http://crrev/c/2512367. enga@chromium.org Bug: 1150490 Change-Id: Iac75b4ba6422e68a4ed87001d80e0fb55857bcda No-Try: True TBR: johnchen@chromium.org CC: behdadb@chromium.org, jonross@chromium.org, sadrul@chromium.org, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546966 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828817}
-
Jacob Kopczynski authored
Bug: chromium:1127088 Change-Id: I9c383eba922eafc94d87f4362bfaa37c076aafcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545877 Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828816}
-
Antonio Sartori authored
Probably because of a typo, we where parsing the Content-Security-Directive 'treat-as-public-address' as 'worker-src' instead. Since 'treat-as-public-address' is ignored in Blink anyway, the only real problem was that if a CSP directive list contained both 'treat-as-public-address' and 'worker-src', in this order, then 'worker-src' would be ignored. This CL fixes that. Bug: 1150314 Change-Id: I7876ddd3440dd761289619afaf92b4ff3e6a9c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544885Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#828815}
-
Nick Burris authored
Updating these metrics' expiry to match the others. Bug: 1149509 Change-Id: I4d0c20572eef024e169c71df9daab868c3f72606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542842 Auto-Submit: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#828814}
-
Stephen Nusko authored
This has been flaky for awhile since at least November 11th. Bug: 1149983 Change-Id: Ia478a5bb9af6720bec2ac895c29529182e087e73 No-Try: True TBR: johnchen@chromium.org CC: tmrts@chromium.org, mythria@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547660 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828813}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4419a69301e267f273e36311b93fbd4e1fa6803f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828812}
-
Peter E Conn authored
Change-Id: I5da8da1fec48214f7b7051793954ded89380e6a5 Bug: 1104817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490105Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828811}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/50066a3edffa..43fcd32b4fae 2020-11-18 rnk@google.com Use pragmas to work around MSVC x86_32 debug miscompile bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3bdab05f7c4e00d09c9c2006a446e5998f1cab2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547144Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828810}
-
Anton Bikineev authored
Bug: 11297512 Change-Id: I51a1de2a77553f2122ca01c62c1e5cb067c3b05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544893Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#828809}
-
Peter McNeeley authored
Command line help for the unit test launcher indicates that the command line variable "--gtest-repeat" is supported when it is actually the variable "--gtest_repeat" that works. Change-Id: Ice54828defdd30347d637a7d809bcbe6ae8e7c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547201 Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828808}
-
Jan Wilken Dörrie authored
This change simplifies the NameToLabel helper inside CSVPasswordSequence to use the new base::fixed_flat_map and return a simple pointer instead of a base::Optional. Bug: 934326 Change-Id: I1325a7470151ee31af37dcc21919d696d829edbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544606Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#828807}
-