- 30 Oct, 2018 40 commits
-
-
Collin Baker authored
ReopenTabInProductHelp will manage the reopen tab in-product help. It will aggregate user events and kick off the IPH flow at a good time. Bug: 887991 Change-Id: I2b245851bdb6af852cd458a378f3325289922b4c Reviewed-on: https://chromium-review.googlesource.com/c/1299918 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#603786}
-
Steve Kobes authored
Bug: 581518 Change-Id: Ib3f64e7a3d05d9f13b6693361bafc355e4290006 Reviewed-on: https://chromium-review.googlesource.com/c/1294695Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603785}
-
Tatsuhisa Yamaguchi authored
This change updates tooltip for the latest design spec. The tooltips describe either the number of notifications or being in DnD mode, so that these should work well for a11y label as well. Bug: 888072 Change-Id: Ifed382eca722c6948cf14a9f834ad0bb314c1629 Reviewed-on: https://chromium-review.googlesource.com/c/1306935Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603784}
-
Amos Lim authored
legend.focus() should not delegate focus. Bug: https://github.com/whatwg/html/issues/3950 Bug: 880026 Change-Id: I35e046e45bbc45628f148383eaa77f12245e9e98 Reviewed-on: https://chromium-review.googlesource.com/c/1304180Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#603783}
-
Xianzhu Wang authored
- Replace EXPECT_DISPLAY_LIST with EXPECT_THAT(display_item_list, ElementsAre(IsSameId(...))) - Define operator<< for DisplayItemClient, DisplayItem::Type, etc. - Let operator<<(const LayoutObject*) output the address to distinguish different objects - Use EXPECT_THAT(paint_chunks, ElementsAre(IsPaintChunk(...), ...))) Change-Id: I4b1d83ca27f218eae110bd3e91fb955e8ac1f656 Reviewed-on: https://chromium-review.googlesource.com/c/1303338Reviewed-by:Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603782}
-
Siddhartha authored
BUG=859260 Change-Id: I23044240996b52cc532de618fa0fef7164713d30 Reviewed-on: https://chromium-review.googlesource.com/c/1233233 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603781}
-
Jazz Xu authored
Change-Id: I9c2ca23a845a17b33d0fd4acb66a28f7f7ddfa5e Reviewed-on: https://chromium-review.googlesource.com/c/1306238Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603780}
-
Findit authored
This reverts commit 133164fc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 603776 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEzMzE2NGZjZjQ5MjdkYmU0N2FiMjAwMzc1OGM2ZDM4YmFiODE5MmIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29/133426 Sample Failed Step: compile Original change's description: > Convert WebOriginTrials namepsace to a static-only class > > https://www.chromium.org/blink/public-c-api#TOC-Naming > > All public Blink API types and classes are in the namespace blink and > have the prefix Web. > Namespace name should be lower-case but we can't make 'namespace > WebOriginTrials' lower-case because of this naming rule. So we convert > WebOriginTrials to a static-only class. > > Bug: 889726 > Change-Id: Ia2fe9888da297b965d891287f05fb99d45d802f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1304185 > Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603776} Change-Id: I121b4217ed4132d9f739c400950b57b6746e70f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889726 Reviewed-on: https://chromium-review.googlesource.com/c/1307064 Cr-Commit-Position: refs/heads/master@{#603779}
-
Evan Stade authored
aura::client::kImmersiveFullscreenKey is folded into ash::kImmersiveIsActive No bug here currently, but it's confusing to have two different properties that are both meant to indicate immersive mode is active. Also removed some unnecessary ash:: prefixes from //ash. Change-Id: I0c43873fa8f128c3799d32f2c479a1f2caa9a7cf Reviewed-on: https://chromium-review.googlesource.com/c/1298493Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#603778}
-
Yuzu Saijo authored
Add a new group config name for experiments. Change-Id: I4d522dd54be964958b9e32916523a11322543693 Reviewed-on: https://chromium-review.googlesource.com/c/1303318Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#603777}
-
Zhuoyu Qian authored
https://www.chromium.org/blink/public-c-api#TOC-Naming > All public Blink API types and classes are in the namespace blink and have the prefix Web. Namespace name should be lower-case but we can't make 'namespace WebOriginTrials' lower-case because of this naming rule. So we convert WebOriginTrials to a static-only class. Bug: 889726 Change-Id: Ia2fe9888da297b965d891287f05fb99d45d802f5 Reviewed-on: https://chromium-review.googlesource.com/c/1304185 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Iddfa7b6912a753878bef0a85510f9b5f4dcc6e4c Reviewed-on: https://chromium-review.googlesource.com/c/1306956Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603775}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/06305f5d71c7..05e43638cd37 git log 06305f5d71c7..05e43638cd37 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Rename two more CJS_PublicMethods methods. Created with: gclient setdep -r src/third_party/pdfium@05e43638cd37 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2eb7c27b45d8ca89236d0fba97228666eb54160c Reviewed-on: https://chromium-review.googlesource.com/c/1307114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603774}
-
Tetsui Ohkubo authored
This CL removes NotificationTray because now it's replaced by UnifiedSystemTray. This is the part 3 of removing old System Tray (+Notification Tray) code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG=898419 Change-Id: I90f2904161aa453a0048947bf22bf31158d9442f Reviewed-on: https://chromium-review.googlesource.com/c/1304184 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06a4ef497ff1..14768f64fba3 git log 06a4ef497ff1..14768f64fba3 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 caryclark@skia.org update docs for new/changed textblob apis 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4a22f4b04619..3420dcb0cff1 (7 commits) 2018-10-29 brianosman@google.com Keep paint color range/precision into ops and GPs (using GrColor4h) Created with: gclient setdep -r src/third_party/skia@14768f64fba3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I0f05efd8a4977f500acccf8fb18277af6e6775e5 Reviewed-on: https://chromium-review.googlesource.com/c/1306756Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cf33fa7deb4..32abeea1737e Created with: gclient setdep -r src-internal@32abeea1737e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic257f570a844ecfb2afebd13eff76efc7a5eb72d Reviewed-on: https://chromium-review.googlesource.com/c/1307115Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603771}
-
Toni Barzic authored
This was intended to enable auto-filling network credentials during Chromecast setup, but never actually caught on (i.e. it has not been actually used). BUG=846971 Change-Id: I66e5e316ec91eac0c286f82aa4aad1573ed931f8 Reviewed-on: https://chromium-review.googlesource.com/c/1297407 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603770}
-
Tsuyoshi Horo authored
This reverts commit 7b97163e. Reason for revert: Failed ios-device build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/103715 Original change's description: > [ios] Drop iOS10 support, move deployment target to iOS11. > > Bug: 894099 > Change-Id: I638bd439a96e105cd33aa858cfd1209ed2ceabc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1297250 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603758} TBR=dpranke@chromium.org,marq@chromium.org,justincohen@chromium.org,pkl@chromium.org,scottmg@chromium.org,jbudorick@chromium.org Change-Id: Id78ea18cc5a77fa7a967867a890dd81a6af5eea6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894099 Reviewed-on: https://chromium-review.googlesource.com/c/1306936Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603769}
-
Oystein Eftevaag authored
The broad strokes behind this CL is that TracedValue now can be supplied with a factory function, which is used to override its backing implementation. When Perfetto is enabled, this is used to let TracedValue write directly to a proto which can then be memcpy'd into the Perfetto shared buffer, rather than being written into a base::Pickle which is then serialized as a JSON strong. Dependent on these CLs landing and rolled into //third_party/perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/792813 https://android-review.googlesource.com/c/platform/external/perfetto/+/792814 TBR=csharrison@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bfa0cd7398a0ac4788c56d5be13fe951dc56770 Reviewed-on: https://chromium-review.googlesource.com/c/1263354Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603768}
-
Scott Chen authored
Bug: 874122 Change-Id: Ic25e7cf5b0c2d37af4d9ba2af311f9ce0c12e08b Reviewed-on: https://chromium-review.googlesource.com/c/1298616 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#603767}
-
Scott Chen authored
This CL adds the boilerplate codes for browser-testing the onboarding welcome UI, and one simple test to verify it works. There will be follow-up CLs to add more browser tests to all onboarding welcome elements. Bug: 881937 Change-Id: I1c1d33411ad55eff5fd4ab43bd3cc1b93a257d3e Reviewed-on: https://chromium-review.googlesource.com/c/1300673 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ied5535100c5612069aeae967095b2c732f68c159 Reviewed-on: https://chromium-review.googlesource.com/c/1306642Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#603765}
-
Tetsui Ohkubo authored
According to UX spec, check icon shown on the right side of a11y detailed view is 28994F. This change is important in terms of color contrast. TEST=manual BUG=899162 Change-Id: Idd32cbf94d974355a6229ef7bb88e9ae714ab97c Reviewed-on: https://chromium-review.googlesource.com/c/1304284Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603764}
-
Bailey Berro authored
This is the first in a series of changes to create a freeform dialog for adding an SMB share in addition to the dialog existing in settings. - Moves add_smb_share dialog to cr_components - Switches $i18n{} to i18n() - Updates BUILD files Bug: chromium:887135 Test: verified on test device Change-Id: I1133d9e45ee7ac63e338e22e4e69e3e000a3ee02 Reviewed-on: https://chromium-review.googlesource.com/c/1281868 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#603763}
-
Yuri Wiitala authored
Adds the implementation that determines which shader programs to use, and in what order, to execute scaling and format conversion. Also, adds pixel tests to check all the various features provided by GLScaler (via its Parameters). Bug: 870036 Change-Id: I7cb1d64d6df79a3a6221c2ab6cdf4b504b26c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1298737 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603762}
-
Hector Carmona authored
Both the email and google app modules will show the bookmark bar. This change makes it so that the state of the bookmark bar is returned to the way it was before it was shown if no bookmarks are added. R=scottchen@chromium.org Bug: 881937 Change-Id: I64d0a03f6747589d594720dad406e14ee4483ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1302316 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603761}
-
Regan Hsu authored
Add metrics that break down the percentage of users who either accepted or declined MultiDevice OOBE setup. Bug: 870141 Change-Id: I1cf85910a3e445ca3b0b16e35028b5a816b6ec9b Reviewed-on: https://chromium-review.googlesource.com/c/1298495 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I625fa68bf159d2ff66b5314149217823c2f7fb75 Reviewed-on: https://chromium-review.googlesource.com/c/1303326 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
Justin Cohen authored
Bug: 894099 Change-Id: I638bd439a96e105cd33aa858cfd1209ed2ceabc9 Reviewed-on: https://chromium-review.googlesource.com/c/1297250Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603758}
-
Robert Sesek authored
There are no more users of this implementation, and the new shared memory APIs do not support FD-backed shared memory on Mac. Bug: 776564 Change-Id: I9307a6e46daa4329f0d04e6951b6e432a79c2c47 Reviewed-on: https://chromium-review.googlesource.com/c/1303873Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
-
Eliot Courtney authored
Bug: 883114 Bug: 841886 Bug: b/115291749 Test: ash_unittests Change-Id: I2e6cd712e9550d7d4ce4f971f5800dec18316078 Reviewed-on: https://chromium-review.googlesource.com/c/1298530Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#603756}
-
Hiroki Nakagawa authored
This is a cleanup CL. Before this CL, AccessControlStatus for classic worker scripts are passed from each worker implementation to WorkerGlobalScope. Actually, however, AccessControlStatus::kSharableCrossOrigin is always specified because cross-origin workers are disallowed. For cleanup, this CL stops passing AccessControlStatus and instead hard-codes it in WorkerGlobalScope. Bug: 835717 Change-Id: I9af910c113f1d5f032e77f48f54e1bc74153808b Reviewed-on: https://chromium-review.googlesource.com/c/1304279 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603755}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e137b5c3f43c7c5f8811b0e481d7dc31f70c735 Reviewed-on: https://chromium-review.googlesource.com/c/1307113Reviewed-by:
-
Darwin Huang authored
Added comments to explain what KURL and GURL stand for. Mostly just trying to make clear things that I was confused about when first parsing the code Bug: 896479 Change-Id: Ic6857750884a2954ed32f5d4af3c32ff3356377b Reviewed-on: https://chromium-review.googlesource.com/c/1300681Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603753}
-
Jay Harris authored
Dependencies on the LocationBarView have been abstracted into a delegate, so as to make the LocationIconView reusable. This is in preparation for introducing a CustomTabBarView for Desktop PWAs, which will have its own LocationIconView. Bug: 853593 Change-Id: I5817041e532cd8db6065f2a818e6b203a91fb012 Reviewed-on: https://chromium-review.googlesource.com/c/1248067 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603752}
-
Eric Aleshire authored
The WPR tests are now running on ios-wpr-simulator, but failing due to the proxy certificates not getting installed on each sim. I hypothesize this is happening due to an oversight where I do not explicitly create the simulator before installing certificates - therefore, I create the sim as done in SimulatorTestRunner, install certificates, then tear it down at the end of testing. Bug: 892381 Change-Id: I5a77ee609a462be18f22507fb6e73d9229126102 Reviewed-on: https://chromium-review.googlesource.com/c/1306844Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#603751}
-
dpapad authored
Bug: 898763 Change-Id: Iff586501573beaea6ddf8e6ea9d9e5675f480bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1303403Reviewed-by:
-
Chase Phillips authored
This reverts commit d42a4b6f. Reason for revert: The "content/renderer/indexed_db move to Blink" change originally landed as commit d42a4b6f. We received a confirmed report in https://crbug.com/899446 that in one instance an IndexedDB database had its values replaced with incorrect values which bisect showed was caused by that change. We also found a possibly-related issue due to persistence when using Gmail with offline-enabled. This change reverts commit d42a4b6f so the pre-move functionality is restored while we investigate the cause and come up with a fix. This also reverts commit a5b50bfe that removed a using declaration. Original change's description: > IndexedDB: Move content/renderer/indexed_db/ to Blink > > Also in this CL: > - Add a :mojom_modules target to allow mojom files in this group > to link against symbols that only exist in the modules layer. > - Rename indexed*db_struct_traits* to _mojom_traits*. > > Bug: 717812 > Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b > Reviewed-on: https://chromium-review.googlesource.com/c/1265900 > Commit-Queue: Chase Phillips <cmp@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602911} TBR=cmp@chromium.org,dcheng@chromium.org,jsbell@chromium.org,kinuko@chromium.org,dmurph@chromium.org,mek@chromium.org,reillyg@chromium.org,clamy@chromium.org,haraken@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717812 Bug: 899446 Change-Id: I89ba3b64e3b14158d520ed513355b2ac07a09ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1305243Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603749}
-
Josh Pratt authored
Adds feature for Mounting Usbs into Crostini. Bug: 891381, 899568 Change-Id: I36f5cdf88d2901b24c9ef83671418fae64f275ad Reviewed-on: https://chromium-review.googlesource.com/c/1301095 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#603748}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I7a99eaccc08cb2763bfc631f1a725022d59c79f8 Reviewed-on: https://chromium-review.googlesource.com/c/1307013Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#603747}
-
