- 23 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1042208 Change-Id: I76fab1199331f19d4fda31396e4631a16e2c9242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017343 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734669}
-
Nick Burris authored
Screen readers read from the top of the page on a scroll to text navigation, instead of the targeted text. This patch adds an AX call that is made when navigating to an anchor, as is done with element fragment anchors. Confirmed this works with TalkBack on Android. Bug: 1044644 Change-Id: If5c905b083189efd7276f64abc4a547f81f6b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015132Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#734668}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: I567615141ce700cd3edc6327de23b331f38c69a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017468 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734667}
-
Avi Drissman authored
BUG=1044828 Change-Id: I74cf58b4669851006d97f1b81c7a0f5ea6d3e609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016964 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734666}
-
Avi Drissman authored
BUG=1044828 Change-Id: I375866984e4878833b19c29a1276af948756b228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016860 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Lei Zhang authored
- Consolidate Pepper code within a BUILDFLAG(ENABLE_PLUGINS) section in browser_prefs.cc. - Make AddStringsForPdf() a no-op if BUILDFLAG(ENABLE_PDF) is not set in resources_private_api.cc. Bug: 1027360 Change-Id: Ie99dcc278d3b30282f4215e36ac95a6434fa0ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017663Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#734664}
-
Saman Sami authored
This is a reland of ae629163 Original change's description: > viz: Fix FindLatestSurfaceUpTo when there is conflict > > The condition used in the binary search was wrong. Fixed it and added > a unit test. > > Bug: 1000868 > Change-Id: Iaf4af1bdfdb88db1082bfae89a3783faed860934 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800743 > Auto-Submit: Saman Sami <samans@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696170} TBR=jonross@chromium.org,samans@chromium.org Bug: 1000868, 1015120 Change-Id: I2b793035cd689551217e23de5e43d0fd855cbf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017945Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#734663}
-
Xinghui Lu authored
This metric records the time between a password reuse dialog is shown and a user clicks one of the buttons on the dialog. It will help us understand if users pay less attention to dialogs on Android than on desktop. Bug: 1036042 Change-Id: I2f525778d3b2109b05105f5456e5bc16ddc94f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013493 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#734662}
-
Ben Pastene authored
- journal contains system-wide logs (in a machine-readable format). - power_manager contains logs from the daemon that controls system power, and may provide some insight when a device/VM shuts down unexpectedly Bug: 1043953 Change-Id: I14721bdbdc62095d864145bd3d491c2d880b1df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016665Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734661}
-
Gabriel Charette authored
It was never used and never will be as the IO thread is being phased out altogether. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1660340 This CL keeps (diff with the raw revert on PS1): 1) TaskQueueThrottler's Metadata inner class which isolates some logic 2) TaskObserver::OnQueueNextWakeUpChanged dropping the unused TaskQueue* param 3) TaskQueueImpl::SetObserver in favor of TaskQueueImpl::SetOnNextWakeUpChangedCallback (more adaptable to future instrumentation) 4) BrowserTaskQueues::Handle as a ref-counted class (could go back to being copied around but avoiding duplicate state makes state management easier and even essential in some cases like validator_sets_ used to require) Note: The provider of Handle at the time has been renamed from BrowserIOTaskEnvironment to BrowserIOThreadDelegate if you're looking for it. Side-effect: this keeps all the . to -> usage changes for Handle. And removes: A) TaskQueueObserver::OnPostTask B) BrowserTaskQueues::Validator C) ScopedDoNotUseUIDefaultQueueFromIO This is associated to crbug.com/1026641 because supporting BrowserTaskQueues::Validator adds an unnecessary burden (not that it'd be impossible to re-add them if explicitly necessary post-migration). TBR=nasko@chromium.org (BUILD.gn) Bug: 863341, 1026641 Change-Id: I7bfdc8730cacbac33e2e9b57d1936b6755033753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008462 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734660}
-
Andrew Xu authored
Now hotseat is hidden after restoring the active window from overview. The reason is illustrated in the bug description. Actually the in-app shelf only exists in tablet mode where no mouse is available (if there is the mouse connected, device will switch to clamshell mode). So there is no point to check whether mouse event is enabled for shelf widget in this scenario. So skip that code block in tablet mode. Meanwhile, the CL uses the additional attribute to ensure that hotseat is not hidden by window restoration. Bug: 1044366 Change-Id: I6cd2568f2eb7a32aabb8a6be373118ec6c501634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015802Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734659}
-
Demetrios Papadopoulos authored
- Add polymer_modulizer() and js_modulizer() rules as necessary to generate a Polymer3 version of certificate-manager at build time. - Remove unnecessary settings.Router references from tests. - Auto-generate tests for the Polymer3 version (and update Settings WebUI data source as needed) - Add a missing assertion in js_modulizer.py that was discovered. The Polymer3 version will be used by follow up CLs to migrate chrome://certificate-manager and eventually chrome://settings Bug: 1042558 Change-Id: I3a857a45d8f6db578f2059a619720d78fd863e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006615 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734658}
-
Tim Van Patten authored
The test conformance2/rendering/framebuffer-texture-level1.html is flaky on AMD GPUs on Mac Retina: https://ci.chromium.org/p/chromium/builders/try/mac-angle-rel/4837 https://ci.chromium.org/p/chromium/builders/try/mac-angle-rel/4791 This CL will suppress that test while the issue is investigated. Bug: 1044638 Change-Id: Iac30d591a1126d8cbdc373167ce3591b6279b210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015440 Auto-Submit: Tim Van Patten <timvp@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#734657}
-
kylechar authored
There is logic in GLOutputSurface to ensure that SetDrawRectangle() is only called once per swap. However, it's possible for Display::DrawAndSwap() to to draw and not swap. GLOutputSurface will ignore the first SetDrawRectangle() after Reshape() if the last swap was skipped. DirectCompositionChildSurfaceWin::Resize() releases the draw texture, so it should be safe to call call SetDrawRectangle() again after Reshape() even if SwapBuffer() wasn't called. This CL also implements equivalent logic in SkiaOutputSurfaceImpl for SkiaRenderer. Bug: 1042007 Change-Id: Ib1a8f5092d004172d37fe4c16d8a7144cbc7ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013346Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#734656}
-
Prabir Pradhan authored
This reverts commit 9189f6dd. Reason for revert: This CL is unrelated to the test that is was suspected of making flaky. Original change's description: > Revert "Exo: Undo conflation of relative-pointer and pointer-constraints" > > This reverts commit 01116522. > > Reason for revert: suspected of causing > PointerLockBrowserTestWithOptions.UnadjustedMovement to be flaky > > See bug: 1043985 > > Original change's description: > > Exo: Undo conflation of relative-pointer and pointer-constraints > > > > When it was first implemented, adding a relative-pointer-delegate would > > also enable pointer capture (locking the pointer). > > > > This change makes it so that the pointer can only be locked through the > > pointer-constraints protocol. > > > > Bug: b/124059008 > > Test: exo_unittests, manual testting using ArcPointerCaptureTestApp > > Change-Id: Ied0f1c658aa713026e622f4ce26009e261d4f653 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992355 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#733497} > > TBR=mukai@chromium.org,oshima@chromium.org,prabirmsp@chromium.org > > Change-Id: I8581f298f099cb7a9a006a1b578f6345184da1d3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/124059008 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012517 > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733612} TBR=mukai@chromium.org,oshima@chromium.org,nsatragno@chromium.org,prabirmsp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/124059008 Change-Id: I5e0c6615b9dce0c48f94d6b227763cfc205954b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015301Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#734655}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cb4d2c38a343..5ef91b82cbed git log cb4d2c38a343..5ef91b82cbed --date=short --first-parent --format='%ad %ae %s' 2020-01-23 amaiorano@google.com Subzero: temp fix Float4 % Float4 (FRem) 2020-01-23 capn@google.com Use UNIMPLEMENTED() for missing functionality we claim support for 2020-01-23 capn@google.com Replace all UNIMPLEMENTED() with UNSUPPORTED() Created with: gclient setdep -r src/third_party/swiftshader@5ef91b82cbed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I70a9f967fd60cb48886ea743cc82f5bb868db877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734654}
-
Mike Wittman authored
Strips the stack_unwinder module interfaces and contents down to the minimal Java required to get the dynamic feature module to work from native code. The module will be providing native code interfaces[1], which will be consumed by native code, so it doesn't make sense to interpose more Java than necessary in between. It's also the case that the parts of the DFM Java API that deal with the Play Store can't be used within the sandboxed renderer process. This change exposes via JNI the StackUnwinderModuleProvider's functions to query and request installation. This is the only Java-provided functionality that will be required for manipulating the module from native code. 1. Design doc: https://docs.google.com/document/d/1QB5IzWuVKfoPdPuiyRok2MUEta1FmRLIQkq1wDATA4k Bug: 1027654 Change-Id: Ie69e687335a753c17206fc6c81ae981118c698b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003298Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734653}
-
Daniel Rubery authored
Since the CheckClientDownloadRequest will no longer be run on deep scanning, we need to check the file size and encryption within the DeepScanningRequest. This CL moves that functionality. Bug: 1041578, 1020215 Change-Id: If134cfb8097b666cdf5f9057e2921f5634bcbf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007972Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#734652}
-
David Bienvenu authored
Bug: 1043481 TBR=bashi@chromium.org Change-Id: Id5c998c8fc81c98fd5ff898d1b953aeddadba19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016351Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734651}
-
Albert Chaulk authored
Current theory is that JS channels can be set before the frame finishes its initialization, and V8 context creation can occur on the Install() path, this violates some assumptions and crashes. So delay any Install() calls until after the main world context has been created. Bug: b/148202893 Test: no crashes seen on device Change-Id: I55255d9afed36a6e4c97dff8bfbea3c20a4a856a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016350 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#734650}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48655cfdbfd9..40899b279798 git log 48655cfdbfd9..40899b279798 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 487ee81f..c0451968 (734357:734489) 2020-01-23 minyue@webrtc.org Revert "Send absolute capture time through audio coding module." Created with: gclient setdep -r src/third_party/webrtc@40899b279798 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If5c7f63ed8ff5356665d49cc87a624062b305523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017649Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b20535e..fde258b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c9225e9bf101b423747dc158fdd715e8cf78342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017105Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734648}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to sync. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to sync. This code doesn't add a DCHECK that the unconsented primary account exists because there are managed guest session tests that don't have a primary account but still exercise this code path. and on device Test: existing login browser tests, manual tests of login on linux Bug: 1042400 Change-Id: I14ee7bcc18c294dee31c26fcc9bed537836516b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015589 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e504fd6a5f25..cd43517dce3c git log e504fd6a5f25..cd43517dce3c --date=short --first-parent --format='%ad %ae %s' 2020-01-23 mandy.chen@microsoft.com Roll protocol changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@cd43517dce3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2dd291383c97e9018727537092d85a405dd5409b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018024Reviewed-by:
-
Christopher Cameron authored
Change metal_util::TestShader to test either compile or link, and change the default behavior to link. Add inline data for a trivial test shader. Add code to modify the bitcode, to defeat caching. Ensure that the Metal calls for the test are invoked on a thread that has base::TaskPriority::HIGHEST. TBR=jvanverth Bug: 974219 Change-Id: I35e688c3758af2e03f893a1ccbef7aef6b778b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015486Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#734645}
-
ckitagawa authored
This adds UMA metrics for - Capture time in spent in Blink - Total capture time - Usage/Success counters - Frame count to evaluate total frames captured Follow-up CLs will be needed for UKMs and disk-usage. Bug: 1038390 Change-Id: I1b7e0a844da23d23257cb75ad6673ff31a730955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986773Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734644}
-
Aaron Krajeski authored
The expiration now matches that for other offscreen canvas histograms. Bug: 1041517 Change-Id: Ia42ffd003de64f00ed8d55c866f58b4cc4bc655b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015363Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
Eugene But authored
This reverts commit db9b2ce6. Reason for revert: Tests now pass Original change's description: > [ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase. > > TBR=jlebel@chromium.org > > Bug: 1037676,1036840 > Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727312} TBR=eugenebut@chromium.org,jlebel@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037676, 1036840 Change-Id: Ie9c4b650360072c3e916e78d122ae331f55f424c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015408Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I3ff6d274b82325a4a77e71fc5a7aaaa3a0d4e83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017513 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734641}
-
Toni Barzic authored
The app list step introduces the user to the home button, which might be confusing if the home button is not shown, which is the case in tablet mode with kHideShelfControlsInTabletMode feature enabled (the feature removes home/back/overview buttons from shelf in favor of gestural navigation). BUG=1012814 Change-Id: I8621b72a734c08d84774537e962346a74ec3c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015649Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734640}
-
Mohamed Heikal authored
Bug: 1045024 Change-Id: Id5f37e284a97c6bb4a77341203df366f1d36ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017643Reviewed-by:
-
Avi Drissman authored
This changes expectations based on the macOS SDK used to build Chromium. Chromium has required newer than the 10.12 SDK for years, so remove this. Bug: 1044838 Change-Id: I41deec339d7da73392c410dbdb1439a824c0f81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015361 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Some tests in these virtual test suites were failing due to the form controls refresh (mostly; one of the failing tests was about a text layout difference between NG and non-NG [1]), but it doesn't seem worthwhile to run them (uninteresting combination of features), so rather than rebaselining, let's skip. [1] virtual/web-components-v0-disabled/fast/dom/HTMLMeterElement/meter-boundary-values.html R=ikilpatrick@chromium.org,masonfreed@chromium.org Change-Id: I499cbb69cf54969d6136b441e2ea95bdf5fcfe2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016627Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#734637}
-
Toni Barzic authored
Fixes the histogram values for in-app hotseat gesture and swipe from home to overview gesture to match the values that are actually recorded: * Results of the in-app hotseat gestures are recorded as Ash.HotseatGesture, not Ash.HotseatInAppGesture as was specified in histograms.xml * Ash.SwipeHomeToOverviewGesture histogram reports an enum value, not a boolean Change-Id: Ie3d64d9727d2288071eb1a3fe52a451212a702be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015554 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
Aaron Tagliaboschi authored
A fairly long overdue rework of the client hint WPTs. Most of the renaming is on it's own patchsets, so look through each one individually if there's too much to see anything useful. Tests deleted because of other coverage: * accept_ch.tentative.https.html: accept-ch-stickiness/same-origin-navigation.https.html * http_equiv_accept_ch.tentative.https.html: accept-ch-stickiness/http-equiv-same-origin-subresource.https.html * http_equiv_accept_ch.tentative.sub.https.html: accept-ch-change.https.html Bug: 1042828 Change-Id: Ie52abfac485b8e974f4a93a06f3d6d3b845a2010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003338 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#734635}
-
Simeon Anfinrud authored
The "data" list was pointing to a file that did not exist (the path omitted the "resources" prefix). Bug: Internal b/144577042 Test: check that each file from gn desc runtime_deps exists Change-Id: I2eb03db75cf3a8e7608d71446acfbf518074e00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016907 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734634}
-
Nate Chapin authored
This will make it easier to eventually not use SecurityContextInit in Document, and just use it for ExecutionContext/SecurityContext. Bug: 1029822 Change-Id: I6eb6c01756d2a9c3e28fe6e833bdd65e54acedb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015549Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734633}
-
Brian Salomon authored
This will be used by Skia for async YUV420 readbacks with ES2 ANGLE contexts. Bug: 1040643 Change-Id: Ifcc0bff78efcf75764902e8a2910aea7266bf327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015645Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#734632}
-
Dale Curtis authored
Some loads are done from an in memory cache and won't trigger the typical mixed content warnings, so explicitly tell MixedContentChecker about our loads to ensure the proper notifications are generated. Fixed: 868145 Change-Id: I4df0ac3db1f2584c2ef44b5e3606acff314bc4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008396 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734631}
-
Dominic Mazzoni authored
Android accessibility was using a different code path than other platforms to compute the bounding box of accessibility objects. In particular, we were ignoring the root scroll offset from the accessibility tree and using the offsets from RenderCoordinatesImpl instead. It looks like this is causing problems with ImplicitRootScroller, and furthermore it looks like this code is no longer necessary. Switching back to use the scroll offsets from the accessibility tree seems to fix the problem. A follow-up change will remove UseRootScrollOffsetsWhenComputingBounds entirely. This change is minimal in order to be considered for merging. Bug: 1005121 Change-Id: I82e97f046cee6b8b08238fcd4368228da368b92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017662Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734630}
-
