- 04 Aug, 2020 40 commits
-
-
Anthony Vallee-Dubois authored
Bug: 1112795 Change-Id: I5b30f12e33573c9109d5ff2ea030f3651b74b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336280Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#794636}
-
chrome://managementTina Wang authored
Mock: https://docs.google.com/presentation/d/1Tbe2Uh3QTYUKOkxo89npxkthhvEwLgCz13f5xW4KRRw/edit#slide=id.g8cf6ed5ed7_4_220 Screenshot: https://screenshot.googleplex.com/z6vcmmk63ML Bug: 1111037 Change-Id: Iab795d0349561f9428e12e5fc0ecb7330ef1332b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329749Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794635}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7f3c24c7..a8084f7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic59516ad4b8610795b36351621c98c38e52f1e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336953Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794634}
-
Mustaq Ahmed authored
We have quite a few cases where some internal methods "synthesize" user activation notification triggers, as if they were real user interactions. After UAv2 shipped in M72, these calls /should/ be unnecessary, see the bug. However the compat implication is not clear. This CL is part of a sequence that would hook up histograms to each type of triggers. If a synthetic trigger turns out to be ineffective, we would blindly remove them. We will then investigate the remaining ones one-by-one. This CL completes browser-side hookup through UpdateUserActivationState. Bug: 1103249 Change-Id: I850b4fdae3f225b2107ed015ead8dd2de17a0dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281304Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#794633}
-
Toni Barzic authored
This is a reland of 387397c7 The test that started failing after original cl landed was fixed in CL:2333742 TBR=andrewxu@chromium.org (The change is identical to the original) Original change's description: > Fix ShelfNavigationWidget metrics reporting > > Update shelf navigation widget metrics reporter to use the hotseat > state from the time of reporter callback creation to select which > hotseat state dependant metric to report. Note that shelf component > layout happens after the hotseat state is set, so the hotseat state > should have the desired value by the time navigation widget transitions > start. > > The report callback is run asynchronously from the time the animation > completes, so the hotseat state can change between the hotseat animation > changing and the reporter callback running (e.g. if an app window is > closed just after the animation to hidden hotseat ends, which may happen > in perf tests). With the existing logic, where the reporter uses the > current hotseat state to select the histogram to report, the animation > may get registered for an incorrect transition. > > Also, when animating home button bounds, do not request animation, and > create metrics reporter if the view is already animating to the same > target bounds. > > BUG=1108641 > TEST=ran ui.HotseatAnimation tast tests a couple of times > > Change-Id: Idde82ce98545d7ee7e54170abea588c9793e6d3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333141 > Reviewed-by: Andrew Xu <andrewxu@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793793} Bug: 1108641 Change-Id: I0c01f1d229937c02f7d511ba833b144d09bed2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336781Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#794632}
-
Nate Chapin authored
Change-Id: Ie69a1875ce18cba8ef8118e2d61340bf640ec811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333407 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#794631}
-
Yuke Liao authored
This CL switches the test runner to use the new gs location to download continuously uploaded ash-chrome. Bug: 1104318 Change-Id: Iaa6b6afe293df2cc683a182c609157e761828a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333144Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794630}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7176f54720e6..06e30bae5cbf 2020-08-04 treehugger-gerrit@google.com Merge "Add some superclass information to histograms output" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iab84118927f49307656d982b94b550494bbbea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794629}
-
Stephen Roe authored
Currently the system statistics contain top output which truncates executable names. Adding ps output will give full executable names and invocation arguments. Bug: 1100402 Change-Id: I5357fea58e0dbf04dacdc6b6caabf5b2d79ea856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335649Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#794628}
-
edchin authored
Bug: 1106960 Change-Id: I67369d256f438db7c89e2105df5a6f4677ce296b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333388 Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794627}
-
Muyao Xu authored
The DualMediaSinkService now creates one mojo::PendingRemote for each MediaSinkService. It binds the mojo::PendingReceiver with LoggerImpl owned by the MediaRouter and passes the mojo::PendingRemote to the MediaSinkService. The MediaSinkService can take the mojo::PendingRemote and bind it with its mojo::Remote. Bug: 687380, b/154273698 Change-Id: Iaa9aa822b083e39e4b6b7f6abfbe852c7316a93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310873 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#794626}
-
James Long authored
The up/down arrows have been changed into actual buttons. The original up/down arrows in the spinbox that comes with <input type="number"> have been removed via CSS. Inbound/outbound inputs have also been moved into one reusable NumericInput component. Bug: 1102546 Change-Id: I34b40a17cc250b4649459c138b0a9cbdf1b3c241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332846 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#794625}
-
Yue Zhang authored
* Since we want the ntp text color to align with the rest of WebUI, remove the redirection in shared_vars.css and have components use cr-primary-text-color and cr-secondary-text-color directly. * Remove ntp-secondary-text-hover-color which seems to be unused. Bug: 1080878 Change-Id: I7ecc341ed0afb10eb1688ea090d8dc547ab94649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335981Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794624}
-
Devlin Cronin authored
Move //c/b/extensions/extension_action_manager.[h|cc] and associated unit tests to //extensions/sbrowser, since it has no //chrome dependencies. Bug: 1073590 Change-Id: Ic131289b24e71f473788731c20530ac701f769c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259476 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794623}
-
Pranav Batra authored
Before printerAddress contained the full uri path. Now the hostname and path are properly stored in printerAddress, printerQueue respectively. Also relax printer uri validation to allow printerQueue to contain both the path and query portions of the uri. BUG=chromium:1111654 TEST=Add brother printer to DUT via usb TEST=chromeos_unittests --gtest_filter=PrinterTranslatorTest.* Change-Id: I669a21e02b0fc485a00f1ad33d2f806a4c58042a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331519Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Pranav Batra <batrapranav@chromium.org> Cr-Commit-Position: refs/heads/master@{#794622}
-
Marc Treib authored
Bug: 1110878 Change-Id: I92b45b1a8b97e4e00814886a66e646fb727681dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333837 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794621}
-
Julian Mentasti-Meza authored
ScreenshotDelegate is a delegate for UIKit's UIScreenshotService, which will be used to generate full-page screenshots and provide the user with the 'Full Page' screenshot tab when they take a screenshot. Bug: 1103777 Change-Id: I9a297834e19507e1c0fdd90162ed40a12b63dc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305035 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#794620}
-
Noah Rose Ledesma authored
This is a reland of f300ac05 The original change added a method to a mojom interface but neglected to implemnet this method for a class in ChromeOS. This reland adds the missing implementation that caused builds to fail. Original change's description: > GMC: Add IPC for switching the audio output device > > This change adds methods used by the global media controls ui for > switching the audio output device used by a page. > > MediaController::SetAudioSinkId was created allowing the > MediaNotificationService to route the audio output of a > MediaNotificationSession to a specified audio device. > > Mojo interfaces were expanded to allow for this IPC between the > controller and session. > > Bug: 1096243 > Change-Id: Icd0ad17d6ef88ec297444b8b2cbc7ddda6c2c4c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295799 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Auto-Submit: Noah Rose Ledesma <noahrose@google.com> > Cr-Commit-Position: refs/heads/master@{#792935} Bug: 1096243 Change-Id: I0dad44fc7d1c8daac50519e8625a3cc2150fa34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328034Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#794619}
-
Alex Gough authored
Adds a wrapper to contain building proc_thread_attribute_* and to provide storage for pointed-at items for call to CreateProcessAsUserW(). This does not change functionality, but moves code from target_services into a helper. Bug: 1050359 Change-Id: I3d25e028638b2ea6f2917de1154be7a99fdf5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330736Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794618}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 387 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-31. TBR=chromium-metrics-reviews@google.com Change-Id: Iaf3a51a15bbe639afd4072643b8f2b9ebe24dbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337053Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#794617}
-
Mike Wittman authored
Updates the ELF image builder to support building relocatable ELF images with virtual address mapping subject to load bias. Parameterizes tests based on mapping state. Fixes ReadElfLibraryName() for the load bias case. Bug: 1105170 Change-Id: I74c37342e50636fb875c2e0a463a987d7312adc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305569Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794616}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/986a340dd528..8b3601324fde 2020-08-04 wl@gnu.org Minor typos, formatting. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: drott@google.com,thestig@google.com,bungeman@google.com Change-Id: I2bc631fa4fcb18e49b0ce0f64c1d45ef7c4f2520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336655 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794615}
-
Michael Crouse authored
This change adds a commandline switch for controlling the default donwlink bandwidth. This will be used for testing and local evaluation. Bug: 1112788 Change-Id: Ibe50133f1182506d363a010bbb0194f3fd010520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336295Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#794614}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bec988515e9c..d41280a787d1 2020-08-04 jonahr@google.com Suppress SurfacelessContext test on Android/NVIDIA 2020-08-04 cnorthrop@google.com Tests: Remove more optimizations from traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Ie1b5fe7e10566f317db0f85d778bbf9f80d7765c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794613}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596520791-9a2885d858aeb98ad5bcc11e2200637e7a775fe0.profdata to chrome-win64-master-1596542250-4b9669504bdebb7cf76d0d2b9c7cc833bb153daa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I691948ebb390448504aa7f37a6032d6b44a9aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794612}
-
Richard Knoll authored
Handle click and dismiss actions of onboarding notifications and keep track of the last dismiss timestamp to prevent spamming the user with these notifications. Bug: 1102348 Change-Id: I5aa79deea29f9e3068bcd1890b50d6c85c654ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332634Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794611}
-
Brian Ho authored
When the hardware doesn't support CTM [1], Chrome OS needs to fallback to applying the "night light" color shift with the compositor [2] by setting the OutputSurface's display color matrix. GLRenderer uploads this matrix to the fs to apply the tint [3]. SkiaRenderer currently does not respect OutputSurface's color matrix, so this CL adds color matrix support via a SkColorFilter similar to how we tint non-overlay content for debugging. [1] https://01.org/linuxgraphics/gfx-docs/drm/drm-kms-properties.html [2] https://source.chromium.org/chromium/chromium/src/+/master:ash/system/night_light/night_light_controller_impl.cc;l=219;drc=a6765a0769369b0d469e3df88e046e18104f7547?originalUrl=https:%2F%2Fcs.chromium.org%2F [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/gl_renderer.cc;drc=42c6a1c82a29862f869d1a3a5ca1b3be4e55291f;l=3375?originalUrl=https:%2F%2Fcs.chromium.org%2Fchromium%2Fsrc%2Fcomponents%2Fviz%2Fservice%2Fdisplay%2Fgl_renderer.cc Bug: 1098435 Change-Id: Ia4772f245c80a73bfc431981f8ab8dc341232eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327810Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#794610}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iec348432a6388c6a0c41e50cd180703cbe7adc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335493Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794609}
-
Caroline Rising authored
Approval given in crbug/962604. Bug: 910739 Change-Id: I26db0a3f807228cbb6d708889129ceb403233734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334812Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#794608}
-
Mario Bianucci authored
Today, custom SVG cursors are blurry on high DPI displays because they rasterized and then scaled up as required for the display resolution. This results in the cursor being blurry. This CL fixes that by scaling the size of the cursor up before rasterizing and placing it into a cursor to be used in the browser process. Bug: 325565 Change-Id: I61e37f4ae4355a534d71022974a30d62fccc53cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321534Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794607}
-
Toni Barzic authored
Remove the traced process ID from PerfettoService's list of active service PIDs if the process goes away while ConnectToTracingService is in progress. The PID is added to active services list before calling ConnectToTracingService, and if it doesn't get removed, BeginTracing requests will keep waiting for acks from a process that's gone. BUG=1110514 TEST=tast run ui.LauncherAnimationPerf* Change-Id: I1c491536e8740e0e8618dbf3109046440c418749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333873 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794606}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I019e775b7ecd01c6a1c401c13d9a29abd35ad170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326290Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#794605}
-
Thomas Tellier authored
Bug: 1101326 Change-Id: Ibcb9e16bf903d518a69a2631b289881f0303f6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333191Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794604}
-
Egor Pasko authored
Still looking at the data on Dev/Canary. Bug: 1045052 Change-Id: Ibf8f3f54bc944883e4f9450ac85535fff5c7d87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335287 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794603}
-
Thomas Tellier authored
5-second instead of 3-second timer for password/PIN going back to masked format. 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. Bug: 1101326 Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794602}
-
Hiroshige Hayashizaki authored
In order to use ClassicScript in worklet unit tests, this CL changes Script::RunOnWorker() to Script::RunOnWorkerOrWorklet(). This CL removes a DCHECK() in WorkerOrWorkletScriptController to allow kSanitize in non-importScripts() cases. This is to allow ClassicScript::UnspecifiedScript()'s default kSanitize value to be used in worklet unit tests in https://chromium-review.googlesource.com/c/chromium/src/+/2331758 kSanitize doesn't occur here in non-test environment, but allowing kSanitize here and using ClassicScript::UnspecifiedScript()'s default kSanitize value in worklet unit tests makes it easier to track ClassicScript::UnspecifiedScript() with kDoNotSanitize cases as exceptional. Bug: 1111134 Change-Id: Id4c35427391b263b5bdc9568be95266bb8715a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332096 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794601}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a1a497ffe792..2de6d657dde3 2020-08-04 john@johnkgo.com SPV: Standalone; sanity check the client GLSL input semantics option value. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I7d1b7edcabf30579bf30ed88c27367eefba743ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794600}
-
Friedrich Horschig authored
Although every password settings fragment should be launched using PasswordManagerHelper#showPasswordSettings() which requires a referrer, some clients crashed because the bundle seems to be missing regardless. A possible reason is that the fragment wasn't started but just recreated without a bundle. To cover these cases, store the referrer in the savedInstanceState and reuse it on creation. Bug: 1112628 Change-Id: I93805c2d93bae35c5dd0b6647626db87cc7db275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335444Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#794599}
-
David Roger authored
This CL re-organizes the file to avoid duplicated sources and deps sections Change-Id: I6fa29387b6da8c3c2f37412558b2922c2fac5a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335438 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a79b9fd7235f..c6116bf6ce82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,sinhak@google.com Change-Id: I04ec65c1b3fafa8f5d0afb166785823897531975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794597}
-