GitLab

This change makes the header text fire the same event as the drop arrow icon when the current view is the cast mode or sink list view. The cursor styling for the header text is also updated to match the drop arrow icon when clickable.

Also added restrictions to deter from potentially ending up in weird states if assumptions are made and added more tests to cover the different views.

BUG=579131

Review URL: https://codereview.chromium.org/1610523002

Cr-Commit-Position: refs/heads/master@{#371379}

BUG=579782

Review URL: https://codereview.chromium.org/1631093002

Cr-Commit-Position: refs/heads/master@{#371378}

It's a PKCS#8 PrivateKeyInfo blob, not a PKCS#1 RSAPrivateKey.

BUG=none

Review URL: https://codereview.chromium.org/1639553002

Cr-Commit-Position: refs/heads/master@{#371377}

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.

Review URL: https://codereview.chromium.org/1626673002

Cr-Commit-Position: refs/heads/master@{#371376}

R=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, krasin@chromium.org
BUG=539572

Review URL: https://codereview.chromium.org/1636823002

Cr-Commit-Position: refs/heads/master@{#371375}

Fixes a bug introudced in https://codereview.chromium.org/1612083004
when making the external display primary.

BUG=576375

Review URL: https://codereview.chromium.org/1631893003

Cr-Commit-Position: refs/heads/master@{#371374}

Fix I420ToNV21 for wrong dst_stride_y parameter.
Fix memory overwrite in YUY2ToNV12 odd wdiths.
Refactor ARGBToI422 using ARGBToI420 internally.

Full list of changes
https://chromium.googlesource.com/libyuv/libyuv/+log/0e462e6..ad71738

R=brucedawson@chromium.org
BUG=libyuv:546,libyuv:534,libyuv:542,libyuv:536,libyuv:547,libyuv:545,libyuv:549,libyuv:543,libyuv:551,libyuv:548

Review URL: https://codereview.chromium.org/1630933003

Cr-Commit-Position: refs/heads/master@{#371373}

BUG=581210
TBR=yosin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1631923003

Cr-Commit-Position: refs/heads/master@{#371372}

See step 8, "Polygon state" in

https://html.spec.whatwg.org/multipage/embedded-content.html#processing-model

BUG=578125

Review URL: https://codereview.chromium.org/1630763002

Cr-Commit-Position: refs/heads/master@{#371371}

For things labeled as "const", check if they can be compile-time
evaluated when deciding to name them kFooBar or foo_bar.

This fixes cases of const kFooBar = THING + OTHERTHING getting renamed
to k_foo_bar in blink.

Note that the tool is doing a slightly wrong thing when renaming a foo_bar
to a kFooBar, which we can fix separately (this adds some tests for it
that currently fail on that case).

R=dcheng
BUG=581185

Review URL: https://codereview.chromium.org/1638683002

Cr-Commit-Position: refs/heads/master@{#371370}

|socket_dir| variable is not unused for anything in
CreateClientUnixDomainSocket() function, so this patch removes it. While
at it also pass socket_path.value() directly instead of storing it in a
temporary variable.

BUG=None
TEST=ipc_tests
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/1636583002

Cr-Commit-Position: refs/heads/master@{#371369}

BUG=569901
TBR=keishi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1631663005

Cr-Commit-Position: refs/heads/master@{#371368}

https://crrev.com/1611533002/ added necessary serial device enumeration
to the agent, which broke the Android build because I was inadvertently
building the agent on Android builders.

My goal is to have battor_agent only be buildable on Mac, Windows, and
Linux desktop machines. If I did that wrong, please let me know!

Review URL: https://codereview.chromium.org/1611353003

Cr-Commit-Position: refs/heads/master@{#371367}

based on palmer's codereview.chromium.org/1576353003/

Only fixes pre-MD, doesn't attempt to get MD version correct.

BUG=570204

Review URL: https://codereview.chromium.org/1627543002

Cr-Commit-Position: refs/heads/master@{#371366}

BUG=555062
TEST=AutofillFieldTest

Review URL: https://codereview.chromium.org/1626853005

Cr-Commit-Position: refs/heads/master@{#371365}

All crashers of any significance have been addressed as of
85285916. This is the next step towards
increasing the enable rate to 100%.

BUG=541419

Review URL: https://codereview.chromium.org/1631953002

Cr-Commit-Position: refs/heads/master@{#371364}

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043

Review URL: https://codereview.chromium.org/1607873002

Cr-Commit-Position: refs/heads/master@{#371363}

BUG=581159

Review URL: https://codereview.chromium.org/1635763002

Cr-Commit-Position: refs/heads/master@{#371362}

* Updated README.chromium.
* Suppressed non-zero exit status of some commands in reproduce.sh (this caused
  premature exit).
* Added script which generates a short summary of presenting components.

Presubmit complains about removed copy of README.chromium, that is why
NOPRESUBMIT is set.

BUG=none
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1623693002

Cr-Commit-Position: refs/heads/master@{#371361}

BUG=581203
TBR=dstockwell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1632103002

Cr-Commit-Position: refs/heads/master@{#371360}

- Use uint64_t in place of size_t where we need to guarantee 64-bit
  integers.
- Minor formatting and diagnostic improvements.
- Extracted timestamp decoding into its own function, ReadTimeSinceEpoch.
  This will be used more in future code.

BUG=506227

Review URL: https://codereview.chromium.org/1575543002

Cr-Commit-Position: refs/heads/master@{#371359}

BUG=532545

Review URL: https://codereview.chromium.org/1623603002

Cr-Commit-Position: refs/heads/master@{#371358}

There is only one periodicity now, refer to it as a registration
instead of a one-shot registration. If we add periodic back in the
future we can refer to those as periodic registrations.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031

Review URL: https://codereview.chromium.org/1613053004

Cr-Commit-Position: refs/heads/master@{#371357}

There are times where the doodle server sends PNG instead of GIFs in the
url field of image data. This will make BaseGifDrawable to think that
its content is not valid and thus we will always try to download the
valid PNG again on click. This behavior is corrected by this CL.

BUG=580624

Review URL: https://codereview.chromium.org/1634843002

Cr-Commit-Position: refs/heads/master@{#371356}

After crrev.com/1584893002 base/ can use directly allocator.
The grand plan is to dismantle all the indirection layer such that:
 - base is the only thing that knows about allocator-specific details.
 - non-base code uses only base abstractions and stops looking
   at USE_TCMALLOC build flags.

This CL specifically deals with tc_malloc_skip_handler and tc_set_new_mode
and removes the unnecessary base -> content -> base hops.

BUG=564618

Review URL: https://codereview.chromium.org/1610153002

Cr-Commit-Position: refs/heads/master@{#371355}

These tests made invalid assumptions about the WOW64 virtualization
state and were partially disabled. Now they all pass on all platforms.

BUG=580800,6944

Review URL: https://codereview.chromium.org/1624083003

Cr-Commit-Position: refs/heads/master@{#371354}

At least one test that relies on counters was flaky because counters were not being consistently reset for testing.
The counter resetting code was inexplicably calling code to update counters as if an open action had occurred (removed). This change may fix other flaky tests.
Update the test code to just reset all preferences instead of trying to remember to add reset code when adding a new counter.
Fixes testLongPressShowsPeekPromo.

BUG=540820,569123

Review URL: https://codereview.chromium.org/1517883003

Cr-Commit-Position: refs/heads/master@{#371353}

BUG=429053
TEST=gpu_unitests
R=vmiura@chromium.org

Review URL: https://codereview.chromium.org/1625573003

Cr-Commit-Position: refs/heads/master@{#371352}

BUG=549021

Review URL: https://codereview.chromium.org/1621313002

Cr-Commit-Position: refs/heads/master@{#371351}

https://chromium.googlesource.com/skia.git/+log/02cb4d469a2a..7869bbff26b7

$ git log 02cb4d469..7869bbff2 --date=short --no-merges --format='%ad %ae %s'
2016-01-25 msarett Fix gyp files so that gyp_to_Android.mk succeeds
2016-01-25 robertphillips Fix memory leak in pixelxorxfermode GM GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1633773002
2016-01-25 iroth Changes to public.bzl to support building on iOS with objc_library bazel target.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1637543003

Cr-Commit-Position: refs/heads/master@{#371350}

Previous CL (crrev.com/1484093002) made it possible to save contents of
all frames - even if some of them have the same URI, they still get
saved into separate files / SaveItems.  This CL makes sure that we
rewrite links in a html document, based on frame identity if possible
(rather than always doing the rewriting based on the uri):

- SaveItem now stores a frame_tree_node_id that can be potentially used
  (if the SaveItem is for a frame rather than for a savable resource) as
  a key in the map into the local paths.

- WebFrameSerializerImpl now rewrites link uris based on 2 maps
  (url -> local path map as well as frame -> local path map).

BUG=106364, 106158, 538188

Review URL: https://codereview.chromium.org/1502563004

Cr-Commit-Position: refs/heads/master@{#371349}

Trim whitespace and remove stop chars.

BUG=580679
TEST=AutofillManagerTest

Review URL: https://codereview.chromium.org/1627843002

Cr-Commit-Position: refs/heads/master@{#371348}

Adds a new method to SSLClientSocket to get the Token Binding from an SSL
connection where Token Binding was negotiated, and uses that to add the
Set-Token-Binding HTTP header (only when Token Binding was negotiated).

BUG=467312

Review URL: https://codereview.chromium.org/1378613004

Cr-Commit-Position: refs/heads/master@{#371347}

Revert of add remaining unittests to new android bots (patchset #2 id:20001 of https://codereview.chromium.org/1633713002/ )

Reason for revert:
isolate paths aren't quite right, e.g.

https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/2236/steps/base_unittests/logs/stdio

Original issue's description:
> add remaining unittests to new android bots
>
> BUG=514857
>
> Committed: https://crrev.com/3476f7c84c16ed45a8404f491fab9fb4691bda5f
> Cr-Commit-Position: refs/heads/master@{#371331}

TBR=martiniss@chromium.org,bpastene@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514857

Review URL: https://codereview.chromium.org/1639603002

Cr-Commit-Position: refs/heads/master@{#371346}

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com

Review URL: https://codereview.chromium.org/1623073003

Cr-Commit-Position: refs/heads/master@{#371345}

It seems the issue is caused by the button being drawn into
a layer early on and being cached. Adding a -setNeedsDisplay:
when we actually determine whether it should be visible fixes
the problem - so that the first actual paint to the screen
has the correct appearance.

I'm not sure why Cocoa draws it to a layer earlier than this
(this doesn't happen for other buttons), nor why it's background
color is black when that happens. However, this change does fix
the bad appearance.

BUG=563395

Review URL: https://codereview.chromium.org/1630453002

Cr-Commit-Position: refs/heads/master@{#371344}

Currently, shownComponentsChanged_() assumes the first run flow has been stamped before getting the offsetHeight. This is not always the case if the first run flow has already been acknowledged but the current view of the media-router-container is modified.

Review URL: https://codereview.chromium.org/1615633002

Cr-Commit-Position: refs/heads/master@{#371343}

BUG=533750
TEST=build passes

Review URL: https://codereview.chromium.org/1606013005

Cr-Commit-Position: refs/heads/master@{#371342}

Until Oilpan is firmly enabled, always use GeolocationControllerPrivate
to wrap up the non-owned GeolocationController* object. The previous
implementation was performing an untidy downcast with undefined behavior;
no need for such shortcuts here.

R=
BUG=581112

Review URL: https://codereview.chromium.org/1638573002

Cr-Commit-Position: refs/heads/master@{#371341}

Now that we have 3 LGTMs for ImageBitmap and createImageBitmap to ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/jRzvehX9U1U/discussion,
let's ship it and expose it to larger audience!

This CL removes the Runtime flag in ImageBitmapFactories.idl and updates
some global interface layout tests results.

BUG=249384

Review URL: https://codereview.chromium.org/1636633002

Cr-Commit-Position: refs/heads/master@{#371340}