GitLab

Traceing should not mutate the traced object. This CL makes all
TraceAfterDispatch methods const.

The changes were done using a search-and-replace which adds const to
the end of the method signature. Used the following patterns to find
relevant methods:
TraceAfterDispatch(Visitor*);
TraceAfterDispatch(blink::Visitor*);
TraceAfterDispatch(Visitor* visitor)
TraceAfterDispatch(blink::Visitor* visitor)

Change-Id: I28ede532a992af62a123de00c64e6f43e6c53557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087713Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746767}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66e045655d89..07fd18460d09

git log 66e045655d89..07fd18460d09 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 gabriel.luong@gmail.com Migrate ParsedURL and ResourceType tests into Ninja build
2020-03-04 szuend@chromium.org Type check common/Linkifier.js using TypeScript

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@07fd18460d09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I1b82ec4457b9b545a3e12d796c21bef68b0a79c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746766}

This is a repeating callback because it's called repeatedly from for
loops in:
* https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=e501b7156b763939111552df391c615761c3c1bf&l=649
* https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=e501b7156b763939111552df391c615761c3c1bf&l=705
* https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=e501b7156b763939111552df391c615761c3c1bf&l=764

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 1007805
Change-Id: I81bb8448df6577e5f7d56f8027f38490b2594d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080479
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746765}

The activity indicator should not be added in -[UserSigninViewController
viewDidLoad].
The indicator is added when it is started, by -[UserSigninViewController
startAnimatingActivityIndicator].

Bug introduced with: crrev.com/c/2079111

Bug: 971989
Change-Id: I9f8d8ee37399a1fba0197112f1998cdb7bfa5aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087214
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746764}

Remove duplicated code and use range iteration.

Change-Id: Ib114a2faff1310a6eb35a354ce853dc176d75c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087758Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746763}

Follow up to crrev.com/c/1991432 where a new argument was introduced
but considered optional, to avoid breaking compatibility.

After a grace period, this patch makes the argument mandatory and issues
an error if a key version is not provided.

Change-Id: I494b7abbb336df2c5758e9d94db550cf8a100230
Bug: 1032485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078542Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746762}

ShareImageFileUtilsTest.testSaveBitmap is flaky, but only on KitKat.

Tbr: gayane@chromium.org
Bug: 1056059
Change-Id: I45461969f8f87b1f6b9acdb412e729563f588d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087912
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746761}

TBR=bling-p10-rolls@google.com

Change-Id: I9419fa6ee8a22df00fc4971c1864e58acd758943
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087891Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746760}

This CL converts ViewMsg_AnimateDoubleTapZoom to a blink MainFrame. It
introduces AnimateDoubleTapZoom to LocalMainFrame and blink::LocalFrame
implements it.

Bug: 1047466
Change-Id: Ibc721c9cf11b1f4629c83fa25ae911474451afe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083981
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746759}

This adds missing readback bits so that Wayland can be used with
SwiftShader. I encountered this problem when started to work on
enabled tests with wayland backend enabled.

The implementation is quite naive - we create a
shared memory buffer, import a wl_buffer with the fd for that
shm buffer and write pixels that are read with glReadPixels into
the shm buffer.

Also, this patch restores async buffer swap support in
SkiaOutputDeviceGL that was removed in https://crrev.com/c/2025968.
Now, it's Wayland that has the support for async buffer swap, it's
wrong to assume there are no clients that do not support it.

and also running chrome --ozone-platform=wayland --use-gl=swiftshader.

Test: views_unittests to ensure that surface with read back is created
Bug: 1054305
Change-Id: Iff307e1155d0a14965a2bd193a7b9b8d9aceb952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064929
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746758}

Change-Id: I02e2ea17d0d10ca3898bfd732399176a1b1f4908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087399Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746757}

This was replaced by an e2etest in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2085171

TBR=aerotwist@chromium.org

Bug: 1044632
Change-Id: Ic3cc7f86cd1a5950d1c07d335731a3520261d077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087216Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746756}

This reverts commit 8458b988, with
additional changes to address crashes/test failures from:
 crbug/1057744: CreateTraceWriter was occasionally failing, likely
                because the startup tracing timeout didn't reset the
                producer correctly. Fixed this issue.
 crbug/1057614: On windows, allocating the tracing SMB occasionally
                fails. This patch adds a workaround to handle such
                failures gracefully, disabling tracing for the process
                and calling DumpWithoutCrashing().
 crbug/1057896: Android ASAN failures for TracingControllerTests.
                Most TracingControllerTests were already disabled on
                android ASAN. Disabled the two new failing ones, too.

Reason for revert: Relanding and disabling tests / addressing crashes.

Original change's description:
> Revert "perfetto: Switch to SMB-based startup tracing"
>
> This reverts commit 79fca1ef.
>
> Reason for revert: Flakiness of TracingControllerTest. Filed crbug.com/1057896
>
> Original change's description:
> > perfetto: Switch to SMB-based startup tracing
> >
> > Switch from StartupTraceWriter(Registry) and their thread-local buffers
> > to startup tracing using producer-supplied shared memory buffers. Each
> > ProducerClient allocates their own SMB now, which is provided to the
> > service when the ProducerClient connects.
> >
> > With this new mechanism, we're aiming for simpler code with fewer race
> > conditions and hopefully fewer chances for data loss, see design doc
> > for details.
> >
> > Note that this breaks startup tracing with the Perfetto system daemon.
> > At the moment, no tooling uses this, so we can probably remove support
> > for the time being. To add it back, we would have to:
> >  - start tracing with an SMB allocated by PosixSystemProducer. In
> >    sandboxed processes, we can allocate the SMB before the sandbox comes
> >    up, or later via mojo's broker (and then somehow plumb it through
> >    perfetto's IPC mechanism), or allocate it in the browser + pass an FD
> >    to it via the cmdline when spawning.
> >  - attempt to connect to the system service using this SMB.
> >  - bail out, stop and restart the session with a service-provided SMB if
> >    the system service doesn't support producer-provided SMBs (and thus
> >    fails to adopt the producer-provided SMB).
> >
> > Design doc (incl. security review):
> > https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit
> >
> > Related Perfetto-side patches:
> > https://android-review.googlesource.com/c/platform/external/perfetto/+/1218420
> > https://android-review.googlesource.com/c/platform/external/perfetto/+/1196779
> >
> > Bug: 1006753, 941318
> > Change-Id: I3fa7657d57bbf7261d7d504df8895edfc02d9f3f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978682
> > Reviewed-by: Matthew Denton <mpdenton@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Commit-Queue: Eric Seckler <eseckler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#745556}
>
> TBR=skyostil@chromium.org,eseckler@chromium.org,mpdenton@chromium.org,nuskos@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1006753, 941318, 1057896
> Change-Id: Ia7547a2665f59883b6ac0f87097270f8b0635643
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084037
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746279}

TBR=shimazu@chromium.org,mpdenton@chromium.org,nuskos@chromium.org

Bug: 1006753, 941318, 1057896, 1057614, 1057744
Change-Id: I82d210cc7db44d7f2294588dc2393a628795578e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087753Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746755}

Cleaned up the separated Android field trial testing config for enabling
the In Product help UI, and merged it into the QuietNotificationPrompts
field trial, as both the features are being tested together, and there
is currently no need for separate, per-platform configs (the IPH config
is simply ignored on Desktop anyway).

Bug: 1032202
Change-Id: I1bbbadc460bdc3b371941164f415ec06c1c78d7b
TBR: rkaplow@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061153
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746754}

This test asserts behavior that is undesirable. Therefore, I propose to
remove it alltogether.

R=yangguo@chromium.org

Bug: 1044632
Change-Id: Ibe0acd0010c6fead07c7b1847667f187f30f38ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085192
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746753}

PassphraseCreationDialogFragment.

|Profile#getLastUsedProfile| is deprecated and replaced with
|Profile#getLastUsedRegularProfile|. This CL updates
PassphraseCreationDialogFragment class.

Note: This change is only code clean-up, does not change any behavior.

Bug: 1041781
Change-Id: Ia9bc4d3dd37b3afed9dad99b6c52476b77810a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085254Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746752}

Disable flaky tests.

Tbr: crouleau@chromium.org
Bug: 1056235
Change-Id: I515d91c39a8824fe3d439a30e9ef6628546aa612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087613Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746751}

This is a reland of 8698d875
The test was failing on smaller screens due to a missing scrollToView().

Original change's description:
> [Autofill Assistant] Hotfix for radio buttons in FormAction.
>
> Without this CL, UI and model can go out-of-sync when tapping the radio
> button directly (see screenshots in linked bug). This is a hotfix for
> this issue. A proper fix requires a refactoring of the FormAction to
> make the selection state part of its model (same as was done for the
> T&C selection state in the CollectUserDataModel).
>
> Bug: b/150201921
> Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489
> Commit-Queue: Clemens Arbesser <arbesser@google.com>
> Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746539}

Bug: b/150201921
Change-Id: I1a7d9008eb625be46dac9d9bc5f26728c9fcee51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087612Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#746750}

Tbr: afakhry@chromium.org
Bug: 1033651
Change-Id: I77d508ac49278c46a9bc0ee0ffa8e3c10a72c550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087814Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746749}

This moves the reference to the FilterData structure from being stored
on the LayoutSVGResourceFilter to being stored on the data structure
that is associated with the client (SVGElementResourceClient).
This is in preparation for supporting the "full" syntax for the 'filter'
property - which among other things means that multiple reference
filters needs to be supported. It also ends up making the associated
invalidation machinery a tad simpler (for instance no longer needing
the kSkipAncestorInvalidation invalidation flag).

Bug: 109224
Change-Id: I7718a90829bee608a4e0b2a9fcc813dea9233f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081819Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#746748}

Bug: b/150752324
Change-Id: Ida677ca8cd062856c053bcfc632b55da868ada1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087754
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#746747}

Bug: 1052460
Change-Id: I1b72d3f0d6773dde050c79fac21807fae7d9b1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086813
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746746}

ContextualSearchManagerTest#testTapCausesOneLowPriorityRequest and
ContextualSearchManagerTest#testAllInternalStatesVisitedResolvingTap are
flaky.

Tbr: donnd@chromium.org
Bug: 1058297
Change-Id: I88391ac0f3fabdfdd54fa894d966e6559c20afce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087582Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746745}

Change-Id: I91b279054b959b6af3b202bb90e40228360093d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085295Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746744}

CDP’s Emulation#setEmulatedVisionDeficiency no longer accepts
the empty string to clear the override. This patch updates
InspectorEmulationAgent::disable accordingly.

Bug: chromium:1003700
Change-Id: I3f08aafd4b2ff0ecdf119f1d6898a8960cc3eb71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087672
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746743}

This CL replaces ChromeSigninController in
payments/ui/PaymentRequestUI.java by IdentityManager.

Bug: 1049630
Change-Id: Ia29bc0a51388bf33372effa5bff4c43b375150b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083184Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746742}

Also implemented all of the states for the password check (matches the JS frontend ones) and added tests for the Observer logic.

Bug: 1015841
Change-Id: Ie2485cdb406ea0ac44b79d4f3456bf0e7644bbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076477
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746741}

Deserialization methods were removed from Invalidation and
SingleObjectInvalidationSet classes. They weren't used outside of the
tests and requires changes due to Topic->ObjectID refactoring, so it's
better to remove them.

Bug: 1056669
Change-Id: Idaa577e53be599b70b756ff8b89ed7fed6b440c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087712
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746740}

https://webrtc.googlesource.com/src.git/+log/806369810527..4518a20e14ec

git log 806369810527..4518a20e14ec --date=short --first-parent --format='%ad %ae %s'
2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b7f5172d..02cf6c70 (746590:746692)

Created with:
  gclient setdep -r src/third_party/webrtc@4518a20e14ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I15b6238dd026b54ad8ba9f5112697e859ac8dabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087179Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746739}

Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will
create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}
if it does not exist and then delete it. If the test is run on a
development machine, it will corrupt the stable Chrome install.

Bug: 1057233
Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353
Auto-Submit: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746738}

Currently the following windows are not included as we use the same
logic as building a list for the cycler:
- PIP
- Non-activatable windows
- Windows with HIDE_IN_OVERVIEW key.

In MAPIP, the PIP window is not included in the list returned by
BuildWindowForCycleWithPipList as we don't want to show both the pip
and original window in the cycler.
The actual issue we are facing is, currently we use this list to
query Chrome windows from Tast, but as PIP is not included in this
list, Tast can't find the PIP window.

BUG=b:145552924
BUG=b:141899229
TEST=tast --verbose run dut arc.PIP

Change-Id: I16d67f14d8f3bf666e8c2b9a7c2ee99b6740a509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026911
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746737}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56ff573a..579edae5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1d5f4a9a5a6f7c5bba495cdf628854ad97c2875b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087771Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746736}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c40c4bc38a76..c6a4c6d3d8b5

git log c40c4bc38a76..c6a4c6d3d8b5 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 johnkslang@users.noreply.github.com Improve formatting.

Created with:
  gclient setdep -r src/third_party/glslang/src@c6a4c6d3d8b5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com
Change-Id: I37a984fa2e3a3232c7fa8ec0125547305642326d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087175Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746735}

This allows implementing web pages (server-side) that list user
password URLs, even if the password itself is not decryptable. The
blacklisted bit is needed because blacklisted passwords should not
be displayed together with regular ones.

Change-Id: I21ae248804dd7b43c7fda695dae7327fa30be054
Bug: 1053895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087211
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746734}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/393efd6d94e4..66e045655d89

git log 393efd6d94e4..66e045655d89 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 jacktfranklin@chromium.org Migrate `replaceControlCharacters` to StringUtilities

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@66e045655d89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I94c8e6d5fcc2a5181665dd5ec159684480a21f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087177Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746733}

https://chromium.googlesource.com/angle/angle.git/+log/028a7a725cc6..d62881ce79c8

git log 028a7a725cc6..d62881ce79c8 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f32bf1c930c8..97484d689869 (16 commits)
2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e1688b60caf7..a6d3a2dd41d4 (1 commits)
2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 176f3a3dbbc9..126720bd2e57 (2 commits)
2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 56364b6b6026..8985fc91089f (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@d62881ce79c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: I0a3f11d98a5675b351b1324101b1ba259459253b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087178Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746732}

Bug: 1044038
Change-Id: Id4f53493068b51d3a42ea23ac626b3251554b687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083308Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746731}

Incremental steps may process ephemerons. When we are at a very deep
stack there's a chance that the hang monitor interrupts us because
InvokeEphemeronCallbacks is taking too long.

Add deadline logic to InvokeEphemeronCallbacks to make the situation
even more unlikely.

Bug: 1058151
Change-Id: Ic0d455097284be83314c1e4dce6e29803bc33d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087391Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746730}

This is a reland of ed3b55f6

Original change's description:
> media/gpu/test: Group ivf frames whose timestamps are same
> 
> The served stream in webrtc can be dumped by the chrome
> option [1]. When the stream structures spatial-layers, one
> spatial layer is separately saved in one ivf in the dumped
> ivf file.
> 
> On the other hand, to play the ivf file properly, it is needed
> to group the spatial layers, which have the same timestamp in
> ivf frame header. IvfFileReader [2] in webrtc does so in fact.
> 
> This applies the group logic to our own ivf parser used in
> VDA test. This enables us to test SVC stream in VDA test.
> 
> [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp;
> [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h
> 
> Bug: 1044816
> Test: video.DecodeAccel.vp9_ksvc
> Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: David Staessens <dstaessens@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740575}

Bug: 1044816
Change-Id: Ic617db810b7d46e2065b6363d27ac1326b35abbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072341Reviewed-by: David Staessens <dstaessens@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746729}

This test appears to be a noop and it is unclear what the original
intention of the test was.

R=aerotwist@chromium.org

Change-Id: I9c398c0af9761f7ffdea8326c8be51f79dcd4f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083309
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746728}