GitLab

TBR=dtrainor@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iee27f0bbf46466726d507982bfdcd6763b9af1f8
Reviewed-on: https://chromium-review.googlesource.com/774179Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517023}

When RestoreOnStartup is managed it should be the only source of tabs
to be shown to the user on first, second or any other browser start
unless the user is restarting from a crash or starting the browser
with an url on the command line.

BUG=756545
TEST=unit_tests, browser_tests

Change-Id: I5da256009d6e254ecb8f0756cf08b2de991c9c26
Reviewed-on: https://chromium-review.googlesource.com/763532
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517022}

PermissionResponseCallback is created when a permission is requested,
and it holds a weak pointer to the PermissionManager. At shutdown, the
PermissionManager destructor destroys the permission context objects
that it holds. If there are in-flight permission requests, there will be
outstanding PermissionResponseCallback objects, which will be destroyed
and try to access the PermissionManager in their destructor. Since the
PermissionManager is already in the process of being destroyed, it has
zeroed the weak pointer and triggers a crash.

Typically the PermissionRequestManager is destroyed before the
PermissionManager, which would cancel in-flight requests. This crash
only triggers in cases where the PermissionManager is destroyed first.

This CL fixes the crash by checking the weak pointer in the
PermissionResponseCallback destructor before using it.

BUG=751020

Change-Id: Id9712896d9abd1f85260a021a9063c76537131aa
Reviewed-on: https://chromium-review.googlesource.com/773795
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517021}

Bug: 740886
Change-Id: I946c3b33aef3a1bb49ffa3e73bf1c040cbc309c0
Reviewed-on: https://chromium-review.googlesource.com/771373
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517020}

This CL addresses an issue where reloading a page with a persisted
automatic downloads permission retained the omnibox indicator after the
reload - even if a download had not been triggered. This is inconsistent
with other permission indicators, which only appear in the omnibox when
they are actively used.

A new DownloadUiState is introduced in the DownloadRequestLimiter to
allow the UI to have a different state to the internal download state.
The primary difference is that the UI state remains DEFAULT (nothing) if
the page has not invoked a download during the current load. Once a
download is invoked, the UI state will be updated if the automatic
download permission is granted or denied by the user. Every time a
download is intitiated, changes in the UI state will be broadcast so
that the omnibox indicator updates as necessary.

BUG=701680

Change-Id: Iba48ee833422ebdf6111c91fa826758b9e1ceef3
Reviewed-on: https://chromium-review.googlesource.com/770639
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517019}

This dialog will be displayed in response to any of the following:
* user clicks on the "Add to Desktop" menu item
* user clicks on the omnibox badge
* developer calls beforeinstallprompt.prompt()

Bug: 783480

Change-Id: I5af411d4fe826902e664f72f67ac4f66c9151756
Reviewed-on: https://chromium-review.googlesource.com/726958
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517018}

TBR=horo,kochi

Bug: 776656,785685
Change-Id: I64e6ff2448de65db4dbb10d81d8f3c8e39a70157
Reviewed-on: https://chromium-review.googlesource.com/773796
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517017}

Multiple shadow roots are removed in M64, and this test doesn't make
sense any more.  Remove the test from Blink's performance tests.

Bug: 780506, 512024
Change-Id: I7847e9e6f081e6c3d6de0186cc8fb02b039d53f3
Reviewed-on: https://chromium-review.googlesource.com/770851Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517016}

Without target specification, the builder tries to build 'All', 'all' target.
But some targets are unsupported in simple chrome.

Let me fix the issue by using the same target specified in chromeos-amd64-generic-rel.

TBR=dpranke@chromium.org

Bug: 785167
Change-Id: I66a5e99ec80a0df7524db199f206eb9cf22c3cd8
Reviewed-on: https://chromium-review.googlesource.com/773921
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517015}

This roll includes 3 revisions:
https://chromium.googlesource.com/chromium/buildtools/+/9c40f80c99981e0e3b8ab444ead3d8de8751c103
https://chromium.googlesource.com/chromium/buildtools/+/6cce6ca960b98e252fa2a56f1f8f26ed1d8dae85
https://chromium.googlesource.com/chromium/buildtools/+/7f134c70f0f86ed35c2ca1f6b834a48c4ba47d3e

BUG=785170
TBR=dpranke@chromium.org

Change-Id: Id44d5eb1dfe1cf6e6fe2d505b1929bf38cd3dea5
Reviewed-on: https://chromium-review.googlesource.com/773448
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517014}

https://skia.googlesource.com/skia.git/+log/d8d984ecc99d..4355b26b359d

$ git log d8d984ecc..4355b26b3 --date=short --no-merges --format='%ad %ae %s'
2017-11-15 csmartdalton Fold analytic clip FPs into GrReducedClip
2017-11-15 csmartdalton Fix precision caps and rrect/ellipse effect precisions
2017-11-16 angle-deps-roller Roll skia/third_party/externals/angle2/ 4d1469315..39644feeb (2 commits)
2017-11-16 angle-deps-roller Roll skia/third_party/externals/angle2/ 0acb268c9..4d1469315 (1 commit)
2017-11-15 bsalomon Use GrContextFactories that produce a single GrContext in unit tests.
2017-11-15 reed rename overloaded methods as speculative fix/diagnostic
2017-11-15 benjaminwagner Remove Win7/Win8 Perf-Release jobs.
2017-11-15 egdaniel Revert "Add private grpixelconfigs for alpha_8 and alpha_half"
2017-11-15 egdaniel Revert "Nit clean up to add private GrPixelConfig CL"
2017-11-15 benjaminwagner Remove/move remaining Win2k8 GCE jobs.
2017-11-15 egdaniel Nit clean up to add private GrPixelConfig CL
2017-11-15 vmpstr Ensure that removing last extension from GrGLExtension doesn't assert.
2017-11-15 bsalomon Remove support for image load/store
2017-11-15 egdaniel Add private grpixelconfigs for alpha_8 and alpha_half

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Iebb2f097a4e08a0c213c0f8b14ee2b52e6ab494f
Reviewed-on: https://chromium-review.googlesource.com/773449Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517013}

Unnecessary calls of Settings::SetMockScrollbarEnabled in some
unit tests happened because issue 762968 made RenderingTest to inherit
UseMockScrollbarSettings. If unit test calls RenderingTest::SetUp() or
inherits UseMockScrollbarSettings, we don't need to call
Settings::SetMockScrollbarEnabled.

Bug: none

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0fbfcef5c70a5175b80205d497587d7bb9b83701
Reviewed-on: https://chromium-review.googlesource.com/768090
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517012}

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

Bug: 289619
Change-Id: Icfa5e2ed3168559f94bcf94f274787e54134e5bf
Reviewed-on: https://chromium-review.googlesource.com/771388Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517011}

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

Bug: 289619
Change-Id: Icb4145774fbb42cb859fb55ec5899c733eac61e4
Reviewed-on: https://chromium-review.googlesource.com/771490Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517010}

This CL makes PreparePrototypeAndInterface methods work also for
instance objects, and work with the Window wrapper as a global object.
The methods are renamed as InstallConditionalFeaturesOnObjects.


Bug: 782121
Change-Id: I9940e8f4f54cb7566437859f5de2d35490a1f1f6
Reviewed-on: https://chromium-review.googlesource.com/765607
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517009}

In gfx::ColorSpace, make the presence of an ICC profile id indicate that
a given color space is not parametric.

Change the cache of gfx::ICCProfiles to use a gfx::ColorSpace as the
key.

Update gfx::ICCProfile and gfx::ColorSpace to consider the profile id
to be relevant in testing equality and order.

Bug: 766736
Change-Id: I85ba1240a62b4b99da97578aba2eaeac21f64d08
Reviewed-on: https://chromium-review.googlesource.com/768611Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517008}

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

Bug: 289619
Change-Id: I520f6d601ea913f96b13ec95fef1054d96f866d9
Reviewed-on: https://chromium-review.googlesource.com/771379Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517007}

We will use the side data of CacheStorageCache.Put to store the
script code cache while installing service worker.

BUG=768705

Change-Id: I84b2491bde1f1230b532ce12bf8573be905b59fd
Reviewed-on: https://chromium-review.googlesource.com/768341
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517006}

ReadableStream, WritableStream and TransformStream had their own versions of the
InvokeOrNoop and PromiseInvokeOrNoop operations. Consolidate them into a single
set in CommonOperations.js.

Parameters to the methods are taken as positional arguments to avoid the
overhead of constructing an array. There are three specialisations of
PromiseCallOrNoop for 0, 1 and 2 parameters. The operations use the word "Call"
rather than "Invoke" in their names to reflect that they take positional
paramters rather than a list.

As with ReadableStream, a "nameForError" parameter is used to supply a
user-friendly name for the method which will be used in case of error.

Bug: 
Change-Id: Ic0c33278bb7578b1f705f737d837eb9076fb033c
Reviewed-on: https://chromium-review.googlesource.com/771370Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517005}

I'm breaking up the class with a view to making it a non-public,
internal detail one. It will help me monitor the changes being
made in the class.

Bug: 598880
Change-Id: I3671149915c642863f30c2385a747da912fd4421
Reviewed-on: https://chromium-review.googlesource.com/773899Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517004}

These classes are infrastructure to use for the main content area for
forwarding scrolling events.

This CL also adds TestBrowserCoordinator, which is a BrowserCoordinator
subclass with a default UIViewController that can be used in tests
for BrowserCoordinator lifecycle events.

Bug: 769089
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I70c62708613f21247ac813f805620a7b0bb0a8fb
Reviewed-on: https://chromium-review.googlesource.com/735531
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517003}

This removes the dependency of DevToolsURLRequestInterceptor from NetworkHandler
(aside from couple of static methods) and replaces the instance of NetworkHandler
with a single callback. This also fixes crbug.com.777516 (managing active
interception job by target id), which would be a problem for multi-client mode.

Bug: 758136, 777516
Change-Id: Ic065cb5c9683069ff115bbf06409f1e5cc7afcf4
Reviewed-on: https://chromium-review.googlesource.com/752502
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517002}

Changes:
Show correct number of displays in the layout in the display settings.

Specs: https://screenshot.googleplex.com/2nDXdwpsagu
Screenshot: https://screenshot.googleplex.com/YsvtJKF0Nei

BUG=784623

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I179f256c1528da35511d1a7e0d1b0a6836297ec9
Reviewed-on: https://chromium-review.googlesource.com/767648
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517001}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/96187e53aa4b..f78690b68752

$ git log 96187e53a..f78690b68 --date=short --no-merges --format='%ad %ae %s'
2017-11-15 tandrii bot_update: refactor hiding ugly revision details into lower layers.
2017-11-15 tandrii bot_update: refactoring improving variable names.
2017-11-15 tandrii bot_update: refactor giant git_checkout into two.
2017-11-15 tandrii bot_update: fix minor pylint issues.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I80abb45e5fcb793794b77f971ba0ef36e5429fed
Reviewed-on: https://chromium-review.googlesource.com/773784Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517000}

Bug: 714300,712304
Change-Id: I95df2d633b8838fe77971f1816e0e424e239b60c
Reviewed-on: https://chromium-review.googlesource.com/773658
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516999}

This patch makes |LayoutInline::DirtyLinesFromChangedChild()| to work with
LayoutNG by marking layout dirty for |LayoutInline| node instead of marking
|InlineBox| for specified child node because LayoutNG doesn't support
partial dirtiness of box fragment yet.

Bug: 591099
Change-Id: I1f0b616f1fed891e072a84df74a66fe324c85df2
Reviewed-on: https://chromium-review.googlesource.com/768257Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516998}

Let me increase coverage of canary builder.

TBR=dpranke@chromium.org

Bug: 
Change-Id: I30e416236511e8357bee7443fce5761b0540651c
Reviewed-on: https://chromium-review.googlesource.com/771171
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516997}

When mouse hovering and tabbing through the buttons in the ProfileChooserView
at the same time, it is possible to get two different buttons to be highlighted.
Prevent this by requesting focus on hover, then highlighting on focus only. This
prevents confusion about which item actually has keyboard focus.

This has the desired side effect of making the fade-in animation duration
instant as well (crbug.com/784684).

Bug: 785164, 785262, 784684
Change-Id: Id379f2c373307f2c49dbce58cf40d3d61f9f324e
Reviewed-on: https://chromium-review.googlesource.com/773319
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516996}

Changes:
1. Support hardware mirroring by adding function to find/create mirror
   mode for 2+ displays.
2. Add unit tests.

Design doc:
go/multi-display-mirroring

BUG=607844
TEST=DisplayConfiguratorTest.*

Change-Id: If3371fcfa66b6c5a121a1f1401085df777638b4e
Reviewed-on: https://chromium-review.googlesource.com/731658
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516995}

This CL drops the error message parameter in the |not_supported_cb|
passed to KeySystemConfigSelector::SelectConfig() so that the error
message for not supported key system or config is always the same, as
specified in WebEncryptedMediaClientImpl::OnRequestNotSupported().

BUG=760720

Change-Id: I3dd6de9a112efe4dd753be1e38b510740523dc6a
Reviewed-on: https://chromium-review.googlesource.com/772968
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516994}

https://chromium.googlesource.com/angle/angle.git/+log/0acb268c99f6..39644feebaf4

$ git log 0acb268c9..39644feeb --date=short --no-merges --format='%ad %ae %s'
2017-11-15 jmadill Fix Clang build with dEQP.
2017-11-15 ynovikov Skip RenderingLimitToDefaultFBOSizeWithNoAttachments on Linux AMD GL
2017-11-15 jmadill Roll all ANGLE internal DEPS.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ieb79ef51e4d26b05acacf001e4fcec21f199d2d2
Reviewed-on: https://chromium-review.googlesource.com/774042Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516993}

Also rename the SPDY script and build target since it's now
shared with QUIC.

BUG=784865,785216

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iab78013b32e3a7df8109370877a59a6c1427aa8b
Reviewed-on: https://chromium-review.googlesource.com/772781
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516992}

The following UI flow currently only shows the selected permission type,
even if other permissions have non-default values for the selected site:

- Settings -> Site settings -> (e.g.) Location -> (e.g.) permission.site

Upon tapping Location, we fetch content settings data for only Location,
and currently don't re-fetch when drilling down. This CL changes this to
fetch all permissions when drilling down (excluding All Sites, which has
already fetched everything) so the list will be properly populated.

Bug: 673620
Change-Id: Ic1ecaaba00595c7c3ccd59119b787dab12498ee2
Reviewed-on: https://chromium-review.googlesource.com/770932
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516991}

There is no longer any need for non-renderer ChildProcesses to request shutdown
from the host, because it is always granted. Only Renderers need to do this
dance, so the ShutdownRequest message is handled in mojom.RendererHost

As part of this dance, RenderProcessShutdownRequested is called for all
RenderProcessHostObservers,and
SitePerProcessBrowserTest.CloseSubframeWidgetAndViewOnProcessExit
observes this event instead of adding an extra message filter to the
RenderProcessHost.

Bug: 775817
Change-Id: Id01308e28bfc2c1b1ecac4a63d2815300ada50b7
Reviewed-on: https://chromium-review.googlesource.com/768520
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516990}

The tests are currently failing, and since they don't seem to run on
any non-ToT Mac ASan bots we probably shouldn't be running them either.

Bug: 785479
Change-Id: I9f5e23ea545d3937fd2a6db0c25b5517ac05e5ef
Reviewed-on: https://chromium-review.googlesource.com/772867Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516989}

Structs containing interfaces currently store the fields as
InterfacePtr. This is problematic because it prevents such a struct
from being safe to move across sequences.

Given that this is the only limiting factor making struct passing
non-sequence-safe, this changes the storage type to InterfacePtrInfo.

A few places which relied on the old behavior have been updated
accordingly, with varying degrees of inconvenience.

EDIT

Bug: 753431
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I765a58a80a44ba61fed93c23a62578fb114a5245
Reviewed-on: https://chromium-review.googlesource.com/764988
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516988}

In order to enable -Wshadow for base it is necessary to rename the
ASLClient constructor parameter. This gives it a name that better
represents its generic use rather than its specific use in this one
context.

Change-Id: Ib12d058961376da63b5f864f2169f814c462d934
Reviewed-on: https://chromium-review.googlesource.com/773112Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516987}

BUG=785662
TBR=kozyatinskiy@chromium.org

Change-Id: I9b1e1f7c8216b09ee7c321ca255c1a32af7cfcb6
Reviewed-on: https://chromium-review.googlesource.com/773859Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516986}

We used to invalidate only parent LayoutSVGText but
need invalidate ancestor LayoutSVGText because LayoutSVGText
consists of a tree like "<svg><text><tspan>foo</tspan></text></svg>".

Bug: 781705
Change-Id: I12b38a7a4a78c7bff3e90698e3f64e62fac6101a
Reviewed-on: https://chromium-review.googlesource.com/771061Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516985}

Also adds x509_util::CryptoBufferAsStringPiece as a more efficient replacement for X509Certificate::GetDEREncoded.

Bug: 769549
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4c548dc67ee89ce29f7343a0031d7add5bf16d65
Reviewed-on: https://chromium-review.googlesource.com/762191Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Moe Ahmadi (slow) <mahmadi@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516984}