GitLab

Makes some Skia flags be matched properly.

e.g.

  '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
vs
  -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"

Diffs 393202 -> 374424.

It does make the script quite a bit slower unfortunately, I guess the
regular split is native C.

BUG=335824

Review URL: https://codereview.chromium.org/580213003

Cr-Commit-Position: refs/heads/master@{#295562}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0d276f7..23e280d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/580243002

Cr-Commit-Position: refs/heads/master@{#295561}

Enable accessibility tests for history page.
Add aria-label for the history search box.
Add aria-label to Today/Previous/Next.
Add aria-label to all the checkboxes.
Add aria-hidden when list is not visible.

BUG=406150

Review URL: https://codereview.chromium.org/513923003

Cr-Commit-Position: refs/heads/master@{#295560}

Review URL: https://codereview.chromium.org/582783002

Cr-Commit-Position: refs/heads/master@{#295559}

This prevents the power consumption data from accidentally leaking visited websites after clearing browser history.

Review URL: https://codereview.chromium.org/514433002

Cr-Commit-Position: refs/heads/master@{#295558}

linux-release-64/sizes/chrome-data/data: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome-data&checked=all&rev=295451

BUG=415523
TBR=bokan@chromium.org

Review URL: https://codereview.chromium.org/578243005

Cr-Commit-Position: refs/heads/master@{#295557}

Part of extensions refactoring in https://codereview.chromium.org/562273006/

Landing manually because the tryjob patch step cannot handle empty binary files

BUG=none
TEST=none
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/580283003

Cr-Commit-Position: refs/heads/master@{#295556}

Changes include:
e0399c7 Fix Regression: Incomplete file loading is seen for multi page pdf files.
9135010 gn: don't remove -fno-exceptions to match gyp
69dcf14 When forcing clear page data, no need to release colorspace when releasing pattern
4481496 Add a boundary check before accessing the table of 'Index to Location'
4cce875 Check Null pointer in CPDF_Dictionary::GetUnicodeText
56ef173 Fix hebrew character highlight issue in a special document

TBR=jam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/580173004

Cr-Commit-Position: refs/heads/master@{#295555}

Necessary with upcoming ChromeVox2 changes.

Review URL: https://codereview.chromium.org/574693003

Cr-Commit-Position: refs/heads/master@{#295554}

BUG=415609,415688
TEST=gpu bots
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/580183002

Cr-Commit-Position: refs/heads/master@{#295553}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/560563004

Cr-Commit-Position: refs/heads/master@{#295552}

- Previously, we had an unguarded bool flag for whether an interface lookup had been logged to UMA. Now each InterfaceInfo has a lock+flag. Should be near-zero contention.
- Previously, PpapiGlobals::GetBrowserSender did lazy creation with no synchronization. Now we create it at process startup and clear it at process shutdown, so there should be no race while the plugin is running.

BUG=413513,414150

Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a
Cr-Commit-Position: refs/heads/master@{#294715}

Review URL: https://codereview.chromium.org/568793002

Cr-Commit-Position: refs/heads/master@{#295551}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/580123004

Cr-Commit-Position: refs/heads/master@{#295550}

Revert of Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/)

Reason for revert:
this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup.  here's an example:

[15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by:
[15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker()
#2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter()
#3 0x000000df57f1 IOThread::InitSystemRequestContext()
#4 0x000000df570b IOThread::system_url_request_context_getter()
#5 0x000001443d9e BrowserProcessImpl::system_request_context()
#6 0x000001028a8e SafeBrowsingService::Initialize()
#7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService()
#8 0x000001446196 BrowserProcessImpl::safe_browsing_service()
#9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate()
#10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated()
#11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated()
#12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
#13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted()
#14 0x7f44be068302 base::internal::RunnableAdapter<>::Run()
#15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo()
#16 0x7f44be06821a base::internal::Invoker<>::Run()
#17 0x7f44be54e46e base::Callback<>::Run()
#18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow()
#19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks()
#20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize()
#21 0x7f44be05c7df content::BrowserMain()
#22 0x7f44bdee5f6f content::RunNamedProcessTypeMain()
#23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run()
#24 0x7f44bdee5505 content::ContentMain()
#25 0x0000041aa8cb content::BrowserTestBase::SetUp()
#26 0x00000173e117 InProcessBrowserTest::SetUp()
#27 0x000000671180 ExtensionBrowserTest::SetUp()
#28 0x0000006711b2 ExtensionBrowserTest::SetUp()
#29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>()
#31 0x0000017dd1e3 testing::Test::Run()
#32 0x0000017dd92b testing::TestInfo::Run()
#33 0x0000017ddf1a testing::TestCase::Run()
#34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests()
#35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>()
#37 0x0000017e30b1 testing::UnitTest::Run()
#38 0x000004187e41 RUN_ALL_TESTS()
#39 0x000004186e67 base::TestSuite::Run()
#40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite()
#41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#42 0x0000041bc2fb content::LaunchTests()
#43 0x00000173c6e9 LaunchChromeTests()
#44 0x0000007fccbf main
#45 0x7f44ad8ed76d __libc_start_main
#46 0x000000601389 <unknown>

[15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1)
#0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x7f44b58d7a62 logging::LogMessage::~LogMessage()
#2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks()
#3 0x000000df8e13 IOThread::CleanUp()
#4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp()
#5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp()
#6 0x7f44b59d0601 base::Thread::ThreadMain()
#7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc()
#8 0x7f44b1aa9e9a start_thread
#9 0x7f44ad9c03fd clone

Original issue's description:
> Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM
>
> BUG=384041
> TEST=new tests added
>
> Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63
> Cr-Commit-Position: refs/heads/master@{#295524}

TBR=zea@chromium.org,fgorski@chromium.org,thestig@chromium.org,bauerb@chromium.org,jianli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384041

Review URL: https://codereview.chromium.org/582913003

Cr-Commit-Position: refs/heads/master@{#295549}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=erg@chromium.org

Review URL: https://codereview.chromium.org/584553006

Cr-Commit-Position: refs/heads/master@{#295548}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/574903003

Cr-Commit-Position: refs/heads/master@{#295547}

BrowserInstantController calls Reload() if the google url
changes. This triggers closing the session crashed info bar
prematurely. Seems like we want this for all InfoBars, so I've
centralized the ignore.

BUG=401024
TEST=none
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/553333006

Cr-Commit-Position: refs/heads/master@{#295546}

BUG=383877

Review URL: https://codereview.chromium.org/580203002

Cr-Commit-Position: refs/heads/master@{#295545}

This fixes an issue with missing newlines in stacktraces.

BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/584693002

Cr-Commit-Position: refs/heads/master@{#295544}

BindToLoop need to set |loop_| synchronously to prevent delete from
destroying the object on the wrong thread.

BUG=415306, 412578

Review URL: https://codereview.chromium.org/575293003

Cr-Commit-Position: refs/heads/master@{#295543}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/21980cb..c3a905f

TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/584633003

Cr-Commit-Position: refs/heads/master@{#295542}

because "extensions/common/test_util.h" has duplicate function.

BUG=394840

Review URL: https://codereview.chromium.org/569493003

Cr-Commit-Position: refs/heads/master@{#295541}

Enable the notification by default. Change flag
--send-v8-idle-notification-after-commit to
--enable-v8-idle-notification-after-commit. Add new flag
--disable-v8-idle-notification-after-commit to override enable or
default.

R=jochen@chromium.org,hpayer@chromium.org,jamesr@chromium.org,danno@chromium.org
BUG=414815

Review URL: https://codereview.chromium.org/566733004

Cr-Commit-Position: refs/heads/master@{#295540}

Contains fixes for setting sampler uniforms.

BUG=414450

Committed: https://crrev.com/ee4fc3e3db62b0a19e39f575b8faecd2dcc2f88b
Cr-Commit-Position: refs/heads/master@{#295519}

Review URL: https://codereview.chromium.org/579903002

Cr-Commit-Position: refs/heads/master@{#295539}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/65b427c..0d276f7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/578243004

Cr-Commit-Position: refs/heads/master@{#295538}

ViewManager from mojo_shell.

Original cl was https://codereview.chromium.org/477923004/

BUG=
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/578353002

Cr-Commit-Position: refs/heads/master@{#295537}

This CL moves the functionality of WebViewGuest::Find() out of the chrome-specific delegate, and into extensions, so that app_shell can also use it.

BUG=352293

Review URL: https://codereview.chromium.org/579563002

Cr-Commit-Position: refs/heads/master@{#295536}

Revert of Roll asan_symbolize.py to llvm r218071. (patchset #2 id:20001 of https://codereview.chromium.org/584673002/)

Reason for revert:
This requires an accompanying change to the Chromium-specific wrapper.

NOTRY=true

Original issue's description:
> Roll asan_symbolize.py to llvm r218071.
>
> This fixes an issue with missing newlines in stacktraces.
>
> BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/f7aef702936dcd93ab4928ead74e3db437c1f862
> Cr-Commit-Position: refs/heads/master@{#295531}

TBR=glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343

Review URL: https://codereview.chromium.org/580233003

Cr-Commit-Position: refs/heads/master@{#295535}

This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/

Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.

Now, the import itself is asychronous and calls back on completion.

While there, this also removes the GMock of the importer.

BUG=413219

Review URL: https://codereview.chromium.org/547553005

Cr-Commit-Position: refs/heads/master@{#295534}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/578413002

Cr-Commit-Position: refs/heads/master@{#295533}

Review URL: https://codereview.chromium.org/581163002

Cr-Commit-Position: refs/heads/master@{#295532}

This fixes an issue with missing newlines in stacktraces.

BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/584673002

Cr-Commit-Position: refs/heads/master@{#295531}

While the keyboard is in the process of hiding, the proxy's visibility
flag may not be updated yet. Use the private keyboard_visible_ flag
instead as it stores the future visibility of the keyboard window after
animation is completed.

BUG=401670
TEST=Updated:
        KeyboardControllerTest.CheckOverscrollInsetDuringVisibilityChange
     On device:
         As the inset update must be initiated after the animation is
         started and before it is finished. Tested on clapper with the
         same method as in the bug, i.e. switch tab after hiding
         keyboard to trigger fast inset update.

Review URL: https://codereview.chromium.org/578653004

Cr-Commit-Position: refs/heads/master@{#295530}

Reason for revert:
Appears to be causing build failures. Here's an example.
http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/12428/steps/steps/logs/stdio

Original issue's description:
> Roll ANGLE.
>
> Contains fixes for setting sampler uniforms.
>
> BUG=414450
>
> Committed: https://crrev.com/ee4fc3e3db62b0a19e39f575b8faecd2dcc2f88b
> Cr-Commit-Position: refs/heads/master@{#295519}

TBR=vmiura@chromium.org,geofflang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414450

Review URL: https://codereview.chromium.org/585593002

Cr-Commit-Position: refs/heads/master@{#295529}

Each RasterWorkerPool implementation is tied to some
RasterBuffer implementation. By moving the RasterBuffer
code into RasterWorkerPool implementation this
relationship becomes more explicit and more easily
adjusted for the need of the RasterWorkerPool
implementation.

BUG=406404

Review URL: https://codereview.chromium.org/562833004

Cr-Commit-Position: refs/heads/master@{#295528}

R=asvitkine@chromium.org,isherman@chromium.org,
BUG=404791

Review URL: https://codereview.chromium.org/577823002

Cr-Commit-Position: refs/heads/master@{#295527}

This also fixes a bug in the tool-bar position when the window is scrolled.

BUG=411996

Review URL: https://codereview.chromium.org/575303002

Cr-Commit-Position: refs/heads/master@{#295526}

The flaky test recovers by itself somehow. Remove the debug logging.

BUG=393995
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/574813002

Cr-Commit-Position: refs/heads/master@{#295525}

BUG=384041
TEST=new tests added

Review URL: https://codereview.chromium.org/561943002

Cr-Commit-Position: refs/heads/master@{#295524}

of Chrome-specific "constants."

These URLs can be overridden by extensions embedders now
and are no longer incorrectly classified as "constants."

BUG=398671
TBR=xiyuan@chromium.org,sky@chromium.org for various files with header updates

Review URL: https://codereview.chromium.org/575113002

Cr-Commit-Position: refs/heads/master@{#295523}