- 28 Feb, 2019 40 commits
-
-
Ioana Pandele authored
This reverts commit 9d958e98. Reason for revert: This breaks on Linux Tests (dbg)(1) Bug: 936778 Original change's description: > Rebase two inspector-protocol/network tests following NetworkService being enabled > > - interception-take-stream.js is only supposed to work with the network service, > old expectations were for errors reported when it doesn't; > - xhr-interception-auth-fail.js change is due to actually changed semantics -- we > do not prompt for auth when sending XHRs in general, but if worked before > because we used to intercept at the lower level (URLRequestJob vs. URLLoader). > > Bug: 933880 > Change-Id: I3d0a1cae30b11af3ca50bd64d4123b294e42b59b > Reviewed-on: https://chromium-review.googlesource.com/c/1492046 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Auto-Submit: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636207} TBR=dgozman@chromium.org,caseq@chromium.org Change-Id: I09e4ddd90b87bce6486c425028cf3826b1626132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933880 Reviewed-on: https://chromium-review.googlesource.com/c/1493907Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#636401}
-
Antonio Gomes authored
BUG=922803 Change-Id: I0c7b1fb637e7f6a7646f52c308fdab9388d055b6 Reviewed-on: https://chromium-review.googlesource.com/c/1491834Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636400}
-
Henrique Ferreiro authored
Move the remaining code from third_party/blink/renderer/platform/scroll/ to core/scroll and remove the directory. This is the last CL in a series of CLs to remove platform/scroll. R=haraken@chromium.org Bug: 922111 Change-Id: I77308e3ac8491147450aa3ce7fa045cf1d3775e5 Reviewed-on: https://chromium-review.googlesource.com/c/1491551Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#636399}
-
Arthur Hemery authored
Disabled a test that did not make sense anymore when IsPerNavigationMojoInterfaceEnabled() is true. See in code comment for more details on why it is not relevant anymore. Bug: 784904 Change-Id: I5f9149467b6d0c281864f66be12ad49d82c34979 Reviewed-on: https://chromium-review.googlesource.com/c/1488916Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#636398}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f80078b4c62c..1179d5dfaf8d git log f80078b4c62c..1179d5dfaf8d --date=short --no-merges --format='%ad %ae %s' 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 aaa17b8528d8..4b314eefc839 (2 commits) Created with: gclient setdep -r src/third_party/skia@1179d5dfaf8d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icd45154f5cad9c0c2746d04473bb767ee5717c46 Reviewed-on: https://chromium-review.googlesource.com/c/1493647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636397}
-
Alexey Seren authored
There is a heap buffer overflow in ContentPasswordManagerDriverFactory::DidFinishNavigation. This bug is a consequence of race between RenderFrameDeleted and DidFinishNavigation methods of ContentPasswordManagerDriverFactory class and occures during execution in following test: browser_tests.MimeHandlerViewCrossProcessTest.NavigationRaceFromEmbedder/1 Change-Id: Ifefb065c4ce2f0603c143ce777982e3fad60bcc2 Reviewed-on: https://chromium-review.googlesource.com/c/1493052 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#636396}
-
Varun Khaneja authored
R=drubery, nparker Change-Id: I6b12a38860dfde781588776fadf027f344572ead Reviewed-on: https://chromium-review.googlesource.com/c/1490213 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636395}
-
Mario Sanchez Prada authored
Member variables should use snake_case_with_trailing_underscore_, while function parameters should use simply snake_case. Bug: 936378 Change-Id: I439e4f5e93d8219ebf570f1690cebdea3ab0b74e Reviewed-on: https://chromium-review.googlesource.com/c/1492113Reviewed-by:
-
Olivier Robin authored
When navigating to a placeholder URL that replace a navigation with a virtualURL, |CRWWebController currentURLWithTrustLevel:| returns the VirtualURL and not the URL. Fix the DCHECK. Bug: 929492 Change-Id: Ib845efc97793ddb9fc665e18f87b243f083a288e Reviewed-on: https://chromium-review.googlesource.com/c/1489731 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#636393}
-
Victor Costan authored
The script extracts the SVN revision number used to build lld-link using an overly restrictive regex, which expects the output to look like "... (trunk 123456)". The current output looks like "... (https://llvm.org/svn/llvm-project/lld/trunk 123456)". This CL makes the regular expression a bit more permissive. TBR=thakis Bug: 936772 Change-Id: I896b56e8a21fc5b8eae9b55bc79741ca63dc678a Reviewed-on: https://chromium-review.googlesource.com/c/1492982Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636392}
-
Hiroki Nakagawa authored
This is just a code cleanup CL. Before this CL, each worker or worklet has its own mechanism to provide the global scope name. This CL unifies them by GlobalScopeCreationParams::global_scope_name. Also, this consolidates |name_| fields in {Dedicated,Shared}WorkerGlobalScope into WorkerOrWorkletGlobalScope, and removes WorkerThread::name(). Note: The global scope name is used for various purposes: - DedicatedWorker and SharedWorker expose it in JS as {Dedicated,Shared}WorkerGlobalScope#name. - PaintWorklet and LayoutWorklet use it for the debugger to distinguish multiple worklet instances created from the same script URL. - ServiceWorker, AudioWorklet, and AnimationWorklet don't use it for now. AudioWorklet and AnimationWorklet may want to use it like PaintWorklet and LayoutWorklet, but it's out of the scope of this CL. Bug: n/a Change-Id: I35eeb12cce4df408b1e7cd5d9a1a736da513d41b Reviewed-on: https://chromium-review.googlesource.com/c/1491875 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636391}
-
David Jean authored
Replace UrlLoader gotten from the UrlLoadingService with the service itself. Bug: 907527 Change-Id: I8b27152a70f7d39b2b378cc7f774aa57e2439e23 Reviewed-on: https://chromium-review.googlesource.com/c/1481411Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#636390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/297f40bc1208..00be6aaa4a3e Created with: gclient setdep -r src-internal@00be6aaa4a3e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80e94462f2a2260bdf2ceea06040a03706976618 Reviewed-on: https://chromium-review.googlesource.com/c/1493103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636389}
-
Henrik Boström authored
In https://webrtc-review.googlesource.com/c/src/+/124701, PostTask() is added to WebRTC threads in order to make it easier to post tasks asynchronously in third_party/webrtc, and to start discouraging blocking thread invokes just like they are in Chrome. Part of that CL adds a DCHECK that the thread is not quitting when posting in order to avoid race conditions and posting when the thread is already quit in WebRTC. The JingleThreadWrapper, which implements rtc::Thread, does not support quitting. Because of a NOTREACHED() it is not possible to use rtc::Thread::PostTask() in Chrome because of this DCHECK. This CL replaces the NOTREACHED() with NOTIMPLEMENTED_LOG_ONCE() in IsQuitting(). If quitting is not supported it is reasonable to always return false. (The alternative would be not to DCHECK !IsQuitting() in PostTask(), but then we'll be warned about less races on platforms that do support quitting.) Bug: webrtc:10294 Change-Id: Ibe35c42f6a860bc7cc933c06deeacff5b2be3215 Reviewed-on: https://chromium-review.googlesource.com/c/1491620 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636388}
-
Alex Danilo authored
Remove the flag and all associated usage of it. Bug: 935217 Tests: Ran all browser and unit tests. Change-Id: I15c4e3d077e2137df96348d8b12f69784161e4ce Reviewed-on: https://chromium-review.googlesource.com/c/1491053Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636387}
-
Ken Rockot authored
Downloads initiated by download link interaction were not plumbed through the WebRequest path at all when NS is enabled. This fixes that. See changes to download_manager_impl.cc, which constitute the bulk of the interesting diff here. The rest of the CL is plumbing a flag through WebRequestProxyingURLLoaderFactory so it knows that these requests are downloads, because leaning on ResourceType seemed like the wrong thing to do (it's defined by content, and the ResourceRequest is constructed within a component that can't depend on content). Bug: 935567 Change-Id: I88f535d5e99435d7bae8ca6046ffa1b88d339bf1 Reviewed-on: https://chromium-review.googlesource.com/c/1493637 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636386}
-
Ioana Pandele authored
This reverts commit 21fe97f0. Reason for revert: crbug.com/936770 Bug:936770 Original change's description: > Stop over-recording data use related to Previews > > Lite Page Server Previews over records data use when it attempts to > record data savings. Instead, only the savings should be recorded. > > This also changes the data usage site breakdown code to use Virtual URL > (the one in the omnibox) instead of the actual host for the sake of > improving UI and tracking HTTPS Lite Page Previews more accurately. > > Bug: 936577 > Change-Id: Ib7dfe8afeea0b277ac065d58c02b2962a4ab6c94 > Reviewed-on: https://chromium-review.googlesource.com/c/1492428 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636282} TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org Change-Id: I59d5ee7cb561d445ba844e93b5d360c28c5a4c87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936577 Reviewed-on: https://chromium-review.googlesource.com/c/1493906Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutBlockFlowRareData| to hold |NGOffsetMapping| for legacy layout to make |NGInlineNode::GetOffsetMapping()| can use |NGOffsetMapping| once it is computed until next layout for making repeated call of |Element#innerText| faster. Before this patch, |NGOffsetMapping| for legacy layout tree is hold by callers to avoid computing |NGOffsetMapping| in same |LayoutBlockFlow|. However, this simple cache doesn't work for |Element#innerText| when it is called for each element: document.body.innerHTML = '<span>a</span>'.repeat(3000); [...document.getElementByTagName('*')].forEach(e => e.innerText); Before this patch, above code fragment takes 4000ms, after this patch it takes 40ms on my local machine. This patch also movs |LayoutBlockFlowRareData| constructor to ".cc" file to avoid including "ng_offset_mapping.h" to instantiate |std::unique_ptr<NGOffsetMapping| in various places. Note: Following patch[1] will get rid of redundant parameter from |NGInlineNode::GetOffsetMapping()|. [1] http://crrev.com/c/1488400 Get rid of redundant parameter from NGInlineNode::GetOffsetMapping() Bug: 935237 Change-Id: I5990f53632b06e721cc17eca0c80aea8aac36675 Reviewed-on: https://chromium-review.googlesource.com/c/1488479 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636384}
-
Ramin Halavati authored
ProfileChooserView prepares several menus, including different flavors of profile menu, guest menu, and incognito menu. The class is now divided into two classes, ProfileMenuViewBase which is in charge of the UI implementation and styling, and ProfileChooserView which decides about the elements in the menu based on the selected menu mode. Bug: 934689 Change-Id: If4c8f3093afbd5c78b872cb08f07ae337996a316 Reviewed-on: https://chromium-review.googlesource.com/c/1482953 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#636383}
-
Tao Bai authored
This patch - Adds ContentCaptureSender which implements WebContentCaptureClient to forward the captured/removed content to browser side, it enables the ContentCapture in blink by setting the client. - adds content capture features, and disables the ContenCapture by default. - adds features parameters to configure how the ContentCapture runs. - adds fieldtrial for ContentCapture. Bug: 924681 Change-Id: I8dd826cb862c75e2706964aece9727fd6f7efdca Reviewed-on: https://chromium-review.googlesource.com/c/1489971 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636382}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature TBR=aleloi Bug: 925652, 936658 Change-Id: Ia20fd8aa27f4a262818cedfc8d4e4922728569ed Reviewed-on: https://chromium-review.googlesource.com/c/1493303Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9dc8eafe11c0..4b314eefc839 git log 9dc8eafe11c0..4b314eefc839 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 jmadill@chromium.org Win7: No warnings as errors in FragData test. Created with: gclient setdep -r src/third_party/angle@4b314eefc839 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920704 TBR=ynovikov@chromium.org Change-Id: I9beb9a77220e1b49f0b611a82536f6eb97dcc1c7 Reviewed-on: https://chromium-review.googlesource.com/c/1493104Reviewed-by:
-
tzik authored
This contains a build fix for C++17 mode on Windows. https://github.com/grpc/grpc/pull/18176 Bug: 752720 Change-Id: Ia524d30202a19ae6d0f064ce612a6c7bbfba68bb Reviewed-on: https://chromium-review.googlesource.com/c/1493340 Auto-Submit: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#636379}
-
Ioana Pandele authored
TBR=jdufault@chromium.org Bug: 936407 Change-Id: I24aed0fb3b2ab2dbb50f432b0cfbfebbb5e9a6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1491621 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
This is a reland of ee05382c Original change's description: > cros: Introduce common concept for conditions that can be awaited it tests. > > Bug: 912704 > Change-Id: Ie1804ce8a6f05721e28a6d2c703530d8e0c53841 > Reviewed-on: https://chromium-review.googlesource.com/c/1481511 > Commit-Queue: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635114} Bug: 912704 Change-Id: I7fdb737d1dfe8d8fd894081ffedc47d21b538c11 Reviewed-on: https://chromium-review.googlesource.com/c/1488915Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#636377}
-
Yutaka Hirano authored
ResourceDispatcher::RemovePendingRequest deletes the RequestPeer asynchronously so we need to cancel the SimpleWatcher manually. Bug: 934956 Change-Id: Iabcdd54c1174b6150a04ffa80c3e4815fbf75fa8 Reviewed-on: https://chromium-review.googlesource.com/c/1491571 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#636376}
-
Alexey Baskakov authored
This is a preparation CL. We will use WebAppProvider::install_manager() instead of BookmarkAppHelper::Create(). TBR=estade@chromium.org Bug: 915043 Change-Id: I5adf312c3d4f0ee34e8bf7007288b5b13c5acbeb Reviewed-on: https://chromium-review.googlesource.com/c/1491154Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#636375}
-
Miyoung Shin authored
- unsigned short/int -> uint16_t. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Iccca63f288e46f1081c3dabcd0aed19cfe350b81 Reviewed-on: https://chromium-review.googlesource.com/c/1491235Reviewed-by:
-
Abhishek Bhardwaj authored
This change adds functionality to support lock screen notifications for Android. The notification module now notifies power manager of a user activity in case a notification is posted or updated. This is done to transition the device to a full resume from a dark resume in case Android draws a notification in response to an alarm or a network packet. This change also adss more functionality to the existing bare bones fake message center. BUG=chromium:898297 TEST=End to end test with Android applications. Change-Id: Ie915c1f8a15b0bb74b2061fdcac6d6af6132ce19 Reviewed-on: https://chromium-review.googlesource.com/c/1372557 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#636373}
-
Jungshik Shin authored
This is to add a missing region display name fix for {HK,MO,FK} in zh-Hant, lt and lv locales. See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1493786 for the change. TBR=yyushkina@chromium.org Bug: 926644 Test: In settings-language menu, HK's display name in zh-Hant is '香港'. Change-Id: I4d5cb8d34790d62a46e554ecf9425f5d6c2d2926 Reviewed-on: https://chromium-review.googlesource.com/c/1493301Reviewed-by:Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636372}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b980fbc..dd689541 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3698449be3d21c14c291fe7abc8a19f82e41db96 Reviewed-on: https://chromium-review.googlesource.com/c/1493708Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636371}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/exported with the macros of Allocator. After some analyzes, it was concluded that for the case of all classes that this CL touches, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. Additionally, this CL annotates BlobBytesStreamer with USING_FAST_MALLOC as well. Bug: 919389 Change-Id: I7153b2aac9175970d17f88b6e46bd0126f17a081 Reviewed-on: https://chromium-review.googlesource.com/c/1493686Reviewed-by:
-
Yi Su authored
This CL converts ios_web_shell_egtests.PluginPlaceholderTestCase to ios_web_inttests.PluginPlaceholderTest, because it doesn't require UI for testting. Bug: 930859 Change-Id: I00e38fa9b20c73b3a374890f30aaaee51e5656fa Reviewed-on: https://chromium-review.googlesource.com/c/1488928 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Amos Lim authored
Move OnSetIdleTimerDelayToZero functions from EmbeddedWorkerTestHelper to FakeServiceWorker. Bug: 934665 Change-Id: I59e3f237452ac2227b7087dbcf857f6fe6304dcb Reviewed-on: https://chromium-review.googlesource.com/c/1493626Reviewed-by:
-
Yoichi Osato authored
This patch is a preparation for Shadow DOM V0, Custom Element V0 (CEv0) and HTML Imports removal. Intent to Deprecate and Remove: http://bit.ly/2RGHe3x Though we soon make these APIs only available for test by turning the json5 feature flag from status: "stable" to status: "test", there is browser tests/chrome internal components that use them. PDF extension is a one of them and this patch reenable the APIs for it. We should migration it using new APIs. This is leftover from previous patch: crrev.com/c/1405955 (only enable HTML Import) that's because Polymer1 uses SDv0 and CEv0. on crrev.com/c/148130 Bug: 924031 TEST: browser_tests --gtest_filter=*PDFExtensionTest* --disable-features=WebUIPolymer2 Change-Id: If7569e629d2c3b1472181d2a641209807b8fe748 Reviewed-on: https://chromium-review.googlesource.com/c/1493687Reviewed-by:
-
Miyoung Shin authored
- unsigned short -> uint16_t, short -> int16_t. - Use std::numeric_limits instead of a magic number - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: If46fa2f4fef4149842f04a104ca186fd5a5e9996 Reviewed-on: https://chromium-review.googlesource.com/c/1491157 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: Idffc12401ef1aae0e47abb1902f81b373ce4753f Reviewed-on: https://chromium-review.googlesource.com/c/1491744 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636365}
-
Mohamed Amir Yosef authored
LoginDatabase::UpdateLogin() used to execute an UPDATE OR REPLACE when updating a form. There was some history behind that "REPLACE". CL in [1] Introduced some changes that make UpdateLogin can match multiple forms which caused some regression. CL in [2] Introduced the replace "REPLACE" to fix that regression CL in [3] basically undid the change in [1] but left the REPLACE This CL basically removes the unnecessary REPLACE because it's more confusing than useful. More details are in the bug. [1] https://codereview.chromium.org/169173005/diff/110001/components/password_manager/core/browser/login_database.cc [2] https://codereview.chromium.org/202903002/diff/100001/components/password_manager/core/browser/login_database.cc [3] https://codereview.chromium.org/299443002/diff/40001/components/password_manager/core/browser/login_database.cc Bug: 349138 Change-Id: I8d38da50c3984f24c9eaae7056c7e3461bcb7a75 Reviewed-on: https://chromium-review.googlesource.com/c/1491623Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#636364}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca6432e20dc4..afd6d361b5b7 git log ca6432e20dc4..afd6d361b5b7 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 jbudorick@chromium.org Revert "speed: Look only for the appropriate devices/browsers." Created with: gclient setdep -r src/third_party/catapult@afd6d361b5b7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932409,chromium:935578 TBR=sullivan@chromium.org Change-Id: I2b73bc22485b11d900040b6439477e547378b211 Reviewed-on: https://chromium-review.googlesource.com/c/1493548Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dfc0f3b7a757..201f136c9907 git log dfc0f3b7a757..201f136c9907 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 chrisforbes@google.com Remove remnants of non-descriptor-backed textures 2019-02-28 headlessclayton@gmail.com Add regres test lists. Created with: gclient setdep -r src/third_party/swiftshader@201f136c9907 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125909515 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ied7acc42d5355219b9158bb5699daaa028ae23f2 Reviewed-on: https://chromium-review.googlesource.com/c/1493549Reviewed-by:
-
