GitLab

This will make adding retry logic here more sane.

BUG=None
TEST=Unittests


Review URL: https://chromiumcodereview.appspot.com/11415280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586
R=estade@chromium.org
TBR=akalin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11415226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170936 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to support the Android WebChromeClient.onCloseWindow API.

Android bots green
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11418292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170935 0039d316-1c4b-4281-b951-d872f2087c98

This change contains:
 - check the presence of the metadata entry before delete it,
 - +1 for start of changestamp to fetch to prevent fetching a change multiple times.

BUG=156041

Review URL: https://chromiumcodereview.appspot.com/11418305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170934 0039d316-1c4b-4281-b951-d872f2087c98

CloseIdleConnectionsForProfile() was a no-op. It was only fetching the
HttpNetworkSession for a specific profile but wasn't actually doing anything
with it. The call to 'session->CloseIdleConnections()' got lost during the
initial review process (see code review 10816038).


Review URL: https://chromiumcodereview.appspot.com/11411315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170933 0039d316-1c4b-4281-b951-d872f2087c98

To be reverted immediately once a test run has started.

BUG=153260

Review URL: https://codereview.chromium.org/11434037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161436
TEST=manual (Launch test app -> Disconnect network -> Connect network -> Receive notification)

Review URL: https://codereview.chromium.org/11419281

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11428073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170930 0039d316-1c4b-4281-b951-d872f2087c98

This bug was caused because Mac's NSMakeRange takes a beginning and a length.  All the other platform's range representations take a beginning and an end.

I audited omnibox_view_win.cc, omnibox_view_views.cc, and omnibox_view_gtk.cc.  They all seem to be correct.  I also tested Windows and Linux and verified that the current behavior is correct.

BUG=163807


Review URL: https://chromiumcodereview.appspot.com/11308330

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170929 0039d316-1c4b-4281-b951-d872f2087c98

  - adjusted styling of App icons
  - added scrollable area for Apps
  - Apps are now sorted alphabetically
  - adjusted positioning of Tiles/Apps

BUG=164018

Review URL: https://chromiumcodereview.appspot.com/11412214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161941


Review URL: https://chromiumcodereview.appspot.com/11280250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170927 0039d316-1c4b-4281-b951-d872f2087c98

> Video capture implementation using the Media Foundation API.
> This replaces the DirectShow based implementation for Vista,Win7 and Win8.
> DirectShow isn't supported in metro mode so once we've landed this,
> we can revert the workaround we have in place for Win8.
> 
> The CapabilityList class is mostly moved code from the DS implementation.
> The difference is that I'm not using a std::map<> since that wasn't
> really necessary and instead adding one member (via inheritance) to
> the capability struct on Windows that holds the stream id that is needed.
> 
> BUG=140545
> TEST=All video capture tests in media_unittests now test this new implementation (except on XP).
> 
> Review URL: https://codereview.chromium.org/11419200

TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/11418307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170922 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 170668
> Needs to revert this because its WebKit patch was unrolled.
> (See r136319, unreviewed, rolling out r136236).
> > Update the Speech Api to support array(s) of result items
> > instead of a single item at a time.
> > 
> > BUG=143124
> > TEST=Covered by content_unittests
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11421103
> 
> TBR=tommi@chromium.org
> Review URL: https://codereview.chromium.org/11416310

TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11316330

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170920 0039d316-1c4b-4281-b951-d872f2087c98

This is a first step towards implementing three major Chromium features, all of which need to associate audio outputs with their source tabs.  See BUGs referenced by this change for more details.

Previous attempt/approach: https://codereview.chromium.org/11166002/

Specifics:

1. Added two new IPC messages: AudioHostMsg_AssociateStreamWithProducer and AudioInputHostMsg_AssociateStreamWithConsumer.
2. Added "associate to render_view_id" IPC calls: PepperPlatformAudioInputImpl, PepperPlatformAudioOutputImpl, RenderAudioSourceProvider, RendererWebAudioDeviceImpl, WebRtcAudioRenderer.
3. AudioOutputDevice instances re-use the same stream IDs.
4. Removed AudioDeviceFactory and replaced test-injection scheme in AudioRendererMixerManager.

Not in scope:

1. Associating RenderViews with audio input to WebRTC.
2. Associating RenderViews with streams produced by the AudioRendererMixer.
3. Speech Input (implementation is in the browser process, not the render process).

Testing method: Confirm correct render_view_id shows up in debug logging when engaging the various audio code paths.  Some of the many test sites used:

1. PPAPI (in and out): http://www.midomi.com/index.php?action=main.mic_check
2. WebMediaPlayer (e.g., <audio> and <video>): http://html5video.org/
3. WebAudio API: http://chromium.googlecode.com/svn/trunk/samples/audio/convolution-effects.html
4. WebRTC (output only): http://apprtc.appspot.com/

BUG=3541,64215,153392
TEST=Enabled debug logging via --vmodule=audio_renderer_host=1,audio_input_renderer_host=1 and then engaged the various Chrome audio code paths to confirm correct render_view_id shows up in browser process.


Review URL: https://chromiumcodereview.appspot.com/11359196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170919 0039d316-1c4b-4281-b951-d872f2087c98

This follows a similar policy as Android browser:

- If an invalidate only intersects the base plus at most one non-base SkPicture, then it creates a new SkPicture of that size.
- If an invalidate intersects two or more non-base SkPictures, then a new SkPicture is created at the top of the pile, sized to the union of the invalidate plus the bounds of all the intersecting pictures.
- Whenever new picture's area fully contains an existing picture, that old picture is destroyed.
- If an SkPicture's area would be >70% of the base, the pile is
  destroyed and the base SkPicture is recreated.

During the invalidate pass, invalidated pictures are represented as
Pictures with a size but no recording.  Then all the blank pictures
are filled in at the end of the Update().

BUG=163429

Review URL: https://chromiumcodereview.appspot.com/11299324

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170917 0039d316-1c4b-4281-b951-d872f2087c98

triggered from hotdog -> Bookmarks when in Metro mode.

To perform the metrics recording, this CL includes changes
to provide a callback mechanism for the asynchronous tile
creation in metro_driver.dll to report back the result of
the use gesture to the browser process. Note that both
metro_driver.dll and chrome.dll link statically to base, so
they have distinct data segments holding UMA histograms,
hence the callback.

BUG=160840
TEST=In Windows 8 Metro Mode, Hotdog -> Bookmarks -> Pin to start page:
 - pin and cancel (escape/click/touch off popup)
 - pin and confirm
 - (when pinned) unpin and cancel
 - unpin and confirm
Above should all work (and report UMA histogram data).

Review URL: https://chromiumcodereview.appspot.com/11280112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170916 0039d316-1c4b-4281-b951-d872f2087c98

It's because GLES2DecoderImpl::HandleDestroyStreamTextureCHROMIUM can
clear the target of a streamtexture which is not zero.
It occurs when destorying a html5 video on Android platform because it will
create/destroy streamtextures.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/11421148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170915 0039d316-1c4b-4281-b951-d872f2087c98

This is the Mac version of this CL:
https://chromiumcodereview.appspot.com/11410067
It limits the width of tab titles and window names in the recent tabs menu.

BUG=160844


Review URL: https://chromiumcodereview.appspot.com/11316127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170914 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160904


Review URL: https://chromiumcodereview.appspot.com/11280140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170913 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the DirectShow based implementation for Vista,Win7 and Win8.
DirectShow isn't supported in metro mode so once we've landed this,
we can revert the workaround we have in place for Win8.

The CapabilityList class is mostly moved code from the DS implementation.
The difference is that I'm not using a std::map<> since that wasn't
really necessary and instead adding one member (via inheritance) to
the capability struct on Windows that holds the stream id that is needed.

BUG=140545
TEST=All video capture tests in media_unittests now test this new implementation (except on XP).

Review URL: https://codereview.chromium.org/11419200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164030


Review URL: https://chromiumcodereview.appspot.com/11421212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163060


Review URL: https://chromiumcodereview.appspot.com/11414238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170908 0039d316-1c4b-4281-b951-d872f2087c98

This refactors the following flash functions to the new resource model.
-GetProxyForURL
-UpdateActivity
-SetCrashData

BUG=


Review URL: https://chromiumcodereview.appspot.com/11415140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156041
TEST=manual

Review URL: https://codereview.chromium.org/11421125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170904 0039d316-1c4b-4281-b951-d872f2087c98

The ConstrainedWindowMacTest.ShowInUninitializedTab was failing on some bots.
http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/78878/steps/browser_tests/logs/stdio

> Fix showing constrained window for uninitialized tabs
> 
> If a tab is added without being shown then the associated tab view for the web content will not be created yet.
> 
> When a constrained window is added to that tab the window never gets shown.
> 
> To fix this I've changed ConstrainedWindowMac2 to reshow the window once the web contents becomes visible.
> 
> BUG=163778
> TEST=Reproduced bug 163778 and verified that my patch fixes it.
> Verified that ConstrainedWindowMacTest.ShowInUninitializedTab fails without my patch and passes with it.
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11419277

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/11418304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11414286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170902 0039d316-1c4b-4281-b951-d872f2087c98

TEST=all existing tests

Review URL: https://codereview.chromium.org/11308340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170901 0039d316-1c4b-4281-b951-d872f2087c98

This patch includes:
- Adding DriveFileSyncClientObserver to notify OnAuthenticated event
- Invoking SyncFileSystemService::OnRemoteServiceStateUpdate when OnAuthenticated event happens.

BUG=161436
TEST=manual (Launch test app -> Logout -> Login -> Receive notification)

Review URL: https://codereview.chromium.org/11414253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170900 0039d316-1c4b-4281-b951-d872f2087c98

toolchain option is deprecated.


BUG=


Review URL: https://chromiumcodereview.appspot.com/11316289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152389


Review URL: https://chromiumcodereview.appspot.com/11312157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170898 0039d316-1c4b-4281-b951-d872f2087c98

- Eliminate variadic arguments in favor of C++ templates.
  This makes ASAN and Valgrind much happier, as we are no
  longer accessing more arguments than what has been passed
  into our function (i.e. in the past, we'd always forward
  six arguments to the kernel, even if the system call
  needed fewer; now, we explicitly pass zeros).

- In the past, callers had to be very careful when passing
  NULL, as the C++ compiler was likely to treat this macro
  as a 32bit integer value rather than a 64bit pointer. We
  now always perform sign extension for expanding arguments
  to the full native word width.

- On x86-64, we could clobber up to eight (in some cases 16)
  bytes in the red zone. This would typically only happen
  when high optimization levels were turned on, and in many
  cases it ended up overwriting data that was no longer
  needed. But we have seen at least one case where we ended
  up clobbering a system call parameter. We now explicitly
  avoid the red zone and this problem can no longer happen.

BUG=163904,162925
TEST=sandbox_linux_unittests
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163804
TEST=ran new tests in accelerator_controller_unittest.cc. tested manually too.

Review URL: https://codereview.chromium.org/11419306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127536
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416336

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170894 0039d316-1c4b-4281-b951-d872f2087c98

Previously the test was racy due to when the RecordUnrecoverError method
expectation was set. Now that it's no longer an unrecoverable error, we
can remove the expectation altogether.

BUG=162793,117796


Review URL: https://chromiumcodereview.appspot.com/11308331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170893 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces VirtualAudio{Input,Output}Streams to handle redirecting audio output from Chrome into a virtual input stream to be used as "fake" microphone input. That stream could then be used through WebRTC peer connection, essentially playing back audio from the browser remotely.

Limitations:
Currently, only one VirtualAudioInputStream is supported, so we can only capture browser-wide audio once. Subsequent requests for audio through the TabCapture API will result in no audio for that stream.

Overview:
When a VirtualAudioInputStream is created (which is triggered by the Chrome TabCapture API), we trigger a device change event which will cause all currently active output streams to be recreated as VirtualAudioOutputStreams. These will attach to the virtual input stream when they start/resume playback.

When the VirtualAudioInputStream is to be released, it triggers another device change event to revert all the output streams back to output to sound hardware. The VirtualAudioOutputStreams must detach from the VirtualAudioInputStream when they are stopped, thus VirtualAudioInputStream must outlive all VirtualAudioOutputStreams.

BUG=153392

Review URL: https://chromiumcodereview.appspot.com/11298006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170892 0039d316-1c4b-4281-b951-d872f2087c98

This change causes shutdown crashes when chrome menu is used to exit.

> Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it.
> 
> This change prevents platform apps getting killed unceremoniously while they have background pages active.
> 
> This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.
> 
> This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots.
> 
> TBR=davemoore@chromium.org for the ash launcher test change.
> 
> BUG=155457
> TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.
> 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772
> 
> Review URL: https://chromiumcodereview.appspot.com/11117011

TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/11299326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170891 0039d316-1c4b-4281-b951-d872f2087c98

The EventHandler overriddes should mark the event as having been processed
(Event::SetHandled) when the event triggered an action, or stop the propagation
of the event (Event::StopPropagation) as appropriate (when the handler destroyed
the event-target, for example).

BUG=163618

Review URL: https://codereview.chromium.org/11280290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170890 0039d316-1c4b-4281-b951-d872f2087c98

Safe reference counting for skia objects ahoy!

R=jamesr
BUG=163454
Depends on: https://codereview.chromium.org/11418217/
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11412255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170889 0039d316-1c4b-4281-b951-d872f2087c98

- This CL changes the directory title for origins, from "chrome-extension://exampleextension" to "exampleextension"
- Also, drops file name escape.

BUG=163554

Review URL: https://codereview.chromium.org/11411280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170887 0039d316-1c4b-4281-b951-d872f2087c98