GitLab

* Cleanup test-only includes.
* Move some logic from panels into panel strip.
* Split DragPanels test into three tests.
* SetExpansionState on panel to move in/out of overflow.
* Added API to panel/native_panel to control whether app icon is visible.

BUG=106227
TEST=Panel*Test.*


Review URL: http://codereview.chromium.org/8827011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113691 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7363: (sehr) Expose LLVM changes to get __builtin_nacl_target_arch intrinsic.
r7364: (pdox) Build GLibC's crt1 as bitcode.
r7365: (mseaborn) Scons: Remove the unused argument 'nocpp'
r7366: (pdox) Get rid of upload to "latest" directory for PNaCl toolchain builders.
r7367: (pdox) Merge with LLVM up to r145883. Merge was trivial except for conflicts caused by adjacent code changes.
r7368: (eugenis) Move ncval usage text to its own variable.
r7369: (eugenis) Change -fasan to -faddress-sanitizer. Add a sanity test.
r7370: (eugenis) Switch ASan bots to opt-host.
r7371: (eugenis) Disable x86_64 hello_world_test on the Mac/ASan bot.
r7372: (eugenis) Really disable x86_64 hello_world_test on the Mac/ASan bot.
r7373: (robertm) Augmented pnacl-as to handle .S files, so we can remove .s/.S support from pnacl-clang.
r7374: (mseaborn) x86-64 Windows: Make stack unwinding test stricter still
r7375: (mseaborn) Revert r7374: x86-64 Windows: Make stack unwinding test stricter still
r7376: (ncbray) Stop using ppapi_ppb_core inside of PyAuto.
r7377: (dschuff) Script to parse LLVM testsuite report output and list of known failures,
r7378: (dschuff) Script and gclient DEPS to sync and run llvm testsuite with pnacl/sel_ldr
r7379: (sehr) Add --pnacl-default-command-line flag to the driver.  This flag controls
r7380: (mseaborn) Scons: Use booleans in CommandTest() arguments where possible
r7381: (mseaborn) Convert some crash tests to using command_tester.py's --declares_exit_status
r7382: (robertm) Assimilate the names "between_builders" files between regular and trybots.
r7383: (sehr) Add a DescWrapper factory method for random number generation.
r7384: (dschuff) Buildbot script for running LLVM test-suite and torture tests,
r7385: (sehr) Update to get default command line toolchain for sandboxed translators.
r7387: (robertm) Modify ARM .S code so it can be processed by both gnu-as and llvm-mc.
r7388: (dschuff) Fix bootstrap loading for toolchain torture tests

BUG=none
TEST=nacl_integration


Review URL: http://codereview.chromium.org/8879027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8890046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113689 0039d316-1c4b-4281-b951-d872f2087c98

Move GpuInfoUpdate to UI thread to avoid potential racing.

BUG=104768
TEST=ExtensionWebstorePrivateBundleTest.GetWebGLStatus
Review URL: http://codereview.chromium.org/8772031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113688 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8890027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113687 0039d316-1c4b-4281-b951-d872f2087c98

renderer. This patch is the chromium side change associated with this patch:
https://bugs.webkit.org/show_bug.cgi?id=70556

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/8888005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106912
TBR=jar@chromium.org

Review URL: http://codereview.chromium.org/8872042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=ui_tests, --gtest_filter=PPAPITest.Fullscreen

Review URL: http://codereview.chromium.org/8789005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113684 0039d316-1c4b-4281-b951-d872f2087c98

WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.

I reverted first attempt as it broke some browser_tests. I've
straightened that out in another patch, so this should be good go
again. TBR since it's the same patch as before.

BUG=104360
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8889022

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8873037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106805
TEST=Follow repro steps

Review URL: http://codereview.chromium.org/8888001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113680 0039d316-1c4b-4281-b951-d872f2087c98

Make check for 'opened' consistent across all audio stream implementations of Start() and log an error if open hasn't been called successfully.
This fixes

BUG=106712
TEST=Run media_unittests.

Review URL: http://codereview.chromium.org/8872028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113679 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a bunch of |reinterpret_cast|s (to |static_cast|).

So we can stop cutting-and-pasting the same mistakes over and over.


Review URL: http://codereview.chromium.org/8879009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113678 0039d316-1c4b-4281-b951-d872f2087c98

This is because, if the newly allocated surface happens to have the same handle / address, a subsequent MakeCurrent will think that the surface has not changed and early out.
Review URL: http://codereview.chromium.org/8869007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113677 0039d316-1c4b-4281-b951-d872f2087c98

WebGraphicsContext3D depending upon which compositor we're
running. This is needed to enable ui tests on the bots.

I reverted first attempt as it broke some browser_tests. I've
straightened that out in another patch, so this should be good go
again. TBR since it's the same patch as before.

BUG=104360
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8889022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100777
TBR=thestig@chromium.org

Review URL: http://codereview.chromium.org/8888029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113675 0039d316-1c4b-4281-b951-d872f2087c98

This updates the dependency to pick up
power_manager::kPowerButtonEventSignal.

BUG=98328
TEST=synced and built successfully
TBR=satorux@chromium.org

Review URL: http://codereview.chromium.org/8889028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88221
TBR=wtc@chromium.org

Review URL: http://codereview.chromium.org/8872039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113673 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8879024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113672 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8888022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113671 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113670 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113669 0039d316-1c4b-4281-b951-d872f2087c98

Inspection does not reveal any obvious paths that would lead to the crash in chromium-os:22577, so adding checks to help isolate the root cause.

BUG=chromium-os:22577
TEST=Run all tests, look for crashes with the signature described in the issue.


Review URL: http://codereview.chromium.org/8854007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113668 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't make sense to fix since it's just a private API.

BUG=54011

Review URL: http://codereview.chromium.org/8888018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104048
TEST=Edit menu item is available in Omnibox.


Review URL: http://codereview.chromium.org/8890029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23269
TEST=None

Review URL: http://codereview.chromium.org/8869001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113665 0039d316-1c4b-4281-b951-d872f2087c98

Fix for configs where the Chrome checkout is under user's home directory (in which case buffer-file-truename returns a path starting with ~).

BUG=none

Review URL: http://codereview.chromium.org/8872013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113664 0039d316-1c4b-4281-b951-d872f2087c98

1) Bug 106880: Creating more than 6 overflow panels or closing the 6th overflow panel triggers assert on debug version
2) Bug 106882: Hovering the mouse over the top of the overflow panels may expand the overflow panels

BUG=106880,106882
TEST=Manul test by following repro steps as in bugs

Review URL: http://codereview.chromium.org/8885019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113663 0039d316-1c4b-4281-b951-d872f2087c98

Fairly straightforward conversion except for two things:
- VisitedLinkMaster tries to be really clever and used StackVector. I converted
  it to use a plain old std::string since I don't think the cleverness adds
  anything.
- web_app::CreateShortcut() sole caller doesn't even use the success callback, so it was removed.

BUG=none
TEST=trybots

Do not submit. It's entirely possible we can just delete all the CreateShortcut
related goop in web_app.


Review URL: http://codereview.chromium.org/8885007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105023
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113634

Review URL: http://codereview.chromium.org/8887003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113661 0039d316-1c4b-4281-b951-d872f2087c98

This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy.

BUG=http://crbug.com/101154

Review URL: http://codereview.chromium.org/8764003

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8890037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8770024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113658 0039d316-1c4b-4281-b951-d872f2087c98

since /O2 implies /Oy

BUG=106711
TEST=examined All.vcproj and ./build/Release/obj/googleurl_unittests/BuildLog.htm and confirmed /Oy- is present


Review URL: http://codereview.chromium.org/8890023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113657 0039d316-1c4b-4281-b951-d872f2087c98

This splits apart the old in-process implementation into a new object in shared_impl that does most of the general tracking. This alllows that code to be shared by the proxy.

BUG=http://crbug.com/101154

Review URL: http://codereview.chromium.org/8764003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105335
TEST=Watch heapcheck for failures in BrowserMainTest.WarmConnectionFieldTrial_WarmestSocket


Review URL: http://codereview.chromium.org/8883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113654 0039d316-1c4b-4281-b951-d872f2087c98

It fails occasionally with:
One or more files could not be expanded. Delta Package Expander Returned 0x80070002
Expanding File ..\third_party\directxsdk\files\redist\jun2010_d3dx9_43_x86.cab Incomplete, Error Code=0x80070002
Error Description: The system cannot find the file specified.

NOTRY=true
TBR=sky@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8883029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/8859001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=bradnelson

Review URL: http://codereview.chromium.org/8888013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113651 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113645 0039d316-1c4b-4281-b951-d872f2087c98

Fix buffer overflow in _canonicalize.

Upstream bug is http://bugs.icu-project.org/trac/ticket/8984

The actual fix is at
 http://codereview.chromium.org/8822005

BUG=chromium:106441
TBR=falken
Review URL: http://codereview.chromium.org/8873031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113644 0039d316-1c4b-4281-b951-d872f2087c98

The UI behavior changes once HasSyncSetupCompleted() returns true, so we need to notify observers when we set this in OnBackendInitialized().

BUG=chromium-os:23151
TEST=See issue. Also make sure error clears correctly and is set correctly for other sync errors.

Review URL: http://codereview.chromium.org/8876001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113643 0039d316-1c4b-4281-b951-d872f2087c98