- 26 Mar, 2020 40 commits
-
-
nancy authored
Launch service will be integrated to AppService, and removed, so this CL is used to migrate ExtensionAppLaunchManager::LaunchApplication to extensions application_launch. Based on the design go/integrating-launch-service-to-app-service, add BrowserAppLauncher class to AppService to handle the launch requests, and forward to extensions application_launch or WebAppLaunchManager. LaunchService->LaunchApplication is replaced with AppServiceProxy's new interface LaunchAppWithCallback. Follow up: 1. Get command line from the current process in GetLaunchFilesFromCommandLine: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/apps/app_service/launch_utils.cc;l=87 Remove command_line from interfaces parameters, and remove command_line from AppLaunchParams: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/apps/app_service/app_launch_params.h;l=57 2. Move ExtensionAppLaunchManager's OpenApplication function to AppService BrowserAppLauncher and remove ExtensionAppLaunchManager. 3. Modify web_app::WebAppLaunchManager to remove the dependency on LaunchManager. 4. Remove LaunchManager. Note: We can't name AppService's BrowserAppLauncher to LaunchService based on design now, because launch_service/launch_service hasn't been removed yet, and they are both in apps namespace, so rename it to BrowserAppLauncher. BUG=1061843 Change-Id: If5a36a9fe6b8ea265ed198d52fdddab477fe58a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119344Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753830}
-
Yue Li authored
If the user disable the Assistant when the opt-in dialog is showing up, the dialog should be dismissed. Bug: b/152283171 Test: Manual Test Change-Id: Iecb9a309f839fd6dbbcb80e82597376658a2ce3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121036Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#753829}
-
Brian Sheedy authored
Adds a --bypass-skia-gold-functionality flag to skia_gold_integration_test_base.py which causes all tests to skip any actual interaction with Gold. This is meant to be used in the unlikely event that there's a Gold outage that can't be fixed quickly so that the outage does not block CLs, etc. Bug: 1057848 Change-Id: I2e5e8d0bfc956fd701cc329d4628755612a02e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123036 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753828}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf6b8d4a16ae..f2bee3043a5e git log bf6b8d4a16ae..f2bee3043a5e --date=short --first-parent --format='%ad %ae %s' 2020-03-26 cnorthrop@google.com Capture/Replay: Implement more GLES entrypoints 2020-03-26 cnorthrop@google.com Roll glslang and Vulkan validation layers Created with: gclient setdep -r src/third_party/angle@f2bee3043a5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I7d65fd01cc7bd52660b6b7ba430bd6fdfc96b179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/319db212..76649a7c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8db4e28702e60be2ef343d6955bc8bf9bff621a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122481Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753826}
-
Dave Tapuska authored
More tests that are passing consistently enabled. BUG=626703,746128,1011515 Change-Id: I983347845a18424435c78032018b41d17c9ae7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122918Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753825}
-
Brian Cui authored
This CL adds new metrics enums to accommodate the following DevTools CL for measuring Settings discoverability. https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2049183 Bug: 1050855 Change-Id: Id6489456269c4f39ee6e11c7d2afe1cdd4279d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055359Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753824}
-
Sasha McIntosh authored
Extend the lifetime of UMA Compositing.Display.Draw.Occlusion.Calculation.Time as we continue to make occlusion culling improvements. Bug: 1016875 Change-Id: Ic369dad5276cba8512ebd24ee0be2bf328c7863b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122808Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#753823}
-
Tina Wang authored
- add PasswordManagerEnabled entry to policy map - add unit test Change-Id: I7991646ccff8fe9cca7ee579140ed9bc31591d34 Bug: 1065143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119310 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753822}
-
Renjie Tang authored
Change-Id: I1f82aab5bf180adf0dc489b833689fabbf9a1749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122864Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753821}
-
Brian Osman authored
Less code and more consistent behavior. Change-Id: Ide942100529a90bb2a2be3dc5893c57043052721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122478Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#753820}
-
Darren Shen authored
When reporting JS errors through crashReportPrivate, we have to check user consent. However, checking user consent is blocking, so we have to run it in a separate thread. We reordered the checks a bit as well. The new ordering is better because the caller can't figure out if user consented simply by calling the API. Bug: 986178 Change-Id: I1ab62b3327544925030829f1bde164cd37dd6f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121521 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753819}
-
Jon Mann authored
This change refactors LocalNetworkCollector::GetSyncableNetwork to accept a network's GUID instead of NetworkIdentifier in order to keep logic related to local network lookups encapsulated in LocalNetworkCollector. Bug: 966270 Change-Id: I36946e0fbb1cfc85e972cf5169f1bf4555080f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107062 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#753818}
-
Sophey Dong authored
We are removing the Desktop OS notifications and instead displaying the sending animation that is present currently when self-sharing from the omnibar icon. Bug: 1007536 Change-Id: I44b47e24c14946d1c633ff69abfb07948f07d9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111775 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#753817}
-
dpapad authored
Bug: 1008122 Fixed: 1063739, 1064966, 1013656, 1031960, 1063723, 929288 Change-Id: I570b26be4acba3d73dc9e181ed1349efb35ef9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122458Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753816}
-
Tommy C. Li authored
To support the secondary buttons focusing, unfocusing, and triggering via keyboard, the OmniboxViewViews calls into OmniboxResultView via OmniboxPopupContentsView. In retrospect, this was a mistake, to have one View invasively start poking into the internal state of another. We should have had both Views interact only with OmniboxPopupModel, which is where orinj's refactor is going. This is leading to some Windows-only crashes, I'm guessing because Windows has some platform-specific window manager logic that's unexpectedly closing the popup - although I am not sure. This is a somewhat speculative fix. Were it not for COVID, I would be diving into the minidumps using Visual Studio and I would have a more informed opinion of what's going on. The ultimate solution though, is orinj's OmniboxPopupModel refactor. Bug: 1063071 Change-Id: I33c916b86c3a7e0fbf2d3edff5732eeb4936124c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122907 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#753815}
-
Tommy Nyquist authored
This was previously disabled only on KitKat, but it's flaky across all bots, so disabling for everything. TBR=gayane@chromium.org Bug: 1056059 Change-Id: I211a25918803b835fc42c6e3da0be778ccf6b53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122923Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753814}
-
Etienne Bergeron authored
Adding standard trace events to help investigating net::disk_cache from the field using slow-reports. R=morlovich@chromium.org, gab@chromium.org Bug: 1065004 Change-Id: I0e2d2a87cc8071ae722ee163d7591d002c93caaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122390 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#753813}
-
Reilly Grant authored
This reverts commit bfbbd2f9. Reason for revert: The Windows OS bug was fixed in 19H1 and a change has been landed to limit use of the new API to this version and later. Original change's description: > [sensors] Disable new WinRT sensor backend > > The new backend is tickling a Windows OS bug that causes the browser > process to crash. It can be re-enabled in the future for Windows > versions containing the fix. > > Bug: 1063124 > Change-Id: I2f054cf6bfe548bdbf7031640172068b2e3e0e1c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121046 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#753375} TBR=rockot@google.com,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1063124 Change-Id: I1b540155bcdbc92891d81424a8223ec5e012e650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122829Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753812}
-
Peter Kasting authored
This is in preparation for making AshTestHelper an AuraTestHelper subclass. The primary purpose here is to move the parts of setup/ teardown that will be handled by the AuraTestHelper to the start/end of the ash setup/teardown phases, respectively, so that moving them into AuraTestHelper will not change the relative order of anything. The secondary purpose, subject to the above, is to better group related functionality and add a few comments about ordering requirements. I didn't aim for perfection, just something better. This is split into its own CL since reordering setup/teardown is risky; there are many implicit dependencies. There are some trivial changes: * Removed a null-check of the cursor manager that was only needed for MASH. * Explicitly reset all unique_ptrs during TearDown() rather than waiting until destruction for a few. * Removed CHECK(!::wm::CaptureController::Get()) during teardown; it's not clear to me why we CHECK this but none of the other many bits of state destruction on teardown. Otherwise, should be no functional change. Bug: none Change-Id: Ief088e58606b83e127e93daad0a60f90601b9866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121085 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#753811}
-
Tommy Nyquist authored
This reverts commit d5c71f24. Reason for revert: Multiple tests failing in: AwContentsClientFullScreenTest. See bug for details, but this is the blame range: https://chromium.googlesource.com/chromium/src/+log/d4bdcae63a031f35db804aaf0b5dc61848be0d6e..a3e8b15392454293e2556669b6c093e63e8e2316 Original change's description: > aw: Force FullScreenView resize > > Follow up to r654240 > > Apparently on apps that does not end up resizing the FullScreenView from > the WebView, avoiding a resize cause odd problems such as FullScreenView > not getting forwarded key events or not being on top of other views as > it should be. Instead set the initial height to be arbitrarily 5 pixels > less in height. This avoids affecting the compositing pipeline > significantly, since height changes generally has small effects on > layout. > > Bug: 1054286 > Change-Id: Ia5bbb384a75736784e660567dd7e36bacbc4b5b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119802 > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753588} TBR=boliu@chromium.org,tobiasjs@chromium.org Change-Id: Ia2dd90baf3ae1dfd6bb045b914ea51a26b8863fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122818Reviewed-by:
-
dpapad authored
Bug: 1000989 Change-Id: I4101732133391b0b1aece1763201f2fa837100b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117300 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Adds a new "additional_search_terms" property to WebApp and uses it for System Web Apps. Bookmark Apps don't have this property but the AppService queries SystemWebAppManager directly to retrieve additional search terms for System Web Apps. Bug: 1054195 Change-Id: Ie0a884bca734e82702083ee21862c1e57f22f8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116159Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#753808}
-
Lily Chen authored
TBR=jschuh@chromium.org Bug: 953306 Change-Id: I5bde61d8ff66261ade4e68caadafda73c522df00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122809Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#753807}
-
Rune Lillesveen authored
A FirstLetterPseudoElement is marked for style recalc when the text node the first letter belongs to is removed from the DOM tree. On the next style recalc, if the first-letter's originating element is inside a subtree marked for layout tree re-attachment, or one of its descendants are marked for re-attachment, we delay the first-letter style update until UpdateFirstLetterPseudoElement is called for the kRebuildLayoutTree or kAttachLayoutTree phases. For the former, we call RecalcStyle which will ClearNeedsStyleRecalc, but ofr the kAttachLayoutTree phase, we called StyleForLayoutObject without clearing the dirty flag. Bug: 1064595 Change-Id: Ibebb9c358b473f61b1cff49a7c5ec43bf6894408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122347Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753806}
-
Yuri Wiitala authored
miu@ will be going on a personal leave for 2020Q2. This adds mfoltz@ to relevant Screen Capture, Mirroring UX, and Cast Streaming OWNERS files to ensure a stakeholder with long-term background knowledge is available for code review. Change-Id: I62b9ae7cfd278f320b566c919408a3456f2a67a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122915 Auto-Submit: Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dca61aa30a9..97094993b251 Created with: gclient setdep -r src-internal@97094993b251 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053589,chromium:1056962,chromium:896775 Tbr: jbudorick@google.com Change-Id: Iaff14c7e85a8b632e2eb4dc4ad32467afd06e4a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122868Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753804}
-
Tommy Nyquist authored
Disable on Android since the test is very flaky, particularly on android-marshmallow-arm64-rel bot. Bug: 1016118 Change-Id: Ie8f1a90a1c26fdc008746a19ef6337ee62661188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122866 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#753803}
-
Brian Sheedy authored
Adds a --bypass-skia-gold-functionality flag to //build/android/test_runner.py which causes all tests that use Skia Gold to skip any actual interactions with Gold. This is meant to be used in the unlikely event that there's a Gold outage that can't be fixed quickly so that the outage does not block CLs, etc. Bug: 1057848 Change-Id: If34b2b8a86fd8a5020d2f5fbc8fc823e66186ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122859Reviewed-by:
-
Ben Pastene authored
Bug: 812428 Change-Id: If8f5473d965ad4cbe07c4bdf46f80458d9473918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110513Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#753801}
-
Javier Ernesto Flores Robles authored
Bug: 1045456 Change-Id: Ibf91aff0fef477255751a689692be281d098ceba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119530 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753800}
-
Xianzhu Wang authored
In CompositeAfterPaint, though backface-visibility:hidden doesn't directly cause compositing, it's very likely that we'll composite the element (when we find its backface-visibility is different from the previous paint chunk), and it indicates preference of compositing, so it's mostly beneficial to prepare for compositing in paint properties: - by creating PaintOffsetTranslation to avoid raster invalidation on paint offset change; - by preferring composited scrolling. Change-Id: I57a59d17a3e864416c479d788291f3a201644c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121355Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753799}
-
Vladislav Kuzkokov authored
Bug: 1060700 Change-Id: Icb823ccdb4cac17e4a6ee7a5885d59e4722a7b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098662 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753798}
-
Devlin Cronin authored
Extensions used to be able to override the bookmark star view in order to provide a custom bookmark manager (this was used for the Stars extension). The extension has been deprecated and removed, and the API never launched. Clean up the remnants. Remove the logic for the StarView being hidden if there's an overriding extension installed. Bug: 894447 Change-Id: I57381c688ddacac747391a9af432e8375e16ca83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119387Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753797}
-
Thiemo Nagel authored
Bug: none Change-Id: I016a3d1f1c16778c82e026953a34d140f712966f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122530 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753796}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4085.6-1584959535-benchmark-82.0.4085.16-r1 to 83-4085.6-1584959535-benchmark-83.0.4091.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9021f73f7f8596ef3daf3123b28240d9a0d90a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122512Reviewed-by:
-
Devlin Cronin authored
Extensions used to be able to override the bookmark star view in order to provide a custom bookmark manager (this was used for the Stars extension). The extension has been deprecated and removed, and the API never launched. Cleaning up the remnants. Remove the logic to hide the default bookmarks commands conditionally if an overriding extension is installed. Bug: 894447 Change-Id: Iddbdb96171fb567ee9adf06390cfa4668996d58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119805 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753794}
-
Ahmed Mehfooz authored
Bug: 1065079 Change-Id: I0646096217a8cdef1715061cb0b60f440c4a6240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122862Reviewed-by:
-
Tommy Nyquist authored
The test has recently been very flaky across many Android bots. TBR=sahel@chromium.org Bug: 825629 Change-Id: I64bac3833f92da55bae524af11ac1ce39b10c594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122748 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d25ae4048565..ba15ec2dc8ee git log d25ae4048565..ba15ec2dc8ee --date=short --first-parent --format='%ad %ae %s' 2020-03-26 tmathmeyer@chromium.org Clean up stale code 2020-03-26 aerotwist@chromium.org [e2e] drop to one job Created with: gclient setdep -r src/third_party/devtools-frontend/src@ba15ec2dc8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f4988ffd60859ce4515e92251da768efbe1e705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122731Reviewed-by:
-
