GitLab

R=rmistry@google.com

Review URL: https://codereview.chromium.org/22331002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215877 0039d316-1c4b-4281-b951-d872f2087c98

This change adds another optional parameter 'overdraw' to the rasterize
method of the skia benchmarking extension. When set to true an image
with pixel overdraw visualized as heat map is returned.

BUG=268342

Review URL: https://chromiumcodereview.appspot.com/22202003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165

Review URL: https://chromiumcodereview.appspot.com/22369003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215875 0039d316-1c4b-4281-b951-d872f2087c98

    
    1. Add the switch "target_fps" to control the playing speed.
       This is used to measure the frame drop rate and CPU usage.
    
    2. Also add a switch "disable_rendering" to disable rendering.
       This is used to measure just the decoding part.
    
    On parrot, using test video: "test-25fps.h264" with target FPS: 60, the CPU
    rate is about 12% and no dropped was frames.
    
    With target FPS as 300, the CPU rate goes to 47.34% and 4/250 frames are
    dropped.
    
    BUG=250718
    TEST=run the unittest on link and parrot

Review URL: https://chromiumcodereview.appspot.com/19151002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215874 0039d316-1c4b-4281-b951-d872f2087c98

Also remove the conditional loading of certificates, which prevents tests including CertLoader.

BUG=NONE
R=stevenjb@chromium.org
TBR=xiyuan@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214351

Review URL: https://chromiumcodereview.appspot.com/20799002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215873 0039d316-1c4b-4281-b951-d872f2087c98

(They should be eventually moved into content/public/test
rather than duplicated in two gypi files)

BUG=265769
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/22180002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=257349
TEST=no behavioral change yet

Review URL: https://chromiumcodereview.appspot.com/22363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215871 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215869 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22378002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215868 0039d316-1c4b-4281-b951-d872f2087c98

This CL extracts copy operation related to Drive from processCopyEntry_ to
an utility method copyFileOnDrive.

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/22373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215867 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267004

Review URL: https://chromiumcodereview.appspot.com/22145004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/21910007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215864 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting
BUG=

Review URL: https://chromiumcodereview.appspot.com/22372002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215863 0039d316-1c4b-4281-b951-d872f2087c98

Delete old MetadataDatabase code before replacing major part of them.

BUG=240165

Review URL: https://chromiumcodereview.appspot.com/22341005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215862 0039d316-1c4b-4281-b951-d872f2087c98

SetModel is only ever used for initialization. Moving the functionality
into the constructor allows for easier reasoning about the state of the
View.

This change is in preparation of the refactor in
https://codereview.chromium.org/20656002/.

Review URL: https://chromiumcodereview.appspot.com/22354002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215861 0039d316-1c4b-4281-b951-d872f2087c98

Move NonClientHitTest to BubbleDelegateTest.
Inline TestBubbleDelegateView function definitions.
Add CreateTestWidget helper for anchors/parents/etc.
Remove unnecessary Show and RunPendingMessages calls.
Enable InitiallyFocusedView, it works fine as-is.
(TestBubbleVisibilityAndClose already tests the same)
Other misc. cleanup.

BUG=NONE
TEST=NONE
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22320003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22312004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215859 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the UMA "Net.PreconnectTriggerUsed", and add the UMA "Net.PreconnectedLinkNavigation". 

PredictorTabHelper collects requests information for user link navigation. This information is sent to class Predictor::PreconnectUsage to see if the navigation has possibly used a preconnect session from {mouse,touch}-event triggers.

The UMA "Net.PreconnectTriggerUsed" records whether if a preconnect trigger is followed by a resource request (from link navigations) to the host or not. This is to measure precision of link-based preconnect triggers.

The UMA "Net.PreconnectedLinkNavigation" records whether if a resource request from link navigations is preceded by a preconnect trigger. This is to measure recall of link-based preconnect triggers.

BUG=235361

Review URL: https://chromiumcodereview.appspot.com/16514008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215858 0039d316-1c4b-4281-b951-d872f2087c98

This flag has been meaningful on Mac as of r213834.

BUG=268789

Review URL: https://chromiumcodereview.appspot.com/22365002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215857 0039d316-1c4b-4281-b951-d872f2087c98

The data in chrome.storage.local had been used but is now no longer used. This patch adds the code to remove them, in order to save the limited user storage.

BUG=268784
TEST=Files.app launches without error in console.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22361002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268812
TEST=Files.app runs without error. All tests pass.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22382002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215855 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces fileOperationUtil namespace and move/extracts some helper
methods from FileCopyManager to it.
This is preparation to move copyTo helper to it, so that moving the copyTo
from js-side to c++-side should be simpler task. The moving copyTo will be done
in following CLs.

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/22291004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215854 0039d316-1c4b-4281-b951-d872f2087c98

I've just checked and found it's unnecessary. Touching comes with click events?

BUG=none
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22384002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/21205007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215852 0039d316-1c4b-4281-b951-d872f2087c98

The Drive file operations are on the blocking pool (not the FILE thread)
so the current fan-in is racy if multiple Drive files are selected.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22336003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215851 0039d316-1c4b-4281-b951-d872f2087c98

Due to flakiness, disabling this test.

BUG=86562
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/22347002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/22325002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215849 0039d316-1c4b-4281-b951-d872f2087c98

Justification: the keyboard shortcuts are already allowed when
--ash-debug-shortcuts is specified.

BUG=None
R=derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22324002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/22306002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215847 0039d316-1c4b-4281-b951-d872f2087c98

This allows RWHVA::CopyFromCompositingSurfaceToVideoFrame to work when the CopyOutputResult contains a bitmap, which happens with the software renderer.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22284006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215846 0039d316-1c4b-4281-b951-d872f2087c98

For consistency with other member functions ReorderChildren now takes
const BookmarkNode pointers.

BUG=126092

Review URL: https://chromiumcodereview.appspot.com/20521005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215845 0039d316-1c4b-4281-b951-d872f2087c98

Previously, there was a single synchronous IPC that would
check if PNaCl is installed, then install if not installed,
as well as open the individual files read-only.

That sync IPC would block the UI if it needed to install PNaCl.

Instead separate checking from the opening a file read-only.
Have a separate IPC that is async, so that the UI is
not blocked, and progress events could eventually be sent.
Some basic plumbing of progress events is set up, but not
yet wired up to JS.

Order of events is:

CheckInstalled
* if Installed, reply w/ success
* if not Installed {
    send progress event indicated install start
    try install
    (may send more progress events)
    send progress of install success or failure
  }


BUG=252760
TEST=unit_tests --gtest_filter=NaClFileHostTest*  (and manual)

Review URL: https://chromiumcodereview.appspot.com/19863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215844 0039d316-1c4b-4281-b951-d872f2087c98

Related review: https://codereview.chromium.org/19281007/

BUG=260644

Review URL: https://chromiumcodereview.appspot.com/19256012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215843 0039d316-1c4b-4281-b951-d872f2087c98

Some of existing IPCs and methods for Blob are renamed for readability.

Note
- raw data sending code in webblobregistry_impl.cc are duplicated intentionally
not to bother michaeln's refactoring

Bonus: Stopped over-optimization of sharing webkit_blob::BlobData::Item instances in webblobregistry_impl.cc

BUG=169957

Review URL: https://chromiumcodereview.appspot.com/15817013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215842 0039d316-1c4b-4281-b951-d872f2087c98

If thumbnail_db_ Init() fails, then reset() is called, so later calls
need to be checked.

BUG=242636
TEST=Chrome stops crashing in the field.

Review URL: https://chromiumcodereview.appspot.com/22305002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215837 0039d316-1c4b-4281-b951-d872f2087c98

navigation is started.

We don't replace browser-initiated pending entries in didStartProvisionalLoad
because either (1) they were just created for this navigation and are already
correct, (2) they're for a different SiteInstance and won't be used upon
commit, or (3) they're same-site (see below).

Note that pending entries for same-site browser-initiated navigations can be
incorrectly used for renderer-initiated navigations that interrupt them, but
that's a long standing bug that we can address separately.

BUG=266922
TEST=See bug for repro steps.

Review URL: https://chromiumcodereview.appspot.com/21913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259492
TBR=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215835 0039d316-1c4b-4281-b951-d872f2087c98

The code was incorrectly using the title as the message for the MessageBox.

BUG=none
TEST=Navigate to about:inducebrowsercrashforrealz and make sure the message
box looks correct.

Review URL: https://chromiumcodereview.appspot.com/22288003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215834 0039d316-1c4b-4281-b951-d872f2087c98

Because variable which has type in the included file becomes pointer.
This change is rest of following:
https://src.chromium.org/viewvc/chrome?view=rev&revision=215590

Review URL: https://chromiumcodereview.appspot.com/22299004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215833 0039d316-1c4b-4281-b951-d872f2087c98