GitLab

The file chrome/test/data/extensions/api_test/gcd_private/api/trun is unneeded.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/342493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277872 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of https://codereview.chromium.org/332003002

BUG=144491

Review URL: https://codereview.chromium.org/340543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277871 0039d316-1c4b-4281-b951-d872f2087c98

Fixes regression introduced by r276036 that removed the title from
the notification center on ChromeOS.

BUG=350449

Review URL: https://codereview.chromium.org/335413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385701
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/336423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277869 0039d316-1c4b-4281-b951-d872f2087c98

Check the preferences thaht can be controlled by other users.
Also look for the secondary user banner, and controlled-by
indicators in headings.

BUG=359578
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/322293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384514
NOTRY=true

Review URL: https://codereview.chromium.org/340523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277867 0039d316-1c4b-4281-b951-d872f2087c98

The picker window is embedded in the parent window and does not have its own native window.

TESTED=verified on Linux, Win and ChromeOS that the picker window is not listed to share with or without a delegate tab, and the chrome window is correctly listed.

BUG=384370

Review URL: https://codereview.chromium.org/338503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384010
TEST=new tests added

Review URL: https://codereview.chromium.org/335693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277865 0039d316-1c4b-4281-b951-d872f2087c98

The params is used for ServiceRuntime::StartSelLdr(). ServiceRuntime
already knows if it is for nonsfi or not. So the use_nonsfi_mode in
SelLdrStartParams is just redundant. Remove it.

BUG=333950
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/332333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277864 0039d316-1c4b-4281-b951-d872f2087c98

The new method RemoveLoginsSyncedBetween() works exactly like the existing RemoveLoginsCreatedBetween(). 

BUG=362679
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/335893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277863 0039d316-1c4b-4281-b951-d872f2087c98

Called from android logging macro used in mesa.

BUG=358029

Review URL: https://codereview.chromium.org/321353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/338933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277861 0039d316-1c4b-4281-b951-d872f2087c98

Improve documentation for Reset and Flush.
Use VpxVideoDecoder in implementation code.

BUG=281689

Review URL: https://codereview.chromium.org/336833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277860 0039d316-1c4b-4281-b951-d872f2087c98

This flag will be controlled via enterprise policy to reenable the
deprecated window.showModalDialog API to extend the time window for
porting apps to other APIs.

The flag will eventually be removed as well.

BUG=345831
R=atwilson@chromium.org

Review URL: https://codereview.chromium.org/334173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277858 0039d316-1c4b-4281-b951-d872f2087c98

Metro's avatar button is no-op w/--new-profile-management.
This may have regressed with r270126, but I'm not sure how.

IsNewAvatarMenu returns true in metro (r263677, r263396).
However, GetNewAvatarMenuButton returns NULL in metro.
(the new button isn't implemented for that frame, afaict)
So ShowAvatarBubbleFromAvatarButton currently does nothing.
Instead, anchor to the avatar menu button or app menu.

Remove the unused |anchor_rect| parameter.

BUG=382895
R=noms@chromium.org,sky@chromium.org
TEST=Avatar button works in Windows 8 mode (metro) with .

Review URL: https://codereview.chromium.org/333353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277857 0039d316-1c4b-4281-b951-d872f2087c98

We currently set a technology to 'enabling' even if it is not available.
We also enable / disable both Cellular and Wimax on the same UI element
since both are never expected to be available.
Simple fix is to ignore technologies that are not available.

BUG=368754

Review URL: https://codereview.chromium.org/336313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277856 0039d316-1c4b-4281-b951-d872f2087c98

Implement iaccessible and isimpledom

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/330413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277855 0039d316-1c4b-4281-b951-d872f2087c98

KeyboardControllerProxy::GetKeyboardWindow() can create the keyboard window if
it's not already created. So during hit-testing, use HasKeyboardWindow() to
first determine if the window exists, before using GetKeyboardWindow().

BUG=380215
R=kevers@chromium.org

Review URL: https://codereview.chromium.org/341573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277854 0039d316-1c4b-4281-b951-d872f2087c98

The rand_util_nacl.cc will be used inside the IRT and outside the IRT.  So we need to use nacl_secure_random() which will work for both.

BUG=nativeclient:3881

Review URL: https://codereview.chromium.org/334353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384729
R=gab@chromium.org, mattm@chromium.org

Review URL: https://codereview.chromium.org/332053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277852 0039d316-1c4b-4281-b951-d872f2087c98

It seems that the logic from the downstream file is different from the
CL that upstreamed it. This CL restores the downstream logic.

Consider this case:

 type == TabLaunchType.FROM_LONGPRESS_BACKGROUND: FALSE
 type == TabLaunchType.FROM_RESTORE: TRUE
 mTabModelSelector.isIncognitoSelected(): FALSE
 isNewTabIncognito: TRUE

In the downstream version willOpenInForeground -> TRUE
In the current version willOpenInForeground -> FALSE which
incorrectlys restores the incognito tab even thought it isn't
the current tab model.

BUG=383470

Review URL: https://codereview.chromium.org/338833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277851 0039d316-1c4b-4281-b951-d872f2087c98

We picked the name "source_prereqs" to try to emphasize that these are source
(compile-time) dependencies rather than data or link-time dependencies.
However, now that all actions are implicit hard deps, the use-case of using
this for binary targets is almost nonexistant (I want to eventually put back
actions-as-soft-deps but this requires some additional checking to make sure
people don't mess up, at which time this may becomre more relevant.)

source_prereqs is hard to type and difficult to understand. Inputs is much more
clear, especially since the typical case is an action.

This will fall back to reading "source_prereqs" for back-compat until we change
all users.

Significantly enhance the "gn desc" command. A bunch of action-related fields
were missing.

BUG=374271
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/333243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382564

Review URL: https://codereview.chromium.org/320323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277849 0039d316-1c4b-4281-b951-d872f2087c98

1. Fix SendTo() result handler for UDP sockets to properly handle errors
   we may get. It wasn't possible in the past because pepper sockets
   were not returning correct error codes. Now they do.
2. Don't try binding to link-local IPv6 addresses because it always
   fails due to crbug.com/384854 .

BUG=382697
R=wez@chromium.org

Review URL: https://codereview.chromium.org/336113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277848 0039d316-1c4b-4281-b951-d872f2087c98

Clearer this way, especially since a deletion may entail a hierarchy
change.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/331243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277847 0039d316-1c4b-4281-b951-d872f2087c98

(Per review comment from https://codereview.chromium.org/330933004/.)

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/339923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277846 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/317203004,
background_contents_service.cc doesn't need the command line switch
related headers anymore. So we can remove these.

BUG=350898

Review URL: https://codereview.chromium.org/338083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277845 0039d316-1c4b-4281-b951-d872f2087c98

Locally, this reduces the time the suite takes from ~15 seconds to ~5 seconds.

BUG=384314

Review URL: https://codereview.chromium.org/333893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277844 0039d316-1c4b-4281-b951-d872f2087c98

This is a straight upstream from Blink's IDL parser, which will allow
us to drop some overrides there, which in turn will allow us to update
this parser to use the grammar of current Web IDL, where static
attributes are supported differently (via a StaticMember production
that handles both static attributes and static methods.)

Preparation for:
IDL parser: drop AttributeOrOperation and StaticAttribute overrides
https://codereview.chromium.org/336733002/ (in Blink)

...and ultimately for:
IDL parser: align with current Web IDL specification
https://codereview.chromium.org/329853005/

BUG=

Review URL: https://codereview.chromium.org/333853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277843 0039d316-1c4b-4281-b951-d872f2087c98

Adding one more very tiny Android file here means fewer changes needed to
compile other files borrowed from Android or Android-x86.

BUG=358029

Review URL: https://codereview.chromium.org/331793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277842 0039d316-1c4b-4281-b951-d872f2087c98

Now, clicking the app item just emits onLaunched event, and the
app will create an app window on the event handler. The API handler
creates a ShellAppWindow for app_shell, but it should create
an activity on athena.

BUG=380421
R=jamescook@chromium.org, oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/335003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277841 0039d316-1c4b-4281-b951-d872f2087c98

SyncMessageFilter::Send() returns false immediately, if the IPC connection
is not yet established. As connecting is done asynchronously, there is
no guarantee that the connection is established on the first Send() invocation.
By this CL, Send() blocks the caller thread if the connection is not yet
established.
Note that currently the ratio should be probably low, because there are some
more initialization steps between the ManifestService creation and the first
Send() invocation. We're switching to changing the initialization procedure,
and then this race would be hit more easily.

TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots. Also, locally modified the code to delay OnFilterAdded with and without this CL, and made sure this CL works well.
BUG=333950
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/334593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277840 0039d316-1c4b-4281-b951-d872f2087c98

Extend and use android_profiling_helper.py to set up a symfs for VTune.
Queries the required libraries from the profiler's output and pulls them from
the device. This allows VTune to resolve all symbols in the profiling output.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276740

Review URL: https://codereview.chromium.org/308123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277839 0039d316-1c4b-4281-b951-d872f2087c98

> Refactor tool-bar event handlers.
> 
> The tool-bar is being phased out as part of the apps v2 work, but as
> part of the transition, the functionality it provides needs to be shared
> between it and the window frame. Step one is to disentangle some of the
> event handling code from client_session.js and toolbar.js.
> 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/336293003

TBR=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/336423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277838 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder (https://codereview.chromium.org/320383004/)

Reason for revert:
This was landed despite an explicit "not lgtm"

Original issue's description:
> Pick a fixed Clang revision for Windows now that we have an LKGR ASan builder
> This way, the LKGR builder and the developers who want to try ASan (or just Clang) on Windows won't get a broken Clang revision.
> 
> The FYI bots got LLVM_WIN_REVISION=HEAD in r276301 so won't be affected.
> 
> BUG=82385,345874
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276366

TBR=hans@chromium.org,rnk@chromium.org,timurrrr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385,345874

Review URL: https://codereview.chromium.org/342533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277837 0039d316-1c4b-4281-b951-d872f2087c98

This is the audio part of r277270.

When Decode(EOS) is called on DecryptingAudioDecoder, the decoder should keep
flushing the decryptor with EOS input until NeedMoreData() is returned. Then the
decoder can return the DecodeCB.

BUG=338529
TEST=Fix unittest to cover this case.

Review URL: https://codereview.chromium.org/332253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127016
TBR=rkc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276656

Review URL: https://codereview.chromium.org/273533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277835 0039d316-1c4b-4281-b951-d872f2087c98

The fix is in Blink r176323, and the blink roll just went past that.

BUG=385386
NOTRY=true
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/333273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383153

Review URL: https://codereview.chromium.org/335243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277833 0039d316-1c4b-4281-b951-d872f2087c98

Adds BIONIC to the manifest.  This is a precursor to automated updates for bionic.

This change only affects the SDK updater and the automated JSON generator, and is not visible to chrome.

R=binji@chromium.org
BUG=344574
NOTRY=true
TEST=naclsdk update -U

Review URL: https://codereview.chromium.org/339933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277832 0039d316-1c4b-4281-b951-d872f2087c98