- 30 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4314.0-1605523684-benchmark-88.0.4324.12-r1 to 89-4324.9-1606128713-benchmark-89.0.4335.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4c5f3d84d767e06be1655c861ee305059c2b32a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565398Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832018}
-
Moe Ahmadi authored
Settings the line-height CSS property can result in unappealing outcomes such as characters appearing chopped off. By default, line-height is calculated based on the font size, font family and other factors such as presence of italic text etc. This CL eliminates uses of line-height in the realbox in order to better support larger minimum font sizes. The following are screenshots of the realbox with "tiny" (default) and "huge" (maximum) minimum font sizes. before (tiny): screenshot/6GZeMfLZEejVEG7 before (huge): screenshot/A8nt8ynzpG4yeKF after (tiny): screenshot/BNyDMfRYbuum8AK after (huge): screenshot/9TdmkQoswconjv4 Fixed: 1145840, 1051865 Change-Id: Ia24c8f44cf9f97ed6345c7f0064178dde525b3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561580Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832017}
-
Robert Kroeger authored
Mac Nvidia Retina is failing consistently on s3tc-and-rgtc.html. Suppress the test failure. Bug: 1153689 Change-Id: Idd1e491643ccdf37980655dc62a9e53acf44059f TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565731Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#832016}
-
Piotr Bialecki authored
Removes plane detection state, world tracking state and world information since the general approach of the APIs that we are adding seems to just add additional entries to XRFrame / XRSession directly, w/o the layer of indirection. The spec also contains a mechanism of detecting whether a feature has been enabled through integration with permissions API - this makes the tracking states unnecessary, since they were only needed to communicate exactly that. Change-Id: I36298b05019f87f0de47c992fc29fef987e6e192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540575 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#832015}
-
Aaron Krajeski authored
I lost a few hours to this when changing a signature and having no idea what was going on: https://chromium-review.googlesource.com/c/chromium/src/+/2564189 I guess they're against the style guide for a reason! Bug: 1140535 Change-Id: I79b534db6b1752b73689cb032aaa24a0e326ac38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564817Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832014}
-
Jason D. Clinton authored
These were reviewed by senior engineers across the project on https://docs.google.com/document/d/1EZNCv9szJzY6ADyj_WojT9iRB6JJUY9aGc6cNiGnvCo/edit Change-Id: I8a839ec93403b3b7fe7bad7ed17bb440e7cb980a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556450Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jason Clinton <jclinton@chromium.org> Cr-Commit-Position: refs/heads/master@{#832013}
-
Tom Sepez authored
Bug: chromium:1129358 Change-Id: Iee01b1df931cd5dcf63cf378ac504d68ea4cbf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565736Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#832012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4492956adde..25c0c4f6128c 2020-11-30 szuend@chromium.org [cleanup] Remove casts that are no longer needed 2020-11-30 michael.liao@microsoft.com [Sources- Accessibility]: Fix keyboard navigation for breakpoint sidebar If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1147743 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1a810cf86fb5cb1fa6468f8aa837becda6cf32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565403Reviewed-by:
-
Ken Rockot authored
Fixed: 902135 Change-Id: I9aeb13d6606ed2cf89185bd7380e621b1dc22caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565656 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#832010}
-
Yuly Novikov authored
instead of 20.04. TBR=bsheedy Bug: 1153160 Change-Id: I2e1370afb24bb2069fdb87368a4bfc232f6c16fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565622Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#832009}
-
Charlie Hu authored
This CL fixes the missing Permissions Policy issue for XSLT document. Previously, the XSLT navigation will commit a new document without necessary header information in |DocumentLoader::response_|, resulting permissions policy header not effective for XSLT documents. This CL lets document loader copy the state of Permissions Policy (Feature Policy) from previous document to solve this problem. Bug: 1151954 Change-Id: I4e1591af65d9e93ad49850fb23f69426bf116dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561144Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#832008}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie1f840d34e5c0b471177aad68cbb77aff9fc8394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565112Reviewed-by:
-
Benjamin Beaudry authored
In NGSimplifiedOOFLayoutAlgorithm, the order in which fragments are added to the builder is important and apparently more complex than I initially thought. The way it was implemented, it caused problem when we were trying to find the matching break token since the order was different. For more info on the new implementation, see my comments in ng_simplified_oof_layout_algorithm.cc. Fixing the order fixed all disabled tests in NGOutOfFlowLayoutPartTest, but one related to nested fragmentation that is unrelated. Bug: 1143301, 1117625, 1148875 Change-Id: I0e2c559930da3f0042ada106c334d35521163d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552076 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832006}
-
Tom Anderson authored
R=dpranke Bug: None Change-Id: Id6af2f6fe655131415ccb24cf6d0150d12600688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555591 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#832005}
-
Thomas Guilbert authored
This CL updates the test expectations that were missed as part of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2556497 Bug: 963141 Change-Id: Ia858b484779160089d1803f3b0753dd8e56a018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561780 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#832004}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9be11f7d2b44..c6465ca683e6 2020-11-30 miu@chromium.org Remote virtual connections [1/3]: Refactor VCRouter to extend VCManager. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I69f2a02082251c2a0831e992648761acdcf4b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564477Reviewed-by:
-
David Van Cleve authored
battre@ pointed out that a number of the data reduction prefs corresponding to obsolete metrics removed in crrev.com/c/1762336 were never cleared, so they continue to take up space in profile directories where they were set. This change adds back the prefs deleted in that CL temporarily, clearing them on startup. I've filed crbug.com/1153394 to remind us to remove the prefs once M90 branches (so that the clearing logic will have been live for two releases). Test: Added a unit test verifying all of the obsolete prefs get cleared Bug: 1132866,934982,1153394 Change-Id: Ife2dab8634205812119db36d50e95d0173884a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563788Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#832002}
-
Kyle Milka authored
Make the divider take up the full width of the bottom sheet. Bug: 1152646 Change-Id: I5aae6100e6e9fe3b66d9a49a9451dd8e1c28b972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563434 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#832001}
-
Christopher Cameron authored
CanvasColorParams is a poor match for ImageData. It has the same CanvasColorSpace names, but different pixel format support, and unused an unused opacity parameter. Remove the accessor ImageData::GetCanvasColorParams because of this mismatch. Clean up serialization of CanvasColorParams to not use these accessors. Remove ImageData::Create that takes a StaticBitmapImage, since this is not used and is the last place where CanvasColorParams are used. Remove the now-unused helper functions from ImageData ImageDataInCanvasColorSettings and ConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat. Bug: 1150969 Change-Id: Icf8697685ed4d0bfbcee07a47196a2fe4772a2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548773Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#832000}
-
Abigail Klein authored
Do not enable extra mac nodes on the AXTree because it caused a crash. Bug: 1136813 Change-Id: I46ce64b3af5ec5d4bf3abb82e30bbb96b71637e5 AX-Relnotes: Fix a browser crash on Mac. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555559 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#831999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata to chrome-linux-master-1606759191-6cd311392c4a2d76b8ec4391ac1874206c9889b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibbe128fb84ccc1e97f186f665afc7e84729bf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565114Reviewed-by:
-
Lucas Radaelli authored
This change implements support in the AccessibilityBridge to deal with multiple semantic trees, each one representing an iframe. The trees are combined before they are sent to Fuchsia into a single semantic tree. Test: AccessibilityBridgeTest.* Bug: fuchsia:63612,fuchsia:63610,fuchsia64329 Change-Id: I174ec9db254647edb33ada5b31eb24595debe031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556462Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#831997}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata to chrome-mac-master-1606759191-e36e6bb9e34aaec2b6f2fa507df72b0ae1dbb4d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8d0ca2c0cf6c2ea4e36b254cb2b6759d97742d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565111Reviewed-by:
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a video frame was displayed before ending the test. Bug: 1083605, 1083609e Change-Id: I6a6b3a4a3349ba35c301fe1c7998857c9f94d9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561746 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL configures //third_party:dagger_java //third_party:dagger_processor so that they can point to the internal implementation of Dagger2 for internal Chrome builds BUG=1141111 Change-Id: Ibe7bc24341afcaad4835bf7a60093f563d65de5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565192Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831994}
-
Benjamin Beaudry authored
Users of Narrator experience a consistent crash caused by an endpoint in AXPlatformNodeTextRangeProvider being on a position that isn't null but had no associated anchor. This position is likely a product of the implementation of TextRangeEndpoints::OnNodeWillBeDeleted, where we move the position to its parent that might have been deleted previously. The crash was caused by an observer not being removed. It was not removed because of the use of !IsNullPosition(), in which we return true if GetAnchor() returns a nullptr. Eventually, when bug:1152939 is fixed at the source, it will be safe to go back with IsNullPosition(). Bug: 1152939 Change-Id: I633d403d8182adca807fde61563a343ce7ee78e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561648 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#831993}
-
Alexander Surkov authored
Move tree formatters Create methods from tree formatters into a separate factory class, which lives in content public and thus can implement create methods for any formatter located both in content and ui. Bug: 1133330 Change-Id: I7ddde664f3307a228e1fd472e20c65f273f4a4bc AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490383Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#831992}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4324.9-1606129869-benchmark-89.0.4337.0-r1 to 89-4324.9-1606737320-benchmark-89.0.4337.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I473cebf6330406365b8550005c95106d48a55128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565108Reviewed-by:
-
evliu authored
Bug: 1122784 Change-Id: I0a683a3965219bdced0b78516c74eb55eabd0d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561123Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#831990}
-
Greg Thompson authored
FilePathWatcher::Watch(bool) is going away. No functional changes. BUG=1147071 R=ericorth@chromium.org Change-Id: I1a59c2d34b24725c46c9bc4e0ba7497151fa3ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562670 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831989}
-
mlcui authored
.gitattributes should force all committed CSVs to have LF line endings (https://crrev.com/c/2102647) but the power measurement CSVs were committed before that CL. The CRLF line endings caused these CSVs to always appear in a `git stash -p`. These files were converted using dos2unix. Bug: None Change-Id: I23812fe00e25b6a82d8d4e0b8533338b13137158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563190 Auto-Submit: Michael Cui <mlcui@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#831988}
-
Fabian Henneke authored
During an Autofill session, distinct sets of views (also called partitions) can trigger individual fill requests. However, there is a configurable limit on the maximum number of partitions, which in the case of stock Android is set to 10. Since Chrome never finishes an Autofill session and every page load with a form adds a partition, this means that Autofill fills stop triggering after a short time. This can be mitigated by cancelling the session when user actions indicate that there is no longer any Autofill-related state to preserve in the current tab: * When the user switches away from a tab. By cancelling the session before the tab contents become hidden, we additionally prevent Autofill from initiating a save flow as all virtual views become invisible. * When top-level navigation occurs that has not been initiated by the renderer. Renderer-initiated navigation, such as tapping a submit button in a form, may trigger Autofill's save functionality and must therefore not cancel the session. * When the domain part of the current URL changes. This behavior is part of the Android Autofill service's compatibility mode, but was partially broken on Android Q+ due to http://crbug.com/1103555 and completely broken by the workaround for that bug. The current change restored this behavior. These changes apply to Android P+ only as this is the first Android version with compatibility Autofill support for Chrome. The remaining scenarios in which the maximal partition count can be reached and Autofill stops triggering include: * A single document with more than ten separate forms. This should be rare and would equally be a problem in a native app. * Single-page apps or those consisting of multiple linked pages with a high total number of fillable forms. If the user does not switch tabs, Autofill may stop working after some time. Further improvements might be possible here, but have to avoid cancelling Autofill in a possible save scenario. Bug: 1150732 Change-Id: I1005cbd349f3ba3ea25a9edafe80d82a21876bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546900Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Adds the necessary files and changes to start generating Android O x86 emulator system images. Bug: 1145728 Change-Id: I31e4b56b70991b7850ac410655a085d84f0eb52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553025 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Patrick Noland authored
ExpandablePaymentHandlerBrowserTest.ClickSecurityIcon Bug: 1094159 Change-Id: I71e397d88cdf43e735bf98d80d6f0cc9a2a5ff3b TBR: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565697Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831985}
-
Jeremy Roman authored
This generates much less code and should be faster at runtime. Part of an ongoing quest to remove unnecessary runtime collection of static data structures. Change-Id: I3951f2093623f4e8a56f610c5174d2ea1458709f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562822 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Willie Koomson <wvk@google.com> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831984}
-
evliu authored
This CL adds a check when binding the speech recognition recognizer to destroy the speech recognition service if the Speech On-Device API (SODA) binary or model files don't exist on the device. This scenario can occur if a user manually deletes the SODA files from their device and triggers the Live caption feature before the files are redownloaded. The speech recognition service will not be launched in the first place if the SODA components have never been installed before because the local prefs containing the paths to the files will be empty. Bug: 1152915 Change-Id: I92d5abccf0ecd6c9fa5f1f80deda650f2344e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561641Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#831983}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ibac313e4c134044a13bb1219aa49895797bd50e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563761 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Patrick Monette authored
This makes it so that all content/ embedders will be able to use the concept of execution context priority. This CL also moves OverrideVoteAggregator, MaxVoteAggregator and BoostingVoteAggregator out of public visibility, as it is no longer needed. Bug: 971272 Change-Id: I39096d966cc844f75b739d909b4ac2df605eef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564038Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#831981}
-
Simon Zünd authored
This CL introduces a new experimental CDP event in the network domain. As mentioned in the event documentation, the event can fire before the corresponding network request is sent, or after the response is received, depending on success/failure and the type of the Trust Token operation. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1126824 Change-Id: I57fad66b08200ce8c98c44b8406b805627fd3b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554542 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#831980}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie7e703e9270086bd5ef1e9c3a2911f8f76d28713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563762 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
