GitLab

BUG=355073

Review URL: https://codereview.chromium.org/216883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261415 0039d316-1c4b-4281-b951-d872f2087c98

Loading empty_feed.json is meaningless now.
LoadAccountMetadataForWapi() is deprecated and has no effect essentially.

BUG=334544
TEST=browser_tests

Review URL: https://codereview.chromium.org/221853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261414 0039d316-1c4b-4281-b951-d872f2087c98

GetResourceEntryReqeust is used by DriveAPIService

BUG=357038
TEST=build

Review URL: https://codereview.chromium.org/221883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261413 0039d316-1c4b-4281-b951-d872f2087c98

    
If a network delegates sets a redirect URL (in BeforeRequest or HeadersReceived), then it should get full
control over the target URL.
In particular, data:-URIs should remain unchanged because Chrome does not interpret # as a delimiter for reference fragments.
    
BUG=354653
TEST=net_unittests:
URLRequestTestHTTP.RedirectWithReferenceFragment:URLRequestTestHTTP.RedirectJobWithReferenceFragment (tests new behavior)
URLRequestTestHTTP.RedirectWithReferenceFragmentAndUnrelatedUnsafeUrl:URLRequestTestHTTP.Redirect302PreserveReferenceFragment (regression test)

Review URL: https://codereview.chromium.org/212543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261412 0039d316-1c4b-4281-b951-d872f2087c98

This changes the presubmit rule for adding pepper interface hashes to UMA to a
notification instead of a warning. This is because the presubmit is a bit too
broad, and was blocking some changes from being submitted through the CQ.

Using a notification message should be fine, since the impact of missing a
histogram is relatively low (we'll just see a number for a while), and the hash
can always be added later.

BUG=351389
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/221973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=358265
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/222683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261410 0039d316-1c4b-4281-b951-d872f2087c98

1) JSON loader does not set error code to 0 on success.
2) Store signature on user import
3) Do not filter out need password change/incomplete flags.

R=nkostylev@chromium.org
TBR=bauerb@chromium.org

BUG=244472

Review URL: https://codereview.chromium.org/221813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261409 0039d316-1c4b-4281-b951-d872f2087c98

This removes the confusing code in content/renderer/accessibility that
serializes updates from Blink's accessibility tree, and replaces it with
calls to the new cleaner and fully-unit-tested AXTreeSerializer class.

BUG=316726

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261099

Review URL: https://codereview.chromium.org/125763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261408 0039d316-1c4b-4281-b951-d872f2087c98

Normalizing source file names before calculating hash by extracting the last component of the file path.
This hash is sent as TrackedObject.source_file_name_hash field.

This solves the problem described in the bug to a degree that we can build a functioning prototype for the server-side analysis tool. The tool will use (filename:line) pair to identify a piece of code that posts a task, and extract parameters to PostTask (and similar) functions to conveniently identify the task.

This solution is not final because the short filenames are not unique, and we’ll have about 6 conflicting pairs. This is OK for the proof-of-concept tool; further development might go in 1 of 2 different directions:
1. We like the results of the (file, line) method mentioned above, and we improve this solution, for example, by renaming files to make them unique.
2. We don’t like it, probably because of inconsistency of names on the server-side tool and the chrome://profiler page, and because it doesn’t show task entrypoints when the closure is created outside of the PostTask parameters list. In this case, we may want to explore adding an identifying parameter to the closure constructor. I’m not going to dive too deep into this, but we have a design for this. Anyways, in this case, we won’t use filename to identify tasks, and the fact that they are not unique will be OK.

For the record, there were other alternatives to extracting the last component, mainly:
1. Post-preprocessing (sic!) or compile-time or post-compile step that normalizes file names.
The issue was the high price (may be weeks of work), which is not OK for a proof-of-concept tool. For example, if we choose later to pass ID in the closure, this work would be wasted.

2. Identify the task by PC (program counter) instead of (file, line). This would require extending the UMA with a map of addresses of loaded modules, per process, and add 2 fields to TrackedObject: PC and module ID. This may be too much for a prototype. There also are some concerns regarding the server-side part of this approach.

BUG=357787

Review URL: https://codereview.chromium.org/217483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349058

Review URL: https://codereview.chromium.org/221353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261406 0039d316-1c4b-4281-b951-d872f2087c98

This patch contains images used by r261396.

BUG=343127
TEST=ran browser_test on Release/Debug.
manually verified that each filetype icons appears correctly.
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/224073002

Patch from Naoki Fukino <fukino@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261405 0039d316-1c4b-4281-b951-d872f2087c98

This code is dependent on aura but not on ash. It'd be
useful in app_shell, which doesn't use ash.

BUG=354711

Review URL: https://codereview.chromium.org/222383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261404 0039d316-1c4b-4281-b951-d872f2087c98

R=miguelg@chromium.org,iancottrell@chromium.org

Review URL: https://codereview.chromium.org/221173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261403 0039d316-1c4b-4281-b951-d872f2087c98

AW Shell shows a white screen when we play a video. It only plays sound.
This patch implements onShowCustomView() and onHideCustomView() of AwContentsClient to fix it up.

Review URL: https://codereview.chromium.org/223253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261402 0039d316-1c4b-4281-b951-d872f2087c98

And also I am forced to do some clean up on the existing code to avoid adding the source provider inside the WebRtcLocalAudioTrack.

NOTRY=true

BUG=358960
TEST=content_unittests

Review URL: https://codereview.chromium.org/221863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261401 0039d316-1c4b-4281-b951-d872f2087c98

The repeat feature did not work if there was only a single file in the list. This patch fixes the issue.

BUG=chrome-os-partner:27258
TEST=audio_player tests pass
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/221623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261398 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danakj@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/216633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261397 0039d316-1c4b-4281-b951-d872f2087c98

Make Files.app and Chrome refer same icon sets and remove duplicate files.
Now those icon files are not under file_manager folder, changed their id from IDR_FILE_MANAGER_IMG_FILETYPE_* to IDR_FILETYPE_*

BUG=343127
TEST=ran browser_test on Release/Debug.
manually verified that each filetype icons appears correctly.

R=jochen@chromium.org, oshima@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/209433005

Patch from Naoki Fukino <fukino@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261396 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327641

Review URL: https://codereview.chromium.org/220263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/222543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107602

Review URL: https://codereview.chromium.org/222143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261391 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/223213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261390 0039d316-1c4b-4281-b951-d872f2087c98

Replace with ExtensionRegistry::enabled_extensions().GetExtensionOrAppByUrl().

BUG=351891

Review URL: https://codereview.chromium.org/220053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261389 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327256

Review URL: https://codereview.chromium.org/221613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261387 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- r158 Add whitelist support to data_pack.RePack()

BUG=338759

Review URL: https://codereview.chromium.org/217283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261386 0039d316-1c4b-4281-b951-d872f2087c98

(I'll probably remove a lot more soon, but I also want to commit this
before I move files around.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/221953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
TEST=no change

Review URL: https://codereview.chromium.org/222783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261384 0039d316-1c4b-4281-b951-d872f2087c98

gpu: Allow fences to check whether a flush has occurred

This skips waiting on a fence that was created but never committed.

BUG=352419,355275
TBR=piman@chromium.org

> Original Review URL: https://codereview.chromium.org/197563003

Review URL: https://codereview.chromium.org/222103008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261383 0039d316-1c4b-4281-b951-d872f2087c98

    
Discovered following issues:
1. after each native library load, the code starts a thread
   to delete old libs;
2. render process also tries to delete old libs;
3. Context.getDir(...) creates the directory if not
   existing, so existence test is always successful,
   and assertion may fail;
    
The CL fixes these issues. LibraryLoader.ensureInitialized
and LibraryLoader.loadNow have a second boolean parameter,
inBrowserProcess, used by caller to indicate whether the code should try to delete old libs.

BUG=357655

Review URL: https://codereview.chromium.org/217283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261382 0039d316-1c4b-4281-b951-d872f2087c98

Although all current toolchains that we use have the
same algorithm backing that function, it is apparently
not guaranteed by the spec and the libc++ implementation
differs.

Since we rely on consistent results here, change the code
to do its own shuffle using the same algorithm.

Correctness is already covered by existing tests.

BUG=358564

Review URL: https://codereview.chromium.org/222373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261381 0039d316-1c4b-4281-b951-d872f2087c98

These are not used anymore except for clearing the client-provided texture, so
this removes 1 of 4 TextureLayer paths, and simplifies externally-exposed state.

BUG=337922

Review URL: https://codereview.chromium.org/213743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261380 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert due to perf regression:
http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=48755

Original issue's description:
> Refactorise the policy_path_parser framework
> 
> This CL performs a refactorisation of the policy path parser framework.
> 
> BUG=352627
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261370

TBR=pastarmovj@chromium.org,kaliamoorthi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=352627

Review URL: https://codereview.chromium.org/223993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261379 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261376 0039d316-1c4b-4281-b951-d872f2087c98

> roll skia DEPS to 14039
> 
> Chromium base revision: 261279 / d22d1189
> Old Skia revision: 14021
> New Skia revision: 14039
> Control CL: https://codereview.chromium.org/223273002
> 
> This CL was created by Skia's roll_deps.py script.
> 
> Bypassing commit queue trybots:
> NOTRY=true
> R=rmistry@chromium.org
> 
> Review URL: https://codereview.chromium.org/223283002

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/223763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261375 0039d316-1c4b-4281-b951-d872f2087c98

AVCaptureVideoDataOutput uses AVVideoScalingModeResizeAspect
to "Preserve aspect ratio of the source, and fill remaining areas
with black to fit destination dimensions." [1]. However, in at least
two cases, this seems to be problematic:
- When capturing 480p using a Blackmagic Ultra Studio Mini 
Recorder. (http://crbug.com/347371).
- When opening the camera in a 16:9 aspect ratio using 
AVFoundation _and then without closing it_ opening in a 4:3
aspect ratio with QTKit (http://crbug.com/357252).

The solution in both cases is to instruct the AVCaptureVideoDataOutput
to use AVVideoScalingModeResizeAspectFill: "Preserve aspect ratio of
the source, and crop picture to fit destination dimensions" [1].

[1] https://developer.apple.com/library/mac/documentation/AVFoundation/Reference/AVFoundation_Constants/Reference/reference.html#jumpTo_75

BUG=288562, 357252, 347371

Review URL: https://codereview.chromium.org/223513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261373 0039d316-1c4b-4281-b951-d872f2087c98

[IME] InputMethodUtil should cache the hardware layouts from VPD, instead of the filtered hardware layouts. So that GetHardwareLoginLayouts() can be called more than once when InputMethodUtil is init'ed or not init'ed.
And don't use SetInputMethodLoginDefault() in OOBE, use EnableLoginLayouts() instead, because SetInputMethodLoginDefault() will default select the previous activated layout.

BUG=358249,358591
TEST=Verified on pixel.

Review URL: https://codereview.chromium.org/218623015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261372 0039d316-1c4b-4281-b951-d872f2087c98

The maximum decoded image size is adjusted from 1/32 of accessible
memory to 1/25 of accessible memory. This is to enable the upload of
4K*4K WebGL textures on platforms with 2GB of physical memory of which a
small region is reserved for direct hardware access and thus invisible to
Chromium.

BUG=356181
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/220993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261371 0039d316-1c4b-4281-b951-d872f2087c98