- 09 Sep, 2019 40 commits
-
-
Adithya Srinivasan authored
Disable tests on ASAN. Bug: 1001421 Change-Id: Id6060b463e07d2e7c97bde31d25eb65392f39135 Tbr: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791535Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#694792}
-
Pâris MEULEMAN authored
SigninManager uses IdentityManager's observer (onPrimaryAccountSet/Cleared) through IdentityManager.java instead of signin_manager_android. Bug: 934688 Change-Id: I037906b6c59254a9c205d615284c503af268ecd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751245 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#694791}
-
rajendrant authored
Image with 0 height in sub-pixel layout is a special case for intersection observer that causes it not fire. This CL adds a test for that. Bug: 999019 Change-Id: I3b95a46eebcc534a22af42dc9c47f2d40a201606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780060Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#694790}
-
Ali Juma authored
This adds the file as an EG2 target, and updates #includes. This also adds a displayTitleForURL method to ChromeEarlGrey and ChromeEarlGreyAppInterface. This provides the functionality of web::GetDisplayTitleForUrl. The logic of parsing a URL in this manner cannot be moved to the test process, since it depends on app-process-specific logic; for example, it depends on ChromeWebClient::AddAdditionalSchemes for registering the "chrome:" scheme in order to correctly parse chrome:// URLs. Bug: 987646 Change-Id: I2ef13336dae4dad1b9a774713c35f8c08e680233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790602Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#694789}
-
Koji Ishii authored
This patch adds a quirks for atomic inline+nbsp defined in CSS Text, saying: > for Web-compatibility, introduces a soft wrap opportunity > between itself and any adjacent U+00A0 NO-BREAK SPACE > character. https://www.w3.org/TR/css-text-3/#line-break-details This is resolved at: https://lists.w3.org/Archives/Public/www-style/2015Mar/0187.html > zcorpan: I checked httparchive for nbsp before/after an > image, and there were 16k matches. About 130k pages in the > set, so about 12% of all the pages match the query. Bug: 993893, 1001793 Change-Id: I24c30b43f282c2005abccf5be4de68262875b87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792465 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#694788}
-
Koji Ishii authored
This patch fixes NGLineBreaker not to go to an infinite loop when `break-word` and `nowrap` appear in specific combinations. Bug: 1001359 Change-Id: I0fb282e96eb29cd65033232329aaa5dc5be3da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792040 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is preparation of OS upgrade. Bug: 1002055 Change-Id: Ica90a0b953fa0dc4a5b9822ade28884a018b1fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792663 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#694786}
-
John Delaney authored
Add a constructor to TestNavigationObserver that takes a target net:Error, and will wait until a navigation with that error finishes. This simplifies the testing of error pages in the browser process. Prevents racing with other navigations when registering an observer for an error. This is a precursor to crrev.com/c/1783300 which introduces tests that have many subframe navigations which eventually cause an error page to load. Change-Id: I7ad301c1d4999e79b6590cd4d5d2d4dccaf3aeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789427Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694785}
-
Scott Violet authored
No functional changes, just fix ordering. BUG=none TEST=none TBR=jam@chromium.org Change-Id: I829b10760523f9e4d059912a769e9476417ae7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790761Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#694784}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee3d995091da..2aaf66e4644a git log ee3d995091da..2aaf66e4644a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 82910f73..75cf3925 (694601:694706) 2019-09-09 perkj@webrtc.org Check input parameter in RemoteEstimatorProxy::IncomingPacket without lock Created with: gclient setdep -r src/third_party/webrtc@2aaf66e4644a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:NONE Change-Id: I28cce11ae4a3d7d51b2578bf3088505b67ff67fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694783}
-
Robbie Gibson authored
Bug: 1002077 Change-Id: I24b4209c99ae56e1e8aa3671aa89d6642511b7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790110Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694782}
-
Adithya Srinivasan authored
Disable test on chrome os. Bug: 1002066 Change-Id: Ie8306b18777ed33dee10e6bf8c9f1f9d61b0328f Tbr: pmarko@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793004Reviewed-by:
-
Jonathan Backer authored
Each call to SharedContextState::MakeCurrent takes about 1% of CPU time in RendererPerfTest/1.TextureQuads5x5. These calls are on the fast path with context virtualization (e.g. time is mostly from eglGetCurrent). We always call CopyOutput or SkiaSwapBuffers right after drawing to the framebuffer. This CL defers the draw on GPU main until one of those occurs to eliminate a MakeCurrent call. Bug: 974359 Change-Id: I0047318ddb04dbe81d14065e40685269c2db3272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787356 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#694780}
-
Koji Ishii authored
This patch will prevent crashes in |HarfBuzzShaper::ShapeSegment| probably caused by |ShapingLineBreaker| or |ShapeResult|, but I could not come up with a good explanation how this happens. A case I looked at was LTR Arabic, trying to break a |ShapeResult| for range 0-28. When we found a break opportunity at 20, |last_safe| becomes 25. Shaping a range 25-20 causes OOM in |HarfBuzzShaper::ShapeSegment| because start > end. Checked if any possibilities to accidentally move |last_safe|, and possibilities where |ShapeResult::CachedPreviousSafeToBreakOffset| can return larger value than the given argument, but could not find how it computes such value. This is a speculative fix. Bug: 1000560, 1002061 Change-Id: Ieb9c2c988b5a116a49d5de407d1c269106c52dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787026Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694779}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78fb80a2b328..73b8376b302a git log 78fb80a2b328..73b8376b302a --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ethannicholas@google.com Fixed skslc assertion failure discovered by fuzzer 2019-09-09 brianosman@google.com Remove legacy flag: GrContextOptions::fDisallowGLSLBinaryCaching Created with: gclient setdep -r src/third_party/skia@73b8376b302a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ic3f4a8bbc8b88cdf083591e080543dbfcecd7e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791436Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f5102cee4165..4273c0b00841 Created with: gclient setdep -r src-internal@4273c0b00841 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I31386ba6604c86fea2f616889f29894bd054d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694777}
-
Peter Boström authored
Bug: None Change-Id: I4b552e6c712efaf31bbdf184e9b2d2ec5c9ecdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789682Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694776}
-
Dave Tapuska authored
Keep the lifecycleState on the client but remove the ability to filter. Spec change: https://github.com/WICG/page-lifecycle/pull/39 BUG=968417 Change-Id: I0dcfd6bfee0746e5a405f82d6a3009a663ec7a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789693Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694775}
-
Fredrik Söderquist authored
Seems like that these flakes aren't platform dependent. Tbr: schenney@chromium.org Bug: 1001936, 1002046 Change-Id: Ie62882630c56e72e5edcbb6e4a8003da703dd38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790109Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#694774}
-
Anton Bikineev authored
Before this CL the rules for GarbageCollectedFinalized were diverging from standard C++ std::is_trivially_destructible because heap collections had a destructor that would be ignored because the classes were not required to be GarbageCollectedFinalized. After the CL, std::is_trivially_destructible can be used as replacement for GarbageCollectedFinalized. Benchmarks (blink_perf.dom, blink_perf.bindings, speedometer) show no regressions. Bug: 990913 Change-Id: I62de9fd28238ea02ee440f3244007f1d26a97b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742147 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#685557} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789809 Cr-Commit-Position: refs/heads/master@{#694773}
-
Andrew Grieve authored
These targets require building the name of the underlying android_apk template, which was renamed in 88952e43. Change-Id: I4cd02165e42a3ff932bcc7c3b605f52248e103fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792968 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694772}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/dbus/auth_policy. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=tnagel@chromium.org Bug: 891670 Change-Id: I4b88ebcfc2c108c02a6ff8987d121f24bb7c5195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786827 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#694771}
-
Dave Tapuska authored
Ensure that the result of mouse up is passed back to the browser so that it can be executed on the browser side. BUG=850847,705583 Change-Id: Iebf871c43a9957af1f66a398344efcddc47d7293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769525 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694770}
-
Michael Lippautz authored
Removes the stand-alone scheduling heuristics of Oilpan. Since M77 V8 takes care of scheduling unified heap garbage collections and also considers memory pressure of the Blink heap when doing so. We still maintain ways to trigger stand-alone GCs as they should stay supported. Bug: 948807 Change-Id: Idc60921354a5b4996cda7edb601b2242a1fbe213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692751Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91d331cf. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iecdc3dbdbdcd9548ec6fad9152b6049f6da528fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792843Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694768}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/97a7d404..26505d54 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d16f742cd9dae6d9c4a1d5f1979bb06b40db881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792842Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694767}
-
Friedrich Horschig authored
By increasing the vertical threshold, we ensure that the user has 80dp left even if the keyboard accessory is showing. Since we considered the accessory height in addition to that threshold in our sheet height calculations, the latter needed an update. FYI: I intend to merge this CL into M78. Bug: 1002002 Change-Id: I447667e69a493ca9da238a8a38ada012733dabf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790883Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#694766}
-
Andrew Grieve authored
This reverts commit 3455d426. Reason for reland: restored proper dependent CL TBR=boliu@chromium.org,agrieve@chromium.org,iclelland@chromium.org Bug: 1000510 Change-Id: I5df68e7d90894a558b35bde90be9b8248eb8c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788019 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#694765}
-
Sylvain Defresne authored
The PrimaryAccountManager used to store just the CoreAccountId of the authenticated account and to fetch the extended information from the AccountTrackerService. This could result in missing information if the account is removed from the AccountTrackerService while the authenticated account is not yet cleared. This should not have been a problem as it should not happen in production however some regression where found during the introduction of IdentityManager. To fix those inconsistencies, IdentityManager was changed to cache the information about the primary account. This however meant that two objects are now storing the same information. Also the value passed to GoogleSignedOut() method could still be inconsistent. This CL removes the cache from IdentityManager and instead move it to PrimaryAccountManager. This was not possible at the time due to complex inheritance in PrimaryAccountManager (formerly SigninManager). After this change, the information is stored in PrimaryAccountManager and updated by IdentityManager when information is updated in the AccountTrackerService (AccountTrackerService does not use Observer but instead a callback which can only have one target, this target is IdentityManager::OnAccountUpdated). The CL also remove PrimaryAccountManager::SetAuthenticatedInfo() as it is equivalent to calling AccountTrackerService::SeedAccountInfo() followed by PrimaryAccountManager::SignIn(). Bug: 862619 Change-Id: I5f0d7a13f6886c2d1f5db5b83d967f60380d206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#694764}
-
Aaron Tagliaboschi authored
Fix issue where asynchronous validation requests (specifically, revalidation on stale-while-revalidate requests) result in a duplicate value for client hint headers (i.e. `Sec-CH-UA: Chromium 76, Chromium 76` instead of `Sec-CH-UA: Chromium 76`) Bug: 959611 Change-Id: Iac16b84b129108b9ebe1258e11722cdc9eaa52de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645455 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694763}
-
Rakib M. Hasan authored
The tags generated for the Android OS version name have changed in telemetry. We also need to update the tags in gpu tests. Bug: chromium:999335 Change-Id: I44f7af062a80c5cf5035d908893c712b07c4b837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790477 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694762}
-
Jérôme Lebel authored
Unified consent feature flag is always on, so the pre-unity UI can be removed. Pre-unity UI removed in: - bookmarks - content suggestions - first run - sign-in promo - recent tabs Bug: 951313 Change-Id: I1ffd95c420bab229f930ea6b14e7e6ca6ecca637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787545Reviewed-by:
-
Andrew Grieve authored
It was meant to denote removed symbols, but doesn't really work. We'll track re-adding the feature in crbug/978307 Bug: 978307 Change-Id: Ide015ea4ca24ed57ca4f1f5d95363b21deb96bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790791 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#694760}
-
Mugdha Lakhani authored
Add some instrumentation tests for Background Sync. We currently don't have any that run on Android, and this CL bridges that gap. A previous attempt was made at this here: https://chromium-review.googlesource.com/c/chromium/src/+/1534160 but it worked by fluke, since our test devices happened to have network connectivity. That can't be guaranteed so this CL mocks out network connection type. It also mocks out BackgroundTaskScheduler because the last attempt was failing to get the BackgroundTaskScheduler delegate for Android L and below. This was because Google Play services isn't up to date on our test devices. Bug: 996664 Change-Id: I904664a87e31439a65c0f9a04a1c9c4b21d03bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768321 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#694759}
-
Rune Lillesveen authored
TBR=kojii@chromium.org Bug: 953479 Change-Id: I6738e1fb082f3dbf0275c3913b6f987e6f2be7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790107Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694758}
-
Rune Lillesveen authored
TBR=schenney@chromium.org Bug: 1002049 Change-Id: I6488f6376a3fa41c1cc9358b6c83f04d8313d4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792864Reviewed-by:
-
redatawfik authored
1- Move two methods "ExtractCreditCardNumber" and "SubstituteSimilarCharactersInRecognizedText" from mediator to Util file. 2- Write a unit test for the two methods. Change-Id: Ie6e191cf06e4ae23d9993ded738dc374ec1c8790 Bug: 984545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782802Reviewed-by:Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#694756}
-
Sami Kyostila authored
This is a reland of 0bf621ef Original change's description: > base: Remove temporary "WithTraits" task API wrappers > > Now that everyone has been migrated to the renamed > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. > > TBR=gab@chromium.org > (to apply side-effects of mechanical change in //base) > > Bug: 968047 > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693695} TBR=gab@chromium.org (reland without changes) Bug: 968047 Change-Id: I1969ecad2af1527b14e4c8160e16156cde31cf45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790105 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#694755}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink::mojom::FileSystemCancellableOperation, FileSystemOperationListener, ReceiverSnapshotListener and FileSystemManager interfaces. Bug: 955171, 978694 Change-Id: I69305173de67148fc2708e5a31e106e525d340de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773146Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#694754}
-
Sergey Ulanov authored
DisplayResourceProvider wasn't calling ResourceFence->Set(). Because of this the fence wasn't signaled in SkiaRenderer::FinishDrawingQuadList() when it is necessary. As result GpuMemoryBufferVideoFramePool kept re-allocating new GPU memory buffers instead of reusing them. As result the system would run out of memory very quickly when playing video. Bug: 1001296 Change-Id: I390bfb63455b7e4b2bfa61717450d3f30bc05303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790275 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#694753}
-
