- 05 Oct, 2018 40 commits
-
-
Olivier Robin authored
Change-Id: Ice8b17739f5849f75feb03be4001cef7917572bf Reviewed-on: https://chromium-review.googlesource.com/c/1261399Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597112}
-
David 'Digit' Turner authored
Use C++11 default initializers to make ScopedTracer smaller and simpler. Surprisingly, this saves 12288 bytes in MonochromePublic.apk for the 32-bit ARM build! BUG=702718,708990 R=agrieve@chromium.org,lizeb@chromium.org,pasko@chromium.org,alexilin@chromium.org,primiano@chromium.org,picksi@chromium.org Change-Id: Ia1d3e936ec8b9cfe3c52b9cfc0b97a2a38ac7043 Reviewed-on: https://chromium-review.googlesource.com/c/1254723Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#597111}
-
Paul Jensen authored
Bug: 879209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Idf94d64fc56addd13b7fafbb3e49d477a4e8c4bd Reviewed-on: https://chromium-review.googlesource.com/c/1231735 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#597110}
-
Siddhartha authored
This CL is moving lifting out the loading from the resource bundle to the corresponding 'ssl_error_assistant_component'. The previous implementation was loading on-demand the bundled proto when needed. But, when the 'ssl_error_assistant_component' is ready, it's setting the received proto. As no SSL error occured, the bundled proto is not loaded and must be loaded on the UI thread. This is causing jank on the UI thread. Which can be seen on the bug 888555. The current proposition is to keep the bundle loading on-demand since error paths are not the common ones. But, for the 'ssl_error_assistant_component' path we proposed to also read the bundled proto and choose the most recent one before sending it to the error assistant on the UI thread. That way, most of the job is done before getting on the UI thread. NOTE: ReadErrorAssistantProtoFromResourceBundle is thread safe and can be executed on any thread. It can also be executed twice. R=fdoray@chromium.org, meacer@chromium.org CC=carlosil@chromium.org, agl@chromium.org Bug: 888555 Change-Id: Icd994f93c849b3c4d8b01d7921dff69f571397a8 Reviewed-on: https://chromium-review.googlesource.com/c/1247025 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597109}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4bb1e4a1d50f..a1134509c91d git log 4bb1e4a1d50f..a1134509c91d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 618ddbcb..d62b62d8 (596951:597059) 2018-10-05 titovartem@webrtc.org Switch webrtc from deprecated usages of NetworkSimulationInterface 2018-10-05 nisse@webrtc.org Set ChannelReceive transport at construction time. 2018-10-05 phensman@webrtc.org Remove @SuppressLint(NewApi) and guard @TargetApi methods 2018-10-05 mbonadei@webrtc.org Make modules/audio_mixer:audio_mixer_impl publicly visible. 2018-10-05 nisse@webrtc.org Delete support for VoIP metrics (RFC 3611 4.7) Created with: gclient setdep -r src/third_party/webrtc@a1134509c91d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1886ba2aabaea49195bbe20bfafeeb3b73d35a4d Reviewed-on: https://chromium-review.googlesource.com/c/1264626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597108}
-
Henrik Grunell authored
Adds unit test for effects. Bug: 891202 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I16653e77faa5fc12d4462514b8cd73abbe74341b Reviewed-on: https://chromium-review.googlesource.com/c/1264535Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597107}
-
Rayan Kanso authored
I reproduced the failure locally, and then re-ran with the changes 100 time successfully TBR=peter@chromium.org Change-Id: Ieb60211fcd9c6beb1aec2b152f298335c4d9178b Reviewed-on: https://chromium-review.googlesource.com/c/1264640Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597106}
-
Stephane Zermatten authored
Before this patch, AutofillAction would behave as follows: - when there are no cards or profile registered for autofill, the action would hang forever, as AutofillAssistantUiDelegate.showProfiles and showCards would return immediately without reporting any results. - when a card or profile was selected, the button would remain, but clicking on it would crash the application (as it would call a C++ callback that was already deleted). This patch attempts to guarantee that the callbacks that correspond to AutofillAssistantUiDelegate.Client::onAddressSelected and onCardSelected are called exactly once. With this patch: - when there are no cards, the callback is called with an empty guid which tells the action to fall back to manuall filling - buttons disappear once they're clicked. If that fails, the C++ layer ignores duplicate calls for the same callback, without crashing. Bug: 806868 Change-Id: I15bb1b1e6ee528c18cbd76763827e69dfe3f1726 Reviewed-on: https://chromium-review.googlesource.com/c/1264475Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#597105}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56216d7832a4..de52d9ad295e git log 56216d7832a4..de52d9ad295e --date=short --no-merges --format='%ad %ae %s' 2018-10-05 sadrul@chromium.org scroll: Allow for more errors. Created with: gclient setdep -r src/third_party/catapult@de52d9ad295e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892036 TBR=sullivan@chromium.org Change-Id: Ic8478361b73397bcad961ca65dc35681cf52910f Reviewed-on: https://chromium-review.googlesource.com/c/1264625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597104}
-
Rune Lillesveen authored
Style sharing is removed and we should not need to avoid caching of matched properties in these cases. Change-Id: I5f6edee0ccd8da16f3361e17077b9b448a978f33 Reviewed-on: https://chromium-review.googlesource.com/c/1264638Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597103}
-
Lan Wei authored
In order to improve the performance and eliminate the issues that the fake mouse move events cause to the testing and web developers, we should not send fake mouse move events during scroll. This is implemented behind a flag. We will update the hover effect after scroll finishes in a following patch. TBR=bokan@chromium.org,nzolghadr@chromium.org,dtapuska@chromium.org, dgozman@chromium.org Bug: 877132 Change-Id: I484d7457f13d66e8add6faf5bc6c6d14c805af75 Reviewed-on: https://chromium-review.googlesource.com/c/1262423 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597102}
-
Roger McFarlane authored
This CL adds the PersonalDataManager as a History Service Observer and clears the data used to throttle upload events when the user deletes their browsing history data. Bug: 860285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I14b1c697fc34e6a6f4afc6599ca60baed55cab5b Reviewed-on: https://chromium-review.googlesource.com/c/1255143Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#597101}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d61a9f0f0d98..263549ba0d66 Created with: gclient setdep -r src-internal@263549ba0d66 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I55b91c8ccb4f702a84c428c14236d80b9f5c7c26 Reviewed-on: https://chromium-review.googlesource.com/c/1264623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597100}
-
Thomas Tangl authored
Already configure sync in the UnifiedConsentService when the sync engine is initialized, instead of waiting for sync to be active. Bug: 891706 Change-Id: I4f072e56820784f42ce9f2033724e43d8d5f5bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1264656Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#597099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6262495da48..b3ce196a4d9d git log a6262495da48..b3ce196a4d9d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 mtklein@google.com de-guard SK_LEGACY_TF_APPLY Created with: gclient setdep -r src/third_party/skia@b3ce196a4d9d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I7a069f33b293afc27dc1083d742bf2925aec4087 Reviewed-on: https://chromium-review.googlesource.com/c/1264622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597098}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3b5960174f6d..497958d899c3 git log 3b5960174f6d..497958d899c3 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 stevenperron@google.com Removing HLSLCounterBuffer decorations when not needed. (#1954) 2018-10-04 jaebaek@google.com Validator: function scope variable at start of entry block #1923 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@497958d899c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I73ecd80882769b71034aa41b661c4ae8c9133325 Reviewed-on: https://chromium-review.googlesource.com/c/1264621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597097}
-
Sigurdur Asgeirsson authored
Change-Id: Ib2e213b3ca883c0671b12bf8be864719a240feab Reviewed-on: https://chromium-review.googlesource.com/c/1259245Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597096}
-
Luke Zielinski authored
This method always returns true going forward. Also added TODOs in the code as reminders for other methods to clean up in upcoming CLs. Bug: 662944 Change-Id: If411bd98ce9d1d623503eb08215423fad4a1a748 Reviewed-on: https://chromium-review.googlesource.com/c/1259343Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597095}
-
Dmitry Gozman authored
RenderFrameImpl already knows about form submission during DecidePolicyForNavigation callback. Bug: 855189 Change-Id: I2bd71a7deb381a58988a03ea58e58079b2ede031 Reviewed-on: https://chromium-review.googlesource.com/c/1260383Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597094}
-
Daniel Bratell authored
In 2015 a dependency from search_engines to omnibox was created and it's created a cycle that causes linking problems in some ios+jumbo configurations. It works without jumbo because the cycle will be part of a dead .o file which will be ignored by the linker. With jumbo the .o file is not 100% dead anymore since dead and live code will be mixed in it. Bug: 488901 Change-Id: I4b36a1b4e9f46a2814d9562f288e55dadc63d9dd Reviewed-on: https://chromium-review.googlesource.com/c/1254082 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597093}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: Ibdc7919fb7658858b16227976e7e74c9eb74a007 Reviewed-on: https://chromium-review.googlesource.com/c/1261448Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597092}
-
Martin Šrámek authored
...due to a high amount of flakes. TBR=noel@chromium.org Bug: 891119 Change-Id: I2b13e7542bbd4cb4e827ab049f761c0f6eb73fc1 Reviewed-on: https://chromium-review.googlesource.com/c/1264539Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597091}
-
Koji Ishii authored
Following bot results are included. 10292 10296 10303 10312 10317 10322 10325 10332 10339 10349 10352 0 lines were removed and 0 lines were deflaked by consecutive results since 10290. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8518b892ef22e220e79efa2ac93ef6e0d5597535 Reviewed-on: https://chromium-review.googlesource.com/c/1260606 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597090}
-
Armando Miraglia authored
Since the parameters are now checked when passed through Mojo, this test is now outdated as the parameters are never invalid. This is verifyed by a DCHECK intorduced in crrev.com/c/1181134. BUG=891202 TESTS=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibbda19ce4d6d99363e02136883709082383582c2 Reviewed-on: https://chromium-review.googlesource.com/c/1264676Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#597089}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/78cdde3df652..4bb1e4a1d50f git log 78cdde3df652..4bb1e4a1d50f --date=short --no-merges --format='%ad %ae %s' 2018-10-05 aleloi@webrtc.org Lower gain parameters for AGC2. 2018-10-05 sprang@webrtc.org Hide libvpx vp8 encoder behind an interface and add mock for testing. Created with: gclient setdep -r src/third_party/webrtc@4bb1e4a1d50f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:892043 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c344b233a72919ef2cfa09d34ea7f3adb194e41 Reviewed-on: https://chromium-review.googlesource.com/c/1264619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597088}
-
Harald Alvestrand authored
This reverts commit 3f90035e. Reason for revert: The original problem was solved using another approach, and this CL (which modifies the content layer) just adds complexity with no purpose. Original change's description: > Implement DTMF [[ToneBuffer]] in the blink layer > > This CL makes the Blink layer keep a copy of the tone buffer > and update it on insertDTMF and ontonechange events only; this > makes it possible to expose the state of the tone buffer at the > time the event is fired to the Javascript callback. > > It removes a queueing step inside the DTMF sender, because > that queueing step destroyed the consistency. > > Bug: chromium:816475 > Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291 > Reviewed-on: https://chromium-review.googlesource.com/1213084 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589910} Bug: chromium:816475 Change-Id: Iaee9fefa8a37e3c6c7256dacac0855f426601e0d Reviewed-on: https://chromium-review.googlesource.com/c/1264165Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#597087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/25a2b998..060ca87d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I80f8e5e2cbd4331da184465825f7eb3ba7809a9d Reviewed-on: https://chromium-review.googlesource.com/c/1263892Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597086}
-
Mikel Astiz authored
A new feature toggle is introduced to influence how TabNodePool::CleanupTabNodes() issues deletions of tab nodes (i.e. sync entities for SESSIONS). The new mode is very aggressive and is conceptually similar to removing the notion of 'free' nodes, although this is not obvious in the code because it depends on how TabNodePool is used by upper layers (i.e. FreeTab() is followed closely by CleanupTabNodes() for the local session, in SyncedSessionTracker::CleanupLocalTabs()). The risk that this mode (disabled by default) entails is that closed tabs may never have the chance to sync, so if the user closed the tab accidentally, or expected to see the tab in other devices, it would be a regression. This doesn't seem very realistic, so let's experiment via Finch and assess the impact of the change. Bug: 882489 Change-Id: I76609434e5a733b8b5e4c94820ef2f29dd862ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1264597 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597085}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a4d068d23a6..4c11f3dcc855 git log 7a4d068d23a6..4c11f3dcc855 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 treehugger-gerrit@google.com Merge "Hopefully actually fix Windows build." 2018-10-05 treehugger-gerrit@google.com Merge "base: extract Event class for eventfd/pipe" 2018-10-05 hjd@google.com Merge "trace_processor: Add execution time to raw_query.proto" 2018-10-04 primiano@google.com Roll libunwindstack/libcore for standalone builds 2018-10-05 primiano@google.com Speculative (2) Windows fix 2018-10-04 cferris@google.com Merge "Add new parameter for creation of MapInfo object." 2018-10-04 primiano@google.com Merge "Speculatively fix windows build and unblock autoroller" 2018-10-04 primiano@google.com Merge "perfetto-ui: Add copy to tsv for queries" 2018-10-04 primiano@google.com Merge "Chrome: Change string table indices to unsigned" 2018-10-04 primiano@google.com Fix mac build 2018-10-04 primiano@google.com Merge "perfetto-ui: Improve thread data loading performance" 2018-10-04 fmayer@google.com Merge "Fix windows build." 2018-10-04 treehugger-gerrit@google.com Merge "Update README.chromium to point to correct license file" 2018-10-04 hjd@google.com Merge "perfetto-ui: Factor common code from loadTraceFromX" 2018-10-04 dproy@google.com Merge "[perfetto-ui] Update canvas size when container parent size changes" 2018-10-04 hjd@google.com Merge "perfetto-ui: Refactor to remove old Actions" 2018-10-04 fmayer@google.com Merge "Correctly handle partial writes." Created with: gclient setdep -r src/third_party/perfetto@4c11f3dcc855 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie9129dc2f538996c7fb27acc29d72633c76aee8c Reviewed-on: https://chromium-review.googlesource.com/c/1264617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597084}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74a9acd4a7c1..d61a9f0f0d98 Created with: gclient setdep -r src-internal@d61a9f0f0d98 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I287cf1076b7d5aa86591d9938239a1a716e0f941 Reviewed-on: https://chromium-review.googlesource.com/c/1264620Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92d10833de63..a6262495da48 git log 92d10833de63..a6262495da48 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 14246813a110..0ca09753392d (1 commits) Created with: gclient setdep -r src/third_party/skia@a6262495da48 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I3d7c6cded307e698887ff2d63985f475f508f64c Reviewed-on: https://chromium-review.googlesource.com/c/1264616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597082}
-
Rune Lillesveen authored
ApplyRuleSetChanges was hard to understand because it contained various branching for user style updates which wasn't clear were for user style. Move the user style specific font and keyframes handling to a separate ApplyUserRuleSetChanges and create a common InvalidateForRuleSetChanges to do the common code for marking nodes for style invalidation/recalc. Change-Id: I7b4907e526e5768f1957e5be3ad1b41f9a5d35f0 Reviewed-on: https://chromium-review.googlesource.com/c/1258543Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597081}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ca09753392d..2343836c4210 git log 0ca09753392d..2343836c4210 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 jmadill@chromium.org Remove gl::ErrorOrResult. 2018-10-05 jmadill@chromium.org Remove gl::LinkResult. Created with: gclient setdep -r src/third_party/angle@2343836c4210 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I306e90894630a4365e3910d50fd07017804b4662 Reviewed-on: https://chromium-review.googlesource.com/c/1264618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597080}
-
Thomas Tangl authored
When a custom passphrase is recognized for a user that is eligible for the consent bump otherwise, the consent bump will be suppressed. Note: Checking whether a user has a custom passphrase takes some time, because this information is only available when the sync engine is initialized. Bug: 888756 Change-Id: Ie661769cb65cfd2b432ed433ad416e944a979fce Reviewed-on: https://chromium-review.googlesource.com/c/1261441 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#597079}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /components. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibbb775036736e0b07c6ce5393569ed40878b5c62 Reviewed-on: https://chromium-review.googlesource.com/c/1257852Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597078}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I6ba0ce622392c38fe1f7fc23fcfde7829bbe0480 Reviewed-on: https://chromium-review.googlesource.com/c/1261556Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597077}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/push_messaging. This CL was uploaded by git cl split. R=mvanouwerkerk@chromium.org Bug: 809610 Change-Id: Ib8ccd8e3763c2c8172b9d7dcb7dac3cbc5e8e809 Reviewed-on: https://chromium-review.googlesource.com/c/1261699Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597076}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/530c5963e910..74a9acd4a7c1 Created with: gclient setdep -r src-internal@74a9acd4a7c1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib629adf6e50a488136ae6ba1e53efed13fffbee4 Reviewed-on: https://chromium-review.googlesource.com/c/1263874Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b2f9583. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25868 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If543bcc74b17c59182501eb945d642aacb71cd8e Reviewed-on: https://chromium-review.googlesource.com/c/1263891 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597074}
-
Alexander Timin authored
Replacing MessageLoop with ScopedTaskEnvironment will allow us to get more accurate information about its lifetime and get rid of lazy bindings. R=jochen@chromium.org CC=gab@chromium.org,alexclarke@chromium.org BUG=892139,891670 Change-Id: I9ffc7fec4c34a87c205c4d65d6e0fb8c5e21b05e Reviewed-on: https://chromium-review.googlesource.com/c/1261816Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597073}
-