- 19 Jan, 2011 40 commits
-
-
jhawkins@chromium.org authored
CSS values provided by Glen Murphy <glen@chromium.org>. BUG=none TEST=none Review URL: http://codereview.chromium.org/6241006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71836 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
- Adds oninput handling to live-save the homepage pref. I had avoided this before because I didn't want to pollute metrics, but this pref doesn't actually have a metric. (Also, if one is added, we can increment it only on the onchange events.) - Does URL fixup for onchange events (not oninput, because it would make typing impossible). BUG=69901,62851 TEST=Change the homepage to a non-canonical URL; it should be updated on blur to a full URL. On ChromeOS, power off the machine after changing the home page, but not blurring the field; it should be saved. Review URL: http://codereview.chromium.org/6332006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71835 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
r536 All surfaces follow D3D Y convention http://codereview.appspot.com/3265041 r535 Build fix needed on certain platforms. Explicitly cast away const. http://codereview.appspot.com/4043042 TEST=try BUG=none Review URL: http://codereview.chromium.org/6254010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71834 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
This is just a move CL, code changes will come in a followup. Moving the files will make the next code review easier. BUG=56415 TEST=None Review URL: http://codereview.chromium.org/6265010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71833 0039d316-1c4b-4281-b951-d872f2087c98
-
anicolao@google.com authored
BUG=70086 TEST=manual builds in various configurations Review URL: http://codereview.chromium.org/6310013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71832 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
BUG=none TEST=manual Review URL: http://codereview.chromium.org/6323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71830 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6344008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71829 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6362007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71827 0039d316-1c4b-4281-b951-d872f2087c98
-
dilmah@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/6279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71825 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
OnTouchEvent now returns the status of the touch sequence, instead of a simple bool. The gesture manager can presumably make a better decision if this information is available to it. For more details: http://codereview.chromium.org/6347002/ BUG=none TEST=ViewTest.TouchEvent Review URL: http://codereview.chromium.org/6253005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71824 0039d316-1c4b-4281-b951-d872f2087c98
-
mal@chromium.org authored
This makes licenses.py happy. pdfsqueeze changes: http://code.google.com/p/pdfsqueeze/source/list r4 Added copying file + minor change to preserve date stamps. r3 Fixed up inputs and outputs on script phase. This modifies a file under xcodeproj, which should not affect Chromium (we have a gyp file for pdfsqueeze). Review URL: http://codereview.chromium.org/6269012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71822 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
TBR=cbentzel BUG=70115 TEST=none Review URL: http://codereview.chromium.org/6260012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71821 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
tests are (usually) monitored for a fixed length of time. With this change field trial tests turn them selves off (will use the default group) after the expiration time (specified in the Field Trial constructor). BUG=13463 TEST=field_trial_unittests tests this code thorougly. spdy session and testing field_trials in renderer process would be very helpful. thanks much. Review URL: http://codereview.chromium.org/6317004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98
-
tschmelcher@chromium.org authored
- Fix graphical artifacting for images downloaded from the Internet caused by overwriting them with their own mip-maps. This resulted in each image being rendered with copies of itself of decreasing size in one of the corners. Cairo does not support/need mip-maps, so we now just ignore the calls to set the mip-maps. - Do not alpha-blend new texture content with the old texture content, which is wrong and would have been wasting a bit of CPU too. TEST=loaded O2D and verified the artifacting is fixed BUG=none Review URL: http://codereview.chromium.org/6268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71819 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
The problem is that CrxInstaller wasn't considering updates when looking for previously installed apps with overlapping extents. BUG=68872 TEST=Steps outlined in bug report. Review URL: http://codereview.chromium.org/6292007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71818 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Update header guard & add EOF newline in chrome/browser/ui/view_ids.h Split C/C++ system headers into blocks in: chrome/browser/ui/gtk/gtk_expanded_container.cc chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc Sync manually with r71749 BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6296012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98
-
atwilson@chromium.org authored
BUG=69391 TEST=Create lots of new tabs, bring up task manager, should be fast. Review URL: http://codereview.chromium.org/6240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71815 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
Re-landing r71485 (which was reverted in r71500). BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6278007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71814 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
This mirrors the behaviour on other platforms, and allows the optimized Pepper plugin painting path to be used (see RenderWidget::DoDeferredUpdate()). BUG=none TEST=MacFlapper paints correctly in the "windowed" case Review URL: http://codereview.chromium.org/6359005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71813 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Pass correct dummy filename ("name.html" instead of "name./html") to GTK MIME lookup, to fix the file-filter drop-down in GTK file dialogs. BUG=none TEST=manual Review URL: http://codereview.chromium.org/6379001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71812 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@google.com authored
Add TextRange and GetSelectedRange, SelectRange and GetCursorPosition, which are necessary to implement ominibox. I'm adding them as Views only and left win/gtk blank because we don't use win/gtk impl for omnibox. I also didn't add TextRange variable to Textfield as its state is kept in Model. Let me know if you want to add it in Textfield class as well. BUG=none TEST=added new tests RangeTest, SelectRangeTest Review URL: http://codereview.chromium.org/6318004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71811 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Filed http://code.google.com/p/drmemory/issues/detail?id=273 to find out why a separate suppression type is needed BUG=57910,68307 TBR=glider TEST=DrM/FYI bot should become greener Review URL: http://codereview.chromium.org/6314009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71810 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/5740004zelidrag@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6289005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71809 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
BUG=none TEST=python:PolicyJsonUnittest.* Review URL: http://codereview.chromium.org/6312006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71808 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=69883 TEST=Display Task Manager while one or more tabs are open, and start typing into the Omnibox of one of them. Review URL: http://codereview.chromium.org/6240006 Patch from Wez Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71807 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
The password manager was incorrectly down-casting from WebNode to WebInputElement and then upon method invocation, was crashing. This change adds extra checks to |FindFormInputElements| before down-casting. Also, when "name" attributes are ambiguous, the code now rejects filling. This fixes the case where password text can erroneously get filled in the username field. BUG=29352 TEST=PasswordAutocompleteManagerTest.*, and manual according to bugs. Review URL: http://codereview.chromium.org/6271007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71806 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
The first is inside GCF where we get a tab message after the target tab has been torn down. Before, we set handled to 'false' which would cause the message to end up in AutomationProxy which doesn't know how to handle it. The fix is to drop the message and treat it as handled. The second is when we attempt to send a download request to the host browser but the request has already been terminated. We treated this as a fatal error, but now only log an error. TEST=See repro steps in bug. BUG=69595 Review URL: http://codereview.chromium.org/6260009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71805 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
TBR=pastarmovj@chromium.org BUG=70115 TEST=None Review URL: http://codereview.chromium.org/6348008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71804 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71803 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=70115 TEST=None Review URL: http://codereview.chromium.org/6318006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71802 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=68910 TEST=playing a compressed wave should fail gracefully Review URL: http://codereview.chromium.org/6288008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71801 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
situation where the opener ends up the same as the tab being closed. The only way I could see this happening is a new tab getting the same address as a tab that was deleted. This seems unlikely, but I've added the code to make sure we clean up properly when a tab is deleted. I'm also adding a couple more checks. BUG=34135 TEST=none Review URL: http://codereview.chromium.org/6346008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71800 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
ResourceHandler's expect to be deleted on the IO thread after their ref count goes to 0. Change the unit test to explicitly drop ref count and run the IO thread's message loop. BUG=69414 TEST=valgrind trybots Review URL: http://codereview.chromium.org/6136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71798 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Weak symbols are either broken or they don't work the way that we need. Either way, the current weak symbol based scheme is causing runtime-linker aborts on systems without NSS 3.12.6. This change switches to using dlsym to lookup the symbol at runtime. BUG=69345 TEST=Run chrome on systems with libnss.so < 3.12.6 http://codereview.chromium.org/6250008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71796 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=none TEST=still works Review URL: http://codereview.chromium.org/6307006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71795 0039d316-1c4b-4281-b951-d872f2087c98
-
erik.corry@gmail.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6296014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71794 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
the new code location under Source/. Review URL: http://codereview.chromium.org/6264004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71793 0039d316-1c4b-4281-b951-d872f2087c98
-
skerner@google.com authored
This change will enable a fix for issue 57289, which requires a different base directory for extensions. BUG=70111 TEST=ExtensionServiceTest.ExternalPrefProvider Review URL: http://codereview.chromium.org/6293006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71792 0039d316-1c4b-4281-b951-d872f2087c98
-