- 25 Oct, 2018 5 commits
-
-
Peter Kasting authored
De-parameterizes one test that doesn't care about the MD mode. Bug: none Change-Id: I8a89eda9e66a9fc59b2c61668d1fdebc4ee7879b Reviewed-on: https://chromium-review.googlesource.com/c/1297647Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602535}
-
Becca Hughes authored
Add playback state to MediaSessionInfo. This reflects the actual playback state of the media. This is used because the audio focus state may not line up with whether there is media playing (e.g. apps commonly hold audio focus when they are paused). BUG=893296 Change-Id: I025856fe007c08e61e85cb1417b472aecd5a3ccb Reviewed-on: https://chromium-review.googlesource.com/c/1282026 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602534}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f598e8c829a..7e4c630e7399 git log 4f598e8c829a..7e4c630e7399 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 19603b9e7b20..c3ee7ec01dda (1 commits) 2018-10-24 herb@google.com Cleaup SkGlyph 2018-10-24 nigeltao@google.com New GIF codec; new third_party/wuffs dep Created with: gclient setdep -r src/third_party/skia@7e4c630e7399 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I0e5e731eee8ef33097f075a40585a4a2b5589266 Reviewed-on: https://chromium-review.googlesource.com/c/1298279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602533}
-
Roberto Carrillo authored
We agreed to use a standard sized machine for tester. TBR=smut,nodir Bug: 897407 Change-Id: I9579001261f36e3b86dd92c154b65873e4116735 Reviewed-on: https://chromium-review.googlesource.com/c/1298491Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#602532}
-
James Darpinian authored
When reading from stdin, process lines as they are read and echo them, rather than trying to read all of stdin before doing anything. This allows piping adb logcat directly to stack.py during normal development. You can still see the logcat output and any stacks found will be symbolized on the fly. Change-Id: I0fa525a8d73b85559738d4ce186e1b7bdcc19f27 Reviewed-on: https://chromium-review.googlesource.com/c/1297692Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#602531}
-
- 24 Oct, 2018 35 commits
-
-
David Tseng authored
This makes it so we don't output ChromeVox logs for the log page itself. This is a requirement for any user of ChromeVox to use this log page. Test: manual Change-Id: Ie453b5cfeab113b1a0cd9cc16af2e991758f9751 Reviewed-on: https://chromium-review.googlesource.com/c/1295489 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#602530}
-
Sammie Quon authored
It was not shown before, probably because of Ink drop behaviour set to ON_NO_GESTURE_HANDLER. Manually set the ink drop states when home launcher is shown. Test: manual Bug: 898656 Change-Id: Ic8fa65ae01d839d5adfeebc976bc9e744a080f2e Reviewed-on: https://chromium-review.googlesource.com/c/1298425Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#602529}
-
Robert Ogden authored
This ensures that an old previews_freshness_ won't be shown on the wrong page. Bug: 898570 Change-Id: I19cb1ab9916eae9b80fb4ca8d260cd18ebd66a97 Reviewed-on: https://chromium-review.googlesource.com/c/1298245Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#602528}
-
siyua authored
Bug: 897998 Change-Id: I39e0595288a4d9441fc2452b2d47b4f430a4d0cb Reviewed-on: https://chromium-review.googlesource.com/c/1298083 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602527}
-
Scott Violet authored
OobeInteractiveUITest.SimpleEndToEnd has been globally disabled. BUG=891277 TEST=test only change Change-Id: I830ded4ed17980f6b3b3a590142950e25ffda6aa Reviewed-on: https://chromium-review.googlesource.com/c/1298422Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602526}
-
Alex Danilo authored
Commit https://codereview.chromium.org/1158923004 updated incorrect escapes in some RegExp constructors, but some of the escapes were superfluous. When checking the formats it became obvious that the original MIME types used were incorrect for the family of openxmlformats documents. This change corrects the MIME types and removes the unneeded escapes. BUG=chromium:675506 TEST=Ran all the FilesApp tests Signed-off-by:
Alex Danilo <adanilo@chromium.org> Change-Id: Ic79e4655ebb61ea2e7c8fbb83509f899d7d1cb60 Reviewed-on: https://chromium-review.googlesource.com/c/1297775Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#602525}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/44a262a6aae2..4cb4786d780f git log 44a262a6aae2..4cb4786d780f --date=short --no-merges --format='%ad %ae %s' 2018-10-24 benwright@webrtc.org Add expected default values to video configuration tests. Created with: gclient setdep -r src/third_party/webrtc@4cb4786d780f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a8bbe941cec0d9dcde7442d57c230a510eabaee Reviewed-on: https://chromium-review.googlesource.com/c/1298168Reviewed-by:
-
David Bertoni authored
The new functions draw the icon into another bitmap, combining it with the background color to determine the visibility of the resulting icon. Bug: 805600 Change-Id: I592ed5342d6eb3bfb6c36a4da7148280ed2a0f85 Reviewed-on: https://chromium-review.googlesource.com/c/1297398 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Scott Violet authored
Many of these tests previously worked by using a pattern such as: . make TabScrubbers timer use a zero delay. . generate a bunch of async scroll events (using EventGenerator) . record when active tab changes. . run message loop, waiting for active tab to change to certain index, then stop. This is problematic in the mash case as EventGenerator, for mash, runs a message loop. This meant the timer would fire at unexpected times. The fix is to increase the timer delay, generate a single event and then force the TabScrubber timer to complete. This way the test gets consistent results, regardless of whether EventGenerator internally runs a message loop. BUG=889097,890050 TEST=test only changes Change-Id: I5decb690c4ef7ff67af21cc9a588aaa5046fad89 Reviewed-on: https://chromium-review.googlesource.com/c/1297288Reviewed-by:
-
rbpotter authored
Bug: 898444 Change-Id: Icadd1866dc0292993b6e52b06198363868af4a81 Reviewed-on: https://chromium-review.googlesource.com/c/1297458Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602521}
-
Daniel Cheng authored
Other empty containers are marked as const to ensure that they stay empty. Change-Id: I6771a853cf3cde47fcdcff1e3af7862234f04683 Reviewed-on: https://chromium-review.googlesource.com/c/1298399Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602520}
-
Xiyuan Xia authored
- Add occlusion state tracking to WindowService; - WindowTree::TrackOcclusionState to start tracking in Window Service on server side; - WindwoTreeClient::OnOcclusionStateChanged to notify the client side that the occlusion state is changed on the server side; - WindowPortMus uses WindowService for occlusion tracking; - WindowOcclusionTracker allows external window-has-content checking and WindowService uses that to mark Windows with remote client as has-content; - Route ScopedPause to WS for MUS aura; Bug: 867150 Test: WindowPortMusTest.TrackOcclusionState, WindowTreeClientTest.OcclusionStateFromServer and WindowTreeTest.OcclusionStateChange Change-Id: Id43a69fb119c602375e8c35d72ead7095eca91d6 Reviewed-on: https://chromium-review.googlesource.com/c/1269717Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602519}
-
Matt Mueller authored
Unused since https://crrev.com/230996f183bc6eb2f8ec2a39f7d19f9d6267ec84 Bug: 779166 Change-Id: I57e2f6253b834734829fd7acacc6254afbe07081 Reviewed-on: https://chromium-review.googlesource.com/c/1298418Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#602518}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bd88028..111e0f2f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4e8b4105e4a913a9952863316bd567218c1ce6aa Reviewed-on: https://chromium-review.googlesource.com/c/1298352Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602517}
-
Jun Mukai authored
The EventGenerator isn't using EventInjector for Mash when the target window is specified. But actually this EventGenerator is only generating key events, which can be replaced by ui_test_utils::SendKeyPressSync(). This doesn't fix the SingleProcessMash cases, but at least now the key events are processed by Ash. And this simplifies the code. BUG=898658 TEST=interactive_ui_tests Change-Id: Ibf3df0588fdaf8a6429ddf05326f6ed119c4e063 Reviewed-on: https://chromium-review.googlesource.com/c/1298075Reviewed-by:
-
Ryan Sturm authored
This allows Offline previews to work after network s13n is turned on. Bug: 842233 Change-Id: I9cc97a29308b25490a5ea1b97b353aada82cccf0 Reviewed-on: https://chromium-review.googlesource.com/c/1297472Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#602515}
-
Dale Curtis authored
BUG=898642 TEST=none TBR=pfeldman Change-Id: I1d67c0cdc9da3444d2b28c4a0c1cb323cbc59f83 Reviewed-on: https://chromium-review.googlesource.com/c/1298413Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602514}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: I15be67b385349af7da4c47d3763ba08c5141061d Reviewed-on: https://chromium-review.googlesource.com/c/1297986Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602513}
-
Katie D authored
This works by starting the drag on the first dwell and ending the drag on the second dwell, and rewriting mouse moved events to mouse dragged events in between. This is still hidden behind the accessibility flag. Bug: 894907 Change-Id: Ia2cd72053e3d1023711764e2b581caa686f2fb98 Reviewed-on: https://chromium-review.googlesource.com/c/1295250 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602512}
-
Ted Choc authored
This internally introduces a property model to SuggestionView and moves some of the logic to it. It also splits out the init call to primarily be operating on the model. After this the init call should be moved entirely out of the view and the binder should be pulled out too. BUG=898522 Change-Id: I5db1bb30c45cb4e63d7bfee75b2457817cfb6864 Reviewed-on: https://chromium-review.googlesource.com/c/1298213 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602511}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/00455e014868..bdcfce54a8d5 git log 00455e014868..bdcfce54a8d5 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 kbr@chromium.org Print Telemetry's help in run_browser_tests. 2018-10-24 kjharland@google.com Whitelist Fuchsia Global integration CI builder Created with: gclient setdep -r src/third_party/catapult@bdcfce54a8d5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898602 TBR=sullivan@chromium.org Change-Id: Ibcf2b7266600cb78dae90a2f90624eba5a72225d Reviewed-on: https://chromium-review.googlesource.com/c/1298167Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/334f03f88fc4..062e25f6a6b0 Created with: gclient setdep -r src-internal@062e25f6a6b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If598b81c5623635fc409ab73be606b5b3632cf43 Reviewed-on: https://chromium-review.googlesource.com/c/1298166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602509}
-
Matt Mueller authored
PKP persistence was removed as part of https://crrev.com/230996f183bc6eb2f8ec2a39f7d19f9d6267ec84 Bug: 779166 Change-Id: Ic8dcc6a983f08418465b301e99e0bd226521e073 Reviewed-on: https://chromium-review.googlesource.com/c/1297286Reviewed-by:
-
Hector Carmona authored
This is usually a sign that an include path is incorrect. R=scottchen@chromium.org Bug: NONE Change-Id: Id382b43eeeb967fe727a05e81b152091cbcc000e Reviewed-on: https://chromium-review.googlesource.com/c/1297278Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602507}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19603b9e7b20..c3ee7ec01dda git log 19603b9e7b20..c3ee7ec01dda --date=short --no-merges --format='%ad %ae %s' 2018-10-24 geofflang@chromium.org Implement EGL_ANDROID_image_native_buffer. Created with: gclient setdep -r src/third_party/angle@c3ee7ec01dda The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I79406ba81a46c9d863ac22f6b092d1df7a5335de Reviewed-on: https://chromium-review.googlesource.com/c/1298259Reviewed-by:
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I2f41fe40066107c51b3054b05a084f50e0a0213e Reviewed-on: https://chromium-review.googlesource.com/c/1298200Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#602505}
-
Daniel Cheng authored
since the set only contains string constants, using base::StringPiece is more efficient. base: :flat_set is typically more efficient than std::set. In addition, Change-Id: Id92f2e6008415f3091a08fc407303c0705c69d20 Reviewed-on: https://chromium-review.googlesource.com/c/1298073Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602504}
-
Joshua Bell authored
A few cases noted in storage API backends. Change-Id: I8282bdead392b970bf3d34d20921fbe02aa80572 Reviewed-on: https://chromium-review.googlesource.com/c/1298248 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#602503}
-
Scott Graham authored
This happens to fail on Fuchsia, but is just generally not IWYU. Bug: 808287 Change-Id: I46c8527f0becf79d10c4e960a083e4b9e8eb8bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1298241Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602502}
-
Darren Shen authored
Full width virtual keyboard on multiple displays was broken because we made an assumption that we only attach the virtual keyboard to a root window at initialization. Actually, it can be called whenever the keyboard changes displays. So we should actually be maintaining the same bounds whenever we attach to a new root window. Unfortunately, floating keyboard on multiple displays looks utterly broken...but that's a separate issue. Bug: 897007 Change-Id: I6392a790cd172cd3899c2c0b3cfd41f31a096fbc Reviewed-on: https://chromium-review.googlesource.com/c/1296948Reviewed-by:
-
Maks Orlovich authored
Bug: 893971 Change-Id: I9340eef7af2d6c414dcc3d9ce2d3829f2a5cfaaf Reviewed-on: https://chromium-review.googlesource.com/c/1298296 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
-
Paul Meyer authored
attribute. Change-Id: I32c8821aec5a32b5dfdeb44db4a48e719ec0205b Reviewed-on: https://chromium-review.googlesource.com/c/1236493Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#602499}
-
Scott Graham authored
Bug: 808287 Change-Id: I412c47c632f3dc3042e324939e9a241522cb7a33 Reviewed-on: https://chromium-review.googlesource.com/c/1297277Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602498}
-
Sadrul Chowdhury authored
This reverts commit 5c2e137d. Reason for revert: crbug.com/898127 Original change's description: > viz: Throttle begin-frames when gpu is busy. > > Throttle begin-frames to clients until gpu is done processing the > earlier swaps. This helps with reducing work when the gpu has a high > load, by not sending begin-frames to clients. > > The clients always keep receiving the compositor-frame-ack messages > when a surface becomes activated (or replaces an older pending frame), > even if the gpu is busy doing work from earlier frames. So this change > introduces the back pressure by way of withholding begin-frames so > clients have to do less work. > > BUG=877906 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: If34eb5c5af03961e17932c8f57caf352d0362bab > Reviewed-on: https://chromium-review.googlesource.com/c/1282219 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601383} TBR=sadrul@chromium.org,fsamuel@chromium.org,sunnyps@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 877906, 898127 Change-Id: I3a21b59feacaa5152e187bc4483336abd5254b5e Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1298333Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#602497}
-
Xi Cheng authored
Previously, a pointer to the NotificationImageRetainer object is stored in NotificationTemplateBuilder. This is unnecessary as this object is only used by two private methods called within Build() and never used again. This CL changed to pass the pointer into those functions directly. Separately, a GetCleanupTask() method is added for NotificationImageRetainer so that it doesn't need to expose AsWeakPtr() to the public. Bug: 888276 Change-Id: I4a7fa2a39e30c739f9adb7021b4809a4b56062fa Reviewed-on: https://chromium-review.googlesource.com/c/1292712 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#602496}
-
