- 26 Apr, 2019 40 commits
-
-
Jose Dapena Paz authored
Change-Id: I828ea4a42c4b1f4d29fa62cb0b6370febabcca6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584291 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#654600}
-
Eric Orth authored
As manager-wide properties, removed the DnsClient-setting and DnsClient- enabling methods from ContextHostResolver. It can now only be changed directly on the manager. Since much of the usage was just setting an initial value, added |dns_client_enabled| to ManagerOptions. This is especially needed for stand-alone resolver cases where such an intial value is needed, but there are no references to the underlying manager. Also cleaned up the methods on HostResolverManager to make methods to set the actual DnsClient instance (rather than just SetDnsClientEnabled(...)) test-only. FuzzedResolver logic overriding DnsClient-setting got moved to the fuzzed manager. As there was nothing left in the fuzzed ContextHostResolver except construction, replaced it with a Create method that uses a normal ContextHostResolver with the fuzzed manager. Bug: 934402 Change-Id: I82cd5189b9e55dc95a5bb283acf97c5620c58add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582424 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#654599}
-
Lei Zhang authored
Put repeated code in its own method, and optimize the method. Change-Id: I418ea40480626bfe56a547d64fe74b7019dd53c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585973Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#654598}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7f22e29c4a1..bbeee6d77ff6 git log d7f22e29c4a1..bbeee6d77ff6 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 benjhayden@chromium.org Roll third_party/gae_ts_mon Created with: gclient setdep -r src/third_party/catapult@bbeee6d77ff6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867060 TBR=eyaich@chromium.org Change-Id: Ib248f2cf7a9a43340d3bf5d3e9f879097dc64f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654597}
-
Dmitry Gozman authored
TBR=npm@chromium.org Bug: 957181 Change-Id: I94d905ce74365b5f5864797941019424aa0a6c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585116Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#654596}
-
lgcheng authored
OOBE flow: remove "skip button" for managed user, as administrator has enabled ARC by policy, so skipping setup just delays ARC setup. in-session: do not show in-session dialog when ARC++ is managed enabled. Also leave B&R or GLS as off if they are not managed in this case, as the user did not set them in the ToS dialog. User can still modify these settings if not managed through Android settings. This also means ARC will auto starts in case of any previous error. e.g. Power off the device when seeing Arc Tos page. Bug:950013 Test: Pass/fix tests Test: Update test expectations for skip Tos With OOBE/in-session optin. Test: Manual simulate different policy setup to verify: 1. OOBE Tos is skipped when Arc and both B&R and GLS are managed 2. In-Session Tos is skipped when Arc is managed. Change-Id: If8b6b265af20b819375b82a2c6c0c1308b11bbac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560491 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654595}
-
Tom Bergan authored
I also added a redirect_chain field to HTTPResponse. This is the ordered list of URLs in the redirect chain. If a request did not have any redirects, this list is empty. This is used to verify that a server bypass happend. For example, testServerReturnsBypass checks that we show the original page, and also that we got there via a redirect (bypass) from the server. OTOH, testServerReturnsBypassWithHostBlacklisted loads the page twice, where the second load should _not_ go through the server. R=robertogden@chromium.org Bug: 908491 Change-Id: I0e4c66917098013f2137d0cf2306567ddf8f4a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584436Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tom Bergan <tombergan@chromium.org> Cr-Commit-Position: refs/heads/master@{#654594}
-
Kurt Horimoto authored
This is necessary to allow proper destruction of objects stored in Browser's user data when they depend on the Browser's WebStateList. The Browser's WebStateList is destroyed in Browser's destructor, while any WebStateListObservers stored in Browser's user data is destroyed in Browser's base::SupportsUserData destructor, which occurs later. This observer callback gives these objects a chance to perform clean up and reset any pointers to WebStateLists before the WebStateList is destroyed. Bug: 950104, 956727 Change-Id: Ifbff974cb44ed5177b92040bd277624056a3690b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583444 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#654593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/057f2dd516ce..dfd2f8c4fcb0 git log 057f2dd516ce..dfd2f8c4fcb0 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 hjd@google.com docs: Fix typos in traceconv.md 2019-04-26 bhamrick@google.com Merge "Update links to Fuchsia tracing documentation" Created with: gclient setdep -r src/third_party/perfetto@dfd2f8c4fcb0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:131426263 TBR=perfetto-bugs@google.com Change-Id: I5e255176d7681867bc1749fd9f1b95045375f477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654592}
-
rbpotter authored
- Remove print_preview_new namespace, and move everything to print_preview - Rename print_preview_new.html to print_preview.html Bug: 888272 Change-Id: I3b601b3c1fbc299377f63d1da9d93fb36f80d19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586219Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#654591}
-
Hiroki Nakagawa authored
This is just a refactoring as follows: - For on-the-main-thread classic worker script fetch, SetAddressSpace() call is slightly delayed from the WorkerGlobalScope constructor to Initialize(). This doesn't change the behavior because AddressSpace is not used during the period. - For off-the-main-thread classic worker script fetch and module worker script fetch, there is no behavior change because the initialization order is not changed. Bug: 945215 Change-Id: Iad5f07cf619674d288f72c98d0c4ae297e7252b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583174 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#654590}
-
John Rummell authored
Refactoring to get rid of "const scoped_refptr<VideoFrame>&" and "const scoped_refptr<AudioBuffer>&" parameters from the callbacks. BUG=946265 TEST=compiles Change-Id: Ic7e4f7b33d87f072dadd7f86b2ef181324d111d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583345Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#654589}
-
Daniel Rubery authored
Now that M75 is branched, we can remove the old RAR inspection path for M76. This CL also removes symbols from the unrar_wrapper that were used to support the old RAR inspection path. Bug: 909778, 934372 Change-Id: I385db8851a11fe71679c1b2500fff97ea0b6aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575683Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#654588}
-
Philip Rogers authored
This patch adds a fast-path for updating composited pinch-zoom (visual viewport scale and translation nodes) without requiring a PaintArtifactCompositor update. There are two main changes: 1) Return PaintPropertyChangeType from the visual viewport paint property node update. This closely follows the pattern used by PaintPropertyTreeBuilder. With this change, the PrePaintTreeWalk can avoid setting PaintArtifactCompositor::NeedsUpdate for some changes. 2) Directly update viewport scale and translation cc::TransformNodes. This closely follows the approach of https://crrev.com/651338. Bug: 956747 Change-Id: I7e593774fb05cc8c4d7b91c153b02cf2bbb6f36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585082Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654587}
-
Abhishek Bhardwaj authored
This change adds logic to parse a DeviceScheduledUpdateCheck proto. BUG=924762 TEST=None. Change-Id: Ib8360d27884b46393ec5546a9c004a61a11ca0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574462Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#654586}
-
Dale Curtis authored
No longer used since we stopped doing splicing for MSE. BUG=none TEST=cq R=chcunningham Change-Id: I846a3925e98e1aca7ceb6592159674d65e71bec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586197 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#654585}
-
Nikunj Bhagat authored
Change-Id: Ib2915910b353c0615b25e047e0567a0e3490dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586242Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#654584}
-
Wez authored
- Fix RunUntilBrowserProcessQuits() to run-and-clear the |run_loop_|. - Update comment in PostRunTestOnMainThread() to refer to the bug that now tracks the blocking cleanup work. Bug: 922118 Change-Id: I4f1d30e0c2e19b810c09df5b102e4fea920e6767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585095 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#654583}
-
Ian Kilpatrick authored
This introduces NGFragmentGeometry, which holds the pre-layout values of: - The border-box-size (the block-size may be indefinite at this stage). - The border, scrollbar, padding. This is generated before entering into the layout algorithm. A followup patch will use this data to determine if the size of a fragment *will* change, given a new constraint space. (At the moment our caching logic sometimes misses, even though the resulting size will be the same). There are some slight behaviour changes, e.g. NG-flexbox will now clamp the size of the scrollbars, similar to flow layout, etc. (The clamping of scrollbars occurs when the size of the fragment is smaller than the border_padding sum, and the scrollbar occupies the left-over space). Bug: 635619, 667370 Change-Id: I7fe0f6eb53ca1878075c47e772fd22978c231bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530121Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#654582}
-
Adrienne Walker authored
https://chromium-review.googlesource.com/c/chromium/src/+/1584617 caused this regression. The issue here is that DesktopWindowTreeHostX11::HideImpl doesn't call SetVisible directly and so the is_compositor_set_visible_ flag stays true and SetVisible(true) during Show does nothing. Bug: 956997 Change-Id: I65174cb126debd5e10d68dbd237ddfa0e7ff8c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586235 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#654581}
-
Matthew Jones authored
This patch adds the ability for infobars to spec touchless support for themselves. Each infobar has the option to state whether it supports touchless mode and provide a model for the touchless UI surface to use. Bug: 930746 Change-Id: If4a5a81c08b06c48b201a87320b2ad213ff496cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582835 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#654580}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/199182fd64c7..99d965d911f3 git log 199182fd64c7..99d965d911f3 --date=short --no-merges --format='%ad %ae %s' 2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@99d965d911f3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib82d81d2706ec42cb048c7a8a6dddeb147b0ace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654579}
-
Yuwei Huang authored
Chromotocol uses STUN and TURN services provided by the Talk server, which won't be available after the XMPP->FTL migration. This CL forces the host and playground to use TURNaaS when FtlSignalStrategy is being used. The host and client are able to connect via relay for the first time but subsequent connection will fail until we wait for ~5 minutes. This is a known issue to Chromotocol even when using GTURN, while WebRTC doesn't seem to be affected, even when using it on mobile clients. Bug: 955617 Change-Id: I3799fb316c9861a57c7c019d85843f9211ef8242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584932 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#654578}
-
kylechar authored
If posting the task fails then it's not an appropriate task runner. See https://crrev.com/c/1572809/3/base/files/important_file_writer.cc#258 for more context. Bug: 714018 Change-Id: I620bd978ec2a1d6b6219fa3d85ac6fbcd5563af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580041 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#654577}
-
Bill Orr authored
The issue here is that we validate frame data coming in, and fall back to defaults if the frame data was invalid. The logic to fall back to defaults was only run if there was a pose. The fix makes it so we fall back to defaults even when there is no pose. Bug: 956614 Change-Id: I8b394639d3278178ebff49b3a6b24e631c3e48d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585009Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654576}
-
Matthew Mourgos authored
Bug: 953525 Change-Id: Id7d9ce4cd3485af59f871c3dd9290065b2cbda3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584888 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#654575}
-
Adithya Srinivasan authored
Test times out on Windows debug bot. Bug: 890372 Change-Id: Ib337d19167c8864612bf697b2adb420507c27e76 Tbr: cthomp@chromium.org, estark@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585536Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#654574}
-
Thomas Guilbert authored
Currently, a MojoRenderer is directly used to pass through messages to and from the FlingingRenderer (FR). This CL adds the FlingingRendererClient (FRC), which serves almost exactly the same purpose as a pass-through MojoRenderer. The difference is that, the FRC implements the mojom::FlingingRendererClientExtension, which allows the FR to send remote Play/Pause change events directly to the FRC. This removes the need for the general mojom::RendererClient to have a specialized OnRemotePlayStateChange(). A follow up CL will remove media::RendererClient::OnRemotePlayState(). Bug: 956677 Change-Id: Ia7484b54849991cfad8a78040d0e47ab156bc3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526637 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#654573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a30cf84b47a8..ee90eb42fe4f git log a30cf84b47a8..ee90eb42fe4f --date=short --no-merges --format='%ad %ae %s' 2019-04-26 jvanverth@google.com Clean out stale shadow vertices from the SkResourceCache 2019-04-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-26 jvanverth@google.com Merge MTLRenderPassDescriptors when possible. Created with: gclient setdep -r src/third_party/skia@ee90eb42fe4f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130757982 TBR=mtklein@chromium.org Change-Id: I44690326661a88916950d37e77e175ea740380a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654572}
-
Jacob Dufault authored
This CL shows how all of the Get*View methods in OobeUI can be eliminated, which simplifies adding a step to OOBE. TBR=rsorokin@chromium.org TBR=xiyuan@chromium.org Bug: 928555 Change-Id: Ia798d223ca07841a6ecfbc884bd8944465a0b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577947 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#654571}
-
Jose Dapena Paz authored
CompositorFrameReportingController is using DCHECK_NE to compare several unique_ptr. This is valid in libc++, but on libstdc++ unique_ptr does not have an ostream operator. Change-Id: I9f23ef17f02b9e107694ba493f6f8f3caf5cac4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584292Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#654570}
-
Daniel Rubery authored
Bug: 955226 Change-Id: I7b8aff177370702b5a9baaf1e0823a2fde7e15e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585060 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#654569}
-
Katie D authored
Movements greater than the movement threshold should cancel autoclick with stabilization "off". Bug: 957113 Change-Id: Ibce4a7f168241a16a169c5811692807556eb51bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584784Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#654568}
-
Kenneth Russell authored
Removed some now-unneeded Mac- and Linux-related test suite exceptions. There are no changes to the generated waterfalls. Bug: 833020 Change-Id: Ia76178134f60fd0c018ef84658d9f0f3ea4390ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585987 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#654567}
-
Brian Sheedy authored
Enables JavaScript console logs being copied to the system log in all XR instrumentation and browser tests. This used to be the default, but was recently changed to be disabled by default for privacy reasons. Bug: 956784 Change-Id: I2f417bea9149bddf168e342d4674524624628c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585072 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#654566}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdbb453061f8..5557cd43e22e Created with: gclient setdep -r src-internal@5557cd43e22e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=andruud@chromium.org,alexmos@chromium.org,horo@chromium.org,adithyas@chromium.org Change-Id: If9aea184ce794b98442a08ea6be875cc18805751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584355Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#654565}
-
Tim Song authored
This change removes a double slide animation when the user flings to dismiss a notification. TEST=manually verified, new unit test BUG=933640 Change-Id: I7f9f4e558dfa53e8acf0abdbd86cf4449c1ea891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583344 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#654564}
-
Andrey Kosyakov authored
Bug: b/131183141 Change-Id: I4db5d99a42220319e98871903ec94c28e25cd628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582623Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#654563}
-
Emily Stark authored
Both WebContentsDelegate and WCO have DidChangeVisibleSecurityState methods. The WCO method was previously only being called if there was a delegate. This broke some unit testing scenarios in which we want to exercise a WCO method but there is no delegate, and there's no reason for the two to be tied together. Change-Id: Icff39b26317ff9cf7c373cfba02ed1e66a231e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579102 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#654562}
-
Ian Wells authored
Adds a string "attribution" to OfflineItem and a gfx::Image "custom_favicon" to OfflineItemVisuals. Also adds a parameter "GetVisualsOptions" to GetVisualsForItem to allow callers to specify which visuals they want if one or more isn't needed. Bug: 852872 Change-Id: I26ed0e6313ca91f40bd2bf80f8043b065c5262ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576006 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#654561}
-